Re: Footnotes handling debug

Sorry, Luca. My bad. The test should have been on the flow, not in the
footnote area. I've corrected it in CVS.

Right now, that last empty block creates a block area that has a BPD of
14400. In the end this area should collapse to a BPD of 0 so it doesn't
affect the page breaking. A footnote like this is a regular work-around
in 0.20.5 and we should have it working again. Or maybe it's just a
matter of getting linestacking-strategy right. I haven't investigated
much, yet. At any rate, this pattern is used to emulate
page-position="last". You would agree that an empty block should
collapse to a zero BPD, wouldn't you?

I hope this answers your question.

On 31.05.2005 18:13:25 Luca Furini wrote:
> I'm trying to correct the footnotes handling, as the testfile
> footnotes2.xml does not pass yet.
> 
> I succeeded in handling a page-dependent footnote separator, with the
> reasonable (at least IMO) assumption that the separator bpd does not
> change, but there is a check I don't understand:
> 
>     [...]
>     <!-- last block on page 3 -->
>     <eval expected="360000" xpath="//pageViewport[3]/page/regionViewport/regionBody/footnote/block[last()]/ <at> ipd"/>
>     <eval expected="0" xpath="//pageViewport[3]/page/regionViewport/regionBody/footnote/block[last()]/ <at> bpd"/>
>     [...]
> 
> Why should the last footnote block have bpd = 0?
> 

DO NOT REPLY [Bug 23709] - Height of SVG rect tag negative when rendering SVG

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=23709>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=23709

------- Additional Comments From johnfleenor76 <at> yahoo.com  2005-06-01 17:10 -------
I have the same problem with placing backgrounds on cells.

In the org.apache.fop.render.AbstractRenderer:123  There is a negative h.  
if (props.backColor.alpha() == 0) {
            this.addFilledRect(x, y, w, -h, props.backColor);
}

I just for svg out put I placed a Math.abs(h) in 
org.apache.fop.render.svg.SVGRenderer:195.

protected void addRect(int x, int y, int w, int h, float r, float g,
                           float b, float fr, float fg, float fb) {
        Element rect = SVGUtilities.createRect(svgDocument, x / 1000f, 
pageHeight - (y / 1000f), w / 1000f, Math.abs(h) / 1000f);
        rect.setAttributeNS(null, "style", "stroke:rgb(" + ((int)(255 * r)) 
+ "," + ((int)(255 * g)) + "," + ((int)(255 * b)) + ");fill:rgb(" + ((int)(255 
* fr)) + "," + ((int)(255 * fg)) + "," + ((int)(255 * fb)) + ")");
        currentPageG.appendChild(rect);
}

I have not investagated what imapact changing the -h in the abstract renderer 

Unneeded code in PSLM?

http://xxx.xx.x/yyyy.tif : class org.apache.fop.image.TiffImage - length mismatch on read

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35184>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35184

           Summary: Error while loading image http://xxx.xx.x/yyyy.tif :
                    class org.apache.fop.image.TiffImage - length mismatch
                    on read
           Product: Fop
           Version: 0.20.5
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: images
        AssignedTo: fop-dev <at> xml.apache.org
        ReportedBy: sergey <at> fct.ru
                CC: sergey <at> fct.ru

When used TIFF image from remote host (via http or ftp) only part of image
readed from inputStream, and error check failed. From local filesystem all works
fine.

/org/apache/fop/image/TiffImage.java  must be modifyed:

Code:

      inputStream = this.m_href.openStream();
      inputStream.skip(offset);
      bytes_read = inputStream.read(readBuf);
      if (bytes_read != length) {
        throw new FopImageException("Error while loading image "
                                    + this.m_href.toString() + " : "
                                    + this.getClass() + " - "
                                    + "length mismatch on read");
      }

      this.m_bitmaps = readBuf;

must be replaced with:

      ByteArrayOutputStream baos = new ByteArrayOutputStream();

      try {
        inputStream = this.m_href.openStream();
        inputStream.skip(offset);
        while ( (bytes_read = inputStream.read(readBuf)) != -1) {
          baos.write(readBuf, 0, bytes_read);
        }
      }
      catch (java.io.IOException ex) {
        throw new FopImageException("Error while loading image " +
                                    this.m_href.toString() + " : " +
                                    ex.getClass() +
                                    " - " + ex.getMessage());
      }
      this.m_bitmaps = baos.toByteArray();
      bytes_read = m_bitmaps.length;
      if (bytes_read != length) {
        throw new FopImageException("Error while loading image "
                                    + this.m_href.toString() + " : "
                                    + this.getClass() + " - "
                                    + "length mismatch on read");
      }

--

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 31692] - [PATCH] color for SVG text elements wasn't set correctly

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31692>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31692

------- Additional Comments From azack <at> grtmail.com  2005-06-02 22:59 -------
Confirmed that this fixes a real bug with the fop maintenance branch in cvs. It
would be nice if it could be checked in.

--

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Impact of logging on performance (was: Re: cvs commit: xml-fop/src/java/org/apache/fop/area PageViewport.java)

An explanation why the "log.isDebugEnabled()" was there and why it
should be added again (maybe not necessarily in this case since it's
only called once per page but as a general rule):

"+" operations with Strings usually results in a StringBuffer being
created the two Strings before and after the operator being combined and
then converted to a String object again. If you have multiple "+"
operator it depends on the intelligence of the JIT compiler whether it
creates only one StringBuffer or one for each "+" operation. Older VMs
always created multiple StringBuffers.

What happens without the isDebugEnabled() is that the combined String is
always (!) built (possibly multiple new String and StringBuffer
instances as well as possibly multiple calls to other methods for
building te String) and then passed into the debug() method. Only then
will the logging implementation check if the log level is sufficient to
output the log statement.

General rule of thumb: Always surround a debug log statement with a
isDebugEnabled() check if the log statement is non-trivial (i.e.
not a simple constant String).

More information:
http://jakarta.apache.org/commons/logging/api/org/apache/commons/logging/Log.html
http://logging.apache.org/log4j/docs/manual.html#performance
http://excalibur.apache.org/apidocs/org/apache/avalon/framework/logger/Logger.html
https://www.qos.ch/ac2001/F11-190.html

On 06.06.2005 07:46:00 gmazza wrote:
>   -        if (log.isDebugEnabled()) {
>   -            log.debug("[" + curPV.getPageNumberString() + (bIsBlank ? "*" : "") + "]");
>   -        }
>   -
>   -        curPV.createSpan(false);
>   +        log.debug("[" + curPV.getPageNumberString() + (bIsBlank ? "*" : "") + "]");
>            return curPV;

Jeremias Maerki

Re: Impact of logging on performance (was: Re: cvs commit: xml-fop/src/java/org/apache/fop/area PageViewport.java)

On 06.06.2005 09:15:34 Jeremias Maerki wrote:
> operator it depends on the intelligence of the JIT compiler whether it

That should have been the Java Compiler, not the JIT compiler.

Jeremias Maerki

FYI: Proposal for Google's Summer of Code

FYI, I've just posted a proposal for Google's Summer of Code on the Wiki
at:
http://wiki.apache.org/general/SummerOfCode2005

I thought, since I'm currently too busy in the layout engine and Peter
Herweg has obviously gone inactive, I'll post this. Maybe we get lucky.
The task is quite isolated which makes it ideal.

Subject ID 
fop-rtf 

Title 
Finalize the RTF output support for Apache FOP 

ASF Project 
Apache FOP (XSL-FO processor) 

Keywords 
FOP, XSL-FO, formatting objects, RTF, Rich Text Format, document
generation 

Description 
JFOR, an open source XSL-FO to RTF converter, has been integrated into
Apache FOP some time ago. Now that we're getting close to releasing our
rewritten layout engine it would be great to have RTF output releasable,
too. The framework for generating RTF is there and many things already
work, but there are still many missing features and a number of bugs to
be handled so this part of FOP is ready production use. RTF is still a
quite important format when enterprises want to create documents from
business cases. Unlike PDF and PostScript documents, RTF documents can
be opened in Microsoft Word, for example, and manually edited by the
user which is a frequent desire. 

Possible Mentors 
Jeremias Märki (< jeremias <at> apache.org>) 

Status 
Available 

Jeremias Maerki

[Tests] automated Tests for FOP's XSL-Standard compilance

Hi there,

are there any (unit) tests regarding FOP's standard compilance?

I'd like to document the FOP behaivor when it becomes an input file that contains a <fo:table/> with NO table-layout="fixed".
So in my case (not a test case (yet)) I saw a PDF file on my disk (so "out.size() > 0" is true ;)), but that guy is
empty, since
FOP isn't able to process that <fo:table/>. Such a test case would be fine to create automated test on my
development cases.

I am using/evaluating (better testing?) some converters (html2fo and css2xslfo) to produce FO files from
(x)html files. And that pain I would like to automate ;)

Any ideas? Or perhaps existing test cases ? ;)

Thanks and regards,
Matthias

build fop-1.0dev in java IDE