headers
phancock | 6 Feb 11:18
Picon
Favicon

svn commit: r1240963 - in /xmlgraphics/fop/branches/Temp_ImproveAccessibility: ./ src/java/org/apache/fop/accessibility/ src/java/org/apache/fop/accessibility/fo/ src/java/org/apache/fop/apps/ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/ s...

Author: phancock
Date: Mon Feb  6 10:18:09 2012
New Revision: 1240963

URL: http://svn.apache.org/viewvc?rev=1240963&view=rev
Log:
Addressed findbugs and checkstyle regressions

Findbugs report generated with version 1.3.9.
Checkstyle report generated with version 5.5.


Modified:
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/findbugs-exclude.xml
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/accessibility/DummyStructureTreeEventHandler.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/accessibility/StructureTree2SAXEventAdapter.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/accessibility/StructureTreeElement.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/accessibility/fo/StructureTreeEventTrigger.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/apps/FOUserAgent.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/area/AreaTreeParser.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/FOEventHandler.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/FONode.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/FOText.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/flow/AbstractGraphics.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/flow/AbstractListItemPart.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/flow/AbstractPageNumberCitation.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/flow/Block.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/flow/Footnote.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/flow/FootnoteBody.java
    xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/fo/flow/InitialPropertySet.java
(Continue reading)

Permalink | Reply | 0 comments |
headers
mehdi | 6 Feb 16:29
Picon
Favicon

svn commit: r1241041 - in /xmlgraphics/fop/trunk/src/documentation/content/xdocs: dev/api-doc.xml site.xml trunk/embedding.xml

Author: mehdi
Date: Mon Feb  6 15:29:12 2012
New Revision: 1241041

URL: http://svn.apache.org/viewvc?rev=1241041&view=rev
Log:
Bugzilla#52536: Added documentation about FOPs API and updated related documentation

Removed:
    xmlgraphics/fop/trunk/src/documentation/content/xdocs/dev/api-doc.xml
Modified:
    xmlgraphics/fop/trunk/src/documentation/content/xdocs/site.xml
    xmlgraphics/fop/trunk/src/documentation/content/xdocs/trunk/embedding.xml

Modified: xmlgraphics/fop/trunk/src/documentation/content/xdocs/site.xml
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/documentation/content/xdocs/site.xml?rev=1241041&r1=1241040&r2=1241041&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/documentation/content/xdocs/site.xml (original)
+++ xmlgraphics/fop/trunk/src/documentation/content/xdocs/site.xml Mon Feb  6 15:29:12 2012
@@ -211,7 +211,6 @@
   </design>

   <develop label="Develop" href="dev/" tab="development">
-    <api-doc label="API Doc" href="api-doc.html"/>
     <walkthru label="Walk-Thru" href="implement.html" tab="development"/>
     <patch label="Patch Queue"
href="http://issues.apache.org/bugzilla/buglist.cgi?bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;email1=&amp;emailtype1=substring&amp;emailassigned_to1=1&amp;email2=&amp;emailtype2=substring&amp;emailreporter2=1&amp;bugidtype=include&amp;bug_id=&amp;changedin=&amp;votes=&amp;chfieldfrom=&amp;chfieldto=Now&amp;chfieldvalue=&amp;product=Fop&amp;short_desc=%5BPATCH%5D&amp;short_desc_type=allwordssubstr&amp;long_desc=&amp;long_desc_type=allwordssubstr&amp;bug_file_loc=&amp;bug_file_loc_type=allwordssubstr&amp;keywords=&amp;keywords_type=anywords&amp;field0-0-0=noop&amp;type0-0-0=noop&amp;value0-0-0=&amp;namedcmd=Fop+all&amp;newqueryname=fop+patch+queue&amp;tofooter=1&amp;order=Reuse+same+sort+as+last+time" tab="development"/>
     <conventions label="Conventions" href="conventions.html" tab="development"/>

Modified: xmlgraphics/fop/trunk/src/documentation/content/xdocs/trunk/embedding.xml
(Continue reading)

Permalink | Reply | 0 comments |
headers
phancock | 10 Feb 17:51
Picon
Favicon

svn commit: r1242848 [4/5] - in /xmlgraphics/fop/trunk: ./ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/accessibility/ src/java/org/apache/fop/accessibility/fo/ src/java/org/apache/fop/afp/apps/ src/java/org/apache/fop/afp/parser/ ...

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java?rev=1242848&r1=1242847&r2=1242848&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java Fri Feb 10 16:51:08 2012
 <at>  <at>  -37,6 +37,7  <at>  <at>  import org.apache.fop.fonts.SingleByteFo
 import org.apache.fop.fonts.Typeface;
 import org.apache.fop.pdf.PDFDocument;
 import org.apache.fop.pdf.PDFNumber;
+import org.apache.fop.pdf.PDFStructElem;
 import org.apache.fop.pdf.PDFTextUtil;
 import org.apache.fop.pdf.PDFXObject;
 import org.apache.fop.render.RenderingContext;
 <at>  <at>  -133,24 +134,24  <at>  <at>  public class PDFPainter extends Abstract
         PDFXObject xobject = getPDFDoc().getXObject(uri);
         if (xobject != null) {
             if (accessEnabled) {
-                String ptr = getContext().getStructurePointer();
-                prepareImageMCID(ptr);
+                PDFStructElem structElem = (PDFStructElem) getContext().getStructureTreeElement();
+                prepareImageMCID(structElem);
                 placeImageAccess(rect, xobject);
             } else {
                 placeImage(rect, xobject);
             }
         } else {
             if (accessEnabled) {
-                String ptr = getContext().getStructurePointer();
-                prepareImageMCID(ptr);
+                PDFStructElem structElem = (PDFStructElem) getContext().getStructureTreeElement();
(Continue reading)

Permalink | Reply | 0 comments |
headers
phancock | 10 Feb 17:51
Picon
Favicon

svn commit: r1242848 [2/5] - in /xmlgraphics/fop/trunk: ./ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/accessibility/ src/java/org/apache/fop/accessibility/fo/ src/java/org/apache/fop/afp/apps/ src/java/org/apache/fop/afp/parser/ ...

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/AbstractGraphics.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/AbstractGraphics.java?rev=1242848&r1=1242847&r2=1242848&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/AbstractGraphics.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/AbstractGraphics.java Fri Feb 10 16:51:08 2012
 <at>  <at>  -19,17 +19,20  <at>  <at> 
 
 package org.apache.fop.fo.flow;
 
+import org.apache.fop.accessibility.StructureTreeElement;
 import org.apache.fop.apps.FOPException;
 import org.apache.fop.datatypes.Length;
 import org.apache.fop.fo.FONode;
 import org.apache.fop.fo.FObj;
 import org.apache.fop.fo.GraphicsProperties;
 import org.apache.fop.fo.PropertyList;
+import org.apache.fop.fo.properties.CommonAccessibility;
+import org.apache.fop.fo.properties.CommonAccessibilityHolder;
 import org.apache.fop.fo.properties.CommonBorderPaddingBackground;
 import org.apache.fop.fo.properties.KeepProperty;
 import org.apache.fop.fo.properties.LengthRangeProperty;
 import org.apache.fop.fo.properties.SpaceProperty;
-import org.apache.fop.fo.properties.StructurePointerPropertySet;
+import org.apache.fop.fo.properties.StructureTreeElementHolder;
 
 /**
  * Common base class for the <a href="http://www.w3.org/TR/xsl/#fo_instream-foreign-object">
 <at>  <at>  -38,10 +41,11  <at>  <at>  import org.apache.fop.fo.properties.Stru
  * <code>fo:external-graphic</code></a> flow formatting objects.
  */
(Continue reading)

Permalink | Reply | 0 comments |
headers
phancock | 10 Feb 17:51
Picon
Favicon

svn commit: r1242848 [5/5] - in /xmlgraphics/fop/trunk: ./ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/accessibility/ src/java/org/apache/fop/accessibility/fo/ src/java/org/apache/fop/afp/apps/ src/java/org/apache/fop/afp/parser/ ...

Added: xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/FONodeMocks.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/FONodeMocks.java?rev=1242848&view=auto
==============================================================================
--- xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/FONodeMocks.java (added)
+++ xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/FONodeMocks.java Fri Feb 10 16:51:08 2012
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* $Id$ */
+
+package org.apache.fop.fo;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyString;
+import static org.mockito.Mockito.mock;
(Continue reading)

Permalink | Reply | 0 comments |
headers
phancock | 10 Feb 17:51
Picon
Favicon

svn commit: r1242848 [3/5] - in /xmlgraphics/fop/trunk: ./ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/accessibility/ src/java/org/apache/fop/accessibility/fo/ src/java/org/apache/fop/afp/apps/ src/java/org/apache/fop/afp/parser/ ...

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFDocument.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFDocument.java?rev=1242848&r1=1242847&r2=1242848&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFDocument.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFDocument.java Fri Feb 10 16:51:08 2012
 <at>  <at>  -350,25 +350,6  <at>  <at>  public class PDFDocument {
     }
 
     /**
-     * Makes sure a Lang entry has been set on the document catalog, setting it
-     * to a default value if necessary. When accessibility is enabled the
-     * language must be specified for any text element in the document.
-     */
-    public void enforceLanguageOnRoot() {
-        if (root.getLanguage() == null) {
-            String fallbackLanguage;
-            if (getProfile().getPDFAMode().isPDFA1LevelA()) {
-                //According to Annex B of ISO-19005-1:2005(E), section B.2
-                fallbackLanguage = "x-unknown";
-            } else {
-                //No language has been set on the first page-sequence, so fall back to "en".
-                fallbackLanguage = "en";
-            }
-            root.setLanguage(fallbackLanguage);
-        }
-    }
-
-    /**
      * Get the { <at> link PDFInfo} object for this document.
      *
(Continue reading)

Permalink | Reply | 0 comments |
headers
phancock | 10 Feb 17:51
Picon
Favicon

svn commit: r1242848 [1/5] - in /xmlgraphics/fop/trunk: ./ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/accessibility/ src/java/org/apache/fop/accessibility/fo/ src/java/org/apache/fop/afp/apps/ src/java/org/apache/fop/afp/parser/ ...

Author: phancock
Date: Fri Feb 10 16:51:08 2012
New Revision: 1242848

URL: http://svn.apache.org/viewvc?rev=1242848&view=rev
Log:
Merged in Temp_ImproveAccessibility

revs 1187234, 1188205, 1205935, 1236718, 1238313, 1240963

Added:
    xmlgraphics/fop/trunk/src/java/org/apache/fop/accessibility/DummyStructureTreeEventHandler.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/accessibility/StructureTree2SAXEventAdapter.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/accessibility/StructureTreeElement.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/accessibility/StructureTreeEventHandler.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/accessibility/fo/
      - copied from r1242827, xmlgraphics/fop/branches/Temp_ImproveAccessibility/src/java/org/apache/fop/accessibility/fo/
    xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/DelegatingFOEventHandler.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/CommonAccessibilityHolder.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/StructureTreeElementHolder.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/intermediate/IFStructureTreeBuilder.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFStructureTreeBuilder.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/util/LanguageTags.java
    xmlgraphics/fop/trunk/test/accessibility/fop.xconf
    xmlgraphics/fop/trunk/test/accessibility/pdf/background-image_jpg_repeat.pdf   (with props)
    xmlgraphics/fop/trunk/test/accessibility/pdf/background-image_jpg_single.pdf   (with props)
    xmlgraphics/fop/trunk/test/accessibility/pdf/background-image_png_repeat.pdf   (with props)
    xmlgraphics/fop/trunk/test/accessibility/pdf/background-image_png_single.pdf   (with props)
    xmlgraphics/fop/trunk/test/accessibility/pdf/background-image_svg_repeat.pdf   (with props)
    xmlgraphics/fop/trunk/test/accessibility/pdf/background-image_svg_single.pdf   (with props)
(Continue reading)

Permalink | Reply | 0 comments |
headers
mehdi | 13 Feb 12:41
Picon
Favicon

svn commit: r1243479 - /xmlgraphics/fop/branches/Temp_URI_Unification/

Author: mehdi
Date: Mon Feb 13 11:41:04 2012
New Revision: 1243479

URL: http://svn.apache.org/viewvc?rev=1243479&view=rev
Log:
Created branch for URI unification

Added:
    xmlgraphics/fop/branches/Temp_URI_Unification/   (props changed)
      - copied from r1243478, xmlgraphics/fop/trunk/

Propchange: xmlgraphics/fop/branches/Temp_URI_Unification/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Mon Feb 13 11:41:04 2012
@@ -0,0 +1,17 @@
+build
+jpfop-0.17.0
+build-local.properties
+checkstyle-noframes.xsl
+.classpath
+.project
+.externalToolBuilders
+.checkstyle
+.settings
+.cache
+dist-bin
+dist-src
+work
(Continue reading)

Permalink | Reply | 0 comments |
headers
mehdi | 13 Feb 16:00
Picon
Favicon

svn commit: r1243549 - in /xmlgraphics/fop/trunk/test/java/org/apache/fop: fo/flow/table/AllTests.java pdf/PDFLibraryTestSuite.java

Author: mehdi
Date: Mon Feb 13 15:00:41 2012
New Revision: 1243549

URL: http://svn.apache.org/viewvc?rev=1243549&view=rev
Log:
Corrected error in Junit4 migration

Modified:
    xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/flow/table/AllTests.java
    xmlgraphics/fop/trunk/test/java/org/apache/fop/pdf/PDFLibraryTestSuite.java

Modified: xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/flow/table/AllTests.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/flow/table/AllTests.java?rev=1243549&r1=1243548&r2=1243549&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/flow/table/AllTests.java (original)
+++ xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/flow/table/AllTests.java Mon Feb 13
15:00:41 2012
@@ -19,16 +19,20 @@

 package org.apache.fop.fo.flow.table;

+import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
+import org.junit.runners.Suite.SuiteClasses;

 /**
  * All test to be added in FOTreeTestSuite
  *
  */
(Continue reading)

Permalink | Reply | 0 comments |
headers
mehdi | 14 Feb 15:48
Picon
Favicon

svn commit: r1243963 - in /xmlgraphics/fop/trunk: build.xml test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java test/layoutengine/disabled-testcases.xml

Author: mehdi
Date: Tue Feb 14 14:48:00 2012
New Revision: 1243963

URL: http://svn.apache.org/viewvc?rev=1243963&view=rev
Log:
Enabled assertions in junit tasks (analagous to JVM arg -ea)

- Disabled a layout test that fails an assertion
- Added an expression to a mocked class to pass assertion

Modified:
    xmlgraphics/fop/trunk/build.xml
    xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java
    xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml

Modified: xmlgraphics/fop/trunk/build.xml
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/build.xml?rev=1243963&r1=1243962&r2=1243963&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/build.xml (original)
+++ xmlgraphics/fop/trunk/build.xml Tue Feb 14 14:48:00 2012
@@ -787,6 +787,9 @@ list of possible build targets.
         <classpath>
           <path refid="@{classpath}"/>
         </classpath>
+	<assertions>
+	  <enable/>
+	</assertions>
         <test name="@{testsuite}" todir="${junit.reports.dir}" outfile="@{outfile}"/>
       </junit>
(Continue reading)

Permalink | Reply | 1 comment |

Gmane