1 Jul 2003 01:00
RE: Contribution: MultiPartPostAction & FilePartGenerator
Geoff Howard <cocoon <at> leverageweb.com>
2003-06-30 23:00:28 GMT
2003-06-30 23:00:28 GMT
Thank you for this work and your interest in contributing. I hope this is the first of many. Here are my thoughts after a quick look: The MultiPartPostAction seems unnecessary. What do you gain by placing a copy of the uploaded file which is already in the ObjectModel under the Request object directly in the ObjectModel? The FilePartGenerator OTOH seems useful (I don't think the existing StreamGenerator will do this). As noted above, the action is not needed in the equation - you can just get the FilePart right out of the Request in the Generator. Then, I don't see the reason behind the overloaded getInputSource() - the FilePart is designed to allow polymorphism there - just cast the Request.get() to FilePart and call FilePart.getInputStream() on it. If you find I'm correct, could you look at refactoring this and submitting a patch to Bugzilla? I'd be more than willing to help with anything that doesn't make sense to you. As far as I can see, none of the HSSF stuff is useful without the GnumericWriter which is GPL. The last I heard someone was working directly in the poi project on a Gnumeric "generator" from Excel that could then go straight in cvs. Unless that is now not a project that will ever happen for some reason, I'd be against introducing even the hooks for a GPL version that would just get replaced later. If you want to keep this available for others to contribute and benefit, I'd recommend approaching cocoondev which can by its nature accomodate GPL.(Continue reading)
RSS Feed