Steven Dolg (JIRA | 2 Nov 15:03
Picon
Favicon

[jira] Created: (COCOON3-9) Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.

Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.
---------------------------------------------------------------------------------------------------------------

                 Key: COCOON3-9
                 URL: https://issues.apache.org/jira/browse/COCOON3-9
             Project: Cocoon 3
          Issue Type: Improvement
          Components: cocoon-pipeline
    Affects Versions: 3.0.0-alpha-1
            Reporter: Steven Dolg
            Assignee: Cocoon Developers Team
             Fix For: 3.0.0-alpha-2

Currently the PipelineCache is very specific for caching the complete results of a pipeline execution.
COCCON3-6 is the first issue requiring a caching mechanism at the PipelineComponent level.

With only some minor modifications the PipelineCache can be used for those requirements.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Steven Dolg (JIRA | 2 Nov 16:04
Picon
Favicon

[jira] Updated: (COCOON3-9) Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.


     [
https://issues.apache.org/jira/browse/COCOON3-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Dolg updated COCOON3-9:
------------------------------

    Attachment: cache.patch

The provided patch basically renames the org.apache.cocoon.pipeline.caching.PipelineCache to
org.apache.cocoon.pipeline.caching.Cache and makes the interface more explicit about retrieving
valid/invalid cache entries.

Additionally I extended the org.apache.cocoon.pipeline.caching.CacheValue interface to allow
direct access to the stored content and provided a new implementation suitable for the requirements of COCOON3-6.

I also introduced abstract implementations for the Cache and CacheValue interface and added some more
documentation to make the interfaces/classes more comprehensible.

> Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: COCOON3-9
>                 URL: https://issues.apache.org/jira/browse/COCOON3-9
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: Steven Dolg
>            Assignee: Cocoon Developers Team
(Continue reading)

Steven Dolg (JIRA | 2 Nov 16:10
Picon
Favicon

[jira] Updated: (COCOON3-9) Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.


     [
https://issues.apache.org/jira/browse/COCOON3-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Dolg updated COCOON3-9:
------------------------------

    Description: 
Currently the PipelineCache is very specific for caching the complete results of a pipeline execution.
COCOON3-6 is the first issue requiring a caching mechanism at the PipelineComponent level.

With only some minor modifications the PipelineCache can be used for those requirements.

  was:
Currently the PipelineCache is very specific for caching the complete results of a pipeline execution.
COCCON3-6 is the first issue requiring a caching mechanism at the PipelineComponent level.

With only some minor modifications the PipelineCache can be used for those requirements.

> Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: COCOON3-9
>                 URL: https://issues.apache.org/jira/browse/COCOON3-9
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: Steven Dolg
>            Assignee: Cocoon Developers Team
(Continue reading)

Steven Dolg (JIRA | 3 Nov 10:40
Picon
Favicon

[jira] Updated: (COCOON3-9) Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.


     [
https://issues.apache.org/jira/browse/COCOON3-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Dolg updated COCOON3-9:
------------------------------

    Attachment: cache-fixed.patch

Apparently my first patch was broken.

Here a fixed one.

> Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: COCOON3-9
>                 URL: https://issues.apache.org/jira/browse/COCOON3-9
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: Steven Dolg
>            Assignee: Cocoon Developers Team
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cache-fixed.patch, cache.patch
>
>
> Currently the PipelineCache is very specific for caching the complete results of a pipeline execution.
(Continue reading)

Jeremy Quinn | 3 Nov 13:15
Picon
Favicon

Re: Very early 2.1.12-dojo1_1-dev committed

Dear Roy

Sorry about my delay in responding, I have been away.

Many thanks for finding and reporting these bugs, I will get your  
fixes submitted asap.

Firefox is pretty susceptible to comma issues, so I had hoped I had  
squashed them all. Well found !!

Keep up the good work.

best regards

Jeremy

On 29 Oct 2008, at 12:24, 黄海冬公司邮箱 wrote:

> Hi,Jeremy
>
> I found the reason why your code did't work under IE7. I found a  
> thread from
> dojo support forum
> http://dojotoolkit.org/forum/dojo-core-dojo-0-9/dojo-core-support/loading-cu
> stom-modules-ie7 and they are right,it is comma issues.
> I post your js code to jslint http://www.jslint.com/ and correct the  
> comma
> issues,rebuild,and works in IE 7.
>
> I change two files common.js and AjaxForm.js,the attachments are  
(Continue reading)

Picon
Favicon

[jira] Commented: (COCOON3-9) Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.


    [
https://issues.apache.org/jira/browse/COCOON3-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644712#action_12644712
] 

Simone Tripodi commented on COCOON3-9:
--------------------------------------

I merged the patch and played with it, IMHO this patch should be applied in trunk's code; just minor fixes
should be done:

1) javadoc: I didn't understand how the Cache should use
org.apache.cocoon.pipeline.caching.CacheKey's mehods;
2) IMHO an AbstractCache should be provided since we need also monitoring the cached resources and reload
them when "expired", so this logic could be managed in the Abstract class, concrete implementations
should only persist and retrieve resources;
3) How to inject Cache's instances to PipeLine Components? I suppose in cocoon-sitemap Caches will be
declared in the sitemap, but a public setter, in components that need using the Cache, could be useful to
inject it.

What do you think about it?

> Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: COCOON3-9
>                 URL: https://issues.apache.org/jira/browse/COCOON3-9
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
(Continue reading)

Picon
Favicon

[jira] Commented: (COCOON3-9) Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.


    [
https://issues.apache.org/jira/browse/COCOON3-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644716#action_12644716
] 

Simone Tripodi commented on COCOON3-9:
--------------------------------------

Sorry I didn't notice that an AbstractCache is already present, btw we should study a "Monitor" that lives
in the AbstractCache that's able to reload out-of-date entries...

> Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: COCOON3-9
>                 URL: https://issues.apache.org/jira/browse/COCOON3-9
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: Steven Dolg
>            Assignee: Cocoon Developers Team
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cache-fixed.patch, cache.patch
>
>
> Currently the PipelineCache is very specific for caching the complete results of a pipeline execution.
> COCOON3-6 is the first issue requiring a caching mechanism at the PipelineComponent level.
> With only some minor modifications the PipelineCache can be used for those requirements.
(Continue reading)

Steven Dolg (JIRA | 4 Nov 07:46
Picon
Favicon

[jira] Commented: (COCOON3-9) Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.


    [
https://issues.apache.org/jira/browse/COCOON3-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644905#action_12644905
] 

Steven Dolg commented on COCOON3-9:
-----------------------------------

Hi Simone,

I don't think we should add automatic reloading of cached resource to the cache itself.
IMO this would add unnecessary complexity to the cache, because it would need to know how to recreate the resources.
This should be the component's job. (Just compare this with available caching libraries like Ehcache)

Injecting caches into the PipelineComponents using the sitemap module works as you said (using an IOC container).
When creating a pipeline using the Pipeline API this has to be done programatically.
Since the components are constructed directly in the code the public setter of the component itself
(instead of the PipelineComponent interface) should be easily possible.

The Cache implementation itself does not need to bother with the CacheKey interface. This is merely a
mechanism to create specific CacheKeys that can be used to check cached resource for validity and/or
create compound cache keys (like the ones for pipelines where the validity depends on the configuration
of all relevant PipelineComponents).

> Generalize the PipelineCache, so that it can be used as a general purpose cache for PipelineComponents as well.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: COCOON3-9
>                 URL: https://issues.apache.org/jira/browse/COCOON3-9
>             Project: Cocoon 3
(Continue reading)

lingerer huang | 4 Nov 10:01
Picon

Re: Very early 2.1.12-dojo1_1-dev committed

Hi,Jeremy

I found two more problems.

1.Still IE problem,The TextArea.js make a extra comma for IE,I delete the
extra one and it works.The diff file shows what I did.

2.I am using UTF-8 for my application .But I found under the new dojo
version,my encoding setting will fail then when I saved the form the Chinese
chacter became ??.I capture the post info from browser and found only one
different .

The new one using Content-Type: application/x-www-form-urlencoded;
charset=UTF-8,but the old one using Content-Type:
application/x-www-form-urlencoded

I change your code in AjaxForm.js(line 71) back to using
"application/x-www-form-urlencoded" and it works all fine.

My original setting is all using ISO-8859-1,and setting form-encoding
through form-encoding action like:
	<map:act type="form-encoding">
		<map:parameter name="form-encoding" value="utf-8" />
	</map:act>	
So I guest when you using Content-Type: application/x-www-form-urlencoded;
charset=UTF-8,the server will do twice UTF-8 decode.Or you can provide a new
setting for international users.

best regards

(Continue reading)

Picon
Favicon

[jira] Created: (COCOON3-10) Packages could be re-organized

Packages could be re-organized
------------------------------

                 Key: COCOON3-10
                 URL: https://issues.apache.org/jira/browse/COCOON3-10
             Project: Cocoon 3
          Issue Type: Improvement
          Components: cocoon-pipeline
    Affects Versions: 3.0.0-alpha-2
            Reporter: Simone Tripodi
            Assignee: Cocoon Developers Team
             Fix For: 3.0.0-alpha-2
         Attachments: PackageOrganizing.patch

According to older cocoon's taxonomy, packages - particularly the xml package - could be re-organized,
discerning the roles of cocoon's components:

- generators
- serializers
- transformer

This is a nice way to maintain well-organized the code.

What do you think about it?

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

(Continue reading)


Gmane