Picon
Favicon

[jira] Commented: (COCOON-2216) IncludeCacheManager can not perfom parallel includes


    [
https://issues.apache.org/jira/browse/COCOON-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636059#action_12636059
] 

imran pariyani commented on COCOON-2216:
----------------------------------------

Hi Grzegorz, 

were u able to reproduce the problem with the second test case and with your patch applied ? 

> IncludeCacheManager can not perfom parallel includes
> ----------------------------------------------------
>
>                 Key: COCOON-2216
>                 URL: https://issues.apache.org/jira/browse/COCOON-2216
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Christoph Gaffga
>            Assignee: Grzegorz Kossakowski
>         Attachments: cocoon-trunk.patch, multi-thread-simple-28.09.2008.patch,
ParallelInclusionProblem-cocoon_TRUNK.patch, test-block.zip, test-block.zip,
test-webapp.zip, test-webapp.zip
>
>
> Since we migrated from cocoon 2.1 to 2.2 a generator that merges multiple sources from other cocoon
pipelines into one (similar to the aggregator) is not working anymore.
(Continue reading)

jira | 1 Oct 19:41
Picon
Favicon

[jira] Subscription: COCOON-open-with-patch

Issue Subscription
Filter: COCOON-open-with-patch (107 issues)
Subscriber: cocoon

Key         Summary
COCOON-2233 Update archetypes to current trunk artifact versions
            https://issues.apache.org/jira/browse/COCOON-2233
COCOON-2222 Add SaxParser configuration properties
            https://issues.apache.org/jira/browse/COCOON-2222
COCOON-2217 HttpServletResponseBufferingWrapper throws NPE when response body is empty
            https://issues.apache.org/jira/browse/COCOON-2217
COCOON-2216 IncludeCacheManager can not perfom parallel includes
            https://issues.apache.org/jira/browse/COCOON-2216
COCOON-2212 jx:attribute does not check name is correct before proceeding
            https://issues.apache.org/jira/browse/COCOON-2212
COCOON-2211 Support for jx:element
            https://issues.apache.org/jira/browse/COCOON-2211
COCOON-2197 Making the cocoon-auth-block acegi-security-sample work
            https://issues.apache.org/jira/browse/COCOON-2197
COCOON-2173 AbstractCachingProcessingPipeline: Two requests can deadlock each other
            https://issues.apache.org/jira/browse/COCOON-2173
COCOON-2162 [PATCH] Fix for Paginator when accessing out of bounds Pagination page
            https://issues.apache.org/jira/browse/COCOON-2162
COCOON-2137 XSD Schemas for CForms Development
            https://issues.apache.org/jira/browse/COCOON-2137
COCOON-2114 fix sorting in TraversableGenerator
            https://issues.apache.org/jira/browse/COCOON-2114
COCOON-2108 xmodule:flow-attr Does not accept document objects
            https://issues.apache.org/jira/browse/COCOON-2108
COCOON-2104 [PATCH] Add base URI fixup support to XIncludeTransformer
(Continue reading)

Favicon
Gravatar

Re: 2.2 samples down

Grzegorz Kossakowski pisze:
> Jasha Joachimsthal pisze:
>> Hi there,
>>  
>> the samples of 2.2 are (still) down [1]. Does anyone know how to bring
>> them up again?
>>  
>> [1] http://cocoon.zones.apache.org/demos/trunk/
> 
> Logs[2] do not reveal anything trivial so I guess this might be caused by my last activity on zone
> related to upgrade of Maven to 2.0.9 and Java to 1.5.
> [2] http://cocoon.zones.apache.org/logs/cocoon-demos/trunk/
> 
> I may have a look today's night or tomorrow.

Found the cause - Maven starts jetty using wrong (default) port number, see the last line of the log[3]:
2008-10-01 16:11:14.548::INFO:  Started SelectChannelConnector <at> 0.0.0.0:8888

After quick testing at my local computer it looks like settings from MAVEN_OPTS environment variable
are not propagated to jetty:run plug-in. In order to test it try:
cd core/cocoon-webapp
export MAVEN_OPTS="-Djetty.port=8123"
mvn jetty:run

and check at which port jetty listens. If it's not 8123 then we have found a bug and we should
report it to Maven team. If anyone confirms this problem I'll introduce temporary fix so our demos
are online again.

[3] http://cocoon.zones.apache.org/logs/cocoon-demos/trunk/stderr.log

(Continue reading)

Picon
Favicon

[jira] Commented: (COCOON-2216) IncludeCacheManager can not perfom parallel includes


    [
https://issues.apache.org/jira/browse/COCOON-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636201#action_12636201
] 

Grzegorz Kossakowski commented on COCOON-2216:
----------------------------------------------

Hi Imran,

Sorry for next delay - this time I'm moving to a new flat.

When it comes to your problem I've looked into sources of JX templates and found:
Attr 1 :${cocoon.request.getParameter('attr1')}<br/>

I believe it should look like:
Attr 1 :${cocoon.request.getAttribute('attr1')}<br/>

After applying this change both parameters and attributes works fine for me. Is there anything else
missing? I would like to start polishing of my patch so it can be applied to trunk.

> IncludeCacheManager can not perfom parallel includes
> ----------------------------------------------------
>
>                 Key: COCOON-2216
>                 URL: https://issues.apache.org/jira/browse/COCOON-2216
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.2-dev (Current SVN)
(Continue reading)

Picon
Favicon

[jira] Commented: (COCOON-2216) IncludeCacheManager can not perfom parallel includes


    [
https://issues.apache.org/jira/browse/COCOON-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636231#action_12636231
] 

imran pariyani commented on COCOON-2216:
----------------------------------------

sorry for that typo .. but for me after changing it to attribute also its still the same .. i mean the fisrt time
the page is loaded the attributes and the parameters are there .. but then when u keep clicking the links
with the parameters most of the time the attributes are missing .. 

on each component at the ends there are links like: 
With Parameter 1 With parameter 1 and 2 With parameter 1,2 and 3 

those are the three links .. and as i said if u keep clicking them most of the time the parameters and the
attributes are missing .. 

without the params also the attribute should always be there .. but if i keep refreshing the page the
attribute is also often missing 

did u change anything except for the changes present in the patch ?
i have the source from your git repo so i think it should be the recent one ..  

> IncludeCacheManager can not perfom parallel includes
> ----------------------------------------------------
>
>                 Key: COCOON-2216
>                 URL: https://issues.apache.org/jira/browse/COCOON-2216
>             Project: Cocoon
(Continue reading)

Jasha Joachimsthal | 2 Oct 08:59
Favicon
Gravatar

RE: 2.2 samples down


> -----Original Message-----
> From: Grzegorz Kossakowski [mailto:grek <at> tuffmail.com] 
> Sent: woensdag 1 oktober 2008 23:43
> To: dev <at> cocoon.apache.org
> Subject: Re: 2.2 samples down
> 
> Grzegorz Kossakowski pisze:
> > Jasha Joachimsthal pisze:
> >> Hi there,
> >>  
> >> the samples of 2.2 are (still) down [1]. Does anyone know how to 
> >> bring them up again?
> >>  
> >> [1] http://cocoon.zones.apache.org/demos/trunk/
> > 
> > Logs[2] do not reveal anything trivial so I guess this 
> might be caused 
> > by my last activity on zone related to upgrade of Maven to 
> 2.0.9 and Java to 1.5.
> > [2] http://cocoon.zones.apache.org/logs/cocoon-demos/trunk/
> > 
> > I may have a look today's night or tomorrow.
> 
> Found the cause - Maven starts jetty using wrong (default) 
> port number, see the last line of the log[3]:
> 2008-10-01 16:11:14.548::INFO:  Started 
> SelectChannelConnector <at> 0.0.0.0:8888
> 
> After quick testing at my local computer it looks like 
(Continue reading)

Favicon
Gravatar

Re: 2.2 samples down

Jasha Joachimsthal wrote:
> I just tried to start up the "My first block" with "mvn
> -Djetty.port=8123 jetty:run" but it still uses port 8888. 

This is weird. For me this worked yesterday. Only when setting
jetty.port using MAVEN_OPTS Maven ignored that setting.

> Only when I
> comment the <connectors> part in the pom.xml it listens to port 8123. So
> I think the configuration in the pom overrides the commandline port.
>   
Which should be the opposite way.

What version of Maven and jetty plugin do you use?

--

-- 
Grzegorz

Jasha Joachimsthal | 2 Oct 11:47
Favicon
Gravatar

RE: 2.2 samples down


> -----Original Message-----
> From: Grzegorz Kossakowski [mailto:grek <at> tuffmail.com] 
> Sent: donderdag 2 oktober 2008 11:21
> To: dev <at> cocoon.apache.org
> Subject: Re: 2.2 samples down
> 
> Jasha Joachimsthal wrote:
> > I just tried to start up the "My first block" with "mvn
> > -Djetty.port=8123 jetty:run" but it still uses port 8888. 
> 
> This is weird. For me this worked yesterday. Only when 
> setting jetty.port using MAVEN_OPTS Maven ignored that setting.
> 
> > Only when I
> > comment the <connectors> part in the pom.xml it listens to 
> port 8123. 
> > So I think the configuration in the pom overrides the 
> commandline port.
> >   
> Which should be the opposite way.
> 
> What version of Maven and jetty plugin do you use?

Maven 2.0.9, jetty-plugin 6.1.7, Java 5 in Windows XP

Jasha

Picon
Favicon

[jira] Commented: (COCOON-2216) IncludeCacheManager can not perfom parallel includes


    [
https://issues.apache.org/jira/browse/COCOON-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636361#action_12636361
] 

Grzegorz Kossakowski commented on COCOON-2216:
----------------------------------------------

Imran,

It's my time to apologize. I didn't read your previous description carefully enough. Now I could reproduce
your problem which is just a sign of much bigger problem.

IncludeCacheManager uses thread pooling technique which does not play nicely with ThreadLocals, see: http://java.sys-con.com/node/37241

As I said this problem is not limited to the newly introduced Factory for ObjectModel. Servlet Service Fw
and Spring itself use ThreadLocals as well.

I think this is a right time to move this discussion to dev@ list so others can comment. I'll be probably in
favour of removing thread pooling completely but I don't know performance implications at the moment.

> IncludeCacheManager can not perfom parallel includes
> ----------------------------------------------------
>
>                 Key: COCOON-2216
>                 URL: https://issues.apache.org/jira/browse/COCOON-2216
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.2-dev (Current SVN)
(Continue reading)

Picon
Favicon

[jira] Commented: (COCOON-2216) IncludeCacheManager can not perfom parallel includes


    [
https://issues.apache.org/jira/browse/COCOON-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636376#action_12636376
] 

imran pariyani commented on COCOON-2216:
----------------------------------------

hi Grzegorz,

in the article there was something about "Lack of a Standard Thread-Pooling Library " .. now there is a
standard which comes with the JDK .. i don't know if we are using that or not .. but it is possible that it might
take care of the ThreadLocal variables .. just a thought.

should i forward this discussion to the dev mailing list ? 

> IncludeCacheManager can not perfom parallel includes
> ----------------------------------------------------
>
>                 Key: COCOON-2216
>                 URL: https://issues.apache.org/jira/browse/COCOON-2216
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Christoph Gaffga
>            Assignee: Grzegorz Kossakowski
>         Attachments: cocoon-trunk.patch, multi-thread-simple-28.09.2008.patch,
ParallelInclusionProblem-cocoon_TRUNK.patch, test-block.zip, test-block.zip,
test-webapp.zip, test-webapp.zip
(Continue reading)


Gmane