Cocoon development

Rice Yeh | 2 Sep 08:53

Re: True OO for servlet service

Hi Grek,
Attached is the patch that is based on the present cocoon-servlet-service-impl implementation. cocoon-servlet-service-impl has some change since I posted my patch on COCOON-2038, which has already too many files attached to it. In order not to confuse you, I have the the patch attached to this mail. So you do not need to patch the files in COCOON-2038. I find you already have written a test case class ServletServiceContextTestCase for ServletServiceContext. I add one more test case in it to test COCOON-1939. All the test cases in ServletServiceContextTestCase are passed.
So after applying this patch, you might close COCOON-2038 by referring back to this mail if there are no further problems.

Regards,
Rice

On 8/29/07, Grzegorz Kossakowski <grek <at> tuffmail.com> wrote:

Hello,

I don't have that much time to spend these days on Cocoon but I would really like to see true Object
Oriented approach implemented in upcoming[1] release of cocoon-servlet-service. The main task is
tracked by COCOON-2038[2] where Rice Yeh has uploaded his patch implementing true OO behaviour in
servlet-service-fw. According to Rice, this patch contains a bug-fix as well (details in the comments).

After reviewing Rice's patch I decided that we really need test coverage for this quite complicated
functionality for both ServletServiceContext class usage clarity and casual hunting for bugs. Daniel
pointed me to another bug report (COCOON-1939[3]) that involves OO aspects of servlet-service-fw.
That makes point about test coverage even more strong.

What I would like to ask you for in this e-mail is to add additional tests to
ServletServiceContextTestCase class that exhibit problems mentioned in both issues. As soon as I
have working test cases I guess that fixing problems would be quite easy. Since it was you who
discovered problems it should be quite easy to write tests for them, too.

Alexander and Rice, can I count on your help with this before next release in late September is cut?

[1] http://article.gmane.org/gmane.text.xml.cocoon.devel/74999
[2] https://issues.apache.org/jira/browse/COCOON-2038
[3] https://issues.apache.org/jira/browse/COCOON-1939

--
Grzegorz Kossakowski
http://reflectingonthevicissitudes.wordpress.com/

Attachment (cocoon-servlet-service-impl.patch): application/octet-stream, 8 KiB

headers

Grzegorz Kossakowski (JIRA | 2 Sep 11:11

[jira] Updated: (COCOON-2038) Implement true Object Oriented approach for handling super calls


     [
https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2038:
-----------------------------------------

    Attachment:     (was: DispatcherServlet.java.patch)

> Implement true Object Oriented approach for handling super calls
> ----------------------------------------------------------------
>
>                 Key: COCOON-2038
>                 URL: https://issues.apache.org/jira/browse/COCOON-2038
>             Project: Cocoon
>          Issue Type: Task
>          Components: - Servlet service framework
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: cocoon-servlet-service-impl.patch
>
>
> As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317 implementation of
super calls should be changed to make it more OO-like.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

headers

Grzegorz Kossakowski (JIRA | 2 Sep 11:11

[jira] Updated: (COCOON-2038) Implement true Object Oriented approach for handling super calls


     [
https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2038:
-----------------------------------------

    Attachment:     (was: StatusRetrievableResponse.java)

> Implement true Object Oriented approach for handling super calls
> ----------------------------------------------------------------
>
>                 Key: COCOON-2038
>                 URL: https://issues.apache.org/jira/browse/COCOON-2038
>             Project: Cocoon
>          Issue Type: Task
>          Components: - Servlet service framework
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: cocoon-servlet-service-impl.patch
>
>
> As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317 implementation of
super calls should be changed to make it more OO-like.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

headers

Grzegorz Kossakowski (JIRA | 2 Sep 11:11

[jira] Updated: (COCOON-2038) Implement true Object Oriented approach for handling super calls


     [
https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2038:
-----------------------------------------

    Attachment:     (was: ServletServiceContext.java.patch)

> Implement true Object Oriented approach for handling super calls
> ----------------------------------------------------------------
>
>                 Key: COCOON-2038
>                 URL: https://issues.apache.org/jira/browse/COCOON-2038
>             Project: Cocoon
>          Issue Type: Task
>          Components: - Servlet service framework
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: cocoon-servlet-service-impl.patch
>
>
> As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317 implementation of
super calls should be changed to make it more OO-like.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

headers

Grzegorz Kossakowski (JIRA | 2 Sep 11:11

[jira] Updated: (COCOON-2038) Implement true Object Oriented approach for handling super calls


     [
https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2038:
-----------------------------------------

    Attachment:     (was: BlockCallHttpServletResponse.java.patch)

> Implement true Object Oriented approach for handling super calls
> ----------------------------------------------------------------
>
>                 Key: COCOON-2038
>                 URL: https://issues.apache.org/jira/browse/COCOON-2038
>             Project: Cocoon
>          Issue Type: Task
>          Components: - Servlet service framework
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: cocoon-servlet-service-impl.patch
>
>
> As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317 implementation of
super calls should be changed to make it more OO-like.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

headers

Grzegorz Kossakowski | 2 Sep 11:28

Re: True OO for servlet service

Rice Yeh pisze:
> Hi Grek,

Hi Rice :)

>   Attached is the patch that is based on the present
> cocoon-servlet-service-impl implementation. cocoon-servlet-service-impl
> has some change since I posted my patch on COCOON-2038, which has
> already too many files attached to it. In order not to confuse you, I
> have the the patch attached to this mail. So you do not need to patch
> the files in COCOON-2038. 

There is a legal problem with such approach. When attaching patch to a JIRA issue you check the
option that you intend this file for inclusion to the source codes licensed by Apache License. This
agreement is a must in order to commit your patch.

I already cleaned up COCOON-2038 so you can safely attach your patch as
cocoon-servlet-service-impl-with-tests.patch.

> I find you already have written a test case
> class ServletServiceContextTestCase for ServletServiceContext. 

Yes and I wanted to know if testContextInServletCalledFromExplicitSuperCall covers the bug we were
talking about in COCOON-2038 as I'm not sure.

> I add one
> more test case in it to test COCOON-1939. All the test cases in
> ServletServiceContextTestCase are passed.
> So after applying this patch, you might close COCOON-2038 by referring
> back to this mail if there are no further problems.

Great, thanks Rice for your work! As long as all doubts are dispelled I'll commit your patch.

--

-- 
Grzegorz Kossakowski
http://reflectingonthevicissitudes.wordpress.com/

headers

Rice Yeh (JIRA | 2 Sep 12:13

[jira] Updated: (COCOON-2038) Implement true Object Oriented approach for handling super calls


     [
https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rice Yeh updated COCOON-2038:
-----------------------------

    Attachment: cocoon-servlet-service-impl.patch

refer to mail http://www.mail-archive.com/dev <at> cocoon.apache.org/msg53636.html.

Rice

> Implement true Object Oriented approach for handling super calls
> ----------------------------------------------------------------
>
>                 Key: COCOON-2038
>                 URL: https://issues.apache.org/jira/browse/COCOON-2038
>             Project: Cocoon
>          Issue Type: Task
>          Components: - Servlet service framework
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch
>
>
> As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317 implementation of
super calls should be changed to make it more OO-like.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

headers

Grzegorz Kossakowski (JIRA | 2 Sep 12:53

[jira] Assigned: (COCOON-1939) Stack overflow when inheriting from block that alread inherits from another one


     [
https://issues.apache.org/jira/browse/COCOON-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski reassigned COCOON-1939:
--------------------------------------------

    Assignee: Grzegorz Kossakowski

> Stack overflow when inheriting from block that alread inherits from another one
> -------------------------------------------------------------------------------
>
>                 Key: COCOON-1939
>                 URL: https://issues.apache.org/jira/browse/COCOON-1939
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Servlet service framework
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Alexander Klimetschek
>            Assignee: Grzegorz Kossakowski
>
> There are problems with the following scenario: I have one Block A, another one B that has A as super-block
defined and a third one C that has B as super-block defined.
> The super-relation between B and A works ok, but if you start in C, then forward to B, which in turn wants to
forward to block A (all via the block:super: protocol), a stack overflow happens. It looks like he always
thinks he is in C, so that block:super: from B will always get to B, thus creating an endless loop.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

headers

Grzegorz Kossakowski (JIRA | 2 Sep 17:59

[jira] Updated: (COCOON-2038) Implement true Object Oriented approach for handling super calls


     [
https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2038:
-----------------------------------------

    Attachment: cocoon-servlet-service-2007-09-02.patch

Attaching simplified Rice's patch that still does not pass tests.

> Implement true Object Oriented approach for handling super calls
> ----------------------------------------------------------------
>
>                 Key: COCOON-2038
>                 URL: https://issues.apache.org/jira/browse/COCOON-2038
>             Project: Cocoon
>          Issue Type: Task
>          Components: - Servlet service framework
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: cocoon-servlet-service-2007-09-02.patch, cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch
>
>
> As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317 implementation of
super calls should be changed to make it more OO-like.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

headers

Grzegorz Kossakowski (JIRA | 2 Sep 18:21

[jira] Closed: (COCOON-1939) Stack overflow when inheriting from block that alread inherits from another one


     [
https://issues.apache.org/jira/browse/COCOON-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski closed COCOON-1939.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2-dev (Current SVN)

Fixed in r572015.

> Stack overflow when inheriting from block that alread inherits from another one
> -------------------------------------------------------------------------------
>
>                 Key: COCOON-1939
>                 URL: https://issues.apache.org/jira/browse/COCOON-1939
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Servlet service framework
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Alexander Klimetschek
>            Assignee: Grzegorz Kossakowski
>             Fix For: 2.2-dev (Current SVN)
>
>
> There are problems with the following scenario: I have one Block A, another one B that has A as super-block
defined and a third one C that has B as super-block defined.
> The super-relation between B and A works ok, but if you start in C, then forward to B, which in turn wants to
forward to block A (all via the block:super: protocol), a stack overflow happens. It looks like he always
thinks he is in C, so that block:super: from B will always get to B, thus creating an endless loop.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Mon	Tue	Wed	Thu	Fri	Sat	Sun

					1	2
3	4	5	6	7	8	9
10	11	12	13	14	15	16
17	18	19	20	21	22	23
24	25	26	27	28	29	30

9	February 2012
85	January 2012
106	December 2011
54	November 2011
48	October 2011
53	September 2011
88	August 2011
79	July 2011
88	June 2011
9	May 2011
35	April 2011
14	March 2011
44	February 2011
34	January 2011
27	December 2010
15	November 2010
16	October 2010
16	September 2010
25	August 2010
33	July 2010
22	June 2010
12	May 2010
148	April 2010
96	March 2010
37	February 2010
65	January 2010
120	December 2009
80	November 2009
50	October 2009
47	September 2009
78	August 2009
83	July 2009
43	June 2009
56	May 2009
85	April 2009
68	March 2009
187	February 2009
221	January 2009
137	December 2008
128	November 2008
106	October 2008
144	September 2008
398	August 2008
427	July 2008
156	June 2008
136	May 2008
265	April 2008
572	March 2008
123	February 2008
340	January 2008
401	December 2007
271	November 2007
340	October 2007
424	September 2007
658	August 2007
508	July 2007
385	June 2007
547	May 2007
647	April 2007
1214	March 2007
1072	February 2007
812	January 2007
849	December 2006
670	November 2006
760	October 2006
493	September 2006
760	August 2006
558	July 2006
521	June 2006
966	May 2006
856	April 2006
1101	March 2006
859	February 2006
1170	January 2006
906	December 2005
1094	November 2005
2480	October 2005
1363	September 2005
972	August 2005
676	July 2005
994	June 2005
1282	May 2005
916	April 2005
1068	March 2005
950	February 2005
1171	January 2005
1221	December 2004
1676	November 2004
1767	October 2004
756	September 2004
791	August 2004
1111	July 2004
1239	June 2004
1383	May 2004
1773	April 2004
2206	March 2004
1586	February 2004
1313	January 2004
1344	December 2003
1816	November 2003
2070	October 2003
1393	September 2003
1432	August 2003
655	July 2003
1204	June 2003
1890	May 2003
1622	April 2003
1982	March 2003
1535	February 2003
1398	January 2003
1093	December 2002
989	November 2002
1021	October 2002
668	September 2002
901	August 2002
1019	July 2002
1396	June 2002
1142	May 2002
1305	April 2002
922	March 2002
1	November 2001