1 Jan 2005 12:59
Please review this code (was: svn commit: r123799 - /cocoon/branches/BRANCH_2_1_X/src/blocks/repository/java/org/apache/co coon/components/repository/SourceRepositoryImpl.java)
Antonio Gallardo <agallardo <at> agssa.net>
2005-01-01 11:59:20 GMT
2005-01-01 11:59:20 GMT
On Vie, 31 de Diciembre de 2004, 15:45, Joerg Heinicke dijo:
> On 31.12.2004 18:46, Antonio Gallardo wrote:
>
>>>> while (iter.hasNext()) {
>>>>- Source child = null;
>>>>- try {
>>>>- status = remove((Source) iter.next());
>>>>- if (status != STATUS_OK) {
>>>>- return status;
>>>>- }
>>>>- }
>>>>- finally {
>>>>- if (child != null) {
>>>>- m_resolver.release(child);
>>>
>>>------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^
>>>
>>>
>>>>- }
>>>>+ status = remove((Source) iter.next());
>>>>+ if (status != STATUS_OK) {
>>>>+ return status;
>>>> }
>>>> }
>>>> }
>>>
>>>What about releasing the Source's??
>>
>>
>> 'child' is always = null. The condition never happen to be true. Then it
(Continue reading)
It's surely a winner!
There is a great graphical tool called JAWE that you can use to build and
manipulate
XPDL. You can find it at:
RSS Feed