Re: [PATCH] New feature -> add a rollback comment

Emmanuel Engelhart wrote:
> This patch provides the possibility for adding a comment with an admin
> rollback.

Neat! A couple things to work on:

The comment should be retrieved by WebRequest::getText() rather than 
WebRequest::getVal(). This will perform input transcoding on the few 
languages that have this extra feature (Esperanto only, currently). You 
do not need to use urldecode(); this is done by PHP before we ever see 
the data.

Text put into HTML output should pretty much always be escaped via 
htmlspecialchars() to avoid data corruption problems and HTML/JS 
injection attacks. Titles for instance may contain the & character, and 
all kinds of trouble ensues if it's not escaped properly.

Title::getText() will return only the non-namespace portion, so this 
doesn't work on non-article pages. You'll want to use 
Title::getPrefixedText().

Use htmlspecialchars() rather than urlencode() on the user name. The URL 
for the form submission will be created by the browser; we just need to 
make sure that the browser gets the correct data in the first place.

Also, try to stick with tabs as Timwi's mentioned; it gets really messy 
to work with files where indentation styles change constantly.

A minor UI quibble; since the comment field doesn't support line breaks, 
it should probably be an <input> rather than a <textarea>. Also it might 

Re: Update LanguageRO.php from CVS

Brion Vibber wrote:

> Gutza wrote:
>
>> I have updated the categories in LanguageRO.php in CVS. Can someone 
>> please update it on the server? We'd like to start using categories, 
>> and we'd prefer the localized keyword instead of the English one -- I 
>> expect changing the namespace name will result in the desired 
>> behaviour, is this correct? (i.e. we could write [[Categorie:foo]] 
>> instead of [[Category:foo]] once the namespace was changed from 
>> "Category" to "Categorie").
>
>
> Comitted to REL1_3 and installed on Wikipedia.
>
> Thanks for the update!
>
> -- brion vibber (brion  <at>  pobox.com)

Thank YOU for applying the patch so quickly, you have no reason to thank me!

Cheers,
Gutza

Re: Re: Bounties, tenders, and the GNOME experience

On Sun, 2004-01-08 at 00:01 +0200, Magnus Manske wrote:
> Ray Saintonge wrote:
> 
> > Timwi wrote:
> >
> >> Erik Moeller wrote:
> >>
> >>> Because "bounty" carries strong connotations of competition rather 
> >>> than  cooperation, I would like us to stop using that word, at least 
> >>> when  referring to the proposal described above. Instead, it should 
> >>> be described  as a tender process.
> >>
> >>
> >> I never liked the term "bounty" either because it reminds me of a 
> >> chocolate bar. 
> >
> >
> > I get images of cowboys chasing down bad guys. 
> 
> Mutiny, anyone? 

I dont think "bounty" implies competition. It implies going to outside
and/or unusual sources to get something done. ie: bail bondsman (or 1880
sheriffs in the West) hire bounty hunters to track someone down - but
only one (group) at a time. Or to put things in a more geek context:
Jabba hired only one bounty hunter to track down Han, Greedo. Besides,
it would not just be wikipedia using the term: Gnome may have came up
with it, but Horde also uses it. ESR may put it in the Jargon file if he
ever gets off the speaking tour.

Re: Re: Bounties, tenders, and the GNOME experience

Jeff Warnica wrote:

>On Sun, 2004-01-08 at 00:01 +0200, Magnus Manske wrote:
>  
>
>>Ray Saintonge wrote:
>>
>>    
>>
>>>Timwi wrote:
>>>
>>>      
>>>
>>>>Erik Moeller wrote:
>>>>
>>>>        
>>>>
>>>>>Because "bounty" carries strong connotations of competition rather 
>>>>>than  cooperation, I would like us to stop using that word, at least 
>>>>>when  referring to the proposal described above. Instead, it should 
>>>>>be described  as a tender process.
>>>>>          
>>>>>
>>>>I never liked the term "bounty" either because it reminds me of a 
>>>>chocolate bar. 
>>>>        
>>>>
>>>I get images of cowboys chasing down bad guys. 
>>>      
>>>

Re: Re: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Timwi wrote:
> Emmanuel Engelhart wrote:
>> True, new version correcting this bug.
> 
> Again, *please* use tabs to indent lines in the future. I've fixed this 
> for you now and committed it.

Seems pretty straightforward, I've gone ahead and copied it to the 1.3 
branch and installed it.

-- brion vibber (brion  <at>  pobox.com)

_______________________________________________
Wikitech-l mailing list
Wikitech-l <at> wikimedia.org
http://mail.wikipedia.org/mailman/listinfo/wikitech-l

Re: Re: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Hi all,

Le Sunday 01 August 2004 05:22, Brion Vibber a écrit :
> Timwi wrote:
> > Emmanuel Engelhart wrote:
> >> True, new version correcting this bug.
>
> Seems pretty straightforward, I've gone ahead and copied it to the 1.3
> branch and installed it.
>
> -- brion vibber (brion  <at>  pobox.com)

Many thanks to Emmanuel and Brion for this fix.
This bug was quite annoying.

Yann

--

-- 
http://www.non-violence.org/ | Site collaboratif sur la non-violence
http://www.forget-me.net/ | Alternatives sur le Net
http://fr.wikipedia.org/ | Encyclopédie libre
http://www.forget-me.net/pro/ | Formations et services Linux

Re: Re: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

On Sun, 1 Aug 2004 11:37:45 +0200
Yann Forget <yann <at> forget-me.net> wrote:

> Hi all,
> 
> Le Sunday 01 August 2004 05:22, Brion Vibber a écrit :
> > Timwi wrote:
> > > Emmanuel Engelhart wrote:
> > >> True, new version correcting this bug.
> >
> > Seems pretty straightforward, I've gone ahead and copied it to the 1.3
> > branch and installed it.
> >
> > -- brion vibber (brion  <at>  pobox.com)
> 
> Many thanks to Emmanuel and Brion for this fix.
> This bug was quite annoying.
> 

And Timwi... of course.

Emmanuel

--

-- 
-------------------------------------------------------------------------
L'informatique, en tant que discipline, ne traite pas plus des 
ordinateurs que l'astronomie le fait les téléscopes.
	-- E. W. Dijkstra
-------------------------------------------------------------------------
Emmanuel Engelhart      ICQ UIN : 53388731   TEL (+49)(0)6.22.15.88.03.31

Re: [PATCH] New feature -> add a rollback comment

On Sat, 31 Jul 2004 16:08:13 -0700
Brion Vibber <brion <at> pobox.com> wrote:

> Emmanuel Engelhart wrote:
> > This patch provides the possibility for adding a comment with an admin
> > rollback.
> 
> Neat! A couple things to work on:
> 
> The comment should be retrieved by WebRequest::getText() rather than 
> WebRequest::getVal(). This will perform input transcoding on the few 
> languages that have this extra feature (Esperanto only, currently). You 
> do not need to use urldecode(); this is done by PHP before we ever see 
> the data.
> 

Ok

> Text put into HTML output should pretty much always be escaped via 
> htmlspecialchars() to avoid data corruption problems and HTML/JS 
> injection attacks. Titles for instance may contain the & character, and 
> all kinds of trouble ensues if it's not escaped properly.
> 

ok, I hope I escaped everywhere.

> Title::getText() will return only the non-namespace portion, so this 
> doesn't work on non-article pages. You'll want to use 
> Title::getPrefixedText().

Re: $1 Billion in Grants available

On Sat, 31 Jul 2004 11:45, Tom Randall wrote:
> I invite you to view the ForeignAID.com International Funding
> Directory online at:
> http://www.foreignaid.com/foundations
>
> The ForeignAID.com International Funding Directory is a database of
> over 700 foundations and donors in the U.S., Europe, and worldwide
> that give over $1 Billion every year in grants and scholarships to
> individuals and projects. Please tell me what you think.
>
> Most Sincerely,
> Tom Randall
> http://www.foreignaid.com/foundations
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l <at> wikimedia.org
> http://mail.wikipedia.org/mailman/listinfo/wikitech-l

I'm the one who approved this.  i checked the page before I approved it and it 
looked completely different to how it does now - before it didn't look like 
they were just selling a directory.  Rather it looked like a free directory 
which could be useful.

--
Jerome

Re: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Emmanuel Engelhart wrote:
> 
> And Timwi... of course.

Hee. I get thanked for complaining about indentation tabs. :)

Timwi