Aleksey Bragin | 28 Jun 11:21 2016
Gravatar

Status Meeting (June 2016)

Hello,
Let me invite you to the monthly status meeting taking place this 
Thursday, 30rd of June, 19:00 UTC.

IRC service will only be started shortly before the meeting. Your 
participation passwords and server address will be emailed to you 
shortly before the meeting starts, and they are going to be different 
once again as they are not stored in any database. Hopefully it's not 
much of inconvenience.

Alternative place for the meeting is #reactos-meeting on Freenode.

Please send agenda proposals to me before the meeting.  My proposal is 
to discuss 0.4.2 release plans.

Regards,
Aleksey Bragin

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 21 Jun 04:15 2016

Re: [ros-diffs] [zhu] 71644: Implemented IRQ cancelling for listen() and connect() calls.

On 2016-06-15 12:10, zhu <at> svn.reactos.org wrote:
> --- branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c	[iso-8859-1] Wed Jun 15 19:10:40 2016
>  <at>  <at>  -384,7 +384,9  <at>  <at> 
>   Quickie:
>       Irp->IoStatus.Status = Status;
>
> -    return Irp->IoStatus.Status;
> +	IoCompleteRequest(Irp, IO_NETWORK_INCREMENT);
> +	
> +	return Irp->IoStatus.Status;
>   }
>
>   static

This is illegal. IoCompleteRequest frees the IRP so you must not access
it afterwards, and use the local variable instead.

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Yonggang Chen | 9 Jun 12:20 2016

I can't debug CoInitialize function

Hello developers,

 

After building ReactOS and Rostests successfully, I can’t debug CoInitialize function through Visual Studio 2015. It seems Visual Studio thinks I’m using their CoInitialize of Windows kernel.

Anybody can help me?

 

Here is the steps I used to compile ReactOS and Rostests:

1.       install Build Environment

https://reactos.org/wiki/ReactOS_Build_Environment

 

2. download code to the folder specified when by RosBE during installing

     code: svn://svn.reactos.org/reactos/trunk/reactos

  http://svn.reactos.org/reactos/trunk/rostests/

 

  reactOS directory -> E:\Work\reactos

  rostests directory -> E:\Work\reactos\modules\rostests

 

 

3. generate reactos.sln for Visual Stdio

     (a). Open a Windows DDK/WDK/Visual Studio 2015 command prompt.

     (b). run the following command in the code root:

               configure.cmd VSSolution

4. build the huge solutions

     msbuild reactos.sln /m

5. open the ‘ole32_winetest.vcxproj’ (E:\Work\reactos\output-VS-i386\modules\rostests\winetests\ole32)

       Set the command arguments ‘ole2’, set breakpoint at CoInitialize line, and start beginning by pressing F5, but Visual Studio can’t get into CoInitialize funtion

 

 

Best regards

Yonggang Chen

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Alex Ionescu | 6 Jun 00:19 2016
Picon

Re: [ros-diffs] [apriyadarshi] 71530: Added INF File for driver installation with minimal configuration. Device Detection and Initialization working -- tested on VMware. StorPortAllocatePool not working, so asked ...

Hi,

Implementing MSAHCI would be "more correct" for the system, however MSAHCI also doesn't use STORPORT, it uses ATAPORT, which requires changing our PCIIDEX model to support that. Which I think would put Aman's work out of scope.

Now, MSAHCI would be ported to use STORPORT instead, but then we'd essentially be implementing a legacy component on top of a legacy port driver.

At least, by implementing STORAHCI on top of STORPORT, we can implement a 'modern' component on top of the legacy port driver.

And for this, I would either recommend doing things like implementing StorPortExtendedFunction if Aman can do it -- or if someone can help him, or, avoiding its use with temporary work/arounds, etc. _as long as those workarounds still work in Windows_.

Best regards,
Alex Ionescu

On Sun, Jun 5, 2016 at 9:10 PM, Thomas Faber <thomas.faber-td3rRX5TIkhAfugRpC6u6w@public.gmane.org> wrote:
I'm not an expert so I'm not sure what way is best. But I see at least
4 solutions:
* There seems to be a way to get the extended function table through
  StorPortNotification/GetExtendedFunctionTable. This would provide
  some of the newer functionality even with older storport, but is
  potentially an undocumented hack
* Avoid using the modern functionality and implement an old-storport
  compatible storahci, which implies using only memory from the adapter
  extension, and probably a few more things
* Rely on a "modern" storport and do the testing in a newer Windows
  version. Then when ROS gets storport it simply needs to be a "modern"
  version
* Do not use storport and implement msahci rather than storahci

Option 2 would give the greatest compatibility but I can't pretend to
understand what limitations it will imply.


On 2016-06-05 21:43, Aman Priyadarshi wrote:
> Yeah msahci is ataport miniport driver.
> Then what would be the best idea? Leave it with the implementation I made
> there. "Allocated memory for all port extension within device extension?"
> ᐧ
>
>
> Regards
> *Aman Priyadarshi*
> *www.atomixos.com <http://www.atomixos.com>*
>
>
> On Mon, Jun 6, 2016 at 1:02 AM, Thomas Faber <thomas.faber-td3rRX5TIkhAfugRpC6u6w@public.gmane.org>
> wrote:
>
>> On 2016-06-05 14:40, apriyadarshi-FK+hrUIho1S2+TBAgxGDFw@public.gmane.org wrote:
>>> Author: apriyadarshi
>>> Date: Sun Jun  5 12:40:49 2016
>>> New Revision: 71530
>>>
>>> URL: http://svn.reactos.org/svn/reactos?rev=71530&view=rev
>>> Log:
>>> Added INF File for driver installation with minimal configuration.
>>> Device Detection and Initialization working -- tested on VMware.
>>> StorPortAllocatePool not working, so asked Storport to allocate all
>> memory just after loading up the driver -- Bad idea (will change it later).
>>
>> StorPortAllocatePool uses StorPortExtendedFunction, which indeed is not
>> implemented in Win2003. As you can see in WDK samples, 2003's msahci is
>> not a storport miniport driver. Maybe storport wasn't advanced enough
>> for complex drivers back then?


_______________________________________________
Ros-dev mailing list
Ros-dev-td3rRX5TIkhAfugRpC6u6w@public.gmane.org
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 5 Jun 21:32 2016

Re: [ros-diffs] [apriyadarshi] 71530: Added INF File for driver installation with minimal configuration. Device Detection and Initialization working -- tested on VMware. StorPortAllocatePool not working, so asked ...

On 2016-06-05 14:40, apriyadarshi <at> svn.reactos.org wrote:
> Author: apriyadarshi
> Date: Sun Jun  5 12:40:49 2016
> New Revision: 71530
> 
> URL: http://svn.reactos.org/svn/reactos?rev=71530&view=rev
> Log:
> Added INF File for driver installation with minimal configuration.
> Device Detection and Initialization working -- tested on VMware.
> StorPortAllocatePool not working, so asked Storport to allocate all memory just after loading up the
driver -- Bad idea (will change it later).

StorPortAllocatePool uses StorPortExtendedFunction, which indeed is not
implemented in Win2003. As you can see in WDK samples, 2003's msahci is
not a storport miniport driver. Maybe storport wasn't advanced enough
for complex drivers back then?

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 5 Jun 08:26 2016

Re: [ros-diffs] [hbelusca] 71524: [SHELL32] - Minor stylistic whitespace changes. - Use 'IDA_DESKBROWSER' instead of hardcoding its value. - The shell progman window uses the COLOR_DESKTOP as its hbrBackground: pa...

On 2016-06-05 01:29, hbelusca <at> svn.reactos.org wrote:
> -    rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN);
> -    rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN);
> -    rcDesk.right = rcDesk.left + GetSystemMetrics(SM_CXVIRTUALSCREEN);
> -    rcDesk.bottom = rcDesk.top + GetSystemMetrics(SM_CYVIRTUALSCREEN);
> +    rcDesk.left   = GetSystemMetrics(SM_XVIRTUALSCREEN);
> +    rcDesk.top    = GetSystemMetrics(SM_YVIRTUALSCREEN);
> +    rcDesk.right  = GetSystemMetrics(SM_CXVIRTUALSCREEN);
> +    rcDesk.bottom = GetSystemMetrics(SM_CYVIRTUALSCREEN);

Are you sure about this? "CX" normally means width, so right = left + cx
seems more logical. And SM_XVIRUTALSCREEN is probably 0 most of the
time so it would be hard to notice.

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Alexander Rechitskiy | 3 Jun 10:25 2016
Picon

https://code.reactos.org/ does not show recent revisions

https://code.reactos.org/ does not show recent revisions
 
Sync has stoped?
-- 
С уважением,
Alexander Rechitskiy
+79286331900
 
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Ged Murphy | 1 Jun 17:55 2016
Picon

http://winaero.com/blog/a-new-way-to-display-t...

There's another one of these when the OS is running in test mode.
"Bcdedit -set TESTSIGNING ON" will display the following:

Test Mode
Windows (n)
Build (n)

Maybe you can add that one when Alex finishes his UEFI/BCD stuff :)

-----Original Message-----
From: Ros-diffs [mailto:ros-diffs-bounces@...] On Behalf Of hbelusca@...
Sent: 01 June 2016 16:25
To: ros-diffs@...
Subject: [ros-diffs] [hbelusca] 71486: [WIN32K] Display a nice ReactOS version desktop watermark (with
different fonts) when the corresponding registry values are set. See http://winaero.com/blog/a-new-way-to-display-t...

Author: hbelusca
Date: Wed Jun  1 15:24:38 2016
New Revision: 71486

URL: http://svn.reactos.org/svn/reactos?rev=71486&view=rev
Log:
[WIN32K]
Display a nice ReactOS version desktop watermark (with different fonts) when the corresponding registry
values are set.
See http://winaero.com/blog/a-new-way-to-display-the-windows-version-on-your-desktop/ for
more details (which works on Windows 2003 too).
CORE-11349 #resolve
Ged Murphy | 31 May 11:32 2016
Picon

Re: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim ...

Would it not be better to do all this in C++ and let wine write a C interface around it?
When we're trying to move to C++, it seems like a step backwards in order to support wine's insistence on
using C

-----Original Message-----
From: Ros-diffs [mailto:ros-diffs-bounces@...] On Behalf Of mjansen@...
Sent: 28 May 2016 17:43
To: ros-diffs@...
Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329 Implement
some macro's and functions that help when registering shims. These are all written in C, so that wine can
use the shim ...

Author: mjansen
Date: Sat May 28 16:42:57 2016
New Revision: 71439

URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev
Log:
[APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when
registering shims.
These are all written in C, so that wine can use the shim libraries as well.
Jared Smudde | 29 May 23:01 2016
Picon

Semi-protection of our Wikipedia page


Hello all,

It seems that our Wikipedia page seems to have somewhat incorrect information in some sections on the page. Some of it seems to come from IP address which means that they are unregistered. Some of the information could be correct but some of the other information added could be incorrect. I propose that we can see if the wiki page could be Semi-Protected. If the page is Semi-Protected, that means that non-registered users (People logged as IPs in the log) and newly registered users (people that have less than 10 edits and that have been only registered for 4 days). This would mean that people that have been registered for a while and have made edits could edit the page. I hope that this would help with some of the incorrect information on the web page. Not sure what your thoughts are on this but I think it would be nice to have.

Jared
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Timo Kreuzer | 29 May 21:57 2016
Picon

Re: [ros-diffs] [pschweitzer] 71412: [REISERFSLIB] Stub the ReiserFS lib CORE-11005


I thought the idea of the folder reorganization was to get some sense 
into it.
But that doesn't work if people keep adding stuff to the sdk/lib folder, 
just because it is a lib!
I don't see why a file system library would have any reason to go into 
the SDK.

Thanks,
Timo

Am 26.05.2016 um 20:08 schrieb pschweitzer@...:
> Author: pschweitzer
> Date: Thu May 26 18:08:42 2016
> New Revision: 71412
>
> URL: http://svn.reactos.org/svn/reactos?rev=71412&view=rev
> Log:
> [REISERFSLIB]
> Stub the ReiserFS lib
>
> CORE-11005
>
> Added:
>      trunk/reactos/sdk/lib/fslib/reiserfslib/
>      trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt   (with props)
>      trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c   (with props)
>      trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h   (with props)
> Modified:
>      trunk/reactos/sdk/lib/fslib/CMakeLists.txt
>
> Modified: trunk/reactos/sdk/lib/fslib/CMakeLists.txt
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/CMakeLists.txt?rev=71412&r1=71411&r2=71412&view=diff
> ==============================================================================
> --- trunk/reactos/sdk/lib/fslib/CMakeLists.txt	[iso-8859-1] (original)
> +++ trunk/reactos/sdk/lib/fslib/CMakeLists.txt	[iso-8859-1] Thu May 26 18:08:42 2016
>  <at>  <at>  -2,5 +2,6  <at>  <at> 
>   add_subdirectory(btrfslib)
>   add_subdirectory(ext2lib)
>   add_subdirectory(ntfslib)
> +add_subdirectory(reiserfslib)
>   add_subdirectory(vfatlib)
>   add_subdirectory(vfatxlib)
>
> Added: trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt?rev=71412
> ==============================================================================
> --- trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt	(added)
> +++ trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt	[iso-8859-1] Thu May 26 18:08:42 2016
>  <at>  <at>  -0,0 +1,3  <at>  <at> 
> +
> +add_library(reiserfslib reiserfslib.c)
> +add_dependencies(reiserfslib psdk)
>
> Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt
> ------------------------------------------------------------------------------
>      svn:eol-style = native
>
> Added: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c?rev=71412
> ==============================================================================
> --- trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c	(added)
> +++ trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c	[iso-8859-1] Thu May 26 18:08:42 2016
>  <at>  <at>  -0,0 +1,36  <at>  <at> 
> +/*
> + * COPYRIGHT:   See COPYING in the top level directory
> + * PROJECT:     ReactOS ReiserFS library
> + * FILE:        lib/fslib/reiserfslib/reiserfslib.c
> + * PURPOSE:     ReiserFS lib
> + * PROGRAMMERS: Pierre Schweitzer
> + */
> +#include "reiserfslib.h"
> +
> +#define NDEBUG
> +#include <debug.h>
> +
> +NTSTATUS NTAPI
> +ReiserfsFormat(IN PUNICODE_STRING DriveRoot,
> +               IN FMIFS_MEDIA_FLAG MediaFlag,
> +               IN PUNICODE_STRING Label,
> +               IN BOOLEAN QuickFormat,
> +               IN ULONG ClusterSize,
> +               IN PFMIFSCALLBACK Callback)
> +{
> +    UNIMPLEMENTED;
> +    return STATUS_SUCCESS;
> +}
> +
> +
> +NTSTATUS WINAPI
> +ReiserfsChkdsk(IN PUNICODE_STRING DriveRoot,
> +               IN BOOLEAN FixErrors,
> +               IN BOOLEAN Verbose,
> +               IN BOOLEAN CheckOnlyIfDirty,
> +               IN BOOLEAN ScanDrive,
> +               IN PFMIFSCALLBACK Callback)
> +{
> +    UNIMPLEMENTED;
> +    return STATUS_SUCCESS;
> +}
>
> Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c
> ------------------------------------------------------------------------------
>      svn:eol-style = native
>
> Added: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h?rev=71412
> ==============================================================================
> --- trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h	(added)
> +++ trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h	[iso-8859-1] Thu May 26 18:08:42 2016
>  <at>  <at>  -0,0 +1,8  <at>  <at> 
> +/*
> + * COPYRIGHT:   See COPYING in the top level directory
> + * PROJECT:     ReactOS ReiserFS library
> + * FILE:        lib/fslib/reiserfslib/reiserfslib.h
> + */
> +#define NTOS_MODE_USER
> +#include <ndk/umtypes.h>
> +#include <fmifs/fmifs.h>
>
> Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h
> ------------------------------------------------------------------------------
>      svn:eol-style = native
>
>
>

Gmane