Aleksey Bragin | 26 Jul 11:20 2016
Gravatar

Status Meeting (June 2016)

Hello,
Let me invite you to the monthly status meeting taking place this 
Thursday, 28th of June, 19:00 UTC.

IRC service will only be started shortly before the meeting. Your 
participation passwords and server address will be emailed to you 
shortly before the meeting starts, and they are going to be different 
once again as they are not stored in any database. Hopefully it's not 
much of inconvenience.

The backup place to conduct meetings is #reactos-meeting channel on 
Freenode.

Please send agenda proposals to me before the meeting so we don't waste 
time trying to setup the agenda directly during the meeting.

Regards,
Aleksey Bragin

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Pierre Schweitzer | 24 Jul 10:10 2016

Re: [ros-diffs] [tthompson] 71945: [NTFS] *AddRun() - Don't leak RunBuffer when encountering errors. Handle exception from FsRtlAddLargeMcbEntry().

Comment inline

Le 15/07/2016 à 17:27, tthompson@... a écrit :
> Author: tthompson
> Date: Fri Jul 15 15:27:04 2016
> New Revision: 71945
> 
> URL: http://svn.reactos.org/svn/reactos?rev=71945&view=rev
> Log:
> [NTFS]
> *AddRun() - Don't leak RunBuffer when encountering errors.
> Handle exception from FsRtlAddLargeMcbEntry().
> 
> Modified:
>     branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c
> 
> Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c
> URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c?rev=71945&r1=71944&r2=71945&view=diff
> ==============================================================================
> --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c	[iso-8859-1] Fri Jul 15 15:27:04 2016
>  <at>  <at>  -88,25 +88,40  <at>  <at> 
>      ULONGLONG NextVBN = AttrContext->Record.NonResident.LowestVCN;
>  
>      // Allocate some memory for the RunBuffer
> -    PUCHAR RunBuffer = ExAllocatePoolWithTag(NonPagedPool, Vcb->NtfsInfo.BytesPerFileRecord, TAG_NTFS);
> +    PUCHAR RunBuffer;
>      int RunBufferOffset = 0;
>  
>      if (!AttrContext->Record.IsNonResident)
(Continue reading)

Pierre Schweitzer | 24 Jul 10:00 2016

Re: [ros-diffs] [tthompson] 71957: [NTFS] Address some minor issues with attrib.c: Fix gcc build. Fix formatting.

Comment inline.

Le 17/07/2016 à 16:04, tthompson@... a écrit :
> Author: tthompson
> Date: Sun Jul 17 14:04:01 2016
> New Revision: 71957
> 
> URL: http://svn.reactos.org/svn/reactos?rev=71957&view=rev
> Log:
> [NTFS]
> Address some minor issues with attrib.c: Fix gcc build. Fix formatting.
> 
> Modified:
>     branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c
> 
> Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c
> URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c?rev=71957&r1=71956&r2=71957&view=diff
> ==============================================================================
> --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c	[iso-8859-1] Sun Jul 17 14:04:01 2016
>  <at>  <at>  -295,14 +291,14  <at>  <at> 
>      ULONG RunBufferOffset = 0;
>      LONGLONG  DataRunOffset;
>      ULONGLONG LastLCN = 0;
> -
>      LONGLONG Vbn, Lbn, Count;
> +    int i;

Use MS portable type, please (ULONG looks good :-))

(Continue reading)

Pierre Schweitzer | 24 Jul 09:58 2016

Re: [ros-diffs] [tthompson] 71968: [NTFS] +FreeClusters(). Fix a DPRINT.

Comment inline.

Le 19/07/2016 à 17:31, tthompson@... a écrit :
> Author: tthompson
> Date: Tue Jul 19 15:31:22 2016
> New Revision: 71968
> 
> URL: http://svn.reactos.org/svn/reactos?rev=71968&view=rev
> Log:
> [NTFS]
> +FreeClusters(). Fix a DPRINT.
> 
> Modified:
>     branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c
>     branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c
>     branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/ntfs.h
> 
> Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c
> URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c?rev=71968&r1=71967&r2=71968&view=diff
> ==============================================================================
> --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c	[iso-8859-1] Tue Jul 19 15:31:22 2016
>  <at>  <at>  -409,6 +409,208  <at>  <at> 
>      return TRUE;
>  }
>  
> +/**
> +*  <at> name FreeClusters
> +*  <at> implemented
> +*
(Continue reading)

Thomas Faber | 9 Jul 09:43 2016

Re: [ros-diffs] [zhu] 71865: Structural, style, correctness fixes.

On 2016-07-08 19:52, zhu <at> svn.reactos.org wrote:
> --- branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c	[iso-8859-1] Fri Jul  8
17:52:42 2016
>  <at>  <at>  -33,6 +33,8  <at>  <at> 
>  static LIST_ENTRY AddressListHead;
>  
>  /* implementation in testing */
> +/* Must already hold the Context->RequestListLock */
> +/* Context should be in ->FileObject->FsContext */

You know there is a way to actually tell that to MSVC's static
analyzer, right? ;)
You want something like
_IRQL_requires_(DISPATCH_LEVEL)
_IRQL_requires_same_
_Requires_lock_held_(((PTCP_CONTEXT)IrpSp->FileObject->FsContext)->RequestListLock)

The last one might be a little too complicated to actually include, but
the IRQL ones are easy to help indicate things like this.

>  NTSTATUS
>  PrepareIrpForCancel(
>  	PIRP Irp,

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Alex Ionescu | 8 Jul 20:45 2016
Picon

Re: [ros-diffs] [gedmurphy] 71862: [NTOS] - Implement IoCreateFileSpecifyDeviceObjectHint - will be needed for fltmgr - Rename IoCreateFile to IopCreateFile and forward both IoCreateFile and IoCreateFileSpecifyDev...


On Fri, Jul 8, 2016 at 6:18 AM, <gedmurphy-FK+hrUIho1S2+TBAgxGDFw@public.gmane.org> wrote:

+        if (OpenPacket->InternalFlags & IOP_USE_TOP_LEVEL_DEVICE_HINT)
+        {
+            // FIXME: Verify our device object is good to use
+            ASSERT(DirectOpen == FALSE);
         }

You probably want to take a look at IopCheckTopDeviceHint

Best regards,
Alex Ionescu
_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Alex Ionescu | 8 Jul 20:39 2016
Picon

Re: [ros-diffs] [hbelusca] 71819: [RTL]: Follow what I guess might be Alex' coding standards.

 I agree with one-line ifs FWIW...

As for the previous code, I think if the file is using separate braces, you shouldn't go around and write new code that follows the no-braces style -- which yes, we do accept.

Best regards,
Alex Ionescu

On Thu, Jul 7, 2016 at 5:25 PM, Timo Kreuzer <timo.kreuzer-S0/GAf8tV78@public.gmane.org> wrote:

According to the "official" ReactOS coding standards, the previous code was perfectly fine.
Code like "If (Value == 0) Value = FOO;" (in one line) does not match our coding style rules. (And it's also annoying, when stepping through it with WinDbg.)
3 line comments also don't match our coding style :-P

For reference: https://reactos.org/wiki/Coding_Style

Timo



Am 05.07.2016 um 16:30 schrieb Alex Ionescu:
Coding Style - ReactOS Wiki

Stop calling them "mine".

Best regards,
Alex Ionescu

On Mon, Jul 4, 2016 at 5:38 PM, <hbelusca-FK+hrUIho1S2+TBAgxGDFw@public.gmane.org> wrote:
Author: hbelusca
Date: Tue Jul  5 00:38:28 2016
New Revision: 71819

URL: http://svn.reactos.org/svn/reactos?rev=71819&view=rev
Log:
[RTL]: Follow what I guess might be Alex' coding standards.

Modified:
    trunk/reactos/sdk/lib/rtl/process.c

Modified: trunk/reactos/sdk/lib/rtl/process.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/rtl/process.c?rev=71819&r1=71818&r2=71819&view=diff
==============================================================================
--- trunk/reactos/sdk/lib/rtl/process.c [iso-8859-1] (original)
+++ trunk/reactos/sdk/lib/rtl/process.c [iso-8859-1] Tue Jul  5 00:38:28 2016
<at> <at> -75,7 +75,7 <at> <at>
     PVOID BaseAddress = NULL;
     SIZE_T EnviroSize;
     SIZE_T Size;
-    PWCHAR Environment = 0;
+    PWCHAR Environment = NULL;
     DPRINT("RtlpInitEnvironment(ProcessHandle: %p, Peb: %p Params: %p)\n",
             ProcessHandle, Peb, ProcessParameters);

<at> <at> -301,7 +301,9 <at> <at>
                                        DUPLICATE_SAME_ACCESS |
                                        DUPLICATE_SAME_ATTRIBUTES);
             if (!NT_SUCCESS(Status))
+            {
                 _SEH2_LEAVE;
+            }
         }

         if (ProcessParameters->StandardOutput)
<at> <at> -315,7 +317,9 <at> <at>
                                        DUPLICATE_SAME_ACCESS |
                                        DUPLICATE_SAME_ATTRIBUTES);
             if (!NT_SUCCESS(Status))
+            {
                 _SEH2_LEAVE;
+            }
         }

         if (ProcessParameters->StandardError)
<at> <at> -329,7 +333,9 <at> <at>
                                        DUPLICATE_SAME_ACCESS |
                                        DUPLICATE_SAME_ATTRIBUTES);
             if (!NT_SUCCESS(Status))
+            {
                 _SEH2_LEAVE;
+            }
         }
     }
     _SEH2_FINALLY





_______________________________________________ Ros-dev mailing list Ros-dev-td3rRX5TIkjF2uMehF1BdA@public.gmane.orgg http://www.reactos.org/mailman/listinfo/ros-dev



_______________________________________________
Ros-dev mailing list
Ros-dev-td3rRX5TIkhAfugRpC6u6w@public.gmane.org
http://www.reactos.org/mailman/listinfo/ros-dev


_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Ged Murphy | 8 Jul 19:50 2016
Picon

Re: [ros-diffs] [hbelusca] 71864: [FLTMGR]: Remove a MSVC warning: FltObjectDereference, whose prototype is publicly defined in fltkernel.h, doesn't return any value.

This change in incorrect, FltObectDereference does return a value. 
It's the public definition that's does match the function.

-----Original Message-----
From: Ros-diffs [mailto:ros-diffs-bounces <at> reactos.org] On Behalf Of hbelusca <at> svn.reactos.org
Sent: 08 July 2016 18:45
To: ros-diffs <at> reactos.org
Subject: [ros-diffs] [hbelusca] 71864: [FLTMGR]: Remove a MSVC warning: FltObjectDereference, whose
prototype is publicly defined in fltkernel.h, doesn't return any value.

Author: hbelusca
Date: Fri Jul  8 17:44:59 2016
New Revision: 71864

URL: http://svn.reactos.org/svn/reactos?rev=71864&view=rev
Log:
[FLTMGR]: Remove a MSVC warning: FltObjectDereference, whose prototype is publicly defined in
fltkernel.h, doesn't return any value.

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Pierre Schweitzer | 6 Jul 21:09 2016

Re: [ros-diffs] [tthompson] 71807: [NTFS][FREELDR] Fix ReadAttribute() and NtfsReadAttribute() in the case when an attribute contains two data runs; Remove extra if statement that prevents second data run from bei...

Actually, this (duplicated) function looks quite poorly designed (not
your fault, obviously :-p).
The more you fix it, the more it seems natural that the first specific
case should be integrated in the while loop for real. That would make
the function more robust, with less duplicated code (and thus, less bugs
:-p).

GSoC note: this is not a "todo" task. This is just an open discussion
about a possible improvement if some day someone's bored.

Le 04/07/2016 19:02, tthompson@... a écrit :
> Author: tthompson
> Date: Mon Jul  4 17:02:10 2016
> New Revision: 71807
> 
> URL: http://svn.reactos.org/svn/reactos?rev=71807&view=rev
> Log:
> [NTFS][FREELDR]
> Fix ReadAttribute() and NtfsReadAttribute() in the case when an attribute contains two data runs;
Remove extra if statement that prevents second data run from being read after it's decoded.
> 
> Modified:
>     branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c
>     branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c
> 
> Modified: branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c
> URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c?rev=71807&r1=71806&r2=71807&view=diff
> ==============================================================================
> --- branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c	[iso-8859-1] Mon Jul  4 17:02:10 2016
>  <at>  <at>  -320,9 +320,6  <at>  <at> 
>              }
>              else
>                  DataRunStartLCN = -1;
> -
> -            if (*DataRun == 0)
> -                return AlreadyRead;
>          }
>  
>          while (Length > 0)
> 
> Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c
> URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c?rev=71807&r1=71806&r2=71807&view=diff
> ==============================================================================
> --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c	[iso-8859-1] Mon Jul  4 17:02:10 2016
>  <at>  <at>  -384,9 +384,6  <at>  <at> 
>              }
>              else
>                  DataRunStartLCN = -1;
> -
> -            if (*DataRun == 0)
> -                return AlreadyRead;
>          }
>  
>          while (Length > 0)
> 
> 

--

-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

Attachment (smime.p7s): application/pkcs7-signature, 5353 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 6 Jul 02:11 2016

Re: [ros-diffs] [hbelusca] 71829: [CLIPBRD]: Use NULL for null pointer. [EVENTVWR]: Add folder icons (needed for later).

Can't event viewer load those icons from shell32 (much like regedit
should)?

On 2016-07-06 01:42, hbelusca <at> svn.reactos.org wrote:
> Author: hbelusca
> Date: Tue Jul  5 23:42:40 2016
> New Revision: 71829
> 
> URL: http://svn.reactos.org/svn/reactos?rev=71829&view=rev
> Log:
> [CLIPBRD]: Use NULL for null pointer.
> [EVENTVWR]: Add folder icons (needed for later).
> 
> Added:
>     trunk/reactos/base/applications/mscutils/eventvwr/res/folder.ico
>       - copied unchanged from r71828, trunk/reactos/base/applications/regedit/res/folder.ico
>     trunk/reactos/base/applications/mscutils/eventvwr/res/folderopen.ico
>       - copied unchanged from r71828, trunk/reactos/base/applications/regedit/res/folderopen.ico
> Modified:
>     trunk/reactos/base/applications/clipbrd/clipbrd.c
> 
> Modified: trunk/reactos/base/applications/clipbrd/clipbrd.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/clipbrd/clipbrd.c?rev=71829&r1=71828&r2=71829&view=diff
> ==============================================================================
> --- trunk/reactos/base/applications/clipbrd/clipbrd.c	[iso-8859-1] (original)
> +++ trunk/reactos/base/applications/clipbrd/clipbrd.c	[iso-8859-1] Tue Jul  5 23:42:40 2016
>  <at>  <at>  -256,12 +256,12  <at>  <at> 
>  
>          case CMD_ABOUT:
>          {
> +            HICON hIcon;
>              WCHAR szTitle[MAX_STRING_LEN];
> -            HICON hIcon;
>  
>              hIcon = LoadIconW(Globals.hInstance, MAKEINTRESOURCE(CLIPBRD_ICON));
>              LoadStringW(Globals.hInstance, STRING_CLIPBOARD, szTitle, ARRAYSIZE(szTitle));
> -            ShellAboutW(Globals.hMainWnd, szTitle, 0, hIcon);
> +            ShellAboutW(Globals.hMainWnd, szTitle, NULL, hIcon);
>              DeleteObject(hIcon);
>              break;
>          }
> 
> 

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 5 Jul 23:56 2016

Re: [ros-diffs] [zhu] 71823: Fixed crash on client and server exit: Corrected some NULL data marking and checking. Moved some cleanup code so they actually execute on function failure (incomplete). Removed redunda...

Comments inline.

On 2016-07-05 20:35, zhu <at> svn.reactos.org wrote:
> --- branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c	[iso-8859-1] (original)
> +++ branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c	[iso-8859-1] Tue Jul  5
18:35:17 2016
>  <at>  <at>  -357,15 +356,15  <at>  <at> 
>  			
>  			KeReleaseSpinLockFromDpcLevel(&Context->RequestListLock);
>  			
> -			if (Context->lwip_tcp_pcb != Context->AddressFile->lwip_tcp_pcb)
> +			if (Context->lwip_tcp_pcb == Context->AddressFile->lwip_tcp_pcb);

You really don't want a semicolon here ;)

>  			{
> -				tcp_close(Context->lwip_tcp_pcb);
> +				Context->AddressFile->lwip_tcp_pcb = NULL;
>  			}

> +	if (!p)
> +	{
> +		CopiedLength = 0;
> +		Status = STATUS_ADDRESS_CLOSED;
> +		goto BAD;
> +	}
>  	
>  	if (RemainingDestBytes <= p->len)
>  	{
>  		RtlCopyMemory(CurrentDestLocation, p->payload, RemainingDestBytes);
>  		CopiedLength = RemainingDestBytes;
> +		Status = STATUS_SUCCESS;
>  		goto RETURN;

We normally call labels things like "Exit" and "Failure".

>  <at>  <at>  -826,23 +846,24  <at>  <at> 
>  	
>  	tcp_recved(tpcb, CopiedLength);
>  	

I find it confusing not to have Entry = Head->Flink right here. I'm not
sure where it is, but unless there's a good reason for it to be
somewhere else I'd recommend putting it right in front of the loop.

> +	while (Entry != Head)
> +	{
> +		Request = CONTAINING_RECORD(Entry, TCP_REQUEST, ListEntry);

Entry = Entry->Flink? ;)

> +		if (Request->PendingMode == TCP_REQUEST_PENDING_RECEIVE)
> +		{
> +			tcp_recv(tpcb, lwip_tcp_receive_callback);
> +			break;
> +		}
> +	}

>  <at>  <at>  -1666,6 +1690,21  <at>  <at> 
>  	if (!(IsListEmpty(&Context->RequestListHead)))
>  	{
>  		DPRINT1("Disassociating context with outstanding requests\n");
> +		Head = &Context->RequestListHead;
> +		Entry = Head->Flink;
> +		while (Entry != Head)
> +		{
> +			Request = CONTAINING_RECORD(Entry, TCP_REQUEST, ListEntry);

Entry = Entry->Flink;

> +			if (Request->PendingIrp)
> +			{
> +				IrpSp = IoGetCurrentIrpStackLocation(Request->PendingIrp);
> +				DPRINT1("Pending IRP Control Code: %08x\n", IrpSp->MinorFunction);
> +			}
> +			else
> +			{
> +				DPRINT1("IRP is NULL\n");
> +			}
> +		}
>  	}
>  	KeReleaseSpinLockFromDpcLevel(&Context->RequestListLock);
>  	

Thanks.
-Thomas

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Gmane