Timo Kreuzer | 1 Sep 15:15 2014
Picon

Re: [ros-diffs] [jgardou] 64022: [SECUR32] - Update spec file [SCHANNEL] - Update stubs list Please blame binutils

Am 01.09.2014 14:21, schrieb jgardou@...:
> Author: jgardou
> Date: Mon Sep  1 12:21:16 2014
> New Revision: 64022
>
> URL: http://svn.reactos.org/svn/reactos?rev=64022&view=rev
> Log:
> [SECUR32]
>  - Update spec file
> [SCHANNEL]
>  - Update stubs list
> Please blame binutils
>
> Modified:
>     trunk/reactos/dll/win32/schannel/schannel.spec
>     trunk/reactos/dll/win32/schannel/schannel_wine.c
>     trunk/reactos/dll/win32/schannel/stubs.c
>     trunk/reactos/dll/win32/secur32/secur32.spec
>
> Modified: trunk/reactos/dll/win32/schannel/schannel.spec
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/schannel/schannel.spec?rev=64022&r1=64021&r2=64022&view=diff
> ==============================================================================
> --- trunk/reactos/dll/win32/schannel/schannel.spec	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/schannel/schannel.spec	[iso-8859-1] Mon Sep  1 12:21:16 2014
>  <at>  <at>  -15,14 +15,14  <at>  <at> 
>   <at>  stdcall InitSecurityInterfaceW() schan_InitSecurityInterfaceW
>   <at>  stdcall InitializeSecurityContextA(ptr ptr str long long long ptr long ptr ptr ptr ptr) schan_InitializeSecurityContextA
>   <at>  stdcall InitializeSecurityContextW(ptr ptr wstr long long long ptr long ptr ptr ptr ptr) schan_InitializeSecurityContextW
> - <at>  stdcall MakeSignature(ptr long ptr long) secur32.MakeSignature
> + <at>  stdcall MakeSignature(ptr long ptr long) schan_MakeSignature
(Continue reading)

Timo Kreuzer | 1 Sep 11:28 2014
Picon

Re: [ros-diffs] [hbelusca] 64017: [BOOTVID] - Synchronize correctly arm/bootdata.c with i386, as it was done previously. - Code formatting: whitespace fixes, add braces/brackets and spaces where needed; comments s...

Am 01.09.2014 01:00, schrieb hbelusca@...:
> Author: hbelusca
> Date: Sun Aug 31 23:00:29 2014
> New Revision: 64017
>
> URL: http://svn.reactos.org/svn/reactos?rev=64017&view=rev
> Log:
> [BOOTVID]
> - Synchronize correctly arm/bootdata.c with i386, as it was done previously.
Why is that file duplicated at all, if the contents are identical?
cameron.gutman | 27 Aug 20:12 2014

Re: [ros-diffs] [tfaber] 63953: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve

This seems strange. I understand that NT 5.x has a limitation of 64 MB MDLs on x86, but direct I/O was designed for exactly this case of large I/O operations. Has anyone verified that 2k3 doesn’t do MDL chaining for direct I/O when the transfer is larger than a single MDL can hold?

Also aren’t there changes to the IRP dispatch routines required to cope with not having an Irp->MdlAddress pointer anymore?

Cameron

From: tfaber <at> svn.reactos.org
Sent: ‎Tuesday‎, ‎August‎ ‎26‎, ‎2014 ‎6‎:‎41‎ ‎AM
To: ros-diffs <at> reactos.org

Author: tfaber
Date: Tue Aug 26 13:41:57 2014
New Revision: 63953

URL: http://svn.reactos.org/svn/reactos?rev=63953&view=rev
Log:
[FASTFAT]
- Do not use direct I/O since it limits read/write operations to 64 MB
CORE-8410 #resolve

Modified:
    trunk/reactos/drivers/filesystems/fastfat/fsctl.c

Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/fsctl.c?rev=63953&r1=63952&r2=63953&view=diff
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Tue Aug 26 13:41:57 2014
<at> <at> -442,8 +442,7 <at> <at>
         goto ByeBye;
     }
 
-    DeviceObject->Flags = DeviceObject->Flags | DO_DIRECT_IO;
-    DeviceExt = (PVOID) DeviceObject->DeviceExtension;
+    DeviceExt = DeviceObject->DeviceExtension;
     RtlZeroMemory(DeviceExt, ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG)) + sizeof(HASHENTRY*) * HashTableSize);
     DeviceExt->FcbHashTable = (HASHENTRY**)((ULONG_PTR)DeviceExt + ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG)));
     DeviceExt->HashTableSize = HashTableSize;


_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Picon

mplay translation

hello folks, 

i have just updated the spanish translatiuon of mplay. Its here:


Enjoy! :)
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 25 Aug 08:09 2014

Re: [ros-diffs] [jgardou] 63933: [WIN32K] - Enable commented freetype call: set font face size and coordinate transformation matrix Patch by Huw Campbell, reviewed by a gazillion of people. CORE-4657 #resolve #com...

On 2014-08-24 15:28, jgardou@... wrote:
> -//  FT_Set_Pixel_Sizes(ft_face,
> -//                     TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth,
> +    FT_Set_Pixel_Sizes(ft_face,
> +                       TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth,

The abs() was added in the second version of the patch because this
way it breaks tests.
See https://jira.reactos.org/browse/CORE-4657?focusedCommentId=60379&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-60379
Thomas Faber | 25 Aug 08:05 2014

Re: [ros-diffs] [hbelusca] 63940: [MPLAY32] Implement a single-window mode for videos. Patch by Ricardo Hanke. TO ALL TRANSLATORS: Update the translations! CORE-7910 #resolve #comment Committed, thanks!

On 2014-08-24 17:40, hbelusca@... wrote:
> +                    mciSendCommand(wDeviceId, MCI_PUT, MCI_DGV_PUT_DESTINATION | MCI_DGV_RECT | MCI_WAIT, (DWORD)&mciPut);

A DWORD cannot fit a pointer. This function takes DWORD_PTR.
Jérôme Gardou | 24 Aug 12:04 2014

Re: [ros-diffs] [tfaber] 63928: [FASTFAT] - Properly handle errors in CcInitializeCacheMap, CcCopyRead and CcCopyWrite CORE-8410

Hey Thomas

I think that you want to use _SEH2_YIELD in a few places here, that is, 
unless we want to completely ditch pseh2 in favor of pseh3 ;-)

Regards
Jérôme

Le 24/08/2014 05:28, tfaber <at> svn.reactos.org a écrit :
> Author: tfaber
> Date: Sun Aug 24 03:28:01 2014
> New Revision: 63928
>
> URL: http://svn.reactos.org/svn/reactos?rev=63928&view=rev
> Log:
> [FASTFAT]
> - Properly handle errors in CcInitializeCacheMap, CcCopyRead and CcCopyWrite
> CORE-8410
>
> Modified:
>      trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt
>      trunk/reactos/drivers/filesystems/fastfat/fcb.c
>      trunk/reactos/drivers/filesystems/fastfat/fsctl.c
>      trunk/reactos/drivers/filesystems/fastfat/rw.c
>      trunk/reactos/drivers/filesystems/fastfat/vfat.h
>
> Modified: trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt?rev=63928&r1=63927&r2=63928&view=diff
> ==============================================================================
> --- trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/fastfat/CMakeLists.txt	[iso-8859-1] Sun Aug 24 03:28:01 2014
>  <at>  <at>  -26,6 +26,7  <at>  <at> 
>   add_library(fastfat SHARED ${SOURCE} vfatfs.rc)
>   
>   set_module_type(fastfat kernelmodedriver)
> +target_link_libraries(fastfat ${PSEH_LIB})
>   add_importlibs(fastfat ntoskrnl hal)
>   
>   add_pch(fastfat vfat.h SOURCE)
>
> Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/fcb.c?rev=63928&r1=63927&r2=63928&view=diff
> ==============================================================================
> --- trunk/reactos/drivers/filesystems/fastfat/fcb.c	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c	[iso-8859-1] Sun Aug 24 03:28:01 2014
>  <at>  <at>  -340,12 +340,14  <at>  <at> 
>   {
>       PFILE_OBJECT fileObject;
>       PVFATCCB newCCB;
> +    NTSTATUS status;
>   
>       fileObject = IoCreateStreamFileObject (NULL, vcb->StorageDevice);
>   
>       newCCB = ExAllocateFromNPagedLookasideList(&VfatGlobalData->CcbLookasideList);
>       if (newCCB == NULL)
>       {
> +        ObDereferenceObject(fileObject);
>           return STATUS_INSUFFICIENT_RESOURCES;
>       }
>       RtlZeroMemory(newCCB, sizeof (VFATCCB));
>  <at>  <at>  -356,11 +358,24  <at>  <at> 
>       fcb->FileObject = fileObject;
>       fcb->RefCount++;
>   
> -    CcInitializeCacheMap(fileObject,
> -                         (PCC_FILE_SIZES)(&fcb->RFCB.AllocationSize),
> -                         TRUE,
> -                         &VfatGlobalData->CacheMgrCallbacks,
> -                         fcb);
> +    _SEH2_TRY
> +    {
> +        CcInitializeCacheMap(fileObject,
> +                             (PCC_FILE_SIZES)(&fcb->RFCB.AllocationSize),
> +                             TRUE,
> +                             &VfatGlobalData->CacheMgrCallbacks,
> +                             fcb);
> +    }
> +    _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
> +    {
> +        status = _SEH2_GetExceptionCode();
> +        fcb->RefCount--;
> +        fcb->FileObject = NULL;
> +        ExFreeToNPagedLookasideList(&VfatGlobalData->CcbLookasideList, newCCB);
> +        ObDereferenceObject(fileObject);
> +        return status;
> +    }
> +    _SEH2_END;
>   
>       fcb->Flags |= FCB_CACHE_INITIALIZED;
>       return STATUS_SUCCESS;
>
> Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/fsctl.c?rev=63928&r1=63927&r2=63928&view=diff
> ==============================================================================
> --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c	[iso-8859-1] Sun Aug 24 03:28:01 2014
>  <at>  <at>  -550,11 +550,20  <at>  <at> 
>       Fcb->RFCB.ValidDataLength = Fcb->RFCB.FileSize;
>       Fcb->RFCB.AllocationSize = Fcb->RFCB.FileSize;
>   
> -    CcInitializeCacheMap(DeviceExt->FATFileObject,
> -                         (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize),
> -                         TRUE,
> -                         &VfatGlobalData->CacheMgrCallbacks,
> -                         Fcb);
> +    _SEH2_TRY
> +    {
> +        CcInitializeCacheMap(DeviceExt->FATFileObject,
> +                             (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize),
> +                             TRUE,
> +                             &VfatGlobalData->CacheMgrCallbacks,
> +                             Fcb);
> +    }
> +    _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
> +    {
> +        Status = _SEH2_GetExceptionCode();
> +        goto ByeBye;
> +    }
> +    _SEH2_END;
>   
>       DeviceExt->LastAvailableCluster = 2;
>       ExInitializeResourceLite(&DeviceExt->FatResource);
>
> Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/rw.c?rev=63928&r1=63927&r2=63928&view=diff
> ==============================================================================
> --- trunk/reactos/drivers/filesystems/fastfat/rw.c	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/fastfat/rw.c	[iso-8859-1] Sun Aug 24 03:28:01 2014
>  <at>  <at>  -673,22 +673,35  <at>  <at> 
>               Status = /*STATUS_END_OF_FILE*/STATUS_SUCCESS;
>           }
>   
> -        if (IrpContext->FileObject->PrivateCacheMap == NULL)
> -        {
> -            CcInitializeCacheMap(IrpContext->FileObject,
> -                                 (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize),
> -                                 FALSE,
> -                                 &(VfatGlobalData->CacheMgrCallbacks),
> -                                 Fcb);
> -        }
> -
> -        if (!CcCopyRead(IrpContext->FileObject, &ByteOffset, Length,
> -                        (BOOLEAN)(IrpContext->Flags & IRPCONTEXT_CANWAIT), Buffer,
> -                        &IrpContext->Irp->IoStatus))
> -        {
> -            Status = STATUS_PENDING;
> -            goto ByeBye;
> -        }
> +        _SEH2_TRY
> +        {
> +            if (IrpContext->FileObject->PrivateCacheMap == NULL)
> +            {
> +                CcInitializeCacheMap(IrpContext->FileObject,
> +                                     (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize),
> +                                     FALSE,
> +                                     &(VfatGlobalData->CacheMgrCallbacks),
> +                                     Fcb);
> +            }
> +
> +            if (!CcCopyRead(IrpContext->FileObject,
> +                            &ByteOffset,
> +                            Length,
> +                            (IrpContext->Flags & IRPCONTEXT_CANWAIT) != 0,
> +                            Buffer,
> +                            &IrpContext->Irp->IoStatus))
> +            {
> +                ASSERT((IrpContext->Flags & IRPCONTEXT_CANWAIT) == 0);
> +                Status = STATUS_PENDING;
> +                goto ByeBye;
> +            }
> +        }
> +        _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
> +        {
> +            Status = _SEH2_GetExceptionCode();
> +            goto ByeBye;
> +        }
> +        _SEH2_END;
>   
>           if (!NT_SUCCESS(IrpContext->Irp->IoStatus.Status))
>           {
>  <at>  <at>  -947,30 +960,42  <at>  <at> 
>       {
>           // cached write
>   
> -        if (IrpContext->FileObject->PrivateCacheMap == NULL)
> -        {
> -            CcInitializeCacheMap(IrpContext->FileObject,
> -                                 (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize),
> -                                 FALSE,
> -                                 &VfatGlobalData->CacheMgrCallbacks,
> -                                 Fcb);
> -        }
> -
> -        if (ByteOffset.QuadPart > OldFileSize.QuadPart)
> -        {
> -            CcZeroData(IrpContext->FileObject, &OldFileSize, &ByteOffset, TRUE);
> -        }
> -
> -        if (CcCopyWrite(IrpContext->FileObject, &ByteOffset, Length,
> -                        1 /*IrpContext->Flags & IRPCONTEXT_CANWAIT*/, Buffer))
> -        {
> -            IrpContext->Irp->IoStatus.Information = Length;
> -            Status = STATUS_SUCCESS;
> -        }
> -        else
> -        {
> -            Status = STATUS_UNSUCCESSFUL;
> -        }
> +        _SEH2_TRY
> +        {
> +            if (IrpContext->FileObject->PrivateCacheMap == NULL)
> +            {
> +                CcInitializeCacheMap(IrpContext->FileObject,
> +                                     (PCC_FILE_SIZES)(&Fcb->RFCB.AllocationSize),
> +                                     FALSE,
> +                                     &VfatGlobalData->CacheMgrCallbacks,
> +                                     Fcb);
> +            }
> +
> +            if (ByteOffset.QuadPart > OldFileSize.QuadPart)
> +            {
> +                CcZeroData(IrpContext->FileObject, &OldFileSize, &ByteOffset, TRUE);
> +            }
> +
> +            if (CcCopyWrite(IrpContext->FileObject,
> +                            &ByteOffset,
> +                            Length,
> +                            TRUE /*(IrpContext->Flags & IRPCONTEXT_CANWAIT) != 0*/,
> +                            Buffer))
> +            {
> +                IrpContext->Irp->IoStatus.Information = Length;
> +                Status = STATUS_SUCCESS;
> +            }
> +            else
> +            {
> +                ASSERT(FALSE /*(IrpContext->Flags & IRPCONTEXT_CANWAIT) == 0*/);
> +                Status = STATUS_UNSUCCESSFUL;
> +            }
> +        }
> +        _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
> +        {
> +            Status = _SEH2_GetExceptionCode();
> +        }
> +        _SEH2_END;
>       }
>       else
>       {
>
> Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/vfat.h?rev=63928&r1=63927&r2=63928&view=diff
> ==============================================================================
> --- trunk/reactos/drivers/filesystems/fastfat/vfat.h	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/fastfat/vfat.h	[iso-8859-1] Sun Aug 24 03:28:01 2014
>  <at>  <at>  -4,6 +4,7  <at>  <at> 
>   #include <ntifs.h>
>   #include <ntdddisk.h>
>   #include <dos.h>
> +#include <pseh/pseh2.h>
>   
>   #define USE_ROS_CC_AND_FS
>   
>
>

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 14 Aug 22:48 2014

Re: [ros-diffs] [hbelusca] 63885: [KERNEL32] OpenConsoleW was implemented :P [CONSOLE.CPL][CONSRV] Create all the fonts needed at console startup, and then just select what's needed when fonts attributes need to b...

On 2014-08-14 22:10, hbelusca@... wrote:
> +    if (FaceName != GuiData->GuiInfo.FaceName)
> +    {
> +        SIZE_T Length = min(wcslen(FaceName) + 1, LF_FACESIZE); // wcsnlen
> +        wcsncpy(GuiData->GuiInfo.FaceName, FaceName, LF_FACESIZE);
> +        GuiData->GuiInfo.FaceName[Length] = L'\0'; // NULL-terminate
> +    }

Buffer overflow. You mean [Length - 1]
Colin Finck | 12 Aug 09:30 2014

On the server outage

Dear all,

As you've certainly noticed, one of our main servers providing the
www.reactos.org website along with JIRA and FishEye was down yesterday.
Problems began yesterday around 13:00 UTC and lasted till some minutes ago.

This has happened due to a severe hardware failure on the hypervisor
machine serving the affected VMs. Our hosting provider needed two
attempts to find and replace the failed hardware.
Finally, the crash has caused one database table to get corrupted. This
one was repaired just now. No data has been lost though.

All services should be up again now. If you still notice anything not
working, please report to me.
We're sorry for the caused inconveniences!

Best regards,

--
Colin Finck
System & Network Administrator
ReactOS Deutschland e.V.

Attachment (smime.p7s): application/pkcs7-signature, 5057 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Colin Finck | 10 Aug 17:28 2014

Introducing ReactOS development accounts

TL;DR
=====
Your SVN account == "ReactOS development account", because it will be
used for more services than just SVN. You can now change the password on
your own at https://lam.reactos.org

Hi all,

I've been trying to centralize our user accounts for some time now and
finally have something to show. Your known SVN credentials have been
imported into an LDAP-based user directory now.
This gives us the ability to easily plug various services for developers
into the directory: SVN, BuildBot, the participant list for meetings,
especially the upcoming services like Mumble, development VMs and file
sharing.

You can view your account details and change your password on your own
now. Just visit https://lam.reactos.org to do so. The E-Mail address
shown there will be used e.g. for sending meeting invitations.

As we all want the migration to go flawlessy, I've set up a temporary
SVN repository at svn://svn.reactos.org/sasltest
This should work just like our "reactos" repository: If you have write
access there, you have write access in "sasltest" as well. It already
works well for me and my SVN client, but I want confirmations from
others too. Please do so by committing some junk into sasltest :)

We have some members, who don't have SVN write access but participate in
the monthly meetings. They will shortly receive an E-Mail with their
account details. That doesn't give you SVN write access though, it's
just for participating in the meetings for now :P

I'll keep you informed when we finally plug our main repositories into
the LDAP database.

Note that this doesn't change anything with the ReactOS Website accounts
and IServ mail accounts. Former ones will always be in a separate
database as everybody can sign up there.

Cheers,

Colin
Timo Kreuzer | 7 Aug 11:07 2014
Picon

Re: [ros-diffs] [dgorbachev] 63823: [NTOSKRNL][PSEH3] - Add inline asm dependencies to fix undefined reference errors when building with link-time optimization. - Improve formatting. - No functional changes.

Am 07.08.2014 01:10, schrieb dgorbachev@...:
> -              : "m" (*(_TrylevelFrame)), "m" (*(_DataTable)), "c"(__builtin_alloca(0)) \
> +              : "m" (*(_TrylevelFrame)), "m" (*(_DataTable)), "c" (__builtin_alloca(0)), "p"
(_SEH3$_RegisterFrameWithNonVolatiles) \
What's this? Was that intentional?

Timo

Gmane