Jérôme Gardou | 27 Nov 16:14 2014

Re: [ros-diffs] [pschweitzer] 65501: [FASTFAT] Set clean shutdown bit on dismount

Hey Pierre!

This flag
> +    if (DeviceExt->VolumeFcb->Flags & VCB_CLEAR_DIRTY)
> +    {
> +        /* Set clean shutdown bit */
> +        Status = GetNextCluster(DeviceExt, 1, &eocMark);
> +        if (NT_SUCCESS(Status))
> +        {
> +            eocMark |= DeviceExt->CleanShutBitMask;
> +            if (NT_SUCCESS(WriteCluster(DeviceExt, 1, eocMark)))
and that one
> +                DeviceExt->VolumeFcb->Flags &= ~VCB_IS_DIRTY;
> +        }
> +    }
> +
>      /* Flush volume & files */
>      VfatFlushVolume(DeviceExt, (PVFATFCB)FileObject->FsContext);
>  
> 
> 
don't really seem to match. Or is the former a part of a OR combination
defining the latter ?

Cheers.
Jérôme.

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
(Continue reading)

Thomas Faber | 24 Nov 17:04 2014

Re: [ros-diffs] [pschweitzer] 65462: [NTFS] - In NtfsQueryDirectory(), don't upcase name in dir search pattern, it can conflict with POSIX names. - In CompareFileName(), handle the fact that for Win32 & DOS we do ...

On 2014-11-23 10:49, pschweitzer@... wrote:
> +            ASSERT(NT_SUCCESS(RtlUpcaseUnicodeString(&IntFileName, FileName, TRUE)));

You need NT_VERIFY here or this will break debug builds.
Timo Kreuzer | 21 Nov 23:55 2014
Picon

Re: [ros-diffs] [aandrejevic] 65441: [FAST486] Attempt to write the value to the stack before subtracting from the actual ESP register in Fast486StackPush.

Are you sure this is the correct order of execution? The instruction is 
documented as first lowering the stack pointer, then writing to the new 
location.
If a stack exception occurs, you might have esp off by 4.

Am 21.11.2014 10:46, schrieb aandrejevic@...:
> Author: aandrejevic
> Date: Fri Nov 21 09:46:57 2014
> New Revision: 65441
>
> URL: http://svn.reactos.org/svn/reactos?rev=65441&view=rev
> Log:
> [FAST486]
> Attempt to write the value to the stack before subtracting from the actual ESP register
> in Fast486StackPush.
>
>
> Modified:
>      trunk/reactos/lib/fast486/common.inl
>
> Modified: trunk/reactos/lib/fast486/common.inl
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.inl?rev=65441&r1=65440&r2=65441&view=diff
> ==============================================================================
> --- trunk/reactos/lib/fast486/common.inl	[iso-8859-1] (original)
> +++ trunk/reactos/lib/fast486/common.inl	[iso-8859-1] Fri Nov 21 09:46:57 2014
>  <at>  <at>  -317,15 +317,19  <at>  <at> 
>               return FALSE;
>           }
>   
> +        /* Store the value in SS:[ESP - 4] */
(Continue reading)

Giannis Adamopoulos | 21 Nov 12:35 2014

Rant

I don't know how many times I need to send the same link here but let's say that this is the last time:

this is a post about wpf but in the middle there is a paragraph about how win32k in windows processes mouse messages:
http://blogs.msdn.com/b/dwayneneed/archive/2008/09/08/transparent-windows-in-wpf.aspx

And here is the important part:
Which HWND is the mouse over?

The operating system must respond very quickly to mouse movement.  Windows uses a dedicated Raw Input
Thread (RIT), running in the kernel, to handle the signals from the mouse hardware.  The RIT quickly scans
over the HWND hierarchy to see which window the mouse is over.  Because the system must be responsive, no
application code is invoked.  For normal windows, the RIT checks the mouse position against the window's
rectangle (or region, if one is set).  But for layered windows, the RIT looks in the bitmap that specifies
the content for the window and checks the effective transparency at that location (which can be affected
by the constant opacity setting, the color key setting, or the per-pixel alpha channel).  If the pixel is
100% transparent, the RIT skips the window and keeps looking. 
  Once a window has been located, the mouse move flag is set on the thread that owns the window.  This will cause
the thread to receive a WM_MOUSEMOVE message the next time it calls GetMessage() and there are no other
higher-priority messages.

Now let me explain why a flag is needed. The window manager needs to coalesce mouse move messages. If the
mouse moves over a window and the system registers 10 positions over it, if the window doesn't process
messages fast enough the unprocessed positions are dropped and only the last is kept. Even if another
message gets between these mouse move messages get lost. 

That's why the last mouse position is not stored in a message queue but in a field in the thread info. That's
how the window manager worked the last 20 years in windows. 

I'm sick and tired to see readable and correct code to be rewritten by shitty code, that is not readable and
has obvious bugs without any reason why the previous implementation was wrong. I just give up. Do whatever
(Continue reading)

Hermès BÉLUSCA - MAÏTO | 19 Nov 13:50 2014
Picon

Selling ReactOS CDs

Hi all !

 

In the forums some spokesperson of an Indian company offering services related to FOSS wants to add us to their online shop, see http://www.reactos.org/forum/viewtopic.php?f=13&t=13780 for more information. What do you think about this? How should we react? Should we make clearer our line of conduct about such kind of things?

 

Cheers,

Hermès.

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 16 Nov 21:58 2014

Re: [ros-diffs] [dquintana] 65415: [SHELL32] * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems th...

On 2014-11-15 13:34, dquintana@... wrote:
> [SHELL32]
> * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but
looking at the contents of the HDD after syssetup runs seems that the shortcuts are all created in their
rightful place. If anyone is able to boot, feel free to test.
>
> Modified:
>      branches/shell-experiments/dll/win32/shell32/wine/shellpath.c

So which is it; to Wine or not to Wine? If we need to fork this then
let's put it in another file? Or at least #ifdef __REACTOS__?
Timo Kreuzer | 13 Nov 11:47 2014
Picon

Re: [ros-diffs] [tkreuzer] 65390: [WIN32SS] if (BooleanValue == TRUE) -> if (!BooleanValue) Patch by Love Nystrom CORE-8799


obviously it was meant to be "if (BooleanValue == TRUE) -> if 
(BooleanValue)"

Am 13.11.2014 11:31, schrieb tkreuzer@...:
> Author: tkreuzer
> Date: Thu Nov 13 10:31:45 2014
> New Revision: 65390
>
> URL: http://svn.reactos.org/svn/reactos?rev=65390&view=rev
> Log:
> [WIN32SS]
> if (BooleanValue == TRUE) -> if (!BooleanValue)
> Patch by Love Nystrom
> CORE-8799
>
> Modified:
>      trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c
>      trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c
>      trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c
>      trunk/reactos/win32ss/drivers/displays/vga/main/enable.c
>      trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c
>      trunk/reactos/win32ss/gdi/dib/floodfill.c
>      trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c
>      trunk/reactos/win32ss/user/ntuser/hotkey.c
>      trunk/reactos/win32ss/user/ntuser/message.c
>      trunk/reactos/win32ss/user/ntuser/msgqueue.c
>      trunk/reactos/win32ss/user/user32/controls/appswitch.c
>      trunk/reactos/win32ss/user/user32/misc/desktop.c
>      trunk/reactos/win32ss/user/user32/misc/winsta.c
>      trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c
>      trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c
>      trunk/reactos/win32ss/user/winsrv/usersrv/register.c
>
> Modified: trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c	[iso-8859-1] Thu Nov 13
10:31:45 2014
>  <at>  <at>  -38,7 +38,7  <at>  <at> 
>   {
>   	 PPDEV ppdev = (PPDEV)dhpdev;
>   
> -	 if (ppdev->bDDInitialized == TRUE)
> +	 if (ppdev->bDDInitialized)
>   	 {
>   		 return TRUE;
>   	 }
>  <at>  <at>  -237,7 +237,7  <at>  <at> 
>   	{
>   		ppdev->pvmList = pvmList;
>   
> -		if ( bDDrawHeap == TRUE)
> +		if (bDDrawHeap)
>   		{
>   			pvmList->dwFlags        = VIDMEM_ISLINEAR ;
>               pvmList->fpStart        = ppdev->ScreenHeight * ppdev->ScreenDelta;
>
> Modified: trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -110,7 +110,7  <at>  <at> 
>   VOID FASTCALL
>   IntShowMousePointer(PPDEV ppdev, SURFOBJ *DestSurface)
>   {
> -   if (ppdev->PointerAttributes.Enable == TRUE)
> +   if (ppdev->PointerAttributes.Enable)
>      {
>         return;
>      }
>
> Modified: trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c	[iso-8859-1] Thu Nov 13
10:31:45 2014
>  <at>  <at>  -38,7 +38,7  <at>  <at> 
>   {
>   	 PPDEV ppdev = (PPDEV)dhpdev;
>   
> -	 if (ppdev->bDDInitialized == TRUE)
> +	 if (ppdev->bDDInitialized)
>   	 {
>   		 return TRUE;
>   	 }
>  <at>  <at>  -237,7 +237,7  <at>  <at> 
>   	{
>   		ppdev->pvmList = pvmList;
>   
> -		if ( bDDrawHeap == TRUE)
> +		if (bDDrawHeap)
>   		{
>   			pvmList->dwFlags        = VIDMEM_ISLINEAR ;
>               pvmList->fpStart        = ppdev->ScreenHeight * ppdev->ScreenDelta;
>
> Modified: trunk/reactos/win32ss/drivers/displays/vga/main/enable.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/vga/main/enable.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/drivers/displays/vga/main/enable.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/drivers/displays/vga/main/enable.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -302,7 +302,7  <at>  <at> 
>       PPDEV ppdev = (PPDEV)DPev;
>       ULONG returnedDataLength;
>   
> -    if(Enable==TRUE)
> +    if (Enable)
>       {
>           /* Reenable our graphics mode */
>           if (!InitPointer(ppdev))
>
> Modified: trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c	[iso-8859-1] Thu Nov 13
10:31:45 2014
>  <at>  <at>  -560,7 +560,7  <at>  <at> 
>               pb++;
>           }
>   
> -        if (edgePixel == TRUE)
> +        if (edgePixel)
>           {
>               b1 = *pb;
>               if(b1 != trans) vgaPutPixel(x2, j, b1);
>
> Modified: trunk/reactos/win32ss/gdi/dib/floodfill.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/dib/floodfill.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/gdi/dib/floodfill.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/gdi/dib/floodfill.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -61,7 +61,7  <at>  <at> 
>   {
>     if (RECTL_bPointInRect(DstRect,x,y))
>     {
> -    if (isSurf == TRUE &&
> +    if (isSurf &&
>         DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y) != Color)
>       {
>         return;
>
> Modified: trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -1837,7 +1837,7  <at>  <at> 
>       {
>           /* Free it */
>           Return = NtGdiDdDeleteDirectDrawObject((HANDLE)pDirectDrawGlobal->hDD);
> -        if (Return == TRUE)
> +        if (Return)
>           {
>               pDirectDrawGlobal->hDD = 0;
>           }
>  <at>  <at>  -1852,7 +1852,7  <at>  <at> 
>           {
>               /* Delete the object */
>               Return = NtGdiDdDeleteDirectDrawObject(ghDirectDraw);
> -            if (Return == TRUE)
> +            if (Return)
>               {
>                   ghDirectDraw = 0;
>               }
>
> Modified: trunk/reactos/win32ss/user/ntuser/hotkey.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/hotkey.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/ntuser/hotkey.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/ntuser/hotkey.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -212,7 +212,7  <at>  <at> 
>           if (!bIsDown)
>           {
>               /* WIN and F12 keys are not hardcoded here. See comments on top of this file. */
> -            if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive == TRUE)
> +            if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive)
>               {
>                   pWnd = ValidateHwndNoErr(InputWindowStation->ShellWindow);
>                   if (pWnd)
>
> Modified: trunk/reactos/win32ss/user/ntuser/message.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/message.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/ntuser/message.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/ntuser/message.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -2087,7 +2087,7  <at>  <at> 
>   
>       UserLeave();
>   
> -    if (Ret == TRUE)
> +    if (Ret)
>       {
>           _SEH2_TRY
>           {
>
> Modified: trunk/reactos/win32ss/user/ntuser/msgqueue.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/msgqueue.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/ntuser/msgqueue.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/ntuser/msgqueue.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -805,7 +805,7  <at>  <at> 
>         *Message->Result = Result;
>      }
>   
> -   if (Message->HasPackedLParam == TRUE)
> +   if (Message->HasPackedLParam)
>      {
>         if (Message->Msg.lParam)
>            ExFreePool((PVOID)Message->Msg.lParam);
>  <at>  <at>  -887,7 +887,7  <at>  <at> 
>               KeSetEvent(SentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE);
>            }
>   
> -         if (SentMessage->HasPackedLParam == TRUE)
> +         if (SentMessage->HasPackedLParam)
>            {
>               if (SentMessage->Msg.lParam)
>                  ExFreePool((PVOID)SentMessage->Msg.lParam);
>  <at>  <at>  -1966,7 +1966,7  <at>  <at> 
>            KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE);
>         }
>   
> -      if (CurrentSentMessage->HasPackedLParam == TRUE)
> +      if (CurrentSentMessage->HasPackedLParam)
>         {
>            if (CurrentSentMessage->Msg.lParam)
>               ExFreePool((PVOID)CurrentSentMessage->Msg.lParam);
>  <at>  <at>  -1998,7 +1998,7  <at>  <at> 
>            KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE);
>         }
>   
> -      if (CurrentSentMessage->HasPackedLParam == TRUE)
> +      if (CurrentSentMessage->HasPackedLParam)
>         {
>            if (CurrentSentMessage->Msg.lParam)
>               ExFreePool((PVOID)CurrentSentMessage->Msg.lParam);
>
> Modified: trunk/reactos/win32ss/user/user32/controls/appswitch.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/controls/appswitch.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/user32/controls/appswitch.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/user32/controls/appswitch.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -522,7 +522,7  <at>  <at> 
>            return TRUE;
>   
>         case WM_SHOWWINDOW:
> -         if (wParam == TRUE)
> +         if (wParam)
>            {
>               PrepareWindow();
>               ati = (PALTTABINFO)GetWindowLongPtrW(hWnd, 0);
>
> Modified: trunk/reactos/win32ss/user/user32/misc/desktop.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/desktop.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/user32/misc/desktop.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/user32/misc/desktop.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -610,7 +610,7  <at>  <at> 
>                                GetProcessWindowStation(),
>                                0);
>   
> -  if( fInherit == TRUE )
> +  if( fInherit )
>     {
>         ObjectAttributes.Attributes |= OBJ_INHERIT;
>     }
>
> Modified: trunk/reactos/win32ss/user/user32/misc/winsta.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/winsta.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/user32/misc/winsta.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/user32/misc/winsta.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -372,7 +372,7  <at>  <at> 
>                                hWindowStationsDir,
>                                0);
>   
> -  if( fInherit == TRUE )
> +  if( fInherit )
>     {
>         ObjectAttributes.Attributes |= OBJ_INHERIT;
>     }
>
> Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c	[iso-8859-1] Thu Nov 13
10:31:45 2014
>  <at>  <at>  -1784,7 +1784,7  <at>  <at> 
>   static VOID
>   Copy(PGUI_CONSOLE_DATA GuiData)
>   {
> -    if (OpenClipboard(GuiData->hWindow) == TRUE)
> +    if (OpenClipboard(GuiData->hWindow))
>       {
>           PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer;
>   
>  <at>  <at>  -1814,7 +1814,7  <at>  <at> 
>   static VOID
>   Paste(PGUI_CONSOLE_DATA GuiData)
>   {
> -    if (OpenClipboard(GuiData->hWindow) == TRUE)
> +    if (OpenClipboard(GuiData->hWindow))
>       {
>           PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer;
>   
>
> Modified: trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c	[iso-8859-1] Thu
Nov 13 10:31:45 2014
>  <at>  <at>  -1336,7 +1336,7  <at>  <at> 
>   static VOID
>   GuiConsoleCopy(PGUI_CONSOLE_DATA GuiData)
>   {
> -    if (OpenClipboard(GuiData->hWindow) == TRUE)
> +    if (OpenClipboard(GuiData->hWindow))
>       {
>           PCONSOLE Console = GuiData->Console;
>           PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console);
>  <at>  <at>  -1364,7 +1364,7  <at>  <at> 
>   static VOID
>   GuiConsolePaste(PGUI_CONSOLE_DATA GuiData)
>   {
> -    if (OpenClipboard(GuiData->hWindow) == TRUE)
> +    if (OpenClipboard(GuiData->hWindow))
>       {
>           PCONSOLE Console = GuiData->Console;
>           PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console);
>
> Modified: trunk/reactos/win32ss/user/winsrv/usersrv/register.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/usersrv/register.c?rev=65390&r1=65389&r2=65390&view=diff
> ==============================================================================
> --- trunk/reactos/win32ss/user/winsrv/usersrv/register.c	[iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/winsrv/usersrv/register.c	[iso-8859-1] Thu Nov 13 10:31:45 2014
>  <at>  <at>  -53,7 +53,7  <at>  <at> 
>   {
>       PUSER_REGISTER_SERVICES_PROCESS RegisterServicesProcessRequest = &((PUSER_API_MESSAGE)ApiMessage)->Data.RegisterServicesProcessRequest;
>   
> -    if (ServicesProcessIdValid == TRUE)
> +    if (ServicesProcessIdValid)
>       {
>           /* Only accept a single call */
>           return STATUS_INVALID_PARAMETER;
>
>
>
Timo Kreuzer | 12 Nov 15:15 2014
Picon

Re: [ros-diffs] [jgardou] 65388: [TCPIP] - Comment out an optimisation which doesn't work. Reviews of why would be most appreciated.


tcpip.c:264

     /* Keep this list sorted */
     InsertHeadList(ListEntry, &OutInstance->ListEntry);

This should probably be InsertTailList(), since you want to insert 
before the current ListEntry

Am 12.11.2014 12:39, schrieb jgardou@...:
> Author: jgardou
> Date: Wed Nov 12 11:39:13 2014
> New Revision: 65388
>
> URL: http://svn.reactos.org/svn/reactos?rev=65388&view=rev
> Log:
> [TCPIP]
>   - Comment out an optimisation which doesn't work.
> Reviews of why would be most appreciated.
>
> Modified:
>      branches/tcpip_revolution/drivers/network/tcpip/entities.c
>
> Modified: branches/tcpip_revolution/drivers/network/tcpip/entities.c
> URL: http://svn.reactos.org/svn/reactos/branches/tcpip_revolution/drivers/network/tcpip/entities.c?rev=65388&r1=65387&r2=65388&view=diff
> ==============================================================================
> --- branches/tcpip_revolution/drivers/network/tcpip/entities.c	[iso-8859-1] (original)
> +++ branches/tcpip_revolution/drivers/network/tcpip/entities.c	[iso-8859-1] Wed Nov 12
11:39:13 2014
>  <at>  <at>  -309,9 +309,11  <at>  <at> 
>               return STATUS_SUCCESS;
>           }
>   
> +#if 0
>           /* The list is sorted, so we can cut the loop a bit */
>           if (ID.tei_instance < Instance->InstanceId.tei_instance)
>               break;
> +#endif
>   
>           ListEntry = ListEntry->Flink;
>       }
>
>
>
Thomas Faber | 11 Nov 22:17 2014

Re: [ros-diffs] [spetreolle] 65378: [ADVAPI_WINETEST] Make peace^W tests, not war.☮ Wave a hello to sysreg so that it doesn't kill us. ROSTESTS-56

Hmm, my thought behind disabling this was more that this one test
doesn't justify increasing our whole test run time by 10%.

On 2014-11-11 11:12, spetreolle <at> svn.reactos.org wrote:
> Author: spetreolle
> Date: Tue Nov 11 16:12:14 2014
> New Revision: 65378
>
> URL: http://svn.reactos.org/svn/reactos?rev=65378&view=rev
> Log:
> [ADVAPI_WINETEST]
> Make peace^W tests, not war.☮
> Wave a hello to sysreg so that it doesn't kill us.
> ROSTESTS-56
>
> Modified:
>      trunk/rostests/winetests/advapi32/service.c
>
> Modified: trunk/rostests/winetests/advapi32/service.c
> URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/advapi32/service.c?rev=65378&r1=65377&r2=65378&view=diff
> ==============================================================================
> --- trunk/rostests/winetests/advapi32/service.c	[iso-8859-1] (original)
> +++ trunk/rostests/winetests/advapi32/service.c	[iso-8859-1] Tue Nov 11 16:12:14 2014
>  <at>  <at>  -2166,6 +2166,9  <at>  <at> 
>       DWORD le1, le2;
>       SERVICE_STATUS status;
>
> +#ifdef __REACTOS__
> +    fprintf(stdout, "ROSTESTS-56: Hello sysreg, I am awake\n");
> +#endif
>       ret = StartServiceA(svc_handle, 0, NULL);
>       le1 = GetLastError();
>       ok(!ret, "%s: StartServiceA() should have failed\n", name);
>  <at>  <at>  -2260,12 +2263,6  <at>  <at> 
>            * insanely long timeout: 120s. So skip the rest of the tests.
>            */
>           win_skip("Skip some service start/stop tests on NT4\n");
> -        goto cleanup;
> -    }
> -
> -    if (!winetest_interactive)
> -    {
> -        skip("ROSTESTS-56: Skipping service start timeout tests!\n");
>           goto cleanup;
>       }
>

_______________________________________________
Ros-dev mailing list
Ros-dev <at> reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Michael Fritscher | 10 Nov 21:38 2014
Picon

Re: [ros-diffs] [pschweitzer] 65367: [PARTTEST] Add a dummy application that will open first disk and check first sector for MBR and then will open first partition to check for something known (& not MBR)

Hi,
> +    if (Sector->BytesPerSector * Sector->SectorsPerCluster > 32 * 1024)
> +    {
> +        return FALSE;
> +    }

FAT supports cluster sizes until 64KB ;-) At least the WinNT series can
work with them.

Best regards,
Michael Fritscher
Alex Ionescu | 10 Nov 19:02 2014
Picon

Re: [ros-diffs] [pschweitzer] 65352: [NTOSKRNL] So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack. But, so far, onl...

Let me make a simple arrogant comment:

Don't try to fix hacks that I spent years trying to fix (and failed). They just can't be fixed :P

Best regards,
Alex Ionescu

On Mon, Nov 10, 2014 at 1:45 AM, <pschweitzer-FK+hrUIho1S2+TBAgxGDFw@public.gmane.org> wrote:
Author: pschweitzer
Date: Mon Nov 10 09:45:43 2014
New Revision: 65352

URL: http://svn.reactos.org/svn/reactos?rev=65352&view=rev
Log:
[NTOSKRNL]
So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice hack.

But, so far, only reenable it for the 1st stage: the most intensive storage stack stage (unless you start playing with partitions & formating in 3rd stage).

CORE-8732 #resolve #comment Bug is now properly hidden with r65352

Modified:
    trunk/reactos/ntoskrnl/io/iomgr/file.c

Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?rev=65352&r1=65351&r2=65352&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c      [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c      [iso-8859-1] Mon Nov 10 09:45:43 2014
<at> <at> -404,6 +404,27 <at> <at>
     /* Check if we can simply use a dummy file */
     UseDummyFile = ((OpenPacket->QueryOnly) || (OpenPacket->DeleteOnly));

+    /* FIXME: Small hack still exists, have to check why...
+     * This is triggered multiple times by usetup and then once per boot.
+     */
+    if (ExpInTextModeSetup &&
+        !(DirectOpen) &&
+        !(RemainingName->Length) &&
+        !(OpenPacket->RelatedFileObject) &&
+        ((wcsstr(CompleteName->Buffer, L"Harddisk")) ||
+        (wcsstr(CompleteName->Buffer, L"Floppy"))) &&
+        !(UseDummyFile))
+    {
+        DPRINT1("Using IopParseDevice() hack. Requested invalid attributes: %lx\n",
+        DesiredAccess & ~(SYNCHRONIZE |
+                          FILE_READ_ATTRIBUTES |
+                          READ_CONTROL |
+                          ACCESS_SYSTEM_SECURITY |
+                          WRITE_OWNER |
+                          WRITE_DAC));
+        DirectOpen = TRUE;
+    }
+
     /* Check if this is a direct open */
     if (!(RemainingName->Length) &&
         !(OpenPacket->RelatedFileObject) &&



_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev

Gmane