Alexander Rechitskiy | 30 Oct 14:34 2014
Picon

Do not waste 65432 and 65536 GET!

Do not waste 65432 and 65536 GET!
 
65000 GET was wasted////
 
-- 
С уважением,
Alexander Rechitskiy
+79286331900
 
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Aleksey Bragin | 29 Oct 22:03 2014

Status Meeting (October 2014)

Hello,
Let me invite you to the monthly status meeting taking place 30th of 
October, 19:00 UTC (that's tomorrow!).

IRC service will only be started shortly before the meeting. Your 
participation passwords and server address will be emailed to you 
shortly before the meeting starts, and they are going to be different 
once again as they are not stored in any database. Hopefully it's not 
much of inconvenience.

If someone still is not getting passwords sent before a meeting - please 
email Pierre before the meeting started to get one.

Please send agenda proposals to me before the meeting, so that we can 
start with a proposed agenda.

Regards,
Aleksey Bragin
Hermès BÉLUSCA - MAÏTO | 29 Oct 19:43 2014
Picon

Monthly Meeting?

Hi !

 

Is there our monthly meeting tomorrow ?

 

Cheers,

Hermès.

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Colin Finck | 27 Oct 16:04 2014

BuildBot changes

Hi all,

As you can see in project-tools SVN, I've improved our Bash scripts for
Buildslaves. They're now also usable under Windows (in a Cygwin
environment) and I'm already doing this on our new Windows Buildslave
Carrier-Win7.
Bash on Windows may look hacky at first, but it's definitely more
comfortable than Batch! Moreover, we now only have a single version of
build scripts to maintain for all our Buildslaves!
This also involved some naming changes on the existing slaves to
maintain a consistent scheme. Tell me if anything broke.
Bringing all desired Windows builders back will still take some time.
I've only started with a RosBE-Windows based one right now and I need
your help here:

For some reason, VirtualBox 4.3.18 (used for reg-testing) doesn't want
to run headless. I can do a 'runas /user:buildbot VBoxManage controlvm
"ReactOS Testbot" poweroff' in a CMD and it will work well. The very
same command executed through BuildBot ends with:

====================================================================
VBoxManage.exe: error: Failed to create the VirtualBox object!
VBoxManage.exe: error: Code E_ACCESSDENIED (0x80070005) - General access
denied error (extended info not available)
VBoxManage.exe: error: Most likely, the VirtualBox COM server is not
running or failed to start.
====================================================================

See
http://build.reactos.org/builders/Carrier-Win7%20VBox-Testbot/builds/6/steps/shell/logs/stdio
VBoxSVC.log isn't touched when BuildBot tries this command, so I have no
additional information.

Haven't found a solution yet, so I'm asking here if any of the VBox
experts know what could be going wrong.

Cheers,

Colin

Attachment (smime.p7s): application/pkcs7-signature, 5057 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Ged Murphy | 25 Oct 22:10 2014
Picon

Re: [ros-diffs] [akhaldi] 64994: [ADVAPI32] * Update ImpersonateNamedPipeClient(). CORE-8540

Eeww, these are a bit ugly :(

On 25/10/2014 19:30, "akhaldi@..." <akhaldi@...>
wrote:

>Author: akhaldi
>Date: Sat Oct 25 18:30:05 2014
>New Revision: 64994
>
>URL: http://svn.reactos.org/svn/reactos?rev=64994&view=rev
>Log:
>[ADVAPI32]
>* Update ImpersonateNamedPipeClient().
>CORE-8540
>
>Modified:
>    trunk/reactos/dll/win32/advapi32/wine/security.c
>
>Modified: trunk/reactos/dll/win32/advapi32/wine/security.c
>URL: 
>http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/wine/s
>ecurity.c?rev=64994&r1=64993&r2=64994&view=diff
>==========================================================================
>====
>--- trunk/reactos/dll/win32/advapi32/wine/security.c	[iso-8859-1]
>(original)
>+++ trunk/reactos/dll/win32/advapi32/wine/security.c	[iso-8859-1] Sat Oct
>25 18:30:05 2014
> <at>  <at>  -954,37 +954,14  <at>  <at> 
>     return TRUE;
> }
> 
>-/**********************************************************************
>- * ImpersonateNamedPipeClient			EXPORTED
>- *
>- *  <at> implemented
>- */
>-BOOL
>-WINAPI
>-ImpersonateNamedPipeClient(HANDLE hNamedPipe)
>-{
>-    IO_STATUS_BLOCK StatusBlock;
>-    NTSTATUS Status;
>-
>-    TRACE("ImpersonateNamedPipeClient() called\n");
>-
>-    Status = NtFsControlFile(hNamedPipe,
>-                             NULL,
>-                             NULL,
>-                             NULL,
>-                             &StatusBlock,
>-                             FSCTL_PIPE_IMPERSONATE,
>-                             NULL,
>-                             0,
>-                             NULL,
>-                             0);
>-    if (!NT_SUCCESS(Status))
>-    {
>-        SetLastError(RtlNtStatusToDosError(Status));
>-        return FALSE;
>-    }
>-
>-    return TRUE;
>+BOOL WINAPI ImpersonateNamedPipeClient( HANDLE hNamedPipe )
>+{
>+    IO_STATUS_BLOCK io_block;
>+
>+    TRACE("(%p)\n", hNamedPipe);
>+
>+    return set_ntstatus( NtFsControlFile(hNamedPipe, NULL, NULL, NULL,
>+                         &io_block, FSCTL_PIPE_IMPERSONATE, NULL, 0,
>NULL, 0) );
> }
> 
> /*
>
>
Timo Kreuzer | 25 Oct 10:40 2014
Picon

Re: [ros-diffs] [tfaber] 64974: [CRT] - Add frame pointer omission information to assembly string functions to fix debugging annoyances. Reviews appreciated

Am 25.10.2014 02:08, schrieb tfaber@...:
> Author: tfaber
> Date: Sat Oct 25 00:08:23 2014
> New Revision: 64974
>
> URL: http://svn.reactos.org/svn/reactos?rev=64974&view=rev
> Log:
> [CRT]
> - Add frame pointer omission information to assembly string functions to fix debugging annoyances.
Reviews appreciated
>
>
>
> Modified: trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc?rev=64974&r1=64973&r2=64974&view=diff
> ==============================================================================
> --- trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc	[iso-8859-1] (original)
> +++ trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc	[iso-8859-1] Sat Oct 25 00:08:23 2014
>  <at>  <at>  -5,7 +5,8  <at>  <at> 
>   PUBLIC _tcsnlen
>   .code
>   
> -_tcsnlen:
> +FUNC _tcsnlen
> +    FPO 0, 1, 1, 1, 0, FRAME_FPO
This one has 2 parameters
Thomas Faber | 23 Oct 14:22 2014

Re: [ros-diffs] [jgardou] 64911: [USER32] - Fix LookupIconIdFromDirectoryEx, returning 0 when no matching entry is found. - Fix error handling when opening a cursor file. - Various code beautification here and the...

On 2014-10-23 11:32, jgardou@... wrote:
> -    if ( dwFileSize < (sizeof(*dir) + sizeof(dir->idEntries[0])*(dir->idCount-1)) )
> +    if (dwFileSize < (sizeof(*dir) + FIELD_OFFSET(CURSORICONFILEDIR, idEntries[dir->idCount])))

Did you mean to remove the sizeof(*dir)?
Alexander Rechitskiy | 23 Oct 11:19 2014
Picon

Tuesday is a best day for software\pr releases

Tuesday is a best day for software\pr releases. 
 
This conclusion is based on the analysis of the number of downloads and visits to the site ReactOS.org
In normal times Tuesday - a day of peak attendance or the day before the day of peak attendance.
 
This will help to improve the promotion of information in the media
 
--
Best regards,
Alexander Rechitskiy
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Timo Kreuzer | 22 Oct 21:19 2014
Picon

Re: [ros-diffs] [tfaber] 64889: [NTOS:MM] - Add a way to generate a pool tag from the calling driver name if none is specified. Disabled by default.


Simpler:

+    if (LdrEntry)
+    {
+        ULONG i;
+        Tag = '____'; // IMO better than '    '
+        for (i = 0; i < min(4, LdrEntry->BaseDllName.Length / sizeof(WCHAR)); i++)
+            ((PCHAR)&Tag)[i] = (LdrEntry->BaseDllName.Buffer[i] & 0xff);
+    }

Maybe we can also add support for tracking backtraces of pool allocations.

Am 22.10.2014 15:26, schrieb tfaber@...:
> Author: tfaber
> Date: Wed Oct 22 13:26:50 2014
> New Revision: 64889
>
> URL: http://svn.reactos.org/svn/reactos?rev=64889&view=rev
> Log:
> [NTOS:MM]
> - Add a way to generate a pool tag from the calling driver name if none is specified. Disabled by default.
>
> Modified:
>      trunk/reactos/ntoskrnl/mm/ARM3/expool.c
>
> Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/expool.c?rev=64889&r1=64888&r2=64889&view=diff
> ==============================================================================
> --- trunk/reactos/ntoskrnl/mm/ARM3/expool.c	[iso-8859-1] (original)
> +++ trunk/reactos/ntoskrnl/mm/ARM3/expool.c	[iso-8859-1] Wed Oct 22 13:26:50 2014
>  <at>  <at>  -2046,10 +2046,25  <at>  <at> 
>   ExAllocatePool(POOL_TYPE PoolType,
>                  SIZE_T NumberOfBytes)
>   {
> -    //
> -    // Use a default tag of "None"
> -    //
> -    return ExAllocatePoolWithTag(PoolType, NumberOfBytes, TAG_NONE);
> +    ULONG Tag = TAG_NONE;
> +#if 0 && DBG
> +    PLDR_DATA_TABLE_ENTRY LdrEntry;
> +
> +    /* Use the first four letters of the driver name, or "None" if unavailable */
> +    LdrEntry = KeGetCurrentIrql() <= APC_LEVEL
> +                ? MiLookupDataTableEntry(_ReturnAddress())
> +                : NULL;
> +    if (LdrEntry)
> +    {
> +        ULONG i;
> +        Tag = 0;
> +        for (i = 0; i < min(4, LdrEntry->BaseDllName.Length / sizeof(WCHAR)); i++)
> +            Tag = Tag >> 8 | (LdrEntry->BaseDllName.Buffer[i] & 0xff) << 24;
> +        for (; i < 4; i++)
> +            Tag = Tag >> 8 | ' ' << 24;
> +    }
> +#endif
> +    return ExAllocatePoolWithTag(PoolType, NumberOfBytes, Tag);
>   }
>   
>   /*
>  <at>  <at>  -2513,7 +2528,7  <at>  <at> 
>       //
>       // Allocate the pool
>       //
> -    return ExAllocatePoolWithQuotaTag(PoolType, NumberOfBytes, 'enoN');
> +    return ExAllocatePoolWithQuotaTag(PoolType, NumberOfBytes, TAG_NONE);
>   }
>   
>   /*
>
>
>
Timo Kreuzer | 22 Oct 20:56 2014
Picon

Re: [ros-diffs] [khornicek] 64882: [SERVMAN] - fix resource leaks CID 716292, 716293, 716294 - fix CID 716772 (double free), 513719 (wrong NULL check), 1206739 (cosmetic) - make line endings CR LF when exporting t...

Am 22.10.2014 00:58, schrieb khornicek@...:

> -                if (LVText != NULL)
> +                if (_tcslen(LVText))
>                   {
>                       WriteFile(hFile,
>                                 LVText,

I think LVText might not be zero terminated, when the SendMessage call 
fails.
What about if (dwTextLength != 0)?
Alex Ionescu | 20 Oct 20:50 2014
Picon

Re: [ros-diffs] [hbelusca] 64773: [FAST486]: Do not call RtlCopyMemory for copying few bytes (2 and 4).

memcpy already has logic to handle, 1, 2, 4, 8, etc.. sizes.

Best regards,
Alex Ionescu

On Thu, Oct 16, 2014 at 2:48 PM, <hbelusca-FK+hrUIho1S2+TBAgxGDFw@public.gmane.org> wrote:
Author: hbelusca
Date: Thu Oct 16 21:48:18 2014
New Revision: 64773

URL: http://svn.reactos.org/svn/reactos?rev=64773&view=rev
Log:
[FAST486]: Do not call RtlCopyMemory for copying few bytes (2 and 4).

Modified:
    trunk/reactos/lib/fast486/fast486.c
    trunk/reactos/lib/fast486/opgroups.c

Modified: trunk/reactos/lib/fast486/fast486.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/fast486.c?rev=64773&r1=64772&r2=64773&view=diff
==============================================================================
--- trunk/reactos/lib/fast486/fast486.c [iso-8859-1] (original)
+++ trunk/reactos/lib/fast486/fast486.c [iso-8859-1] Thu Oct 16 21:48:18 2014
<at> <at> -117,7 +117,6 <at> <at>
 Fast486MemReadCallback(PFAST486_STATE State, ULONG Address, PVOID Buffer, ULONG Size)
 {
     UNREFERENCED_PARAMETER(State);
-
     RtlMoveMemory(Buffer, (PVOID)Address, Size);
 }

<at> <at> -126,7 +125,6 <at> <at>
 Fast486MemWriteCallback(PFAST486_STATE State, ULONG Address, PVOID Buffer, ULONG Size)
 {
     UNREFERENCED_PARAMETER(State);
-
     RtlMoveMemory((PVOID)Address, Buffer, Size);
 }


Modified: trunk/reactos/lib/fast486/opgroups.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/opgroups.c?rev=64773&r1=64772&r2=64773&view=diff
==============================================================================
--- trunk/reactos/lib/fast486/opgroups.c        [iso-8859-1] (original)
+++ trunk/reactos/lib/fast486/opgroups.c        [iso-8859-1] Thu Oct 16 21:48:18 2014
<at> <at> -2016,6 +2016,7 <at> <at>

 FAST486_OPCODE_HANDLER(Fast486OpcodeGroup0F01)
 {
+    // FAST486_TABLE_REG TableReg;
     UCHAR TableReg[6];
     FAST486_MOD_REG_RM ModRegRm;
     BOOLEAN OperandSize, AddressSize;
<at> <at> -2054,8 +2055,9 <at> <at>
             }

             /* Fill the 6-byte table register */
-            RtlCopyMemory(TableReg, &State->Gdtr.Size, sizeof(USHORT));
-            RtlCopyMemory(&TableReg[sizeof(USHORT)], &State->Gdtr.Address, sizeof(ULONG));
+            // TableReg = State->Gdtr;
+            *((PUSHORT)&TableReg) = State->Gdtr.Size;
+            *((PULONG)&TableReg[sizeof(USHORT)]) = State->Gdtr.Address;

             /* Store the GDTR */
             return Fast486WriteMemory(State,
<at> <at> -2076,8 +2078,9 <at> <at>
             }

             /* Fill the 6-byte table register */
-            RtlCopyMemory(TableReg, &State->Idtr.Size, sizeof(USHORT));
-            RtlCopyMemory(&TableReg[sizeof(USHORT)], &State->Idtr.Address, sizeof(ULONG));
+            // TableReg = State->Idtr;
+            *((PUSHORT)&TableReg) = State->Idtr.Size;
+            *((PULONG)&TableReg[sizeof(USHORT)]) = State->Idtr.Address;

             /* Store the IDTR */
             return Fast486WriteMemory(State,
<at> <at> -2117,7 +2120,8 <at> <at>
             }

             /* Load the new GDT */
-            State->Gdtr.Size = *((PUSHORT)TableReg);
+            // State->Gdtr = TableReg;
+            State->Gdtr.Size = *((PUSHORT)&TableReg);
             State->Gdtr.Address = *((PULONG)&TableReg[sizeof(USHORT)]);

             /* In 16-bit mode the highest byte is masked out */
<at> <at> -2156,7 +2160,8 <at> <at>
             }

             /* Load the new IDT */
-            State->Idtr.Size = *((PUSHORT)TableReg);
+            // State->Idtr = TableReg;
+            State->Idtr.Size = *((PUSHORT)&TableReg);
             State->Idtr.Address = *((PULONG)&TableReg[sizeof(USHORT)]);

             /* In 16-bit mode the highest byte is masked out */



_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev

Gmane