Thomas Faber | 23 Aug 11:01 2015

Re: [ros-diffs] [bfreisen] 68792: [HHPCOMP] Improve functionality of Windows MSVC build. Based on a WIP patch by Michael Fritscher. See CORE-10019.

On 2015-08-22 13:16, bfreisen@... wrote:
> [HHPCOMP]
> Improve functionality of Windows MSVC build. Based on a WIP patch by Michael Fritscher.
> See CORE-10019.

> +/* if O_BINARY is not defined, the system is probably not expecting any such flag */
> +#ifndef O_BINARY
> +#define O_BINARY 0
> +#endif

> -		chm->fd = creat(filename, 0644);
> +		chm->fd = open(filename, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, 0644);

Hmm... fopen wouldn't have this problem ;)
Thomas Faber | 18 Aug 14:35 2015

Re: [ros-diffs] [hbelusca] 68754: [NTVDM]: Initialize the PSP' memory control block owner name with the file name (without extension, and up to 8 chars) of the started program.

On 2015-08-18 14:26, hbelusca@... wrote:
> [NTVDM]: Initialize the PSP' memory control block owner name with the file name (without extension, and
up to 8 chars) of the started program.

Shouldn't that use GetShortPathName to make sure the program can find
itself on disk? :p
Colin Finck | 15 Aug 12:08 2015

Follow-up on Hackfest

Hi all,

First of all, let me thank everybody who could make it to Aachen for
Hackfest! Thanks also go to all the others on IRC, Twitter, etc. who
supported us during that time!
It was a pleasure to have you all here and simply a great week! :)

Now let's spread the word even more, so that everyone can get an idea of
our Hackfest:

Hackfest report
===============
Aleksey suggested (and volunteered!) to write a report about our
Hackfest for the website. He wants someone to help him though.
Victor, as you did a pretty great job at live streaming every day, would
you help Aleksey here?
If there are other volunteers, just raise your voice :)

Photos
======
I've created a folder "ReactOS Hackfest 2015" in the "Developers" file
section on IServ. You already find all my photos there (among them,
first group photos from Saturday).
Please share your photos as well, either by uploading through the
website or through SFTP (WinSCP is a great tool for this).

If you're not in the "Developers" section, but participated in the
Hackfest, please tell either Christoph, Pierre or me and we will add you.

Cheers,
(Continue reading)

Thomas Faber | 10 Aug 20:52 2015

Re: [ros-diffs] [cwittich] 68673: [MSAFD] don't trace an uninitialized UNICODE_STRING

On 2015-08-10 19:54, cwittich@... wrote:
>  <at>  <at>  -40,8 +40,8  <at>  <at> 
>      PLIST_ENTRY	        Helpers;
>      INT                 Status;
>  
> -    TRACE("AddressFamily %p, SocketType %p, Protocol %p, Group %u, Flags %lx, TransportName %wZ,
HelperDllContext %p, HeplperDllData %p, Events %p\n",
> -        AddressFamily, SocketType, Protocol, Group, Flags, TransportName, HelperDllContext,
HelperDllData, Events);
> +    TRACE("AddressFamily %p, SocketType %p, Protocol %p, Group %u, Flags %lx, HelperDllContext %p,
HeplperDllData %p, Events %p\n",
> +        AddressFamily, SocketType, Protocol, Group, Flags, HelperDllContext, HelperDllData, Events);

So change it to %p? This is tracing all function arguments... seems
keeping that scheme would be good.
(also you could fix the Heplper typo if you're already at it :p)
Thomas Faber | 10 Aug 20:48 2015

Re: [ros-diffs] [dreimer] 68672: [BROWSEUI] Address is untranslatable by Adam Stachowicz CORE-9977 #resolve #comment Committed (with a Unicode fix), thx ^^

On 2015-08-10 18:52, dreimer@... wrote:
> --- trunk/reactos/dll/win32/browseui/addressband.cpp	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/browseui/addressband.cpp	[iso-8859-1] Mon Aug 10 16:52:40 2015
>  <at>  <at>  -93,7 +93,11  <at>  <at> 
>          pdbi->ptActual.y = 22;
>      }
>      if (pdbi->dwMask & DBIM_TITLE)
> -        wcscpy(pdbi->wszTitle, L"Address");
> +    {
> +        if (!LoadStringW(_AtlBaseModule.GetResourceInstance(), IDS_ADDRESSBANDLABEL,
pdbi->wszTitle, _countof(pdbi->wszTitle)))
> +            return E_FAIL;
> +    }

As a general rule, try not to use E_FAIL.
HRESULT_FROM_WIN32(GetLastError()) would probably be correct here.
Andrew Greenwood | 9 Aug 15:40 2015
Picon

Audio development

Hi everyone,

 

Some of you probably remember me. I was involved with trying to get audio/sound implemented in ReactOS a few years ago.

 

To be honest, my progress was rather poor, I managed to write a few bits of code but never really had a proper understanding of kernel/OS development or CPU/system architectures. Additionally, whilst I could grasp how the multimedia APIs (MME) in NT4 worked, and how they interacted with the drivers (audio device X opens device Y and writes buffered data to it) for Windows 2000 and later, Kernel Streaming was used which partly built on top of the older implementation but added a load of new stuff.

 

This complicated matters as firstly, KS uses COM (which I still struggle to wrap my head around) in kernel-mode, secondly there were multiple components involved between the application and the hardware (wdmaud.drv -> wdmaud.sys -> ks.sys -> portcls.sys -> driver as far as I remember), and finally I really struggled to find example code and thorough documentation describing how it all worked.

 

Ultimately I gave up with that and intended to move to another platform to develop multimedia applications. Not much happened with that.

 

I remember there were complaints from application developers over Kernel Streaming offering poor latency – instead developers would turn to other technologies such as ASIO or DirectSound. So for recent versions of Windows (Vista onwards?) Microsoft implemented a new, user-mode sound system (WASAPI) which again uses COM but is pretty nicely documented, with code samples.

 

Having done a little reading about this, it renewed my interest. It still uses COM, and KS.SYS is still present (I assume for compatibility?) but as a lot of this is implemented in user-space I suspect it’d be easier to develop/test.

 

Aside from this, over the past few years I’ve also gained a better understanding of topics I didn’t know much about previously and I feel more confident at being able to write lower-level stuff that works properly. I’ve also developed more of a keen interest in how Windows works.

 

So basically I’m considering implementing the current Windows audio system in ReactOS. I’d imagine we don’t need to be too concerned about audio drivers themselves (at least, initially) as vendors tend to offer these and it’s not like we need sound immediately post-install!

 

The only thing I really lack now is knowledge of how to implement COM classes – at least, outside of using Visual Studio… Anyone got recommended reading or example code for this?

 

 

Andrew

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 9 Aug 11:46 2015

Re: [ros-diffs] [dreimer] 68645: [shell32] Change Trash to Recycle Bin by Lee Schroeder CORE-8391 #resolve #comment Committed the big one with changes to all RC files, because it's the right way to do that. All th...

Well... since you asked...
Really good reason not to: if something's not broken, don't fix it.
Really good reason not to: if everything works fine and the user experience is generally Windows-like, we should NOT try to make things more Windows-like. On the contrary. Different is good, both in terms of project philosophy and legally.
Really good reason not to: as another non-native speaker... neither of the two terms seems better than the other for any objective reason. Except that 'trash' is something people actually say :p

Keep on hacking! ;)

On August 9, 2015 9:56:47 AM CEST, dreimer-FK+hrUIho1S2+TBAgxGDFw@public.gmane.org wrote:
Author: dreimer
Date: Sun Aug 9 07:56:47 2015
New Revision: 68645

URL: http://svn.reactos.org/svn/reactos?rev=68645&view=rev
Log:
[shell32]
Change Trash to Recycle Bin by Lee Schroeder
CORE-8391 #resolve #comment Committed the big one with changes to all RC files, because it's the right way to do that. All these strings are originated from the english resource and NEVER were translated up to now, so we keep these strings in sync. Second argument. Trash is not the right word here (YES, a non native dares to say this ^^) We use the Windows way here, unless someone gives me a REALLY good reason not to ^^

Modified:
trunk/reactos/dll/win32 /shell32/lang/ca-ES.rc
trunk/reactos/dll/win32/shell32/lang/da-DK.rc
trunk/reactos/dll/win32/shell32/lang/en-US.rc
trunk/reactos/dll/win32/shell32/lang/fi-FI.rc
trunk/reactos/dll/win32/shell32/lang/he-IL.rc
trunk/reactos/dll/win32/shell32/lang/hu-HU.rc
trunk/reactos/dll/win32/shell32/lang/ko-KR.rc
trunk/reactos/dll/win32/shell32/lang/nl-NL.rc
trunk/reactos/dll/win32/shell32/lang/pt-BR.rc
trunk/reactos/dll/win32/shell32/lang/sl-SI.rc
trunk/reactos/dll/win32/shell32/lang/sv-SE.rc
trunk/reactos/dll/win32/shell32/lang/zh-TW.rc

Modified: trunk/reactos/dll/win32/shell32/lang/ca-ES.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ca-ES.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Desktop"
IDS_MYCOMPUTER "My Computer"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT " Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or cop y\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/da-DK.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/da-DK.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -667,7 +667,7 <at> <at>
/* special folders */
IDS_DESKTOP "Skrivebord"
IDS_MYCOMPUTER "Min Computer"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -695,10 +695,10 <at> <at>
IDS_DELETEITEM_TEXT "Er du sikker på du vil slette '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CAN TTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "Overskriv fil %1?"
IDS_OVERWRITEFILE_CAPTION "Bekræft overskrivelse af fil"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/en-US.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/en-US.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] Sun Aug 9 07: 56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Desktop"
IDS_MYCOMPUTER "My Computer"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/fi-FI.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/fi-FI.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Työpöytä"
IDS_MYCOMPUTER "Oma Tietokone"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"
<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Haluatko varmasti tuhota '%1':n?"
IDS_DELETEMULTIPLE_TEXT "Haluatko varmasti tuhota nämä %1?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CAN TTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Vahvista Tiedoston Ylikirjoitus"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/he-IL.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/he-IL.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] (original)
+++ trunk/reacto s/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/hu-HU.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/hu-HU.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/rea ctos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Asztal"
IDS_MYCOMPUTER "Számítógép"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Biztosan törölni szeretnéd?: '%1'?"
IDS_DELETEMULTIPLE_TEXT "Biztosan törölni szeretnéd ezt a(z) %1 elemet?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHM ULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Állomány felülírása"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. D o you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/ko-KR.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ko-KR.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Desktop"
IDS_MYCOMPUTER "My Computer"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -689 ,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CAN TTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/nl-NL.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/nl-NL.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/nl-NL.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win 32/shell32/lang/nl-NL.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Desktop"
IDS_MYCOMPUTER "My Computer"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1 ' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/pt-BR.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/pt-BR.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Você tem certeza que deseja excluir '%1'?"
IDS_DELETEMULTIPLE_TEXT "Você tem certeza que deseja excluir estes %1 arquivos?"
IDS_DELETESELECTED_TEXT "Você tem certeza que deseja excluir o(s) arquivo(s) selecionado(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirmar sobreescrever arquivo"
IDS_OVERWRITEFOLDER_TEXT "Th is folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/sl-SI.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sl-SI.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Desktop"
IDS_MYCOMPUTER "My Computer"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTRO LPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"

Modified: trunk/reactos/dll/win32/shell32/lang/sv-SE.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sv-SE.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/rea ctos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -661,7 +661,7 <at> <at>
/* special folders */
IDS_DESKTOP "Desktop"
IDS_MYCOMPUTER "My Computer"
- IDS_RECYCLEBIN_FOLDER_NAME "Trash"
+ IDS_RECYCLEBIN_FOLDER_NAME "Recycle Bin"
IDS_CONTROLPANEL "Control Panel"
IDS_ADMINISTRATIVETOOLS "Administrative Tools"

<at> <at> -689,10 +689,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you su re that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe fo lder?"

Modified: trunk/reactos/dll/win32/shell32/lang/zh-TW.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/zh-TW.rc?rev=68645&r1=68644&r2=68645&view=diff

--- trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] Sun Aug 9 07:56:47 2015
<at> <at> -697,10 +697,10 <at> <at>
IDS_DELETEITEM_TEXT "Are you sure you want to delete '%1'?"
IDS_DELETEMULTIPLE_TEXT "Are you sure you want to delete these %1 items?"
IDS_DELETESELECTED_TEXT "Are you sure you want to delete the selected item(s)?"
- IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Trash?"
- IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Trash?"
- IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?"
- IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?"
+ IDS_TRASHITEM_TEXT "Are you sure that you want to send '%1' to the Recycle Bin?"
+ IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all its content to the Recycle Bin?"
+ IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Recycle Bin?"
+ IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Recycle Bin. Do you want to delete it instead?"
IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?"
IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite"
IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1 '.\n\nIf the files in the destination folder have the same names as files in the\nselected folder they will be replaced. Do you still want to move or copy\nthe folder?"



--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Pierre Schweitzer | 7 Aug 10:31 2015

Re: [ros-diffs] [aandrejevic] 68607: [FASTFAT] Irp->UserBuffer being NULL doesn't indicate any error. It could be that the caller really wants the result stored at address NULL (which can be valid, and is valid by...

This patch, as it, is really dangerous. MS allows null pointer in its
Read/Write routines, but they are wrapped inside a SEH block, to prevent
nasty things to happen in case of a null pointer dereference.

Here we don't, meaning that a null pointer here will cause major damages.

Furthermore, your commit regressed ntdll:file:
https://reactos.org/sites/all/modules/reactos/testman/compare.php?ids=40042,40045,40049,40052

Regards,

On 08/07/2015 05:30 AM, aandrejevic@... wrote:
> Author: aandrejevic
> Date: Fri Aug  7 03:30:05 2015
> New Revision: 68607
> 
> URL: http://svn.reactos.org/svn/reactos?rev=68607&view=rev
> Log:
> [FASTFAT]
> Irp->UserBuffer being NULL doesn't indicate any error. It could be that the
> caller really wants the result stored at address NULL (which can be valid,
> and is valid by default for programs like NTVDM).
> 
> 
> Modified:
>     trunk/reactos/drivers/filesystems/fastfat/rw.c
> 
> Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/rw.c?rev=68607&r1=68606&r2=68607&view=diff
> ==============================================================================
> --- trunk/reactos/drivers/filesystems/fastfat/rw.c	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/fastfat/rw.c	[iso-8859-1] Fri Aug  7 03:30:05 2015
>  <at>  <at>  -656,7 +656,7  <at>  <at> 
>      }
>  
>      Buffer = VfatGetUserBuffer(IrpContext->Irp, BooleanFlagOn(IrpContext->Irp->Flags, IRP_PAGING_IO));
> -    if (!Buffer)
> +    if (!Buffer && IrpContext->Irp->MdlAddress)
>      {
>          Status = STATUS_INVALID_USER_BUFFER;
>          goto ByeBye;
>  <at>  <at>  -927,7 +927,7  <at>  <at> 
>      OldFileSize = Fcb->RFCB.FileSize;
>  
>      Buffer = VfatGetUserBuffer(IrpContext->Irp, BooleanFlagOn(IrpContext->Irp->Flags, IRP_PAGING_IO));
> -    if (!Buffer)
> +    if (!Buffer && IrpContext->Irp->MdlAddress)
>      {
>          Status = STATUS_INVALID_USER_BUFFER;
>          goto ByeBye;
> 
> 

--

-- 
Pierre Schweitzer <pierre@...>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

Attachment (smime.p7s): application/pkcs7-signature, 5811 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Alberto Vaudagna | 6 Aug 22:10 2015
Picon

Visual Studio Support

Just wonder why no one has yet fixed the compiling errors you get if you use visual studio.
All the errors are not code related but linking problem, so I wonder why no body solve all the compiler errors.
Thanks,
Alberto Vaudagna
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Picon

VcXsrv Windows X Server

Hello,

i dont know if this list is the correct place to post this,

I found this software some weeks ago, and i thought it would be interesting to have it running in ReactOS.

But, according its website, support for Windows XP has been stopped. So question is, what about asking author to reenable XP support via ReactOS? :)

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Mgr. Janusz Chmiel | 31 Jul 19:46 2015
Picon

WDM sound drivers question

Dear core developers,
Is it possible to use  Windows XP based WDM sound drivers with Reactos 
0.4-CLT2015?
Is it possible to make something so specific WDM sound driver can be 
incorporated to Live CD so it would work out of The box?

If there is issues with using various sound drivers, how complex would 
bew for You to add support for general USB audio device.

Last plea.

Which dlls would had to be redesigned so NVDA screen reader would be used?
Oleacc.dll and other mSAA based libraries?

Thank You very much for  Yours answers.
With kindness regards.

Janusz Chmiel

Gmane