Timo Kreuzer | 15 Sep 21:43 2014
Picon

Topics for next meeting

Hi,

I'd like to propose some topics for the next meeting:

- Agile missing in Jira (looks like an incompatible version)
- new on-demand builders (Clang, VC, x64, arm, branch, patch)
- testbot on a win 2003 machine

Timo
Jérôme Gardou | 14 Sep 23:10 2014

Re: [ros-diffs] [akhaldi] 64151: [XDK][DDK] * Handle the rest of cases about the order of pragma and symbol declaration.

This breaks KDGDB compilation (and most probable KDCOM too if one would 
want to compile it using GCC)

drivers/base/kdgdb/gdb_send.c:77: référence indéfinie vers « 
__imp__KdDebuggerNotPresent »

Le 14/09/2014 17:49, akhaldi <at> svn.reactos.org a écrit :
> Author: akhaldi
> Date: Sun Sep 14 15:49:35 2014
> New Revision: 64151
>
> URL: http://svn.reactos.org/svn/reactos?rev=64151&view=rev
> Log:
> [XDK][DDK]
> * Handle the rest of cases about the order of pragma and symbol declaration.
>
> Modified:
>      trunk/reactos/include/ddk/ntddk.h
>      trunk/reactos/include/ddk/ntifs.h
>      trunk/reactos/include/ddk/wdm.h
>      trunk/reactos/include/xdk/fsrtlfuncs.h
>      trunk/reactos/include/xdk/haltypes.h
>      trunk/reactos/include/xdk/kdfuncs.h
>      trunk/reactos/include/xdk/ketypes.h
>      trunk/reactos/include/xdk/mmtypes.h
>      trunk/reactos/include/xdk/ntifs.template.h
>
> Modified: trunk/reactos/include/ddk/ntddk.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntddk.h?rev=64151&r1=64150&r2=64151&view=diff
> ==============================================================================
(Continue reading)

Timo Kreuzer | 12 Sep 22:53 2014
Picon

Re: [ros-diffs] [jgardou] 64127: [KDGDB] - Add a callback mechanism permitting to "simulate" KD send <-> receive loop without having to actually communicate to GDB - Use that to update the program counter when con...


while(1); is not really a good solution. It should be something that is
visible in GDB.
But I fear that a KeBugCheck() won't work here, since it will rely on a
working KD connection.
Maybe a KD_ASSERT() macro, that calls KdAssert() on failure or
something, resets the GDB connection somehow, issues a debug print and
then halts.

Am 12.09.2014 22:23, schrieb jgardou@...:
> Author: jgardou
> Date: Fri Sep 12 20:23:08 2014
> New Revision: 64127
>
> URL: http://svn.reactos.org/svn/reactos?rev=64127&view=rev
> Log:
> [KDGDB]
>  - Add a callback mechanism permitting to "simulate" KD send <-> receive loop without having to actually
communicate to GDB
>  - Use that to update the program counter when cont'ing a breakpoint
> Now cont'ing an assertion failure is possible, since we actually get beyond the int 3 instruction
>
> Modified:
>     trunk/reactos/drivers/base/kdgdb/gdb_input.c
>     trunk/reactos/drivers/base/kdgdb/kdgdb.h
>     trunk/reactos/drivers/base/kdgdb/kdpacket.c
>
> +)
> +{
> +    DBGKD_MANIPULATE_STATE64* State = (DBGKD_MANIPULATE_STATE64*)MessageHeader->Buffer;
(Continue reading)

Thomas Faber | 12 Sep 14:12 2014

Re: [ros-diffs] [tkreuzer] 64078: [PSEH] - On clang builds we need to do the return twice trick, since we don't have asm goto, which would allow us to specify labels in the code where we can branch to on an except...

On 2014-09-07 23:40, tkreuzer@... wrote:
> --- trunk/reactos/lib/pseh/i386/pseh3_i386.S	[iso-8859-1] (original)
> +++ trunk/reactos/lib/pseh/i386/pseh3_i386.S	[iso-8859-1] Sun Sep  7 21:40:07 2014
>  <at>  <at>  -30,6 +30,10  <at>  <at> 
>      mov [eax + SEH3_REGISTRATION_FRAME_Esi], esi
>      mov [eax + SEH3_REGISTRATION_FRAME_Edi], edi
>  
> +    /* Safe the return address */
> +    mov ebx, [esp]
> +    mov [eax + SEH3_REGISTRATION_FRAME_ReturnAddress], ebx
> +
>  .global __SEH3$_RegisterFrameWithStackLayout
>  __SEH3$_RegisterFrameWithStackLayout:
>  

I think we need to restore ebx before returning? I don't see us telling
the compiler that it was clobbered anywhere.
Timo Kreuzer | 12 Sep 00:57 2014
Picon

Re: [ros-diffs] [jgardou] 64121: [KDGDB] - introduce KDGDB, a KDCOM-like DLL, wrapping the KD protocol and the GDB remote protocol together. It is not fully functional, but for now it permits source-level debuggin...


Awesome stuff!

Am 11.09.2014 22:55, schrieb jgardou@...:
> Author: jgardou
> Date: Thu Sep 11 20:55:42 2014
> New Revision: 64121
>
> URL: http://svn.reactos.org/svn/reactos?rev=64121&view=rev
> Log:
> [KDGDB]
>  - introduce KDGDB, a KDCOM-like DLL, wrapping the KD protocol and the GDB remote protocol together.
> It is not fully functional, but for now it permits source-level debugging in some modules. More will be
added as I feel the need and find the time to work a bit more on it. (That is, unless an angel comes and resume
the work)
> To use it, set GDB and _WINKD_ to TRUE in your CMakeCache.txt. Using separate debug symbols is also a good idea.
>
>
Timo Kreuzer | 11 Sep 15:30 2014
Picon

Re: [ros-diffs] [akhaldi] 64113: [GLU32] * Link with mingwex. * Allow multiple definitions at link time because longjmp exists in both our msvcrt and mingwex. CORE-8516


Are you sure that we will link to the correct one? I doubt that the one
from mingwex is compatible.

Am 11.09.2014 12:13, schrieb akhaldi@...:
> Author: akhaldi
> Date: Thu Sep 11 10:13:05 2014
> New Revision: 64113
>
> URL: http://svn.reactos.org/svn/reactos?rev=64113&view=rev
> Log:
> [GLU32]
> * Link with mingwex.
> * Allow multiple definitions at link time because longjmp exists in both our msvcrt and mingwex.
> CORE-8516
>
> Modified:
>     trunk/reactos/dll/opengl/glu32/CMakeLists.txt
>
> Modified: trunk/reactos/dll/opengl/glu32/CMakeLists.txt
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/glu32/CMakeLists.txt?rev=64113&r1=64112&r2=64113&view=diff
> ==============================================================================
> --- trunk/reactos/dll/opengl/glu32/CMakeLists.txt	[iso-8859-1] (original)
> +++ trunk/reactos/dll/opengl/glu32/CMakeLists.txt	[iso-8859-1] Thu Sep 11 10:13:05 2014
>  <at>  <at>  -114,6 +114,11  <at>  <at> 
>  
>  if(NOT MSVC)
>      add_target_compile_flags(glu32 "-Wno-write-strings -Wno-unused-but-set-variable")
> +    if(CMAKE_C_COMPILER_ID STREQUAL "Clang")
> +        target_link_libraries(glu32 mingwex)
(Continue reading)

Jérôme Gardou | 9 Sep 21:16 2014

Re: [ros-diffs] [akhaldi] 64094: [CMAKE/CLANG] * Globally link mingwex for C modules. CORE-8516

Hey Amine

Is there any reason to not use our own mingwex build ?

Le 09/09/2014 20:11, akhaldi <at> svn.reactos.org a écrit :
> Author: akhaldi
> Date: Tue Sep  9 18:11:10 2014
> New Revision: 64094
>
> URL: http://svn.reactos.org/svn/reactos?rev=64094&view=rev
> Log:
> [CMAKE/CLANG]
> * Globally link mingwex for C modules.
> CORE-8516
>
> Modified:
>      trunk/reactos/toolchain-clang.cmake
>
> Modified: trunk/reactos/toolchain-clang.cmake
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/toolchain-clang.cmake?rev=64094&r1=64093&r2=64094&view=diff
> ==============================================================================
> --- trunk/reactos/toolchain-clang.cmake	[iso-8859-1] (original)
> +++ trunk/reactos/toolchain-clang.cmake	[iso-8859-1] Tue Sep  9 18:11:10 2014
>  <at>  <at>  -56,7 +56,7  <at>  <at> 
>   set(CMAKE_ASM_CREATE_STATIC_LIBRARY ${CMAKE_C_CREATE_STATIC_LIBRARY})
>   
>   # Don't link with anything by default unless we say so
> -set(CMAKE_C_STANDARD_LIBRARIES "-lgcc" CACHE STRING "Standard C Libraries")
> +set(CMAKE_C_STANDARD_LIBRARIES "-lmingwex -lgcc" CACHE STRING "Standard C Libraries")
>   
(Continue reading)

Thomas Faber | 8 Sep 10:27 2014

Re: [ros-diffs] [tkreuzer] 64078: [PSEH] - On clang builds we need to do the return twice trick, since we don't have asm goto, which would allow us to specify labels in the code where we can branch to on an except...

Making the member conditional but writing to it unconditionally seems
like it would overflow the stack variable on GCC?

On 2014-09-07 23:40, tkreuzer@... wrote:
> +#ifdef __clang__
> +    void *ReturnAddress;
>  #endif

> +    /* Safe the return address */
> +    mov ebx, [esp]
> +    mov [eax + SEH3_REGISTRATION_FRAME_ReturnAddress], ebx
Timo Kreuzer | 1 Sep 15:15 2014
Picon

Re: [ros-diffs] [jgardou] 64022: [SECUR32] - Update spec file [SCHANNEL] - Update stubs list Please blame binutils

Am 01.09.2014 14:21, schrieb jgardou@...:
> Author: jgardou
> Date: Mon Sep  1 12:21:16 2014
> New Revision: 64022
>
> URL: http://svn.reactos.org/svn/reactos?rev=64022&view=rev
> Log:
> [SECUR32]
>  - Update spec file
> [SCHANNEL]
>  - Update stubs list
> Please blame binutils
>
> Modified:
>     trunk/reactos/dll/win32/schannel/schannel.spec
>     trunk/reactos/dll/win32/schannel/schannel_wine.c
>     trunk/reactos/dll/win32/schannel/stubs.c
>     trunk/reactos/dll/win32/secur32/secur32.spec
>
> Modified: trunk/reactos/dll/win32/schannel/schannel.spec
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/schannel/schannel.spec?rev=64022&r1=64021&r2=64022&view=diff
> ==============================================================================
> --- trunk/reactos/dll/win32/schannel/schannel.spec	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/schannel/schannel.spec	[iso-8859-1] Mon Sep  1 12:21:16 2014
>  <at>  <at>  -15,14 +15,14  <at>  <at> 
>   <at>  stdcall InitSecurityInterfaceW() schan_InitSecurityInterfaceW
>   <at>  stdcall InitializeSecurityContextA(ptr ptr str long long long ptr long ptr ptr ptr ptr) schan_InitializeSecurityContextA
>   <at>  stdcall InitializeSecurityContextW(ptr ptr wstr long long long ptr long ptr ptr ptr ptr) schan_InitializeSecurityContextW
> - <at>  stdcall MakeSignature(ptr long ptr long) secur32.MakeSignature
> + <at>  stdcall MakeSignature(ptr long ptr long) schan_MakeSignature
(Continue reading)

Timo Kreuzer | 1 Sep 11:28 2014
Picon

Re: [ros-diffs] [hbelusca] 64017: [BOOTVID] - Synchronize correctly arm/bootdata.c with i386, as it was done previously. - Code formatting: whitespace fixes, add braces/brackets and spaces where needed; comments s...

Am 01.09.2014 01:00, schrieb hbelusca@...:
> Author: hbelusca
> Date: Sun Aug 31 23:00:29 2014
> New Revision: 64017
>
> URL: http://svn.reactos.org/svn/reactos?rev=64017&view=rev
> Log:
> [BOOTVID]
> - Synchronize correctly arm/bootdata.c with i386, as it was done previously.
Why is that file duplicated at all, if the contents are identical?
cameron.gutman | 27 Aug 20:12 2014

Re: [ros-diffs] [tfaber] 63953: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve

This seems strange. I understand that NT 5.x has a limitation of 64 MB MDLs on x86, but direct I/O was designed for exactly this case of large I/O operations. Has anyone verified that 2k3 doesn’t do MDL chaining for direct I/O when the transfer is larger than a single MDL can hold?

Also aren’t there changes to the IRP dispatch routines required to cope with not having an Irp->MdlAddress pointer anymore?

Cameron

From: tfaber <at> svn.reactos.org
Sent: ‎Tuesday‎, ‎August‎ ‎26‎, ‎2014 ‎6‎:‎41‎ ‎AM
To: ros-diffs <at> reactos.org

Author: tfaber
Date: Tue Aug 26 13:41:57 2014
New Revision: 63953

URL: http://svn.reactos.org/svn/reactos?rev=63953&view=rev
Log:
[FASTFAT]
- Do not use direct I/O since it limits read/write operations to 64 MB
CORE-8410 #resolve

Modified:
    trunk/reactos/drivers/filesystems/fastfat/fsctl.c

Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfat/fsctl.c?rev=63953&r1=63952&r2=63953&view=diff
==============================================================================
--- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Tue Aug 26 13:41:57 2014
<at> <at> -442,8 +442,7 <at> <at>
         goto ByeBye;
     }
 
-    DeviceObject->Flags = DeviceObject->Flags | DO_DIRECT_IO;
-    DeviceExt = (PVOID) DeviceObject->DeviceExtension;
+    DeviceExt = DeviceObject->DeviceExtension;
     RtlZeroMemory(DeviceExt, ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG)) + sizeof(HASHENTRY*) * HashTableSize);
     DeviceExt->FcbHashTable = (HASHENTRY**)((ULONG_PTR)DeviceExt + ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG)));
     DeviceExt->HashTableSize = HashTableSize;


_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev

Gmane