Alexander Rechitskiy | 24 Apr 23:14 2014
Picon

WebOS and ReactOS

 Let's bring up the webOS topic again. There is an interesting idea to port Nyx portability layer to Win32 and
thus make Open webOS running in ReactOS/Windows. Nice user interface would be a benefit!

http://www.openwebosproject.org/docs/architecture#.U1l8Uvl_vTo

--

-- 
Best regards,
Alexander Reachitskiy
Timo Kreuzer | 24 Apr 09:07 2014
Picon

Re: [ros-diffs] [akhaldi] 62898: [PSDK] * Add missing MAXLONGLONG definition.

Am 22.04.2014 23:43, schrieb akhaldi@...:
> Author: akhaldi
> Date: Tue Apr 22 21:43:39 2014
> New Revision: 62898
>
> URL: http://svn.reactos.org/svn/reactos?rev=62898&view=rev
> Log:
> [PSDK]
> * Add missing MAXLONGLONG definition.
>
> Modified:
>     trunk/reactos/include/psdk/winnt.h
>
> Modified: trunk/reactos/include/psdk/winnt.h
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=62898&r1=62897&r2=62898&view=diff
> ==============================================================================
> --- trunk/reactos/include/psdk/winnt.h	[iso-8859-1] (original)
> +++ trunk/reactos/include/psdk/winnt.h	[iso-8859-1] Tue Apr 22 21:43:39 2014
>  <at>  <at>  -1480,6 +1480,7  <at>  <at> 
>  #define MAXBYTE	0xff
>  #define MAXWORD	0xffff
>  #define MAXDWORD	0xffffffff
> +#define MAXLONGLONG (((LONGLONG)0x7fffffff << 32) | 0xffffffff)
>  #define PROCESSOR_INTEL_386 386
>  #define PROCESSOR_INTEL_486 486
>  #define PROCESSOR_INTEL_PENTIUM 586
>
>
>
Why not use 0x7FFFFFFFFFFFFFFFLL ?
(Continue reading)

Aleksey Bragin | 23 Apr 23:02 2014

Status Meeting (April 2014)

Hello,
Let me invite you to the monthly status meeting taking place last 
Thursday of this month, 24th of April, 19:00 UTC. And this date is very 
close to now!

IRC service will only be started shortly before the meeting. Your 
participation passwords and server address will be emailed to you 
shortly before the meeting starts, and they are going to be different 
once again as they are not stored in any database. Hopefully it's not 
much of inconvenience.
If someone still is not getting passwords sent before a meeting - please 
email Pierre before the meeting started to get one.

Please send agenda proposals to me before the meeting, so that we can 
start with a proposed agenda.

Regards,
Aleksey Bragin
Thomas Faber | 23 Apr 02:48 2014

Re: [ros-diffs] [aandrejevic] 62892: [NTVDM] Quit when ntvdm becomes the last process attached to the console.

On 2014-04-22 22:46, aandrejevic@... wrote:
> --- branches/ntvdm/subsystems/ntvdm/ntvdm.c	[iso-8859-1] (original)
> +++ branches/ntvdm/subsystems/ntvdm/ntvdm.c	[iso-8859-1] Tue Apr 22 20:46:50 2014
>  <at>  <at>  -196,6 +197,11  <at>  <at> 
>              EmulatorInterrupt(0x23);
>              break;
>          }
> +        case CTRL_LAST_CLOSE_EVENT:
> +        {
> +            if (CommandThread) TerminateThread(CommandThread, 0);
> +            break;
> +        }
>          default:
>          {
>              /* Stop the VDM if the user logs out or closes the console */

Wasn't there an event to tell that thread to exit?
Using TerminateThread like this feels icky.
Thomas Faber | 19 Apr 09:31 2014

Re: [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

On 2014-04-18 23:40, pschweitzer@... wrote:
> --- trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] Fri Apr 18 21:40:02 2014
>  <at>  <at>  -129,7 +131,7  <at>  <at> 
>  BOOLEAN
>  CdfsFCBIsRoot(PFCB Fcb)
>  {
> -    return(wcscmp(Fcb->PathName, L"\\") == 0);
> +    return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\\');
>  }

==

Generally I'm seeing a lot of manual work where
RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.
Pierre Schweitzer | 9 Apr 21:43 2014

Heartbleed issue on the ReactOS infrastructure

Dear all,

In case you don't use SSL/TLS on our infrastructure (web sites - drupal,
jira, fisheye), skip reading (and reconsider your choices about such
non-usage).

As you may (should?) have heard recently, OpenSSL has suffered a
critical security vulnerability (CVE-2014-0160), known as Heartbleed Bug
(http://heartbleed.com/). Most of our services were using an affected
release of OpenSSL, with heartbeat feature activated. Be it, mails
services, web services (Drupal, Jira).

We reacted quickly passed the public announcement, and the availability
of the fix to apply it on our infrastructure to limit the risks. Anyway,
this might have been enough (actually, the issue has been here for two
years!) to allow potentials attackers to, for instance, steal our SSL
private keys. So, we took the decision to renew all our certificates and
private keys to guarantee safe infrastructure usage.
Due to the nature of the security issue, we don't know what may have
been compromised in the infrastructure and in the user database. Hence
our drastic measures.

What does it mean for you? It means that your account information
(username + password) might have been compromised, and your account
itself could have been compromised (cookie stealth with the attack).
We highly recommend you to change your passwords and check that
everything is fine on your account. I shall remind you that password
change can take up to 6h to propagate to Fisheye & Jira.

As a side note, we enabled a while ago Perfect Forward Secrecy on our
(Continue reading)

Timo Kreuzer | 7 Apr 00:08 2014
Picon

Re: [ros-diffs] [pschweitzer] 62675: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible


I don't really see the reason here. Whether using the secure function or
not is is a question of whether we need null-termination or not.
If we need it the secure function will do the right thing. If we do not
need null-termination the non-secure function does the right thing and
the secure function would not add any security, but simply do the wrong
thing.
MSDN says about the lfFaceName member of the LOGFONT structure "A
null-terminated string that specifies the typeface name of the font. "
So we want it to be null-terminated and adding one more character does
not add anything useful, but will result in a broken structure.
Another difference is that the non-secure function pads the destination
array with nulls, the secure function does - afaik - not. If that is the
reason, I'd prefer zeroing it out before copying the string.

Am 06.04.2014 22:20, schrieb pschweitzer@...:
> Author: pschweitzer
> Date: Sun Apr  6 20:20:39 2014
> New Revision: 62675
>
> URL: http://svn.reactos.org/svn/reactos?rev=62675&view=rev
> Log:
> [CHARMAP]
> Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible
>
> Modified:
>     trunk/reactos/base/applications/charmap/lrgcell.c
>     trunk/reactos/base/applications/charmap/map.c
>
> Modified: trunk/reactos/base/applications/charmap/lrgcell.c
(Continue reading)

Minas Abrahamyan | 6 Apr 20:37 2014
Picon

Short announce: My Serial port-on-MMIO implementation works - allowing debug logging on laptops

Hi all,

With this few words I would like to share the joyous event of MMIO-based serial port implementation
has finally worked for me.

This is the equivalent of earlycon serial port implementation in Linux with some extension
(so now it is even better then Linux one)
Some work yet is needed to be done to transform the work into the normal patch, but the good news is
it is working, and still doesn't require PNPmanager for work, i.e. it starts very early in kernel and writes kernel log messages.

I use ExpressCard 34 extension board Serial RS232 port, on laptop,
but think it will work fro PC Cards too (former name PCMCIA).

==Importance: Touching the hardware==
For the more developers we need more working PC models ( Real Hardware)
Almost all modern PCs are laptops with PCIe bus (the rest are desktops)
(but few of them able to boot the ReactOS)
Modern serial ports are recommended to use /often use MMIO-based data transfer instead of former I/O ports.

So now possibility appears to debug these new computers and force the ReactOS to work on this important part of new PCs.

Thanks for attention

-Minas Abrahamyan

PS Curious note: for catching the debug logs I use the (small and cheap) soap box-sized microcontroller board with LCD (ready-unit), and I call it "ReactOS debug logger" appliance. It doesn't take space and doesn't produce any noise

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Thomas Faber | 6 Apr 18:53 2014

Re: [ros-diffs] [khornicek] 62665: [MAIN] - fix a copypasta - fix a possible buffer overrun (x5) - fix a negative array index access

You guys should consider replacing that stuff with strsafe functions
while you're at it ;)

On 2014-04-06 18:45, khornicek@... wrote:
> Author: khornicek
> Date: Sun Apr  6 16:45:21 2014
> New Revision: 62665
> 
> URL: http://svn.reactos.org/svn/reactos?rev=62665&view=rev
> Log:
> [MAIN]
> - fix a copypasta
> - fix a possible buffer overrun (x5)
> - fix a negative array index access
> 
> Modified:
>     trunk/reactos/dll/cpl/main/mouse.c
> 
> Modified: trunk/reactos/dll/cpl/main/mouse.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/main/mouse.c?rev=62665&r1=62664&r2=62665&view=diff
> ==============================================================================
> --- trunk/reactos/dll/cpl/main/mouse.c	[iso-8859-1] (original)
> +++ trunk/reactos/dll/cpl/main/mouse.c	[iso-8859-1] Sun Apr  6 16:45:21 2014
>  <at>  <at>  -499,7 +499,7  <at>  <at> 
>                  /* Remove quotation marks */
>                  if (szTempData[0] == _T('"'))
>                  {
> -                    lpStart = szValueData + 1;
> +                    lpStart = szTempData + 1;
>                      szTempData[_tcslen(szTempData) - 1] = 0;
>                  }
>                  else
>  <at>  <at>  -1022,9 +1022,9  <at>  <at> 
>  static VOID
>  LoadInitialCursorScheme(HWND hwndDlg)
>  {
> -    TCHAR szSchemeName[256];
> -    TCHAR szSystemScheme[256];
> -    TCHAR szCursorPath[256];
> +    TCHAR szSchemeName[MAX_PATH];
> +    TCHAR szSystemScheme[MAX_PATH];
> +    TCHAR szCursorPath[MAX_PATH];
>      HKEY hCursorKey;
>      LONG lError;
>      DWORD dwDataSize;
>  <at>  <at>  -1057,7 +1057,7  <at>  <at> 
>  
>      if (dwSchemeSource != 0)
>      {
> -        dwDataSize = 256 * sizeof(TCHAR);
> +        dwDataSize = MAX_PATH * sizeof(TCHAR);
>          lError = RegQueryValueEx(hCursorKey,
>                                   NULL,
>                                   NULL,
>  <at>  <at>  -1101,8 +1101,8  <at>  <at> 
>      else if (dwSchemeSource == 2)
>      {
>          LoadString(hApplet, IDS_SYSTEM_SCHEME, szSystemScheme, MAX_PATH);
> -        _tcscat(szSchemeName, _T(" "));
> -        _tcscat(szSchemeName, szSystemScheme);
> +        _tcsncat(szSchemeName, _T(" "), MAX_PATH - _tcslen(szSchemeName));
> +        _tcsncat(szSchemeName, szSystemScheme, MAX_PATH - _tcslen(szSchemeName));
>      }
>  
>      /* Search and select the curent scheme name from the scheme list */
>  <at>  <at>  -1276,6 +1276,10  <at>  <at> 
>                      {
>                          case LBN_SELCHANGE:
>                              nSel = SendMessage((HWND)lParam, LB_GETCURSEL, 0, 0);
> +
> +                            if(nSel == LB_ERR)
> +                                break;
> +
>                              SendDlgItemMessage(hwndDlg, IDC_IMAGE_CURRENT_CURSOR, STM_SETIMAGE, IMAGE_CURSOR,
>                                                 (LPARAM)g_CursorData[nSel].hCursor);
>                              EnableWindow(GetDlgItem(hwndDlg,IDC_BUTTON_USE_DEFAULT_CURSOR),
> 
> 
Thomas Faber | 6 Apr 18:10 2014

Re: [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add braces and remove an unneeded trace.

This will make any failure messages in the loop useless, since you
won't know which test they're about.
Just because the tests are succeeding now doesn't mean they always will.

On 2014-04-06 17:51, hbelusca@... wrote:
>  <at>  <at>  -188,7 +190,6  <at>  <at> 
>  
>      for (i = 0; i < TestCount; i++)
>      {
> -        trace("i = %d\n", i);
>          switch (TestCases[i].PrefixType)
>          {
>              case PrefixNone:
> 
> 
Pierre Schweitzer | 1 Apr 11:27 2014

Re: [ros-builds] Linux_AMD64_2 VMWPlayer-Test: build failed

Working on DB server atm (hence the fails). Results will be properly
submitted later on.
Ignore failed shell errors for the next hour.

Sorry about that.

On 04/01/2014 11:24 AM, buildbot@... wrote:
> The Buildbot has detected a failed build on builder Linux_AMD64_2 VMWPlayer-Test while building ReactOS.
> Full details are available at:
>  http://build.reactos.org/builders/Linux_AMD64_2%20VMWPlayer-Test/builds/3636
>
> Buildbot URL: http://build.reactos.org/
>
> Buildslave for this Build: Linux_AMD64_2
>
> Build Reason: Triggerable(Linux_AMD64_1 KVM-Test Trigger)
> Build Source Stamp: 62598
> Blamelist: 
>
> BUILD FAILED: failed shell
>
> sincerely,
>  -The Buildbot
>
>
>
>

--

-- 
Pierre Schweitzer <pierre@...>
System Administrator
ReactOS Foundation

Attachment (smime.p7s): application/pkcs7-signature, 5819 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev

Gmane