Timo Kreuzer | 29 Jan 00:03 2015
Picon

Re: [ros-diffs] [pschweitzer] 66101: [CDMAKE] It's totally pointless to nullify after calloc


This code change doesn't help to make the code more readable.

Am 28.01.2015 um 21:41 schrieb pschweitzer@...:
> Author: pschweitzer
> Date: Wed Jan 28 20:41:23 2015
> New Revision: 66101
>
> URL: http://svn.reactos.org/svn/reactos?rev=66101&view=rev
> Log:
> [CDMAKE]
> It's totally pointless to nullify after calloc
>
> Modified:
>      trunk/reactos/tools/cdmake/dirhash.c
>
> Modified: trunk/reactos/tools/cdmake/dirhash.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/dirhash.c?rev=66101&r1=66100&r2=66101&view=diff
> ==============================================================================
> --- trunk/reactos/tools/cdmake/dirhash.c	[iso-8859-1] (original)
> +++ trunk/reactos/tools/cdmake/dirhash.c	[iso-8859-1] Wed Jan 28 20:41:23 2015
>  <at>  <at>  -137,8 +137,6  <at>  <at> 
>       free(parentcase);
>   
>       de = calloc(1, sizeof(*de));
> -    de->head = NULL;
> -    de->child = NULL;
>       de->parent = parent_de;
>       de->normalized_name = strdup(targetnorm);
>       de->case_name = strdup(chop_filename(casename));
(Continue reading)

Thomas Faber | 25 Jan 18:45 2015

Re: [ros-diffs] [hbelusca] 65678: [MSGINA]: Update the function names of stubs, with (in comments) the number of parameters they take. See CORE-8459 for more information. CORE-8459 #resolve #comment Fixed in r65678.

On 2014-12-15 22:07, hbelusca@... wrote:
> +1 stub -noname ShellGetUserList   ; (long long long)

For future reference, you might as well write this kind of thing as
1 stdcall -stub -noname ShellGetUserList(long long long)

Then spec2def will create a stub that uses the correct calling
convention and also prints out the arguments. Plus it's easier to
change to the real thing when someone implements it ;)
Thomas Faber | 25 Jan 17:37 2015

Re: [ros-diffs] [jimtabor] 66085: [Win32ss] - Fix window from point so it handles disabled windows correctly. - Cleanup processing mouse routine. - See CORE-7447.

On 2015-01-25 16:57, jimtabor@... wrote:
> -        if (*HitTest == HTNOWHERE) *HitTest = HTCLIENT;
> +       if (*HitTest == HTNOWHERE && pwndChild == NULL) *HitTest = HTCLIENT;

pwndChild cannot be non-NULL here.
Pierre Schweitzer | 24 Jan 09:19 2015

Re: [ros-diffs] [hbelusca] 66083: [CDMAKE] - Disable unused dir_hash_next_dir function and corresponding target_dir_traversal structure definition. - Be really sure de->head and de->child are initialized at NULL. ...

On 24/01/2015 01:15, hbelusca@... wrote:
> ==============================================================================
> --- trunk/reactos/tools/cdmake/dirhash.c	[iso-8859-1] (original)
> +++ trunk/reactos/tools/cdmake/dirhash.c	[iso-8859-1] Sat Jan 24 00:15:08 2015
>  <at>  <at>  -138,12 +138,14  <at>  <at> 
>      hashcode = djb_hash(targetnorm);
>      de = calloc(1, sizeof(*de));
>      de->parent = parent_de;
> +    de->head = NULL;
> +    de->child = NULL;

de has been allocated few lines upper with calloc.
head & child CANNOT be different from NULL.
This is non sense.

>  <at>  <at>  -170,6 +172,7  <at>  <at> 
>      tf->target_name = strdup(chop_filename(target));
>  }
>  
> +#if 0
>  static struct target_dir_entry *
>  dir_hash_next_dir(struct target_dir_hash *dh, struct target_dir_traversal *t)
>  {
>  <at>  <at>  -200,13 +203,13  <at>  <at> 
>              return t->it;
>      }
>  }
> +#endif

Once again, this is trunk, not your working copy.
(Continue reading)

Colin Finck | 23 Jan 00:52 2015

New Flyers for FOSDEM required

Hi all,

We're still preparing merchandising products for FOSDEM, and flyers are
probably most important here and still doable in time.

Can somebody please take the template from
https://svn.reactos.org/press-media/trunk/Events/2009%20-%20FOSDEM/Flyer/ and
alter it a bit to reflect current ReactOS state?
The best would be a flyer not including a certain ReactOS version
number, so that it is universally usable.

If you don't have InDesign to modify the file, just send me the modified
text here.

Thanks!

Colin

Attachment (smime.p7s): application/pkcs7-signature, 5057 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Pierre Schweitzer | 21 Jan 21:20 2015

Security issue on ReactOS.org website

Dear all,

Just to make sure you read it: https://www.reactos.org/node/928

The SVN accounts are not affected.

Cheers,
--

-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

Attachment (smime.p7s): application/pkcs7-signature, 5328 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Hermès BÉLUSCA - MAÏTO | 19 Jan 00:12 2015
Picon

ReactOS Hybrid CDs

Hi all !

 

Our build system is now able to build so-called “hybrid cds” . What are they?

They are boot+live-cd all-in-one. In addition it is now possible with them to load the live cd as a ramdisk. For that the contents of the bootcd is placed into a bootcd/ directory, the contents of the livecd is placed into a livecd/ directory, and the livecd image itself is also included (this is the one that is used for livecd ramdisk). You can notice that makes a lot of redundancy, but it’s the best thing I could do for now. The best way would be to build some kind of flat HDD image that is used as the livecd ramdisk (and never use the livecd with reads from the cd as we currently do…) .

Anyways.

So here it is !

In addition you can add extra custom files via the build process: just place your files into a <your_ROS_source>/modules/hybridcd_extras/ directory (this directory doesn’t exist by default, it’s up to you to create and populate it; I think it’s better to create a directory somewhere else and then add a symlink “hybridcd_extras” to this directory, inside the modules/ directory, as you already do with rosapps and rostests).

After that you configure a build, build the host-tools and then ninja hybridcd !!

If then you need to change the custom files, do it and then reconfigure a build with the “cmake .” command (when you’re inside <your_ROS_builddir>/reactos/ ) so that cmake can build again the list of files to be included into the hybridcd.

 

See https://jira.reactos.org/browse/CORE-9069 for few more details.

 

Cheers,

Hermès.

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Colin Finck | 18 Jan 18:52 2015

LDAP going live

Hi all,

After finally setting up replication slaves for redundancy, our LDAP
setup went live today! BuildBot and all SVN repositories now
authenticate against a shared user directory.

If everything went well, you shouldn't notice a difference :)
Except that you can now change your SVN password yourself at
https://lam.reactos.org

Keep your credentials safe. We can now easily add more ReactOS developer
services like file sharing and Mumble without needing to duplicate all
user information. And we will do so!

Cheers,

Colin

Attachment (smime.p7s): application/pkcs7-signature, 5057 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
David Quintana (gigaherz | 16 Jan 00:40 2015
Picon

Could someone take over CORE-7864?

The bug was assigned to me a while ago, but this seems to be primarily win32k issues, which are outside my area of expertise. Someone else may be able to handle it better.
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Picon

Revision 66026 - Directory Listing Modified Sun Jan 11 14:38:26 2015 UTC (3 days, 7 hours ago) by dreimer [RAPPS] Database Update. This fixes the now dead LibreOffice link, too. I completely skipped MirandaIM because they suck by deciding to do the same shit, Filezilla did. SF Malware "optimized" installer!

Hello Daniel,

There are links to filezilla which doesnt lead to the malware installer shit. This link ends with ".../download?nowrap"

maybe adding this works for MirandaIM too

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Pierre Schweitzer | 13 Jan 21:17 2015

Downtime tomorrow at noon CET

Dear all,

Due to a hard disk dying, we'll attempt to anticipate its total death
tomorrow at noon CET to change it before it quits working.

It is a disk in one of our hypervisor. The following services will be hit:
-> ReactOS main website
-> Jira/Fisheye
-> Main DNS server
-> ReactOS community website

Sorry for the caused inconvenience.

With my best regards,
--

-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

Attachment (smime.p7s): application/pkcs7-signature, 5328 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev

Gmane