Pierre Schweitzer | 26 Mar 16:21 2015

Re: [ros-diffs] [hbelusca] 66903: [NTVDM] - Fix some english. - Validity checks for DosGetSftEntry returned pointer added. - Use unsigned indices for for-loops indices that are always positive.

On 03/26/2015 03:52 PM, hbelusca@... wrote:
> Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c?rev=66903&r1=66902&r2=66903&view=diff
> ==============================================================================
> --- trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c	[iso-8859-1] (original)
> +++ trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c	[iso-8859-1] Thu Mar 26 14:52:16 2015
>  <at>  <at>  -56,6 +56,13  <at>  <at> 
>  BOOLEAN DosCheckInput(VOID)
>  {
>      PDOS_SFT_ENTRY SftEntry = DosGetSftEntry(DOS_INPUT_HANDLE);
> +
> +    if (SftEntry == NULL)
> +    {
> +        /* Invalid handle */
> +        DosLastError = ERROR_INVALID_HANDLE; // ERROR_FILE_NOT_FOUND

Hum... Why?

Is the error code wrong and should be ERROR_FILE_NOT_FOUND? And then,
why setting this other error code?
Or is the error code right, and then, what's the purpose of such comment?
Or do you have a doubt about the right error code to use? Be it one or
the other?

I come back to my eternal comment: don't comment for yourself. Comment
for the others, you're not alone here. So, make it explicit.

Cheers,
--

-- 
Pierre Schweitzer <pierre@...>
(Continue reading)

Huw Campbell | 26 Mar 12:33 2015
Picon

Win2k3 end of life

Hey,

Win2k3 is end of support in 6 months, which will mean that the symbol
server will go down (as it has done for XP).

At the very least, we should scrape the symbol server so we can
continue to check and debug.

Or move to NT6...
Aleksey Bragin | 26 Mar 11:36 2015

Status Meeting (March 2015)

Hello,
Let me invite you to the monthly status meeting taking place today 26th 
of March, 19:00 UTC, as always.

IRC service will only be started shortly before the meeting. Your 
participation passwords and server address will be emailed to you 
shortly before the meeting starts, and they are going to be different 
once again as they are not stored in any database. Hopefully it's not 
much of inconvenience.

If someone still is not getting passwords sent before a meeting - please 
email Pierre before the meeting started to get one.

Please send agenda proposals to me before the meeting, so that we can 
start with a proposed agenda.

And join Mumble!

Regards,
Aleksey Bragin
Ged Murphy | 26 Mar 10:21 2015
Picon

Re: [ros-diffs] [tkreuzer] 66893: [WIN32K] Rewrite brush code in C++

Timo and C++??
Hell must be a bit chilly today :)

-----Original Message-----
From: Ros-diffs [mailto:ros-diffs-bounces@...] On Behalf Of tkreuzer@...
Sent: 25 March 2015 22:38
To: ros-diffs@...
Subject: [ros-diffs] [tkreuzer] 66893: [WIN32K] Rewrite brush code in C++

Author: tkreuzer
Date: Wed Mar 25 22:38:20 2015
New Revision: 66893

URL: http://svn.reactos.org/svn/reactos?rev=66893&view=rev
Log:
[WIN32K]
Rewrite brush code in C++
Colin Finck | 22 Mar 13:51 2015

msi:msi Wine Test hanging under Windows Server 2003

Hi all,

With my latest log flush change to rosautotest, you see that it's
msi:msi which is hanging in our Windows Server 2003 WHS-Testbot. See
https://build.reactos.org/builders/WHS-Testbot/builds/30/steps/test/logs/stdio

The actual hang looks like this:
http://fs2.directupload.net/images/150322/tsr72fu5.png

This is the only bug that prevents us from running the full Wine Test
Suite under Windows Server 2003. Fixes are welcome :)

Cheers,

Colin
Pierre Schweitzer | 19 Mar 16:54 2015

Jira & Fisheye downtime

Dear all,

Due to DB maintenance, Jira & Fisheye will be down in a few minutes.
There's no ETA for up status.

Sorry for the caused inconvenience,
--

-- 
Pierre Schweitzer <pierre@...>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

Attachment (smime.p7s): application/pkcs7-signature, 5783 bytes
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Fedor Zaitsev | 15 Mar 12:57 2015
Picon

Re: Ros-dev Digest, Vol 127, Issue 29

Thank you, with revision 66721 everything is ok with building ReactOS
Hi Fedor,

Hi. I am trying to compile ReactOS on my macbook with OSX 10.10 on it, but I got an error. Building tools compiled quite well (with some warmings, but I think that it is ok), but when I call "ninja all? I got error:
Can you please try with r66700 and report back?

Cheers,
Amine.

_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Fedor Zaitsev | 14 Mar 14:40 2015
Picon

Error with compiling ReactOS on OSX 10.10

 Hi. I am trying to compile ReactOS on my macbook with OSX 10.10 on it, but I got an error. Building tools compiled quite well (with some warmings, but I think that it is ok), but when I call "ninja all» I got error:
bash-3.2$ cd ../../output-MinGW-i386/reactos
bash-3.2$ ninja 
[544/8381] Building C object dll/openg...Files/mesa_main.dir/api_arrayelt.c.obj
FAILED: /usr/local/RosBE/i386/bin/i686-w64-mingw32-gcc  -DBUILD_GL32 -DFEATURE_GL=1 -DKDBG=1 -DOPENGL32_USE_TLS -DUSE_3DNOW_ASM -DUSE_COMPILER_EXCEPTIONS -DUSE_MMX_ASM -DUSE_SSE_ASM -DUSE_X86_ASM -DWIN32 -DWINVER=0x502 -D_DLL -D_GDI32_ -D_GLAPI_NO_EXPORTS -D_M_IX86 -D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T -D_USE_PSEH3=1 -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502 -D_WIN32_WINNT=0x502 -D_WINDOWS -D_X86_ -D__REACTOS__ -D__i386__ -D_inline=__inline -Di386 -Wa,--compress-debug-sections -pipe -fms-extensions -fno-strict-aliasing -mstackrealign -Wold-style-declaration -Wdeclaration-after-statement -fdebug-prefix-map="/Users/lobster/documents/RosBE/reactos"=ReactOS -gdwarf-2 -gstrict-dwarf -femit-struct-debug-detailed=none -feliminate-unused-debug-symbols -march=pentium -mtune=i686 -Werror -Wall -Wpointer-arith -Wno-char-subscripts -Wno-multichar -Wno-unused-value -Wno-maybe-uninitialized -Wno-error=unused-but-set-variable -Wno-error=type-limits -O1 -fno-optimize-sibling-calls -fno-omit-frame-pointer -mpreferred-stack-boundary=3 -fno-set-stack-executable -Winvalid-pch -Werror=invalid-pch -g -Idll/opengl/mesa/main -I../../dll/opengl/mesa/main -I../../include -I../../include/psdk -I../../include/dxsdk -Iinclude -Iinclude/psdk -Iinclude/dxsdk -Iinclude/reactos -I../../include/crt -I../../include/ddk -I../../include/ndk -I../../include/reactos -I../../include/reactos/libs -I../../dll/opengl/mesa/.     -Wno-error -Wno-type-limits   -include /Users/lobster/documents/RosBE/reactos/output-MinGW-i386/reactos/dll/opengl/mesa/main/mesa_main_pch.h -MMD -MT dll/opengl/mesa/main/CMakeFiles/mesa_main.dir/api_arrayelt.c.obj -MF dll/opengl/mesa/main/CMakeFiles/mesa_main.dir/api_arrayelt.c.obj.d -o dll/opengl/mesa/main/CMakeFiles/mesa_main.dir/api_arrayelt.c.obj -c ../../dll/opengl/mesa/main/api_arrayelt.c
cc1: warning: /Users/lobster/documents/RosBE/reactos/output-MinGW-i386/reactos/dll/opengl/mesa/main/mesa_main_pch.h.gch: had text segment at different address [enabled by default]
cc1: error: one or more PCH files were found, but they were invalid
cc1: fatal error: /Users/lobster/documents/RosBE/reactos/output-MinGW-i386/reactos/dll/opengl/mesa/main/mesa_main_pch.h: No such file or directory
compilation terminated.
and so on
What I am doing wrong? I have googled, but I don’t found anything relevant

Thanks
_______________________________________________
Ros-dev mailing list
Ros-dev@...
http://www.reactos.org/mailman/listinfo/ros-dev
Colin Finck | 14 Mar 13:51 2015

Re: [ros-diffs] [dreimer] 66690: [RAPPS] lack of a proxy configuration by Peter Hater. German translation updated by me. CORE-4852 #resolve #comment Committed, thx for help.

dreimer@... wrote:
> [RAPPS] lack of a proxy configuration by Peter Hater.

I don't think we need a separate proxy configuration per application.
We should rather keep things consistent and always use the system
proxy set in the "Internet Options" control panel applet.

Unless someone has any objections, I suggest reverting this.

- Colin
Aleksey Bragin | 13 Mar 20:02 2015

Re: [ros-diffs] [aandrejevic] 66666: [NTVDM][FAST486] - Implement VDDInstallMemoryHook and VDDDeInstallMemoryHook using page guards. - Implement another API for memory hooks that should be faster than page guards ...

Allright, so NTVDM is evil.
Pretty good choice, as I wouldn't want to taint kernel or other 
important part of the system by 66666 commit made on Friday 13th... ;-)

Regards,
Aleksey Bragin

On 13.03.2015 20:57, aandrejevic@... wrote:
> Author: aandrejevic
> Date: Fri Mar 13 17:57:51 2015
> New Revision: 66666
>
> URL: http://svn.reactos.org/svn/reactos?rev=66666&view=rev
> Log:
> [NTVDM][FAST486]
> - Implement VDDInstallMemoryHook and VDDDeInstallMemoryHook using page guards.
> - Implement another API for memory hooks that should be faster than page guards
> (for NTVDM only).
> - Adjust the VGA and EMS memory handlers to use this method.
> - In Fast486, implement a method that will allow us to "rewind" the current instruction,
> in case it was interrupted by a memory hook page fault.
> - Use a memory hook to protect the BIOS ROM from being written to.
>
Thomas Faber | 10 Mar 11:50 2015

Re: [ros-diffs] [akhaldi] 66660: [ADVAPI32_WINETEST] Sync with Wine Staging 1.7.37. CORE-9246

On 2015-03-10 11:10, akhaldi@... wrote:
> +if(NOT MSVC)
> +    add_target_compile_flags(advapi32_winetest "-Wno-format")
> +endif()

Why are we getting format warnings? Is __WINESRC__ not set correctly?

Gmane