headers
Darin Adler | 1 Jul 2011 01:52
Picon
Favicon

Re: Proposal: Commit messages should start with a one-line summary of the change

I don’t think it’s a good idea to add yet another thing to every change log entry.

I do think that given the tools behavior you described, we should move the reviewer text after the bug title
and patch description paragraph, even though you explicitly said that’s not what you are proposing.

    -- Darin
Permalink | Reply | 7 comments |
headers
Ryosuke Niwa | 1 Jul 2011 01:57
Favicon
Gravatar

Re: Proposal: Commit messages should start with a one-line summary of the change

On Thu, Jun 30, 2011 at 4:52 PM, Darin Adler <darin <at> apple.com> wrote:
I don’t think it’s a good idea to add yet another thing to every change log entry.

I do think that given the tools behavior you described, we should move the reviewer text after the bug title and patch description paragraph, even though you explicitly said that’s not what you are proposing.

I agree with Darin's point.

While I get annoyed by the fact trac log pages don't show any useful information:
rniwa <at> webkit.org: 2011-06-30
Ryosuke Niwa
Software Engineer
Google Inc.


< rniwa <at> webkit.org> Reviewed by Kent …

But that can be addressed by giving the right commit message extracted from the change log as Mark suggested:
On Thu, Jun 30, 2011 at 2:10 PM, Mark Rowe <mrowe <at> apple.com> wrote:
Most ChangeLog entries already have a one-line summary immediately after the "Reviewed by" line.  I'm not sure that there's any benefit to reordering these parts of the ChangeLog.

> Given this format, commit-log-editor will put the summary right at the top of the commit log. webkit-patch will require modifications to do this correctly, as represented by <https://bugs.webkit.org/show_bug.cgi?id=26755>.

commit-log-editor already does the right thing given our current format.  It's just that many people have switched to using webkit-patch, and it was never taught the correct format for commit messages.

We should just fix webkit-patch so that it uses the right commit message.

- Ryosuke

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 1 comment |
headers
Adam Barth | 1 Jul 2011 02:05
Favicon

Re: Proposal: Commit messages should start with a one-line summary of the change

On Thu, Jun 30, 2011 at 4:57 PM, Ryosuke Niwa <rniwa <at> webkit.org> wrote:
> We should just fix webkit-patch so that it uses the right commit message.

Go for it:

http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py#L117

Adam
Permalink | Reply | 0 comments |
headers
sarapkarthik | 1 Jul 2011 08:40
Picon

Join me on StumbleUpon!

sarapkarthik
0 Favorites
1 Followers
sarapkarthik wants to be friends with you on StumbleUpon.
StumbleUpon is a discovery engine that finds you the best web pages, recommended based on your interests. Join today and browse web pages you never would have found before!
To learn more, watch this video and take a tour!
Join for free >

StumbleUpon is a discovery engine that finds the best of the web, recommended just for you. Learn more

If you do not wish to receive emails sent by StumbleUpon, please click here

© StumbleUpon 2001 - 2011 
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 1 comment |
headers
sarapkarthik | 1 Jul 2011 08:40
Picon

Join me on StumbleUpon!

sarapkarthik
0 Favorites
1 Followers
sarapkarthik wants to be friends with you on StumbleUpon.
StumbleUpon is a discovery engine that finds you the best web pages, recommended based on your interests. Join today and browse web pages you never would have found before!
To learn more, watch this video and take a tour!
Join for free >

StumbleUpon is a discovery engine that finds the best of the web, recommended just for you. Learn more

If you do not wish to receive emails sent by StumbleUpon, please click here

© StumbleUpon 2001 - 2011 
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 0 comments |
headers
Adam Barth | 1 Jul 2011 08:51
Favicon

The WebKit2 bot is failing 100% of the tests

The WebKit2 bot seems to be failing 100% of the tests:

http://build.webkit.org/waterfall?show=SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)

The regression range appears to be the following:

http://trac.webkit.org/log/trunk?rev=90166&stop_rev=90160&verbose=on

That regression range has four patches that appear related to WebKit2,
mostly related to API versioning.  I don't know enough about WebKit2
to dig us out of this one, but hopefully someone on this list does.

Adam
Permalink | Reply | 2 comments |
headers
dipak kumar | 1 Jul 2011 09:39
Picon

[WebKit][Windows] compilation errors on Windows (using Cygwin)


Dear All,

I am trying to compile WebKit on Windows using WebKit. I got below compiler errors :

JavaScriptCore/jit/JITStubs.cpp:133: error: size of array 'dummyJITStackFrame_maintains_16byte_stack_alignment' is negative
JavaScriptCore/jit/JITStubs.cpp:134: error: size of array 'dummyJITStackFrame_stub_argument_space_matches_ctiTrampoline' is negative
JavaScriptCore/jit/JITStubs.cpp:135: error: size of array 'dummyJITStackFrame_callFrame_offset_matches_ctiTrampoline' is negative
JavaScriptCore/jit/JITStubs.cpp:136: error: size of array 'dummyJITStackFrame_code_offset_matches_ctiTrampoline' is negative
make[3]: *** [JavaScriptCore/jit/libJavaScriptCore_la-JITStubs.lo] Error 1

I commented out those four line which were compiler assertion and then I got below linking errors :

./.libs/libJavaScriptCore.a(libJavaScriptCore_la-Interpreter.o):Interpreter.cpp:(.text+0x96f): undefined reference to `_ctiTrampoline'
./.libs/libJavaScriptCore.a(libJavaScriptCore_la-Interpreter.o):Interpreter.cpp:(.text+0xb74): undefined reference to `_ctiTrampoline'
./.libs/libJavaScriptCore.a(libJavaScriptCore_la-Interpreter.o):Interpreter.cpp:(.text+0xf1a): undefined reference to `_ctiTrampoline'
./.libs/libJavaScriptCore.a(libJavaScriptCore_la-Interpreter.o):Interpreter.cpp:(.text+0x1d58): undefined reference to `_ctiTrampoline'
./.libs/libJavaScriptCore.a(libJavaScriptCore_la-JITStubs.o):JITStubs.cpp:(.text+0x1f): undefined reference to `cti_vm_throw'
./.libs/libJavaScriptCore.a(libJavaScriptCore_la-JITStubs.o):JITStubs.cpp:(.text+0x4c): undefined reference to `_ctiVMThrowTrampoline'
./.libs/libJavaScriptCore.a(libJavaScriptCore_la-JITStubs.o):JITStubs.cpp:(.text+0x3862): undefined reference to `_ctiOpThrowNotCaught'
./.libs/libJavaScriptCore.a(libJavaScriptCore_la-JITOpcodes.o):JITOpcodes.cpp:(.text+0x3a42): undefined reference to `_ctiVMThrowTrampoline'

I have tried using  __attribute__(used). But I again got the same error.

I am not able to proceed. Please anybody let me know how to remove these errors.

Awaiting reply.

Many Thanks,
Dipak



_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 1 comment |
headers
Adam Barth | 1 Jul 2011 09:49
Favicon

Re: Switching to new-run-webkit-tests

Sorry, no switch over tonight.  The WebKit2 build is too destroyed to
have any confidence that we're doing things correctly and the Snow
Leopard buildbot appears to have an errant HTTP server bound to port
8080.  :(

Adam

On Thu, Jun 30, 2011 at 11:47 AM, Adam Barth <abarth <at> webkit.org> wrote:
> According to https://bugs.webkit.org/show_bug.cgi?id=34984, there are
> only two remaining blocking issues:
>
> 1) Teaching new-run-webkit-tests to understand the difference between
> WebProcess crashes and other sorts of crashes in WebKit2.
> 2) Fixing some issues with the Apple Windows port.
>
> Once we get (1) fixed (hopefully today), we're going to start moving
> (non-Windows) ports over to new-run-webkit-tests (hopefully tonight).
>
> I suspect more issues will crop up once we actually flip the switch.
> Please do not hesitate to contact Eric or myself (either via #webkit
> or via bugs.webkit.org).  We'll try to respond to any issues that
> arise as quickly as possible.
>
> Thanks for your patience.
>
> Adam
>
>
> On Mon, Jun 27, 2011 at 4:26 PM, Xan Lopez <xan <at> gnome.org> wrote:
>> On Tue, Jun 28, 2011 at 1:17 AM, Eric Seidel <eric <at> webkit.org> wrote:
>>> There appear to be 6 remaining blocking issues:
>>> https://bugs.webkit.org/showdependencytree.cgi?id=34984&hide_resolved=1
>>>
>>> We would like to hear from others who have tried new-run-webkit-tests,
>>> if they have issues which they believe should block migrating to NRWT.
>>>  (If so, please file and block the master bug!)
>>
>> I can see the GTK+ port thing with Xvfb is there already, so not a lot
>> to add. NWRT is more sensitive to slow tests than the old
>> infrastructure, so we had to add a bunch of them to the expectations
>> file; I don't think this is particularly bad. In any case with the
>> Xvfb patch and my local expectations file things run beautifully and
>> way faster than before, so looking great from our side!
>>
>> Xan
>>
>>>
>>> Thanks.
>>>
>>> -eric
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev <at> lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev <at> lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
Permalink | Reply | 11 comments |
headers
kanhaiya yadav | 1 Jul 2011 11:10
Picon

Fwd: mipsel-uclibc-linux


Hi All,

I am porting webkit on MIPS for different devices, when I an using MIPS-LINUX it is working fine.

But when I am using MIPSEL-UCLIBC-LINUX tool chain I am getting crash on signal 11 (SIG_SEGV) and launcher stopped at
GtkWidget* webkit_web_view_new(void) { WebKitWebView* webView =WEBKIT_WEB_VIEW(g_object_new(WEBKIT_TYPE_WEB_VIEW, NULL)); return GTK_WIDGET(webView); }

Please let me know if any way out it...

Thanx & Regards,
K L Yadav
Samsung India Software Center,
Noida.

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 1 comment |
headers
Mark Rowe | 1 Jul 2011 15:31
Picon
Favicon

Re: The WebKit2 bot is failing 100% of the tests


On 2011-06-30, at 23:51, Adam Barth wrote:

> The WebKit2 bot seems to be failing 100% of the tests:
> 
> http://build.webkit.org/waterfall?show=SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)
> 
> The regression range appears to be the following:
> 
> http://trac.webkit.org/log/trunk?rev=90166&stop_rev=90160&verbose=on
> 
> That regression range has four patches that appear related to WebKit2,
> mostly related to API versioning.  I don't know enough about WebKit2
> to dig us out of this one, but hopefully someone on this list does.

It was one of my changes that broke this.  I went ahead and landed a fix in r90224.  Is there some reason that you
didn't file a bug report about this issue or even email me directly about it?  If you'd done either of these
things I would have seen it last night and had this fixed much sooner.

- Mark
Permalink | Reply | 1 comment |

Gmane