headers
Eric Seidel | 2 Jan 2011 06:20
Favicon
Gravatar

Apple-Mac-Pro-6 is misconfigured

http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/25306

It's always failign 3 tests:
http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r74852%20(25306)/results.html

Different tests than other bots.  So the sherriff-bot is constantly
reporting patches have broken the tree when apple-mac-pro-6 builds a
patch.

Also... the results seem to be not uploading correctly?  (Note the
pretty-diff links are broken.)

-eric
Permalink | Reply | 3 comments |
headers
Adam Barth | 2 Jan 2011 07:33
Favicon

JavaScriptCore has moved: How to avoid merge conflicts

As of r74855, JavaScriptCore is now located in Source/JavaScriptCore.
If you have outstanding patches to JavaScriptCore, here's what you can
do to avoid merge conflicts:

1) *BEFORE* updating past r74855, create a patch for your change,
either with svn-create-patch or by uploading your patch to
bugs.webkit.org with webkit-patch.

2) Clean your working copy.  I recommend using "webkit-patch clean",
but you can also use svn-unapply, "svn revert", "git reset", or
whatever you're most confortable with.

3) Update to top-of-tree.

4) Apply your patch using svn-apply or "webkit-patch
apply-attachment".  As of r74856, svn-apply is smart enough to
magically apply the JavaScriptCore parts of your patch to
Source/JavaScriptCore.

Please let me know if you have any merge trouble.  Hopefully we've got
things set up so that the move is relatively painless.  Thanks again
for your patience.

Adam
Permalink | Reply | 0 comments |
headers
Adam Barth | 2 Jan 2011 10:17
Favicon

Qt buildbot help

I'm having trouble getting the Qt build bots to compile again after
moving JavaScriptCore into Source.  They don't seem to realize that
PLATFORM(QT) should be defined.  I suspect they might just need a
clobber, but I'm not sure how to do that via build.webkit.org.  I'd be
much obliged if someone with a Qt build and/or access to the buildbot
would lend me a hand.

Thanks!
Adam
Permalink | Reply | 0 comments |
headers
Brian Hoary | 2 Jan 2011 15:30
Picon

Re: Newbie question re: raw bitmaps

I feel I should point out here, that as far as I understand there is no particular patent issue with Jpeg-XR. Microsoft have included Jpeg-XR under their community promise program which is a legal promise not to sue anyone for using patents they own for implementing a Jpeg-XR codec. The issue mentioned in the bugzilla entry is not a patent problem. The problem is with the reference code that Microsoft released for implementing a Jpeg-XR codec. The licencing of which states the code can only be used to create/decode images conforming to the Jpeg-XR spec. This condition makes the code non GPL compatible. There is nothing stopping anyone from creating a GPL compatible Jpeg-XR codec from scratch though.

On 22 December 2010 14:59, Eric Seide <eric <at> webkit.org> wrote:

Platforms provide their own image decoders. Some of them use the cross-platform image decoders checked into WebCore: http://trac.webkit.org/browser/trunk/WebCore/platform/image-decoders A quick skim of mozilla's bug on the subject: https://bugzilla.mozilla.org/show_bug.cgi?id=500500 leads me to believe there is currently no patent-safe way to use JPEG-XR. The only platform which has JPEG-XR natively is Windows, however both Apple's Windows port and Chromium's windows port use the checked-in image decoders. I think WebKit is unlikely to support JPEG-XR any time soon. Without mozilla supporting it (or much content on the web using it) there is little reason to add support. -eric On Wed, Dec 22, 2010 at 4:28 PM, Alex Danilo <alex at legrope.com> wrote: > Hi All, > >        Sorry to post a newbie question. > >        My name's Alex Danilo, I've been doing some SVG stuff over the past > few years and now have spent the past few months looking into the SVG > implementation in WebKit. > >        What I'm tyring to do is add a new image format in the engine > as an exercise. > >        I am trying to add support for JPEG-XR (formerly HD-Photo) as > a new supported image format for the <image> element (and <img> in > HTML I guess too). > >        Looking at the ports, code etc. this all plumbs via the Image > class, BitmapImage class, etc. > >        For some ports, like CG I see that the decode is done lazily > and defers it to CG so that no intermediate bitmaps are generated. > >        For JPEG-XR, I will have to unpack the ARGB32 bitmap somewhere > in memory and do a GraphicsContext drawImage() call to paint it to > the canvas. > >        So my question is, is there any preferred or desirable method > to accomplish this? i.e. how should I structure the interface to the > Image class to make sure it works on all ports without creating > a dog's breakfast of it? > >        All tips and pointers greatly appreciated. > > Cheers, > Alex 


_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 0 comments |
headers
Robert Hogan | 2 Jan 2011 19:47

git and svn out of sync?

Hi,

I committed http://trac.webkit.org/changeset/74869 from a git-svn checkout. 

The change hasn't propagated to git.webkit.org for some reason.

My git-svn copy is set up to point directly to refs/remotes/origin/master 
per the recommendation in:

https://trac.webkit.org/wiki/UsingGitWithWebKit#Updating

I landed the commit with:

Tools/Scripts/webkit-patch --ignore-builders --git-commit=HEAD land

and encountered no errors:

robert <at> mwenge:~/Development/WebKit$ Tools/Scripts/webkit-patch --ignore-
builders --git-commit=HEAD land
[webkit.py autoinstall messages snipped]
Parsing ChangeLog: /home/robert/Development/WebKit/Tools/ChangeLog
No bug id provided and --reviewer= not provided.  Not updating ChangeLogs 
with reviewer.
Parsing ChangeLog: /home/robert/Development/WebKit/Tools/ChangeLog
Committed r74869: <http://trac.webkit.org/changeset/74869>
Committed r74869: <http://trac.webkit.org/changeset/74869>
No bug id provided.

Hopefully no-one else commits before this becomes too difficult to repair..

Let me know if I can provide any more clues.

Thanks,
Robert
Permalink | Reply | 2 comments |
headers
Robert Hogan | 2 Jan 2011 21:36

Re: git and svn out of sync?

Looks like this was a false alarm. The revision is now in git. 

It took an awfully long time to sync though. Was there a problem, or does 
the git repo wait for a minimum number of revisions before sync'ing?

On Sunday 02 January 2011 18:47:40 Robert Hogan wrote:
> Hi,
> 
> I committed http://trac.webkit.org/changeset/74869 from a git-svn
> checkout.
> 
> The change hasn't propagated to git.webkit.org for some reason.
> 
> My git-svn copy is set up to point directly to
> refs/remotes/origin/master per the recommendation in:
> 
> https://trac.webkit.org/wiki/UsingGitWithWebKit#Updating
> 
> I landed the commit with:
> 
> Tools/Scripts/webkit-patch --ignore-builders --git-commit=HEAD land
> 
> and encountered no errors:
> 
> robert <at> mwenge:~/Development/WebKit$ Tools/Scripts/webkit-patch --ignore-
> builders --git-commit=HEAD land
> [webkit.py autoinstall messages snipped]
> Parsing ChangeLog: /home/robert/Development/WebKit/Tools/ChangeLog
> No bug id provided and --reviewer= not provided.  Not updating
> ChangeLogs with reviewer.
> Parsing ChangeLog: /home/robert/Development/WebKit/Tools/ChangeLog
> Committed r74869: <http://trac.webkit.org/changeset/74869>
> Committed r74869: <http://trac.webkit.org/changeset/74869>
> No bug id provided.
> 
> Hopefully no-one else commits before this becomes too difficult to
> repair..
> 
> Let me know if I can provide any more clues.
> 
> Thanks,
> Robert
> _______________________________________________
> webkit-dev mailing list
> webkit-dev <at> lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 1 comment |
headers
Darin Adler | 3 Jan 2011 18:46
Picon
Favicon

Fixing Qt and Chromium builds

To fix Qt I need to add includes of ExceptionCode.h to two source files.

To fox Chromium I have to figure out why my code change to not use defaultChecked seems to have been ineffective.

I will be able to deal with these in an hour or so. If someone else can do so sooner that would be great. I hope it
won't be necessary to roll the change out.

    -- Darin

Sent from my iPhone
Permalink | Reply | 2 comments |
headers
Mihai Parparita | 3 Jan 2011 18:56
Gravatar

Re: Fixing Qt and Chromium builds

I'm Chromium gardener, and I'll take a look at the Chromium compile errors.

Mihai

On Mon, Jan 3, 2011 at 9:46 AM, Darin Adler <darin <at> apple.com> wrote:
> To fix Qt I need to add includes of ExceptionCode.h to two source files.
>
> To fox Chromium I have to figure out why my code change to not use defaultChecked seems to have been ineffective.
>
> I will be able to deal with these in an hour or so. If someone else can do so sooner that would be great. I hope it
won't be necessary to roll the change out.
>
>    -- Darin
>
> Sent from my iPhone
> _______________________________________________
> webkit-dev mailing list
> webkit-dev <at> lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
Permalink | Reply | 1 comment |
headers
Mihai Parparita | 3 Jan 2011 19:06
Gravatar

Re: Fixing Qt and Chromium builds

Looks like http://trac.webkit.org/changeset/74899 will fix things.

Mihai

On Mon, Jan 3, 2011 at 9:56 AM, Mihai Parparita <mihaip <at> chromium.org> wrote:
> I'm Chromium gardener, and I'll take a look at the Chromium compile errors.
>
> Mihai
>
> On Mon, Jan 3, 2011 at 9:46 AM, Darin Adler <darin <at> apple.com> wrote:
>> To fix Qt I need to add includes of ExceptionCode.h to two source files.
>>
>> To fox Chromium I have to figure out why my code change to not use defaultChecked seems to have been ineffective.
>>
>> I will be able to deal with these in an hour or so. If someone else can do so sooner that would be great. I hope
it won't be necessary to roll the change out.
>>
>>    -- Darin
>>
>> Sent from my iPhone
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev <at> lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
Permalink | Reply | 0 comments |
headers
William Siegrist | 3 Jan 2011 19:43
Picon
Favicon

Re: git and svn out of sync?

The git repo should be in sync within a minute after each commit, though there is no transactional guarantee that they are always in sync. If something crashes during the sync, it won't retry until the next svn commit. 

-Bill



On Jan 2, 2011, at 12:36 PM, Robert Hogan wrote:

Looks like this was a false alarm. The revision is now in git.

It took an awfully long time to sync though. Was there a problem, or does
the git repo wait for a minimum number of revisions before sync'ing?

On Sunday 02 January 2011 18:47:40 Robert Hogan wrote:
Hi,

I committed http://trac.webkit.org/changeset/74869 from a git-svn
checkout.

The change hasn't propagated to git.webkit.org for some reason.


_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Permalink | Reply | 0 comments |

Gmane