Adam Barth | 1 Apr 01:54 2010

Chromium Windows build with Visual Studio Express

I'm trying to set up a Chromium Windows EWS bot (to run on the same
machine as our shiny new Apple Windows EWS bot), but I'm having
trouble getting build-webkit --chromium to work.  I didn't see any
documentation on webkit.org about how to build the Chromium port on
Windows.  Here's the error I'm getting:

[[
$ ./WebKitTools/Scripts/build-webkit --chromium
Building results into:
C:\cygwin\home\Administrator\svn\webkit-win-ews\WebKitBuild
/cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE/devenv.com WebKi
t/chromium/WebKit.sln /build Release
Can't exec "/cygdrive/c/Program Files/Microsoft Visual Studio
8/Common7/IDE/devenv.com": No such file or directory at
/home/Administrator/svn/webkit-cr-win-ews/
WebKitTools/Scripts/webkitdirs.pm line 1459.
]]

The "/cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE"
directory exists, but there's no devenv.com there (presumably because
I'm using Visual Studio Express).  What do I need to do to get this
working?

Thanks,
Adam
Peter Kasting | 1 Apr 02:02 2010
Picon

Re: Chromium Windows build with Visual Studio Express

On Wed, Mar 31, 2010 at 4:54 PM, Adam Barth <abarth <at> webkit.org> wrote:
The "/cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE"
directory exists, but there's no devenv.com there (presumably because
I'm using Visual Studio Express).  What do I need to do to get this
working?

Indeed, according to http://msdn.microsoft.com/en-us/library/hs24szh9.aspx the express version explicitly lacks devenv.com.  According to http://msdn.microsoft.com/en-us/library/xee0c8y7(VS.80).aspx , this utility "provides for the delivery of output via standard system streams, such as stdout and stderr, and determines the proper I/O redirection when capturing output, such as to a .txt file."

Sounds like things may still build with devenv.exe but you won't be able to stream the output somewhere?

PK
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Adam Barth | 1 Apr 02:06 2010

Re: Chromium Windows build with Visual Studio Express

On Wed, Mar 31, 2010 at 5:02 PM, Peter Kasting <pkasting <at> google.com> wrote:
> On Wed, Mar 31, 2010 at 4:54 PM, Adam Barth <abarth <at> webkit.org> wrote:
>> The "/cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE"
>> directory exists, but there's no devenv.com there (presumably because
>> I'm using Visual Studio Express).  What do I need to do to get this
>> working?
>
> Indeed, according
> to http://msdn.microsoft.com/en-us/library/hs24szh9.aspx the express version
> explicitly lacks devenv.com.  According
> to http://msdn.microsoft.com/en-us/library/xee0c8y7(VS.80).aspx , this
> utility "provides for the delivery of output via standard system streams,
> such as stdout and stderr, and determines the proper I/O redirection when
> capturing output, such as to a .txt file."
> Sounds like things may still build with devenv.exe but you won't be able to
> stream the output somewhere?

Yeah, we're not getting output from the win-ews on failures.  The
output is dumped into an HTML file somewhere.  I'm told we have code
for read those in.

I'll try switch it over to devenv.exe.

Adam
Adam Barth | 1 Apr 02:11 2010

Re: Chromium Windows build with Visual Studio Express

On Wed, Mar 31, 2010 at 5:06 PM, Adam Barth <abarth <at> webkit.org> wrote:
> On Wed, Mar 31, 2010 at 5:02 PM, Peter Kasting <pkasting <at> google.com> wrote:
>> On Wed, Mar 31, 2010 at 4:54 PM, Adam Barth <abarth <at> webkit.org> wrote:
>>> The "/cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE"
>>> directory exists, but there's no devenv.com there (presumably because
>>> I'm using Visual Studio Express).  What do I need to do to get this
>>> working?
>>
>> Indeed, according
>> to http://msdn.microsoft.com/en-us/library/hs24szh9.aspx the express version
>> explicitly lacks devenv.com.  According
>> to http://msdn.microsoft.com/en-us/library/xee0c8y7(VS.80).aspx , this
>> utility "provides for the delivery of output via standard system streams,
>> such as stdout and stderr, and determines the proper I/O redirection when
>> capturing output, such as to a .txt file."
>> Sounds like things may still build with devenv.exe but you won't be able to
>> stream the output somewhere?
>
> Yeah, we're not getting output from the win-ews on failures.  The
> output is dumped into an HTML file somewhere.  I'm told we have code
> for read those in.
>
> I'll try switch it over to devenv.exe.

Yuck.  Looks like some copy/pasted code wasn't copy/pasted well enough.  :(

At least it's chugging away now.

Thanks,
Adam
Adam Barth | 1 Apr 03:55 2010

Re: Chromium Windows build with Visual Studio Express

On Wed, Mar 31, 2010 at 5:11 PM, Adam Barth <abarth <at> webkit.org> wrote:
> On Wed, Mar 31, 2010 at 5:06 PM, Adam Barth <abarth <at> webkit.org> wrote:
>> On Wed, Mar 31, 2010 at 5:02 PM, Peter Kasting <pkasting <at> google.com> wrote:
>>> On Wed, Mar 31, 2010 at 4:54 PM, Adam Barth <abarth <at> webkit.org> wrote:
>>>> The "/cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE"
>>>> directory exists, but there's no devenv.com there (presumably because
>>>> I'm using Visual Studio Express).  What do I need to do to get this
>>>> working?
>>>
>>> Indeed, according
>>> to http://msdn.microsoft.com/en-us/library/hs24szh9.aspx the express version
>>> explicitly lacks devenv.com.  According
>>> to http://msdn.microsoft.com/en-us/library/xee0c8y7(VS.80).aspx , this
>>> utility "provides for the delivery of output via standard system streams,
>>> such as stdout and stderr, and determines the proper I/O redirection when
>>> capturing output, such as to a .txt file."
>>> Sounds like things may still build with devenv.exe but you won't be able to
>>> stream the output somewhere?
>>
>> Yeah, we're not getting output from the win-ews on failures.  The
>> output is dumped into an HTML file somewhere.  I'm told we have code
>> for read those in.
>>
>> I'll try switch it over to devenv.exe.
>
> Yuck.  Looks like some copy/pasted code wasn't copy/pasted well enough.  :(
>
> At least it's chugging away now.

For those following along at home, everything works now.  We just need
the patch in this bug:

https://bugs.webkit.org/show_bug.cgi?id=36919

Adam
Eric Seidel | 1 Apr 04:59 2010

EWS & Commit Bots now twice as fast

Thanks to a certain Dr. Barth.

http://trac.webkit.org/changeset/56857
http://trac.webkit.org/changeset/56884

There is also now an Apple Windows EWS bot.

If you have any trouble with the bots, let us know.

-eric
Roland Steiner | 2 Apr 07:43 2010
Picon

Rich Text Editing Questions, Refactoring of Position Classes

Hi all,

As I am working on WebKit rich text editing these days, there are 2 issues that I would like to address. From a brief internal discussion both seem feasible and worthwhile, but since they involve changes to current code and behavior I wanted to ask the WebKit community in general, and the original authors of WebKit editing in particular, about your opinion:

.) When a selection that starts in a table and ends outside it is deleted, the current code drags the adjacent outside content into the table. To me this is counter-intuitive (text can be "dragged" in, but not between cells, and not back outside), and it's also contrary to the behavior of other editors (FireFox, TextEdit, Word, etc.). The behavior is, however, enshrined in various layout tests, so I wonder if there was/is a reason to implement it this way. As this behavior also complicates fixing other bugs I wanted to see whether there would be much opposition to changing it (i.e., to content outside of a table staying outside on a delete operation).

.) The current Position classes are IMHO rather unfocused in their implementation, with lots of special cases and "magical" behavior, that still is often incorrect (e.g., with text that has padding, margins, or :before/:after content). For ease of further development they would therefore benefit from refactoring. The idea would be to change the classes into something along the lines of:

    DOMPosition: based on the current RangeBoundaryPoint, working on node + offset, interfacing with JavaScript
    EditingPosition (or TypeablePosition): based on the current PositionIterator for fast iteration, with most of the code of Position except for code that queries renderers
    VisiblePosition: change to work on renderers rather than nodes (moving such code from the current Position into this class).

with explicit, but not implicit, conversion between them. Similarly for Ranges.

In addition, a refactoring could add (or at least allow for) non-contiguous ranges and allow editing operations to work on arbitrary ranges/positions rather than just the (single) selection, which again currently is a pain point. In the long run I would envision to extend the code to allow multiple selections (such as for concurrent editing, or highlighting of find results, etc.), but that probably needs to be discussed separately.


It would be great if you could share your thoughts,


Cheers,

- Roland




_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Jason Rukman | 2 Apr 17:45 2010

Windows mobile build

Right now we have a windows mobile 6.x build for webkit.  I’d like to start merging this into the tree but wanted to get some consensus on an approach.  We have created our own solution and vcproj files that pretty much follow the current solution/vcproj files for the windows cairo build configuration.

 

Would it make sense to add a windows mobile build and solution configuration to the existing windows solution (with some different vsprop changes) or should we check in our version of the solution and project files separately (and where?)  I don’t like the idea of a separate solution/vcproj files but as far as I know if we add the windows mobile configuration you need to have the windows mobile sdk installed to be able to open the solution.  I need to confirm that this is true also if you just run the build from the command line though.  I’ve had some success merging changes between vcproj files so it’s possible this might be automated.

 

Thanks,

Jason.

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
KwangYul Seo | 2 Apr 19:46 2010
Picon

Re: Windows mobile build

Hi, Jason.

I don't think it is a good idea to add separate solution and vcproj
files for Windows Mobile.

Windows Mobile is just a small part of Windows CE. Windows CE covers
multiple CPU architectures (ARM, MIPS, ..) and platforms with varying
features. I hope the build system covers multiple configurations
easily. vcproj file is too verbose and not easy to maintain to keep
multiple configurations as we can see from Windows port.

If we are going to add a build system for Windows CE, I think we need
a more clever way to deal with this problem. I am currently working on
a build system which generates MSVS solution and vcproj files from a
build script. The sole purpose of this build system is to support
multiple Windows CE platforms and configurations from a single script.
I'd like to contribute this work once it is ready.

By the way, what is your contribution plan? Do you plan to contribute
WebKit API and layout tests?

Regards,
Kwang Yul Seo

On Sat, Apr 3, 2010 at 12:45 AM, Jason Rukman <JasonR <at> bsquare.com> wrote:
> Right now we have a windows mobile 6.x build for webkit.  I’d like to start
> merging this into the tree but wanted to get some consensus on an approach.
> We have created our own solution and vcproj files that pretty much follow
> the current solution/vcproj files for the windows cairo build configuration.
>
>
>
> Would it make sense to add a windows mobile build and solution configuration
> to the existing windows solution (with some different vsprop changes) or
> should we check in our version of the solution and project files separately
> (and where?)  I don’t like the idea of a separate solution/vcproj files but
> as far as I know if we add the windows mobile configuration you need to have
> the windows mobile sdk installed to be able to open the solution.  I need to
> confirm that this is true also if you just run the build from the command
> line though.  I’ve had some success merging changes between vcproj files so
> it’s possible this might be automated.
>
>
>
> Thanks,
>
> Jason.
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev <at> lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Jason Rukman | 2 Apr 19:50 2010

Re: Windows mobile build

That's great news... How far away are you from getting this build toolchain working?

I want to upstream the API once I work out how we can integrate our changes; which I think means that first we
need a build environment that can build our changes.

We are still working on the LayoutTests right now so I'm not sure.

-----Original Message-----
From: KwangYul Seo [mailto:kwangyul.seo <at> gmail.com] 
Sent: Friday, April 02, 2010 10:46 AM
To: Jason Rukman
Cc: Webkit Development List
Subject: Re: [webkit-dev] Windows mobile build

Hi, Jason.

I don't think it is a good idea to add separate solution and vcproj
files for Windows Mobile.

Windows Mobile is just a small part of Windows CE. Windows CE covers
multiple CPU architectures (ARM, MIPS, ..) and platforms with varying
features. I hope the build system covers multiple configurations
easily. vcproj file is too verbose and not easy to maintain to keep
multiple configurations as we can see from Windows port.

If we are going to add a build system for Windows CE, I think we need
a more clever way to deal with this problem. I am currently working on
a build system which generates MSVS solution and vcproj files from a
build script. The sole purpose of this build system is to support
multiple Windows CE platforms and configurations from a single script.
I'd like to contribute this work once it is ready.

By the way, what is your contribution plan? Do you plan to contribute
WebKit API and layout tests?

Regards,
Kwang Yul Seo


On Sat, Apr 3, 2010 at 12:45 AM, Jason Rukman <JasonR <at> bsquare.com> wrote:
> Right now we have a windows mobile 6.x build for webkit.  I’d like to start
> merging this into the tree but wanted to get some consensus on an approach.
> We have created our own solution and vcproj files that pretty much follow
> the current solution/vcproj files for the windows cairo build configuration.
>
>
>
> Would it make sense to add a windows mobile build and solution configuration
> to the existing windows solution (with some different vsprop changes) or
> should we check in our version of the solution and project files separately
> (and where?)  I don’t like the idea of a separate solution/vcproj files but
> as far as I know if we add the windows mobile configuration you need to have
> the windows mobile sdk installed to be able to open the solution.  I need to
> confirm that this is true also if you just run the build from the command
> line though.  I’ve had some success merging changes between vcproj files so
> it’s possible this might be automated.
>
>
>
> Thanks,
>
> Jason.
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev <at> lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

>
>
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Gmane