headers
Krzysztof Kowalczyk | 2 Oct 2005 10:27
Picon
Gravatar

Re: Strange Compile Error in HashMap/HashSet

I don't have an answer just 2 observations:

1. VC 2005 (8.0) handles this a little better i.e. it can compile but
fails at link time:

internal.obj : error LNK2019: unresolved external symbol "void *
__cdecl KXMLCore::extractFirst<struct std::pair<void *,void *>
>(struct std
::pair<void *,void *> const &)"
(??$extractFirst <at> U?$pair <at> PAXPAX <at> std <at>  <at>  <at> KXMLCore <at>  <at> YAPAXABU?$pair <at> PAXPAX <at> std <at>  <at>  <at> Z)
referenced in function "priva
te: static void * __cdecl KXMLCore::HashTable<void *,struct
std::pair<void *,void *>,&void * __cdecl KXMLCore::extractFirst<struct
std::pair
<void *,void *> >(struct std::pair<void *,void *> const &),struct
KXMLCore::DefaultHash<void *>,struct KXMLCore::PairHashTraits<struct
KXMLC
ore::HashTraits<void *>,struct KXMLCore::HashTraits<void *> >
>::extractKey(struct std::pair<void *,void *> const &)"
(?extractKey <at> ?$HashTab
le <at> PAXU?$pair <at> PAXPAX <at> std <at>  <at> $1??$extractFirst <at> U?$pair <at> PAXPAX <at> std <at>  <at>  <at> KXMLCore <at>  <at> YAPAXABU12 <at>  <at> ZU?$DefaultHash <at> PAX <at> 3 <at> U?$PairHashTraits <at> U?$HashTraits
 <at> PAX <at> KXMLCore <at>  <at> U12 <at>  <at> 3 <at>  <at> KXMLCore <at>  <at> CAPAXABU?$pair <at> PAXPAX <at> std <at>  <at>  <at> Z)
bin\testkjs.exe : fatal error LNK1120: 1 unresolved externals

2.
#include <bits/cpp_type_traits.h>
in kxmlcore\HashTraits.h is questionable. According to the source
(http://www-evasion.imag.fr/Membres/Frank.Perbet/extdox/stl/html/cpp__type__traits_8h-source.html)
it's a private header for libstdc++ and should not be directly
included by applications.
(Continue reading)

Permalink | Reply | 0 comments |
headers
George Staikos | 4 Oct 2005 06:14
Picon
Favicon

Re: [webkit-changes] cvs commit: JavaScriptCore/kjs date_object.cpp


I'm guessing that this fixes the case of adding a value to a date and crossing 
the DST boundary.  At least prior to this patch it would be off by an hour.  
I posted a possible fix which seems to fix it for me and has been applied to 
KJS.  It's portable, and this is not.  Any reason why the portable one wasn't 
used, and is it possible to commit it also?  (assuming that this patch does 
what I think..)

On Monday 03 October 2005 18:44, Timothy wrote:
>                   * kjs/date_object.cpp:
>                   (timetUsingCF): Fix one of the date tests my making the
> CF version of mktime have the same quirk about the DST field as the real
> mktime. * tests/mozilla/expected.html: Updated for newly fixed test.
>
>   -
>   +
>        CFAbsoluteTime absoluteTime = CFGregorianDateGetAbsoluteTime(date,
> timeZone); +
>   +    if (tm->tm_isdst >= 0) {
>   +      if (CFTimeZoneIsDaylightSavingTime(timeZone, absoluteTime) &&
> !tm->tm_isdst) +        absoluteTime += 3600;
>   +      else if (!CFTimeZoneIsDaylightSavingTime(timeZone, absoluteTime)
> && tm->tm_isdst) +        absoluteTime -= 3600;
>   +    }
>   +
>        CFTimeInterval interval = absoluteTime +

--

-- 
George Staikos
KDE Developer				http://www.kde.org/
(Continue reading)

Permalink | Reply | 3 comments |
headers
Maciej Stachowiak | 4 Oct 2005 07:24
Picon
Favicon

Re: Re: [webkit-changes] cvs commit: JavaScriptCore/kjs date_object.cpp


On Oct 3, 2005, at 9:14 PM, George Staikos wrote:

>
> I'm guessing that this fixes the case of adding a value to a date  
> and crossing
> the DST boundary.  At least prior to this patch it would be off by  
> an hour.
> I posted a possible fix which seems to fix it for me and has been  
> applied to
> KJS.  It's portable, and this is not.  Any reason why the portable  
> one wasn't
> used, and is it possible to commit it also?  (assuming that this  
> patch does
> what I think..)

This is a merge to a branch of a fix from way back (well, 8/11,  
almost two months ago). It has been on TOT a long time. The mktime  
man page implies that if the tm_isdst field is set and nonnegative,  
it overrides the actual DST for that time. This patch attempts to  
emulate this quirk for the CoreFoundation time function case. The  
higher-level code that calls mktime counts on this quirk.

Now, maybe that code was always wrong - I dunno. I'm not sure which  
other fix of yours you have in mind.

Regards,
Maciej

>
(Continue reading)

Permalink | Reply | 2 comments |
headers
David Harrison | 4 Oct 2005 19:16
Picon
Favicon

Re: Re: [webkit-changes] cvs commit: JavaScriptCore/kjs date_object.cpp

Sounds like fine comments to have in the code, not just the changelog.

Dave

On Oct 3, 2005, at 10:24 PM, Maciej Stachowiak wrote:

>
> On Oct 3, 2005, at 9:14 PM, George Staikos wrote:
>
>>
>> I'm guessing that this fixes the case of adding a value to a date  
>> and crossing
>> the DST boundary.  At least prior to this patch it would be off by  
>> an hour.
>> I posted a possible fix which seems to fix it for me and has been  
>> applied to
>> KJS.  It's portable, and this is not.  Any reason why the portable  
>> one wasn't
>> used, and is it possible to commit it also?  (assuming that this  
>> patch does
>> what I think..)
>
> This is a merge to a branch of a fix from way back (well, 8/11,  
> almost two months ago). It has been on TOT a long time. The mktime  
> man page implies that if the tm_isdst field is set and nonnegative,  
> it overrides the actual DST for that time. This patch attempts to  
> emulate this quirk for the CoreFoundation time function case. The  
> higher-level code that calls mktime counts on this quirk.
>
> Now, maybe that code was always wrong - I dunno. I'm not sure which
(Continue reading)

Permalink | Reply | 1 comment |
headers
George Staikos | 4 Oct 2005 19:32
Picon
Favicon

Re: Re: [webkit-changes] cvs commit: JavaScriptCore/kjs date_object.cpp

On Tuesday 04 October 2005 13:16, David Harrison wrote:
> Sounds like fine comments to have in the code, not just the changelog.

  I understand what happened here - it was just a coincidence that this patch 
went in at the same time.  Apparently my patch is still pending and mostly 
unrelated.

--

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
Permalink | Reply | 0 comments |
headers
Kevin Van Vechten | 14 Oct 2005 22:24
Picon
Favicon

cvs.opensource.apple.com upgrade

WebKit Committers,

I will be performing a system upgrade on cvs.opensource.apple.com  
this afternoon at 3pm PDT which will requiring taking it offline for  
about 15-20 minutes.  I'll be disabling logins, and ensuring all  
pending CVS commits are flushed prior to taking it offline

This will not affect anoncvs.opensource.apple.com, so anonymous CVS  
checkouts will continue to work during this time.

Thanks,

Kevin
Permalink | Reply | 0 comments |
headers
André-John Mas | 18 Oct 2005 22:35
Picon
Favicon

Clear colour

Hi,

I am creating a web site designed to be used by a Kiosk, in a dark  
environment. The
problem I have is because I use frames page loading seems to bit  
slower and so the
white colour that is used to clear the page before a redraw is very  
apparent. Since
Safari does not allow me to change this colour, I am planning on  
making a custom
build of WebKit. For this reason I would appreciate it if someone  
knows offhand
which file I should be looking at to save me a bit of time.

André-John
Permalink | Reply | 4 comments |
headers
Eric Seidel | 18 Oct 2005 22:39
Picon
Favicon

Re: Clear colour

You could also design your whole site to be a single page, and page  
"changes" loaded via xmlhttprequest.  Then you could control your  
background color on every browser. ;-)

-eric

On Oct 18, 2005, at 1:35 PM, André-John Mas wrote:

> Hi,
>
> I am creating a web site designed to be used by a Kiosk, in a dark  
> environment. The
> problem I have is because I use frames page loading seems to bit  
> slower and so the
> white colour that is used to clear the page before a redraw is very  
> apparent. Since
> Safari does not allow me to change this colour, I am planning on  
> making a custom
> build of WebKit. For this reason I would appreciate it if someone  
> knows offhand
> which file I should be looking at to save me a bit of time.
>
> André-John_______________________________________________
> webkit-dev mailing list
> webkit-dev <at> opendarwin.org
> http://www.opendarwin.org/mailman/listinfo/webkit-dev
Permalink | Reply | 0 comments |
headers
Darin Adler | 18 Oct 2005 23:21
Picon
Favicon

Re: Clear colour

On Oct 18, 2005, at 1:35 PM, André-John Mas wrote:

> I am creating a web site designed to be used by a Kiosk, in a dark  
> environment. The
> problem I have is because I use frames page loading seems to bit  
> slower and so the
> white colour that is used to clear the page before a redraw is very  
> apparent. Since
> Safari does not allow me to change this colour, I am planning on  
> making a custom
> build of WebKit. For this reason I would appreciate it if someone  
> knows offhand
> which file I should be looking at to save me a bit of time.

You probably don't need a custom build of WebKit.

You can instead use the WebView call (that should have been API, but  
was inadvertently left of the headers) setDrawsBackground:NO.

Then you can put the WebView inside a view that fills with any color  
you like.

     -- Darin
Permalink | Reply | 2 comments |
headers
André-John Mas | 19 Oct 2005 16:41
Picon
Favicon

Re: Clear colour

Safari doesn't seem to have a nib describing the browser windows. Is  
it still
possible to do this without a new build.

Andre

On 18-Oct-05, at 17:21 , Darin Adler wrote:

> On Oct 18, 2005, at 1:35 PM, André-John Mas wrote:
>
>
>> I am creating a web site designed to be used by a Kiosk, in a dark  
>> environment. The
>> problem I have is because I use frames page loading seems to bit  
>> slower and so the
>> white colour that is used to clear the page before a redraw is  
>> very apparent. Since
>> Safari does not allow me to change this colour, I am planning on  
>> making a custom
>> build of WebKit. For this reason I would appreciate it if someone  
>> knows offhand
>> which file I should be looking at to save me a bit of time.
>>
>
> You probably don't need a custom build of WebKit.
>
> You can instead use the WebView call (that should have been API,  
> but was inadvertently left of the headers) setDrawsBackground:NO.
>
> Then you can put the WebView inside a view that fills with any
(Continue reading)

Permalink | Reply | 1 comment |

Gmane