Osztrogonác Csaba | 26 Jan 15:40 2015
Picon

Unused parameter warnings / errors / warning fixes

Hi all,

I noticed many patches to fix newly introduced unused
parameter warnings on GTK and EFL ports nowadays.
(ToT EFL WebKit is warning free right now.)

CMake ports now handle unused parameters as warnings, not build
errors everywhere. (-Werror and -Wno-error=unused-parameter )
Mac port handles them as build errors, except in WebKit, WebKit2
and WebInspectorUI, where it is disabled (-Wno-unused-parameter)
WebInspectorUI  is warning free now, but there are zillion warnings
in WebKit and Webkit2.

It would be great if we can handle unused parameters in the same way:
- treat them as errors
- treat them as warnings and fix sometimes
- disable them and don't try to fix again and again
   (and maybe remove zillion UNUSED_PARAM warning fixes )

I played a little bit to see if it is possible to get rid these warnings
easily on Mac too and then handle the new ones as build failres:
https://bugs.webkit.org/show_bug.cgi?id=140764

But I'm not sure if treating unused parameters as errors would be good
idea, because many of them depend on different feature ifdef guards
and it might cause more frequent build failures. Maybe disabling them
would be better.

Ideas, opinions, concerns and suggestions are welcome.

(Continue reading)

Alexey Proskuryakov | 26 Jan 09:26 2015

Leaks bot at bot watcher's dashboard

Hi,

We have a new addition to the bot watcher's dashboard today, it now displays results from the leaks bot.



There is a link to regular test results, as well as to a little known LeaksViewer, which presents leaks stack traces in a very nice way.


I suspect that there are probably some low hanging fruit there to fix.

- Alexey

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Brent Fulgham | 25 Jan 20:47 2015
Picon

WinCairo 64-bit Bot Failures

Hi Everyone,

It looks like the WinCairo 64-bit bot is having some trouble due to the dread Cygwin rebaseline requirement:

Could someone with bot access please take the bot down and rebaseline it?

These (annoying) failures are one of the reasons I’ve been trying to get the build to work outside of Cygwin. (Patches welcome!)

Thanks,

-Brent
3>------ Build started: Project: JavaScriptCoreGenerated, Configuration: Release_WinCairo Win32 ------ 3> /usr/bin/bash 3> touch "%ConfigurationBuildDir%\buildfailed" 3> perl build-generated-files.pl "%ConfigurationBuildDir%" "C:\cygwin\home\webkitbot\win-cairo-release\build\WebKitLibraries\win" "%PlatformArchitecture%" 3> echo '/home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/ApplicationCache.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/CSS.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Console.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/DOM.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/DOMDebugger.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/DOMStorage.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Database.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Debugger.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/GenericTypes.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Inspector.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/LayerTree.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Network.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/OverlayTypes.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Page.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Runtime.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Timeline.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Worker.json ' | cmp -s - EnabledInspectorDomains || echo '/home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/ApplicationCache.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/CSS.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Console.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/DOM.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/DOMDebugger.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/DOMStorage.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Database.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Debugger.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/GenericTypes.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Inspector.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/LayerTree.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Network.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/OverlayTypes.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Page.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Runtime.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Timeline.json /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/inspector/protocol/Worker.json ' > EnabledInspectorDomains 3> 0 [main] sh 3272 child_info_fork::abort: C:\cygwin\bin\cygreadline7.dll: Loaded to different address: parent(0x2C0000) != child(0x3D0000) 3> /bin/sh: fork: retry: Resource temporarily unavailable 3> 0 [main] sh 2024 child_info_fork::abort: C:\cygwin\bin\cygreadline7.dll: Loaded to different address: parent(0x2C0000) != child(0x330000) 3> /bin/sh: fork: retry: Resource temporarily unavailable 3> 0 [main] sh 2072 child_info_fork::abort: C:\cygwin\bin\cygreadline7.dll: Loaded to different address: parent(0x2C0000) != child(0x3C0000) 3> /bin/sh: fork: retry: Resource temporarily unavailable 3> 0 [main] sh 2084 child_info_fork::abort: C:\cygwin\bin\cygreadline7.dll: Loaded to different address: parent(0x2C0000) != child(0x330000) 3> /bin/sh: fork: retry: Resource temporarily unavailable 3> 0 [main] sh 3528 child_info_fork::abort: C:\cygwin\bin\cygreadline7.dll: Loaded to different address: parent(0x2C0000) != child(0x330000) 3> /bin/sh: fork: Resource temporarily unavailable 3> /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/DerivedSources.make:172: recipe for target 'EnabledInspectorDomains' failed 3> make: *** [EnabledInspectorDomains] Error 254 3> Failed to build /home/webkitbot/win-cairo-release/build/Source/JavaScriptCore/DerivedSources.make: at build-generated-files.pl line 78. 3>NMAKE : fatal error U1077: 'perl' : return code '0x2' 3> Stop.

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Darin Adler | 22 Jan 17:44 2015
Picon

run-webkit-tests question; hashes when comparing ref test output

I noticed that when running tests I get messages like this:

    svg/css/svg-resource-fragment-identifier-img-src.html -> ref test hashes didn't match but diff passed

I understand that we can have hash mismatches in actual checked in images (expected.png files), and there,
at least, I believe the fix might be to regenerate the image. But for a ref test I am really unclear on this.
And further, I think it’s distracting to get messages like this unless you are specifically working on
the testing infrastructure.

Why should the average WebKit engineer care about this? Does this reflect a real performance problem when
running tests? If so, who would fix it and what would that person do?

— Darin
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Brent Fulgham | 22 Jan 05:48 2015
Picon

Abandoned Tests

I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be
leftovers from the Chromium project. I think all ports currently skip these tests:

1. fast/dom/title-directionality-removeChild.html
2. fast/dom/title-directionality.html
3. fast/events/drag-image-filename.html
4. fast/autoresize
5. fast/overflow/scrollbar-restored-and-then-locked.html

If no one is using these tests, or plans to, I would like to remove them and the disconnected bits of code in
DRT/WKTR that were originally meant to drive this code.

If I don’t hear anything by this time next week, I’ll remove the code.

Thanks,

-Brent
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Ryosuke Niwa | 22 Jan 02:24 2015

Implementing ES6 class syntax in JSC

Hello WebKittens,

I'm implementing ES6 class syntax behind a build flag in https://webkit.org/b/140491.  Please let me know if you have any concerns or comments.

- R. Niwa

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Xabier Rodríguez Calvar | 21 Jan 19:40 2015

Problem with a crash using JSC code

	Hi!

I am now implementing with Youenn the Streams API standard [1] in
WebKit. You can find the first patch at [2] (it's r? now). While we get
that patch reviewed and landed we are adding more tests and working out
the problems. One of them is one crash that I cannot hunt, with the
following backtrace:

http://fpaste.org/172619/60635142/

You can find the code under the lines to make it easier. What is going
on is:

     1. There's a call to the ReadableStream object, delegated to the
        JSReadableStreamSource as a result of the object creation.
     2. There's a call to the JSReadableStream::read method, delegating
        in the ReadableStream that ends up pulling again and that second
        call crashes.

It is probably something stupid I am not taking into account, but I have
already been fighting this for a couple of days and cannot make it work
properly.

Any help? Thanks a lot in advance!

[1] https://streams.spec.whatwg.org/
[2] https://bugs.webkit.org/show_bug.cgi?id=138967

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Manuel Rego Casasnovas | 21 Jan 11:48 2015

CSS Grid Layout Status Review (Jan 2015)


Hi,

this is a new status review (last one was in August 2014 [1]) of the CSS
Grid Layout [2] implementation done by Igalia. We'll summarize the work
done during the past months and the plans for the future.
Of course, we'll be really happy to get any kind of feedback from the
community.

The meta-bug to follow the evolution of this feature is:
http://wkb.ug/60731

Main tasks done since August:

* Track Sizing Algorithm (http://wkb.ug/60731):
  * Tracks no longer shrink with undefined remaining space.
  * Fixed the grow beyond growth limits use case.
  * Do not use items spanning through flex tracks when sizing content
sized tracks.
  * Sizing content sized tracks is no longer order-dependent.
  * Support of percentages of indefinite sizes in minmax().

* Auto-placement (http://wkb.ug/103316):
  * Support sparse & dense packing modes.
  * Stack mode was finally dropped from the spec.

* Alignment & justification (http://wkb.ug/133224 & http://wkb.ug/133222):
  * Upgrade self alignment properties (justify-self/items,
align-self/items) to the last CSS3 spec.

* Testing:
  * Improve test coverage, which lead to some bug reports and fixes.
  * Outside WebKit: Started to create the W3C test suite for grid [3].
Still on early stages, check the test plan [4] for more information.

* Bugfixing:
  * Fixed different bugs reported by fuzzinator.
  * Generic bugfixing.

Ongoing tasks:

* Track Sizing Algorithm (http://wkb.ug/60731):
  * Initialization of track sizes from non spanning items.
  * Add and enforce the growth limit >= base size constraint.
  * Improve sizing computations of tracks growing beyond limits.
  * Fix behavior under min/max-width and min/max-content.
  * Add support for mark as infinitely growable and unmark.
  * Rewrite some of the loops that are incorrectly nested.

* Alignment & justification (http://wkb.ug/133224 and http://wkb.ug/133222):
  * Due to some performance concerns, CSS3 upgrade of alignment
properties is stalled.
  * There're several patches pending to fully support the Box Alignment
specification in WebKit.

* Testing:
  * Outside WebKit: Continue working on the W3C test suite in order to
cover the whole spec. Then, import the test suite into WebKit.

Plans for the future:

* Absolutely positioned grid children.

* Alignment & justification
  * Implementation of the Box Alignment spec for Grid Layout.
  * Dealing with orthogonal flows.

* Writing modes.
  * Adapting the track sizing and item positioning to any writing mode
and direction.
  * Implementing support for orthogonal flows.
  * Handling grid's and item's margin, border and padding in different
writing modes and directions.

* Support "auto" keyword for repeat() function.

* Allow to grow the implicit grid before the explicit grid (supporting
properly negative indexes for grid line numbers).

* Implement fragmentation support once the spec is definitive regarding
this topic.

* Performance analysis and optimizations.

* Grid support on Web Inspector.

This is a high level summary, you can check the different bugs for more
details. Please don't hesitate to ask any question. We hope you find
this information useful.

BTW, you can already test CSS Grid Layout using the WebKit nightly
builds (remember to use "-webkit" prefix) [5].

Best regards,
  Rego

[1] https://lists.webkit.org/pipermail/webkit-dev/2014-August/026756.html
[2] http://dev.w3.org/csswg/css-grid/
[3] http://test.csswg.org/shepherd/search/spec/css-grid-1/
[4] http://rawgit.com/w3c/csswg-test/master/css-grid-1/test-plan/index.html
[5] http://nightly.webkit.org/
Jon Lee | 20 Jan 22:48 2015
Picon

WebKit Contributors Meeting 2015 - Save the Date

Hi all,

Apple will once again be hosting a WebKit Contributors Meeting. It will be held on Apple’s Infinite Loop
campus in Cupertino on Thursday, March 12, and Friday, March 13. As in previous years, this event will have
an "unconference"-like format, allowing time for impromptu sessions, discussions, and hacking.

As always, to attend you must be an active WebKit contributor. The meeting will be free of charge, and
registration will open next week.

We hope to see you there!

Thanks,
Jon

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Peter Bittner | 19 Jan 18:58 2015
Picon
Picon

WebKit not rendering images of a local resource (from within Gedit)

Hi,

I'm using WebKit to render HTML in a plugin of Gedit, the Gnome text
editor. The source code is available from
https://github.com/bittner/gedit-reST-plugin/blob/gedit-3.14/reST/restructuredtext.py#L56

Now it looks like WebKit is rendering images from remote resources
(e.g. http://farm3.static.flickr.com/2256/2259897373_d47ecf0983_o_d.png)
fine, but local images (e.g. docs/reStPlugin.png) just display as an
empty box. Interestingly, the size of the box corresponds to the real
size of the image, but the image itself is not displayed.

Some details and a screenshot are available from a bug report at
https://github.com/bittner/gedit-reST-plugin/issues/7

Does this problem sound familiar to someone?

Thanks in advance for any hints,
Peter
Osztrogonác Csaba | 19 Jan 18:44 2015
Picon

Proposal: Removing ENABLE(INSPECTOR) guards

Hi All,

Inspector is enabled by default on all major WebKit port and
the build without inspector isn't really maintained by anyone.

Building without inspector can be useful on an embedded system where
you don't need it, but it only reduces the binary code size with ~3%.
It isn't so much, but the maintenance cost can be much more bigger.

I propose removing ENABLE(INSPECTOR) guards to reduce maintenance cost.

br,
Ossy

Gmane