Rod Whitworth | 1 Feb 01:07 2012

login_yubikey manpage missing stuff

Curiosity made me look at login_yubikey and so I looked at its manpage.

The synopsis says:
login_yubikey [-d] [-s service] user [class]

Nowhere was an explanation of -d.

Guessing that it was debug I went looking at the source and saw that
there was yet another flag unmentioned, to wit, -v.

This was following a complete cvs up yesterday followed by all the
steps upto and including make release.

Perhaps a maestro manpager would like to explain the missing options?

You wouldn't want a diff from me for <that> task 8-)

*** NOTE *** Please DO NOT CC me. I <am> subscribed to the list.
Mail to the sender address that does not originate at the list server is tarpitted. The reply-to: address is
provided for those who feel compelled to reply off list. Thankyou.

Rod/
---
This life is not the real thing.
It is not even in Beta.
If it was, then OpenBSD would already have a man page for it.

Stuart Henderson | 1 Feb 03:38 2012

Re: patch - RFC 4638 increased MTU support for pppoe(8) w/ ppp(8)

On 2012/01/31 23:53, Ben Gould wrote:
> I couldn't get the pppoe server to work on -current, rebuilt -current
> yesterday and it now works - user error.
> 
> The following works in all the combinations 5.0 client/server
> userland and with -current client/server and with -current pppoe(4).
> 
> -- ben

fixed diff (linewrapping and some spaces->tabs and 80-column
formatting in the diff itself), otherwise untested so far.

Index: client.c
===================================================================
RCS file: /cvs/src/usr.sbin/pppoe/client.c,v
retrieving revision 1.24
diff -u -p -r1.24 client.c
--- client.c	5 Nov 2011 09:20:36 -0000	1.24
+++ client.c	1 Feb 2012 02:34:04 -0000
 <at>  <at>  -50,6 +50,7  <at>  <at> 

 u_int32_t client_cookie;
 u_int16_t client_sessionid;
+u_int16_t client_mtu;
 int pppfd, client_state;

 static int getpackets(int, u_int8_t *, u_int8_t *, struct ether_addr *,
 <at>  <at>  -80,6 +81,7  <at>  <at>  client_mode(int bfd, u_int8_t *sysname, 
 	pppfd = -1;
 	client_sessionid = 0xffff;
(Continue reading)

Stuart Henderson | 1 Feb 14:47 2012

db_read_bytes uvm_fault

Machine needs an update anyway, but does anyone know offhand what
this might be?

OpenBSD 4.9-current (GENERIC) #497: Tue Mar 22 13:50:20 MDT 2011
    deraadt <at> amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC

uvm_fault(0xffffffff80d1d0e0, 0x0, 0, 4) -> e
kernel: page fault trap, code=0
Stopped at      0:uvm_fault(0xffffffff80d1d0e0, 0x0, 0, 1) -> e
      kernel: page fault trap, code=0
Stopped at      db_read_bytes+0x20:     movzbl  0(%rdi,%rcx,1),%eax
ddb> [-- MARK -- Wed Feb  1 07:00:00 2012]
[-- sthen <at> localhost attached -- Wed Feb  1 07:21:51 2012]

ddb> tr
db_read_bytes() at db_read_bytes+0x20
db_get_value() at db_get_value+0x34
db_disasm() at db_disasm+0x42
db_trap() at db_trap+0x79
kdb_trap() at kdb_trap+0xc3
trap() at trap+0x163
--- trap (number 6) ---
(null)() at 0
Xintr_ioapic_level16() at Xintr_ioapic_level16+0xe1
--- interrupt ---
Bad frame pointer: 0xffff800021cbff10
end trace frame: 0xffff800021cbff10, count: -8
cpu_idle_cycle+0x13:
ddb> ps
   PID   PPID   PGRP    UID  S       FLAGS  WAIT          COMMAND
(Continue reading)

Stuart Henderson | 1 Feb 03:23 2012

zlib 1.2.6

*obviously* this is not for now (it hasn't even gone through a mkr
yet and I haven't touched the manpage). but I was interested to see
what the speed difference was like (answer: small improvement only)
and since I'd done it anyway I might as well post it to save anyone
else the trouble of porting our changes across.


Index: ChangeLog
===================================================================
RCS file: /cvs/src/lib/libz/ChangeLog,v
retrieving revision 1.4
diff -u -p -r1.4 ChangeLog
--- ChangeLog	20 Jul 2005 15:56:40 -0000	1.4
+++ ChangeLog	1 Feb 2012 02:08:56 -0000
 <at>  <at>  -1,6 +1,498  <at>  <at> 
 
                 ChangeLog file for zlib
 
+Changes in 1.2.6 (29 Jan 2012)
+- Update the Pascal interface in contrib/pascal
+- Fix function numbers for gzgetc_ in zlibvc.def files
+- Fix configure.ac for contrib/minizip [Schiffer]
+- Fix large-entry detection in minizip on 64-bit systems [Schiffer]
+- Have ./configure use the compiler return code for error indication
+- Fix CMakeLists.txt for cross compilation [McClure]
+- Fix contrib/minizip/zip.c for 64-bit architectures [Dalsnes]
+- Fix compilation of contrib/minizip on FreeBSD [Marquez]
+- Correct suggested usages in win32/Makefile.msc [Shachar, Horvath]
+- Include io.h for Turbo C / Borland C on all platforms [Truta]
+- Make version explicit in contrib/minizip/configure.ac [Bosmans]
(Continue reading)

Steffen Daode Nurpmeso | 1 Feb 16:28 2012

Re: Keycode print mode (-r) for wsconsctl(8)

For one: Tobias Stoeckmann already stated more yesterday,
including that exit(3) in a signal handler is a bad thing.
(It surely should have been _exit(2).)

Version 3 (1) doesn't trash errno no more, (2) is hopefully less
messy and (3) does no longer introduce a new file, so also more
easyness for cvs(1).
It fixes a compiler warning in tab_by_name().

Beside that: :c
Thank you very much.

--steffen

Index: src/sbin/wsconsctl/wsconsctl.8
===================================================================
RCS file: /cvs/src/sbin/wsconsctl/wsconsctl.8,v
retrieving revision 1.23
diff -a -p -u -r1.23 wsconsctl.8
--- wsconsctl.8	4 Aug 2008 07:32:51 -0000	1.23
+++ wsconsctl.8	1 Feb 2012 14:41:11 -0000
 <at>  <at>  -49,6 +49,8  <at>  <at> 
 .Op Fl n
 .Op Fl f Ar file
 .Ar name Ns += Ns Ar value ...
+.Nm wsconsctl
+.Fl r
 .Sh DESCRIPTION
 The
 .Nm
(Continue reading)

Jason McIntyre | 1 Feb 16:42 2012
Picon

Re: login_yubikey manpage missing stuff

On Wed, Feb 01, 2012 at 11:07:18AM +1100, Rod Whitworth wrote:
> Curiosity made me look at login_yubikey and so I looked at its manpage.
> 
> The synopsis says:
> login_yubikey [-d] [-s service] user [class]
> 
> Nowhere was an explanation of -d.
> 
> Guessing that it was debug I went looking at the source and saw that
> there was yet another flag unmentioned, to wit, -v.
> 
> This was following a complete cvs up yesterday followed by all the
> steps upto and including make release.
> 
> Perhaps a maestro manpager would like to explain the missing options?
> 

dhill has a diff. just be patient ;)
jmc

Miod Vallat | 1 Feb 18:12 2012
Picon

Re: db_read_bytes uvm_fault

> Machine needs an update anyway, but does anyone know offhand what
> this might be?

Dereference of a NULL (or invalid) function pointer, coupled with the
lack of smarts of the ddb code. (part of my ddb todolist somewhere)

Miod

Mike Belopuhov | 1 Feb 18:18 2012
Picon

Re: db_read_bytes uvm_fault

On Wed, Feb 01, 2012 at 17:12 +0000, Miod Vallat wrote:
> > Machine needs an update anyway, but does anyone know offhand what
> > this might be?
> 
> Dereference of a NULL (or invalid) function pointer, coupled with the
> lack of smarts of the ddb code. (part of my ddb todolist somewhere)
> 
> Miod
> 

here's a diff i keep applying to my local trees and forgeting to ask
an ok for.

db_get_value is used by the 'trace' command so it's not nice when it
faults itself leading to another 'trace' and another fault and so on.

ok?

Index: sys/ddb/db_access.c
===================================================================
RCS file: /home/cvs/src/sys/ddb/db_access.c,v
retrieving revision 1.10
diff -u -p -r1.10 db_access.c
--- sys/ddb/db_access.c	15 Mar 2007 17:10:22 -0000	1.10
+++ sys/ddb/db_access.c	30 Sep 2011 08:09:15 -0000
 <at>  <at>  -51,6 +51,9  <at>  <at>  db_get_value(db_addr_t addr, size_t size
 	db_expr_t value, extend;
 	int i;

+	if (addr == 0)
(Continue reading)

Rod Whitworth | 1 Feb 21:18 2012

Re: login_yubikey manpage missing stuff

On Wed, 1 Feb 2012 15:43:57 +0001, Jason McIntyre wrote:

>dhill has a diff. just be patient ;)
>jmc

Thanks.

*** NOTE *** Please DO NOT CC me. I <am> subscribed to the list.
Mail to the sender address that does not originate at the list server is tarpitted. The reply-to: address is
provided for those who feel compelled to reply off list. Thankyou.

Rod/
---
This life is not the real thing.
It is not even in Beta.
If it was, then OpenBSD would already have a man page for it.

Laurence Tratt | 2 Feb 13:13 2012
Picon

readdir man page

To my surprise (and a couple of hours debugging later), readdir does not
necessarily set errno even if NULL is returned. This is rather confusing
because if NULL is returned two things might have happened:

  1) The end of the directory has been reached in a normal fashion; errno
     won't have been touched in any way.

  2) One of the errors associated with getdirentries might have occurred,
     in which case errno will have been set to a specific value.

So any user who writes:

  if (readdir(dirp) == NULL) {
      if (errno == ...)
         ...
  }

without setting errno to 0 beforehand will get a nasty shock from time to
time (in my case, I was finding EAGAIN was leaking through from a failed
flock call).

The current man page doesn't claim that errno is always set but one might
reasonably assume that it is: certainly, it seems a horribly easy way of
introducing bugs (at least for idiots such as myself). Similar issues (e.g.
with strtoul) are documented, so it seems like a good idea to at least hint
to users that this could happen. The following man page diff attempts to
address this, although there may well be cleaner ways of achieving the same
end.

Laurie
(Continue reading)


Gmane