headers
Ted Unangst | 1 Dec 2010 01:37
Picon

more hotplug events

there are a lot of usb devices that attach more than 16 things at once, 
notably the "endless stream of nonsense uhid" type gadgetry.  increase the 
limit.

this will use more kernel memory of course (only a tiny bit really, but 
whatever) so it's allocated at first open.  if you don't use hotplug, you 
don't waste memory on it.  we could in theory make the buffer quite a bit 
larger even now.

Index: hotplug.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/hotplug.c,v
retrieving revision 1.9
diff -u -r1.9 hotplug.c
--- hotplug.c	9 Nov 2009 17:53:39 -0000	1.9
+++ hotplug.c	30 Nov 2010 21:44:43 -0000
 <at>  <at>  -26,13 +26,14  <at>  <at> 
 #include <sys/fcntl.h>
 #include <sys/hotplug.h>
 #include <sys/ioctl.h>
+#include <sys/malloc.h>
 #include <sys/poll.h>
 #include <sys/vnode.h>

-#define HOTPLUG_MAXEVENTS	16
+#define HOTPLUG_MAXEVENTS	64

 static int opened;
-static struct hotplug_event evqueue[HOTPLUG_MAXEVENTS];
+static struct hotplug_event *evqueue;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Marco Peereboom | 1 Dec 2010 08:44
Picon
Favicon

Re: allow bioctl to read passphrase from stdin

I changed my mind.  I did talk with jsing and deraadt about the bioctl
follow on but haven't gotten to it yet.

On Tue, Nov 30, 2010 at 11:20:53AM -0500, Ted Unangst wrote:
> err, the last time this came up you said you would do it right... :)
> 
> http://marc.info/?l=openbsd-misc&m=125613898224309&w=2
> 
> On Tue, Nov 30, 2010 at 5:16 AM, Marco Peereboom <slash <at> peereboom.us> wrote:
> > I like this.
> >
> > On Mon, Nov 29, 2010 at 02:22:35PM -0800, Chris Kuethe wrote:
> >> Currently bioctl invokes readpassphrase(3) with RPP_REQUIRE_TTY, which
> >> means that there must be a controlling tty to read the password from.
> >> This diff adds an option (-s) to force bioctl to read the passphrase
> >> from stdin. Without this option existing behavior is maintained.
> >>
> >> Index: bioctl.8
> >> ===================================================================
> >> RCS file: /cvs/src/sbin/bioctl/bioctl.8,v
> >> retrieving revision 1.82
> >> diff -u -p -r1.82 bioctl.8
> >> --- bioctl.8  20 Nov 2010 17:46:24 -0000      1.82
> >> +++ bioctl.8  29 Nov 2010 22:17:03 -0000
> >>  <at>  <at>  -43,7 +43,7  <at>  <at> 
> >>  .Pp
> >>  .Nm bioctl
> >>  .Bk -words
> >> -.Op Fl dhiPqv
> >> +.Op Fl dhiPqsv
(Continue reading)

Permalink | Reply | 0 comments |
headers
Marco Peereboom | 1 Dec 2010 08:46
Picon
Favicon

Re: more hotplug events

yes please.  I see all kinds of overruns when resuming currently.

On Tue, Nov 30, 2010 at 07:37:06PM -0500, Ted Unangst wrote:
> there are a lot of usb devices that attach more than 16 things at once, 
> notably the "endless stream of nonsense uhid" type gadgetry.  increase the 
> limit.
> 
> this will use more kernel memory of course (only a tiny bit really, but 
> whatever) so it's allocated at first open.  if you don't use hotplug, you 
> don't waste memory on it.  we could in theory make the buffer quite a bit 
> larger even now.
> 
> Index: hotplug.c
> ===================================================================
> RCS file: /home/tedu/cvs/src/sys/dev/hotplug.c,v
> retrieving revision 1.9
> diff -u -r1.9 hotplug.c
> --- hotplug.c	9 Nov 2009 17:53:39 -0000	1.9
> +++ hotplug.c	30 Nov 2010 21:44:43 -0000
>  <at>  <at>  -26,13 +26,14  <at>  <at> 
>  #include <sys/fcntl.h>
>  #include <sys/hotplug.h>
>  #include <sys/ioctl.h>
> +#include <sys/malloc.h>
>  #include <sys/poll.h>
>  #include <sys/vnode.h>
>  
> -#define HOTPLUG_MAXEVENTS	16
> +#define HOTPLUG_MAXEVENTS	64
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mark Kettenis | 1 Dec 2010 11:33
Picon
Picon
Favicon

Re: update pms driver

> Date: Tue, 30 Nov 2010 21:33:41 +0500
> From: Alexandr Shadchin <alexandr.shadchin <at> gmail.com>
> 
> On Mon, Nov 29, 2010 at 10:08:22PM +0000, Nicholas Marriott wrote:
> > 
> > Well, I don't use it so I don't have strong feelings about it, but it
> > does work for PS/2 mice and it seems that it would be useful for anyone
> > using wsmoused (although there probably aren't many people).
> > 
> > Would it be so hard to leave it, and if it is really not needed remove
> > it entirely as a separate change?
> > 
> > Otherwise aside from the char -> signed char change I mentioned the diff
> > is fine with me.
> > 
> 
> 1) fix char -> signed char
> 2) Returned WSMOUSEIO_SRES
> 
> -- 
> Alexandr Shadchin
> 
> Index: pms.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pckbc/pms.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 pms.c
> --- pms.c	15 Nov 2010 20:25:31 -0000	1.14
> +++ pms.c	30 Nov 2010 16:26:20 -0000
>  <at>  <at>  -52,14 +66,38  <at>  <at>  struct pms_softc {		/* driver status inf
(Continue reading)

Permalink | Reply | 1 comment |
headers
Alexandr Shadchin | 1 Dec 2010 13:14
Picon

Re: update pms driver

On Wed, Dec 1, 2010 at 3:33 PM, Mark Kettenis <mark.kettenis <at> xs4all.nl>
wrote:
>> Date: Tue, 30 Nov 2010 21:33:41 +0500
>> From: Alexandr Shadchin <alexandr.shadchin <at> gmail.com>
>>
>> On Mon, Nov 29, 2010 at 10:08:22PM +0000, Nicholas Marriott wrote:
>> >
>> > Well, I don't use it so I don't have strong feelings about it, but it
>> > does work for PS/2 mice and it seems that it would be useful for anyone
>> > using wsmoused (although there probably aren't many people).
>> >
>> > Would it be so hard to leave it, and if it is really not needed remove
>> > it entirely as a separate change?
>> >
>> > Otherwise aside from the char -> signed char change I mentioned the diff
>> > is fine with me.
>> >
>>
>> 1) fix char -> signed char
>> 2) Returned WSMOUSEIO_SRES
>>
>> --
>> Alexandr Shadchin
>>
>> Index: pms.c
>> ===================================================================
>> RCS file: /cvs/src/sys/dev/pckbc/pms.c,v
>> retrieving revision 1.14
>> diff -u -p -r1.14 pms.c
>> --- pms.c B  B  15 Nov 2010 20:25:31 -0000 B  B  B 1.14
(Continue reading)

Permalink | Reply | 0 comments |

Gmane