headers
Niels Reedijk | 30 Nov 00:27
Picon

bin cleanup

Hi,

I was stuck (once again) with the USB stack, so I decided to go and 
fool around somewhat
with arch (alternative to cvs www.gnu.org/software/gnu-arch). I tried 
fixing the warnings that would be spit out when compiling /current/src/
apps/bin/, and here's the first part of the
fixes:

patch-1
    Fix warning df.cpp
patch-2
    Fix warning in roster.cpp
patch-3
    Fix warning in clipboard.cpp
patch-4
    Fix warning in shutdown.cpp (trivial)
patch-5
    Fix warnings in chop.c (trivial)
patch-6
    Trivial warning fix in eject.c
patch-7
    Trivial warning fix in hd.c
patch-8
    Trivial warning fixes in listarea.c 

They're all trivial fixes anyway. The diff is included below. May I 
merge (and commit) the changes to cvs? If not, please let me know which 
ones can be committed. Thanks a lot.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Niels Reedijk | 30 Nov 18:47
Picon

bin cleanup (#2)

Here's the complete /bin cleanup.

I've cleaned up most of the warnings except some in the gnu utilities, 
and some I haven't yet
understood. For completeness I included the complete changelog of the 
bin-applications--fixes tree, and a complete diff. All the changes are 
trivial and shouldn't (and probably couldn't) effect the working of the 
programs. Can someone (sikosis) give me the green light?

(I haven't found out how to do the diffs with arch yet, so I'm just 
sticking to the cvs diff now)

Niels

patch-1
    Fix warning
patch-2
    Fix warning in roster.cpp
patch-3
    Fix warning in clipboard.cpp
patch-4
    Fix warning in shutdown.cpp (trivial)
patch-5
    Fix warnings in chop.c (trivial)
patch-6
    Trivial warning fix in eject.c
patch-7
    Trivial warning fix in hd.c
patch-8
    Trivial warning fixes in listarea.c
(Continue reading)

Permalink | Reply | 0 comments |
headers
Niels Reedijk | 30 Nov 22:17
Picon

Codycam Warning fixes

Hi,

I've fixed a whole number of warnings.

patch-1
    Fix numerous warnings in codycam

Can I merge these with the main cvs repository?

Niels

--- orig/CodyCam.cpp
+++ mod/CodyCam.cpp
@@ -93,9 +93,6 @@
 CodyCam::ReadyToRun()
 {
        /* create the window for the app */
-       uint32 x = WINDOW_SIZE_X;
-       uint32 y = WINDOW_SIZE_Y;
-
        fWindow = new VideoWindow(BRect(28, 28, 28 + (WINDOW_SIZE_X-1), 
28 + (WINDOW_SIZE_Y-1)),
                                                                (const 
char *)"CodyCam", B_TITLED_WINDOW, B_NOT_RESIZABLE | B_NOT_ZOOMABLE, &
fPort);

@@ -127,8 +124,6 @@
 void
 CodyCam::MessageReceived(BMessage *message)
 {
(Continue reading)

Permalink | Reply | 2 comments |
headers
Sikosis | 30 Nov 23:47
Favicon
Gravatar

Re: Codycam Warning fixes

Do you have write access ?

Cheers

Sikosis
OBOS Pref Team Leader
http://obos.gravity24hr.com/
http://openbeos.org/

Quoting Niels Reedijk <n.reedijk@...>:

> Hi,
> 
> I've fixed a whole number of warnings.
> 
> patch-1
>     Fix numerous warnings in codycam
> 
> Can I merge these with the main cvs repository?
> 
> Niels
> 
> 
> --- orig/CodyCam.cpp
> +++ mod/CodyCam.cpp
> @@ -93,9 +93,6 @@
>  CodyCam::ReadyToRun()
>  {
>         /* create the window for the app */
> -       uint32 x = WINDOW_SIZE_X;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Niels Reedijk | 1 Dec 06:13
Picon

Re: Codycam Warning fixes

Yes, do I get the green light?

Niels Sascha Reedijk

> -----Oorspronkelijk bericht-----
> Van: openbeos-preferences-bounce@... [mailto:openbeos-
> preferences-bounce@...] Namens Sikosis
> Verzonden: zondag 30 november 2003 23:48
> Aan: openbeos-preferences@...
> Onderwerp: [openbeos-preferences] Re: Codycam Warning fixes
> 
> Do you have write access ?
> 
> Cheers
> 
> Sikosis
> OBOS Pref Team Leader
> http://obos.gravity24hr.com/
> http://openbeos.org/
> 
> 
> Quoting Niels Reedijk <n.reedijk@...>:
> 
> > Hi,
> >
> > I've fixed a whole number of warnings.
> >
> > patch-1
> >     Fix numerous warnings in codycam
> >
(Continue reading)

Permalink | Reply | 0 comments |

Gmane