1 Mar 2010 05:46
Re: p9100 bug?
Michael <macallan <at> netbsd.org>
2010-03-01 04:46:17 GMT
2010-03-01 04:46:17 GMT
Hello, On Feb 28, 2010, at 1:28 PM, der Mouse wrote: > sys/dev/sbus/p9100.c (1.34) includes a macro PNOZZ_LATCH which is used > in a handful of places. However, this is dead code; sc- > >sc_last_offset > is initialized (in various places) to 0xffffffff, and thus will never > match anything &0xffffff80, so PNOZZ_LATCH will never do anything but > make that (failing) comparison. > Is this dead code (and thus removal-worthy), or should the assignment > to sc_last_offset in PNOZZ_LATCH be outside the if rather than inside? No, but the == should be an !=. have fun Michael
. I try finding it in newsgroups.
Until then I thank everybody for his/her thoughts.
Frank
RSS Feed