Garrett D'Amore | 13 Sep 16:59 2006

todr changes for sbmips

These are pretty trivial.  Here are the diffs. 

sbmips timecounters are harder, due to SMP considerations, so I have not
attempted that.

--

-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191

Attachment (sbmips.diff): text/x-patch, 5709 bytes
Garrett D'Amore | 13 Sep 18:15 2006

updated diff (again)

This diff is the same, except I've converted the rtc functions to use
the clock_ymdhms variants of the TODR entry points, saving some more
redundant code and inheriting some additional "checks."

(Also, the fewer functions using the old volatile struct timval *, the
better, as I intend to change the signature of that function soon, to
use either struct bintime or struct timespec_t.)

    -- Garrett

Attachment (sbmips.diff): text/x-patch, 11 KiB
Simon Burge | 14 Sep 00:58 2006
Picon

Re: updated diff (again)

First traffic on port-sbmips I can remember in a long time!

Garrett D'Amore wrote:

> This diff is the same, except I've converted the rtc functions to use
> the clock_ymdhms variants of the TODR entry points, saving some more
> redundant code and inheriting some additional "checks."

The patch seems to work.  Setting the date to an incorrect time, and
rebooting back to the same incorrect offset worked.  Setting back to
"normal" with ntpdate and rebooting again also worked.  What other sort
of tests should be done?

> (Also, the fewer functions using the old volatile struct timval *, the
> better, as I intend to change the signature of that function soon, to
> use either struct bintime or struct timespec_t.)

Please discuss this on tech-kern when the time comes.  I'm not sure if
we should be using timespecs or bintime as the "base" system time.  A
long time ago there was talk about switching to timespecs, but that
predated FreeBSD's bintime and timecounters.

Cheers,
Simon.

Garrett D'Amore | 14 Sep 01:23 2006

Re: updated diff (again)

Simon Burge wrote:
> First traffic on port-sbmips I can remember in a long time!
>
> Garrett D'Amore wrote:
>
>   
>> This diff is the same, except I've converted the rtc functions to use
>> the clock_ymdhms variants of the TODR entry points, saving some more
>> redundant code and inheriting some additional "checks."
>>     
>
> The patch seems to work.  Setting the date to an incorrect time, and
> rebooting back to the same incorrect offset worked.  Setting back to
> "normal" with ntpdate and rebooting again also worked.  What other sort
> of tests should be done?
>   

Sounds good.  Can I commit it then?
>   
>> (Also, the fewer functions using the old volatile struct timval *, the
>> better, as I intend to change the signature of that function soon, to
>> use either struct bintime or struct timespec_t.)
>>     
>
> Please discuss this on tech-kern when the time comes.  I'm not sure if
> we should be using timespecs or bintime as the "base" system time.  A
> long time ago there was talk about switching to timespecs, but that
> predated FreeBSD's bintime and timecounters.
>   

(Continue reading)


Gmane