headers
Ben Harris | 9 Feb 2004 18:37
Picon

machdep.c: #if NPC > 0, but not #include "pc.h"

While trying to clean up pckbc(4) and friends, I noticed that both
arch/evbppc/ev64260/machdep.c and arch/sandpoint/sandpoint/machdep.c
contain the following function:

int
pckbc_machdep_cnattach(pckbc_tag_t kbctag, pckbc_slot_t kbcslot)
{
#if (NPC > 0)
	return (pcconskbd_cnattach(kbctag, kbcslot));
#else
	return (ENXIO);
#endif
}

Neither file, though, #includes "pc.h", so I don't think the NPC will ever
be defined, so pcconskbd_cnattach() will never be called and
pckbc_machdep_cnattach() will always return ENXIO.  Am I right?  Is it OK
for me to simplify pckbc_machdep_cnattach() appropriately?

--

-- 
Ben Harris                                                   <bjh21 <at> NetBSD.org>
Portmaster, NetBSD/acorn26           <URL:http://www.NetBSD.org/Ports/acorn26/>
Permalink | Reply | 6 comments |
headers
Allen Briggs | 9 Feb 2004 19:23

Re: machdep.c: #if NPC > 0, but not #include "pc.h"

On Mon, Feb 09, 2004 at 05:37:30PM +0000, Ben Harris wrote:
> Neither file, though, #includes "pc.h", so I don't think the NPC will ever
> be defined, so pcconskbd_cnattach() will never be called and

Heh.  At least sandpoint hasn't run with a PC keyboard console (at least
not for me), so I see no reason to doubt your analysis.

> Is it OK for me to simplify pckbc_machdep_cnattach() appropriately?

What do you propose for simplification?

-allen

--

-- 
 Allen Briggs                     briggs <at> wasabisystems.com
 Wasabi Systems, Inc.             http://www.wasabisystems.com/
Permalink | Reply | 4 comments |
headers
Ben Harris | 9 Feb 2004 19:33
Picon

Re: machdep.c: #if NPC > 0, but not #include "pc.h"

On Mon, 9 Feb 2004, Allen Briggs wrote:

> On Mon, Feb 09, 2004 at 05:37:30PM +0000, Ben Harris wrote:
> > Neither file, though, #includes "pc.h", so I don't think the NPC will ever
> > be defined, so pcconskbd_cnattach() will never be called and
>
> Heh.  At least sandpoint hasn't run with a PC keyboard console (at least
> not for me), so I see no reason to doubt your analysis.
>
> > Is it OK for me to simplify pckbc_machdep_cnattach() appropriately?
>
> What do you propose for simplification?

To blow away the #ifdef so it always returns ENXIO initially.  My
longer-term plan is to add "#define __HAVE_PCKBC_MACHDEP_CNATTACH" to the
few ports that have interesting implementations of
pckbc_machdep_cnattach(), and to remove the function on all the rest
(which would then include sandpoint).  Oh, and probably to rename it to
pckbport_machdep_cnattach() somewhere along the way.

--

-- 
Ben Harris                                                   <bjh21 <at> NetBSD.org>
Portmaster, NetBSD/acorn26           <URL:http://www.NetBSD.org/Ports/acorn26/>
Permalink | Reply | 2 comments |
headers
Allen Briggs | 9 Feb 2004 19:42

Re: machdep.c: #if NPC > 0, but not #include "pc.h"

On Mon, Feb 09, 2004 at 06:33:39PM +0000, Ben Harris wrote:
> > > Is it OK for me to simplify pckbc_machdep_cnattach() appropriately?
> >
> > What do you propose for simplification?
> 
> To blow away the #ifdef so it always returns ENXIO initially.  My
> longer-term plan is to add "#define __HAVE_PCKBC_MACHDEP_CNATTACH" to the
> few ports that have interesting implementations of
> pckbc_machdep_cnattach(), and to remove the function on all the rest
> (which would then include sandpoint).  Oh, and probably to rename it to
> pckbport_machdep_cnattach() somewhere along the way.

That sounds good to me.  Go for it.

-allen

--

-- 
 Allen Briggs                     briggs <at> wasabisystems.com
 Wasabi Systems, Inc.             http://www.wasabisystems.com/
Permalink | Reply | 0 comments |
headers
Kate Feng | 10 Feb 2004 23:44
Favicon

Re: GT64260 EVB driver ?

Matt Thomas wrote:

> On Thursday, October 2, 2003, at 10:07 AM, Kate Feng wrote:
>
> > Hello,
> >
> > I am looking for BSD device drivesr written for the Marvell GT64260B
> > system
> > controller.  I found some traces talking about support for the Marvell
> > GT64260
> > Evaluation Board.  However, I  could not find the software.  I am new
> > to
> >
> > netBSD.....Sorry.
>
> Support for it is in NetBSD-current:
>
> sys/arch/evbppc/ev64260
> sys/arch/powerpc/marvell
> sys/dev/marvell
> --

Are those codes fully tested , especially for the 10/100 M
ethernet on the GT64260 ?
One particular file I looked at is the sys/dev/marvell/if_gfe.c.

in the   gfe_hash_entry_op(),

he = ((uint64_t) eaddr[5] << 43) |
      ((uint64_t) eaddr[4] << 35) |
(Continue reading)

Permalink | Reply | 2 comments |
headers
Matt Thomas | 11 Feb 2004 00:21

Re: GT64260 EVB driver ?

At 02:44 PM 2/10/2004, Kate Feng wrote:
>Matt Thomas wrote:
>
> > On Thursday, October 2, 2003, at 10:07 AM, Kate Feng wrote:
> >
> > > Hello,
> > >
> > > I am looking for BSD device drivesr written for the Marvell GT64260B
> > > system
> > > controller.  I found some traces talking about support for the Marvell
> > > GT64260
> > > Evaluation Board.  However, I  could not find the software.  I am new
> > > to
> > >
> > > netBSD.....Sorry.
> >
> > Support for it is in NetBSD-current:
> >
> > sys/arch/evbppc/ev64260
> > sys/arch/powerpc/marvell
> > sys/dev/marvell
> > --
>
>Are those codes fully tested , especially for the 10/100 M
>ethernet on the GT64260 ?
>One particular file I looked at is the sys/dev/marvell/if_gfe.c.

The datasheet is wrong.  It took me a week of analysis to figure
out the exact algorithm.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tru Huynh | 11 Feb 2004 10:27
Picon
Picon
Favicon

NetBSD-current 2004/02/11 crossbuild evbppc/EXPLORA451 from Red Hat linux 7.3/i386 failed

Hello,

I am trying to play with NetBSD on an NCD explora 451.

background:
Cross build from a RedHat 7.3 linux/i386 with today cvs:

The tools build without problems with 
 ./build.sh -u -m evbppc  \
 -T /home/NetBSD-current/cross/evbppc \
 -D /home/NetBSD-current/evbppc \
 -M /home/NetBSD-current/obj/evbppc \
 tools

The release build fails when I tried with the following script.

#!/bin/sh
TOP=/home/tru/cvs/NetBSD-current
cd $TOP/src
 ./build.sh \
 -m evbppc -u -U \
 -T /home/NetBSD-current/cross/evbppc \
 -D /home/NetBSD-current/evbppc \
 -M /home/NetBSD-current/obj/evbppc \
 kernel=/home/tru/cvs/NetBSD-current/EXPLORA451 \
 release

The error message:
<...>
dependall ===> libfrtbegin
(Continue reading)

Permalink | Reply | 4 comments |
headers
KIYOHARA Takashi | 13 Feb 2004 17:46
Picon

Re: A security issue is in rtc


From: Shigeyuki Fukushima <shige <at> NetBSD.org>
Date: Mon, 26 Jan 2004 10:57:36 +0900

> I'll fix this.
> Thank you for your PR.

Thanks.
but, I'm Sorry. My explanation was difficult. The following patches have
not had you commit.

> > see.
> >   kern/24231

--
kiyohara
Permalink | Reply | 0 comments |
headers
Kate Feng | 13 Feb 2004 20:57
Favicon

Re: GT64260 EVB driver ?

Matt Thomas wrote:

> At 04:17 PM 2/10/2004, you wrote:
> >Matt Thomas wrote:
> >
> > > At 02:44 PM 2/10/2004, Kate Feng wrote:
> > > >Matt Thomas wrote:
> > > >
> > > > > On Thursday, October 2, 2003, at 10:07 AM, Kate Feng wrote:
> > > > >
> > > > > > Hello,
> > > > > >
> > > > > > I am looking for BSD device drivesr written for the Marvell GT64260B
> > > > > > system
> > > > > > controller.  I found some traces talking about support for the
> > Marvell
> > > > > > GT64260
> > > > > > Evaluation Board.  However, I  could not find the software.  I am new
> > > > > > to
> > > > > >
> > > > > > netBSD.....Sorry.
> > > > >
> > > > > Support for it is in NetBSD-current:
> > > > >
> > > > > sys/arch/evbppc/ev64260
> > > > > sys/arch/powerpc/marvell
> > > > > sys/dev/marvell
> > > > > --
> > > >
> > > >Are those codes fully tested , especially for the 10/100 M
(Continue reading)

Permalink | Reply | 2 comments |
headers
Jochen Kunz | 14 Feb 2004 17:30
Picon

Re: GT64260 EVB driver ?

On Fri, 13 Feb 2004 14:57:46 -0500
Kate Feng <feng1 <at> bnl.gov> wrote:

> Again, I  had no previous experience with netBSD.   Why  are'nt
> there any  makefile associated with the files in the sys/dev/marvell
> directory which I got from
> tftp://ftp.NetBSD.org/pub/NetBSD/NetBSD-current/   ?   Is this
> how netBSD archive its source codes ?  
Yes, no Makefile. Read config(9) to get knowledge about device
definition files. Also: Have a look at the kernel section at
http://www.netbsd.org/Documentation/ 

> I saw the file  if_gfe.c was updated  last Aug  5 .  Do you
> know what was changed ? 
Have a look at http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/marvell/
--

-- 

tschüß,
       Jochen

Homepage: http://www.unixag-kl.fh-kl.de/~jkunz/
Permalink | Reply | 0 comments |

Gmane