Discussion of issues relevant to all m68k-based NetBSD ports

Joerg Sonnenberger | 3 Jan 2008 01:32

Picon

Re: mvme68k timecounters.... untested

On Sun, Sep 17, 2006 at 05:16:56PM +0900, Izumi Tsutsui wrote:
> Hmm. pcc_timer_hz2lin() macro should use 0x10000 rather than 65536?
> Anyway, it isn't so important on this change so both are ok for me.

Given that mvme68k is one of the 9 remaining ports without timecounter
support, could you please commit this code? It prefered it is done by
someone who actually knows the hardware.

Joerg

Izumi Tsutsui | 4 Jan 2008 12:17

Picon

Re: mvme68k timecounters.... untested

joerg <at> NetBSD.org wrote:

> On Sun, Sep 17, 2006 at 05:16:56PM +0900, Izumi Tsutsui wrote:
> > Hmm. pcc_timer_hz2lin() macro should use 0x10000 rather than 65536?
> > Anyway, it isn't so important on this change so both are ok for me.
> 
> Given that mvme68k is one of the 9 remaining ports without timecounter
> support, could you please commit this code? It prefered it is done by
> someone who actually knows the hardware.

- we should ask Steve (scw <at> ) first.
- IIRC some sources for old microtime(9) are shared with mvmeppc port
  and in sys/dev/mvme so we should handle it too.

Anyway I'll take a look after I'm back to my home.
---
Izumi Tsutsui

Izumi Tsutsui | 4 Jan 2008 14:54

Picon

Re: mvme68k timecounters.... untested

I wrote:

> - we should ask Steve (scw <at> ) first.
> - IIRC some sources for old microtime(9) are shared with mvmeppc port
>   and in sys/dev/mvme so we should handle it too.
> 
> Anyway I'll take a look after I'm back to my home.

I'm still in my hometown, but I played with the sources via ssh:
---

Index: arch/mvme68k/dev/clock_pcc.c
===================================================================
RCS file: /cvsroot/src/sys/arch/mvme68k/dev/clock_pcc.c,v
retrieving revision 1.16
diff -u -r1.16 clock_pcc.c
--- arch/mvme68k/dev/clock_pcc.c	11 Dec 2005 12:18:17 -0000	1.16
+++ arch/mvme68k/dev/clock_pcc.c	4 Jan 2008 13:46:42 -0000
 <at>  <at>  -48,6 +48,7  <at>  <at> 
 #include <sys/kernel.h>
 #include <sys/systm.h>
 #include <sys/device.h>
+#include <sys/timetc.h>

 #include <machine/psl.h>
 #include <machine/bus.h>
 <at>  <at>  -64,6 +65,7  <at>  <at> 
 	struct device sc_dev;
 	struct clock_attach_args sc_clock_args;
 	u_char sc_clock_lvl;

(Continue reading)

Joerg Sonnenberger | 4 Jan 2008 17:53

Picon

Re: mvme68k timecounters.... untested

On Fri, Jan 04, 2008 at 10:54:13PM +0900, Izumi Tsutsui wrote:
>  <at>  <at>  -75,10 +77,12  <at>  <at> 
>  static int clock_pcc_profintr __P((void *));
>  static int clock_pcc_statintr __P((void *));
>  static void clock_pcc_initclocks __P((void *, int, int));
> -static long clock_pcc_microtime __P((void *));
>  static void clock_pcc_shutdown __P((void *));
> +static uint32_t clock_pcc_getcount(struct timecounter *);

static u_int clock_pcc_getcount(struct timecounter *);
to match the prototype.

>  
>  static struct clock_pcc_softc *clock_pcc_sc;
> +static uint32_t clock_pcc_count;
> +static uint16_t clock_pcc_reload;
>  
>  /* ARGSUSED */
>  int
>  <at>  <at>  -75,10 +77,11  <at>  <at> 
>  static int clock_pcctwo_profintr(void *);
>  static int clock_pcctwo_statintr(void *);
>  static void clock_pcctwo_initclocks(void *, int, int);
> -static long clock_pcctwo_microtime(void *);
>  static void clock_pcctwo_shutdown(void *);
> +static uint32_t clock_pcctwo_getcount(struct timecounter *);

Same here.

>

(Continue reading)

Steve Woodford | 4 Jan 2008 18:03

Picon

Re: mvme68k timecounters.... untested

On Friday 04 January 2008 16:53:47 Joerg Sonnenberger wrote:

> If you can freely program the frequency and just have a free running
> counter, use as high a frequency as possible. With the two glitches
> above, it is otherwise fine.

To be honest, I can't remember the exact details without digging out the 
hardware docs (which are buried somewhere in the attic). But ISTR the 
counter is driven by a fixed 1uS clock.

Cheers, Steve

Izumi Tsutsui | 5 Jan 2008 14:59

Picon

Re: mvme68k timecounters.... untested

joerg <at> britannica.bec.de wrote:

> > +static uint32_t clock_pcc_getcount(struct timecounter *);
> 
> static u_int clock_pcc_getcount(struct timecounter *);
> to match the prototype.

Ah, okay, fixed. (I should open more windows 

> If you can freely program the frequency and just have a free running
> counter, use as high a frequency as possible.

It also affects hardclock(9) so it should be done in
a separate commit after tested on the real hardware, I think.

Anyway, I'll commit the changes tomorrow.
---
Izumi Tsutsui

Frank Wille | 6 Jan 2008 14:43

Picon

Re: Xamiga segfaults with 16 bit on CV64

Hi,

I'm crossposting to port-m68k, because gcc4 compiler bugs may be interesting
for all 68k ports.

Here are some more information about my Xserver crash.

Stack frame backtrace:

#0  0x00091be2 in cfb16FillBoxTile32sCopy ()
#1  0x0008a8b0 in cfb16FillBoxTileOdd ()
#2  0x00088222 in cfb16PaintWindow ()
#3  0x0010ed34 in miWindowExposures ()
#4  0x00025fc0 in MapWindow ()
#5  0x00026106 in InitRootWindow ()
#6  0x0000686a in main ()
#7  0x00005de4 in __start ()

The registers:

d0             0x0      0
d1             0x2      2
d2             0x1      1
d3             0x178500 1541376
d4             0x5      5
d5             0xdffecb4        234876084
d6             0x60dec  396780
d7             0x2037c  131964
a0             0x0      0x0
a1             0x178500 0x178500

(Continue reading)

David Laight | 6 Jan 2008 15:12

Picon

Re: Xamiga segfaults with 16 bit on CV64

On Sun, Jan 06, 2008 at 02:43:00PM +0100, Frank Wille wrote:
> 
> Disassembly of the crash location:
> [...]
> 0x91bd4 <cfb16FillBoxTile32sCopy+56>:   moveal %a1 <at> (16),%a0
> 0x91bd8 <cfb16FillBoxTile32sCopy+60>:   movel %a1,%sp <at> -
> 0x91bda <cfb16FillBoxTile32sCopy+62>:   moveal %a0 <at> (372),%a0
> 0x91bde <cfb16FillBoxTile32sCopy+66>:   jsr %a0 <at> 
> 0x91be0 <cfb16FillBoxTile32sCopy+68>:   addql #4,%sp
> 0x91be2 <cfb16FillBoxTile32sCopy+70>:   movel %a0 <at> (32),%fp <at> (-24)  <-- HERE
> [...]
> 
> The code looks to me like a compiler bug (unless the sub-routine is meant to
> return a result in a0). Register a0 is reused for deferencing after a sub-
> routine call, although it is definitely a volatile register (and zero after
> returning from the sub-routine).

%a0 is used to return a pointer from a function.
So it looks as though the called function returned 'NULL' and it wasn't
checked for.

	David

--

-- 
David Laight: david <at> l8s.co.uk

Frank Wille | 6 Jan 2008 16:05

Picon

Re: Xamiga segfaults with 16 bit on CV64

David Laight wrote:

> On Sun, Jan 06, 2008 at 02:43:00PM +0100, Frank Wille wrote:
>> 
>> Disassembly of the crash location: [...]
>> 0x91bd4 <cfb16FillBoxTile32sCopy+56>: moveal %a1 <at> (16),%a0 0x91bd8
>> <cfb16FillBoxTile32sCopy+60>: movel %a1,%sp <at> - 0x91bda
>> <cfb16FillBoxTile32sCopy+62>: moveal %a0 <at> (372),%a0 0x91bde
>> <cfb16FillBoxTile32sCopy+66>: jsr %a0 <at>  0x91be0
>> <cfb16FillBoxTile32sCopy+68>: addql #4,%sp 0x91be2
>> <cfb16FillBoxTile32sCopy+70>: movel %a0 <at> (32),%fp <at> (-24) <-- HERE [...]
>> 
>> The code looks to me like a compiler bug (unless the sub-routine is meant
>> to return a result in a0). Register a0 is reused for deferencing after a
>> sub- routine call, although it is definitely a volatile register (and
>> zero after returning from the sub-routine).
> 
> %a0 is used to return a pointer from a function.
> So it looks as though the called function returned 'NULL' and it wasn't
> checked for.

Thanks for the explanation. I wasn't aware that NetBSD follows a different ABI
than AmigaOS, which always uses d0 for return values.

Then I have to find out which function pointer is NULL here...

--

-- 
    _  Frank Wille (frank <at> phoenix.owl.de)
 _ //  http://sun.hasenbraten.de/~frank/
 \X/   Phx  <at>  #AmigaGer

(Continue reading)

David Laight | 6 Jan 2008 17:23

Picon

Re: Xamiga segfaults with 16 bit on CV64

On Sun, Jan 06, 2008 at 04:05:27PM +0100, Frank Wille wrote:
> > 
> > %a0 is used to return a pointer from a function.
> > So it looks as though the called function returned 'NULL' and it wasn't
> > checked for.
> 
> Thanks for the explanation. I wasn't aware that NetBSD follows a different ABI
> than AmigaOS, which always uses d0 for return values.

I only know because of the recent issues with the return value from mmap().

	David

--

-- 
David Laight: david <at> l8s.co.uk

Group

gmane.os.netbsd.ports.m68k.

Search Archive

Page

1 | 2

Articles in period: 14

January 2008

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

Ṽ ɨ Ẫ ǥ Ṙ Ẫ (22 May 2013)
Apply for loan @ 2%... (9 Apr 2013)
Dringend - Ihre Karte wird suspendiert! (1 Apr 2013)
Dringend - Ihre Karte wird suspendiert! (28 Mar 2013)
congratulations (19 Mar 2013)
MAN UTD COOPERAZIONE, (12 Mar 2013)
Geldtransaktion/HONGKONG (2 Mar 2013)
Geldtransaktion (27 Feb 2013)
Авто мобильные услуги доставки (18 Feb 2013)
Эта дает толк... (12 Feb 2013)
VFD Controlled Motors (29 Jan 2013)
-m68060 breaks stuff in NetBSD-6 (27 Jan 2013)
Reminder, Abstract submission (26 Jan 2013)
accessories and accessories (26 Jan 2013)
Inna (24 Jan 2013)
NeXT 13W3 monitors (31 Dec 2012)
NeXT 13W3 monitors (30 Dec 2012)
Here is the thing, I like u (21 Dec 2012)
New (6 Dec 2012)
Teren in rate langa plaja, fara avans, fara dobanda, fara comision, 50 (3 Dec 2012)
Teren langa plaja Corbu, in rate, 50 euro x 100 rate, fara avans, fara (26 Nov 2012)

Archives

1	May 2013
3	April 2013
7	March 2013
7	February 2013
8	January 2013
6	December 2012
8	November 2012
1	October 2012
8	September 2012
4	August 2012
3	July 2012
6	June 2012
11	May 2012
2	April 2012
5	February 2012
5	January 2012
2	December 2011
8	November 2011
4	October 2011
1	September 2011
2	July 2011
1	June 2011
2	May 2011
1	April 2011
1	March 2011
1	February 2011
3	January 2011
1	November 2010
1	October 2010
1	September 2010
3	July 2010
6	June 2010
6	May 2010
3	April 2010
8	March 2010
6	February 2010
1	January 2010
12	December 2009
7	November 2009
6	October 2009
12	September 2009
10	August 2009
1	June 2009
11	May 2009
2	April 2009
4	March 2009
7	February 2009
44	January 2009
15	December 2008
1	November 2008
1	October 2008
4	September 2008
3	August 2008
2	July 2008
14	June 2008
6	May 2008
1	April 2008
2	February 2008
14	January 2008
1	December 2007
9	November 2007
1	September 2007
6	August 2007
1	July 2007
20	June 2007
11	May 2007
19	March 2007
7	February 2007
2	January 2007
8	November 2006
4	October 2006
13	September 2006
11	August 2006
2	July 2006
5	June 2006
10	May 2006
2	April 2006
6	March 2006
8	February 2006
12	December 2005
1	November 2005
2	October 2005
1	September 2005
4	August 2005
3	June 2005
2	May 2005
2	April 2005
1	February 2005
12	January 2005
2	September 2004
3	August 2004
6	July 2004
2	June 2004
7	April 2004
1	March 2004
2	February 2004
2	December 2003
1	October 2003
1	September 2003
1	August 2003
5	July 2003
1	June 2003
2	April 2003
22	March 2003
7	January 2003
1	December 2002
13	November 2002
3	October 2002
1	September 2002
4	August 2002
9	July 2002
13	June 2002
1	May 2002
6	April 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template