NetBSD source update | 1 Jan 2009 02:25
Picon

daily pkgsrc CVS update output


Updating pkgsrc tree:
? pkgsrc/INDEX
? pkgsrc/README-IPv6.html
? pkgsrc/README-all.html
P pkgsrc/databases/sqlite3/Makefile
P pkgsrc/devel/cpuflags/Makefile
P pkgsrc/devel/cpuflags/files/cpuflags.sh
P pkgsrc/devel/cpuflags/files/subr_x86
P pkgsrc/devel/qbzr/Makefile
P pkgsrc/doc/CHANGES-2008
P pkgsrc/doc/TODO
P pkgsrc/editors/nvi/Makefile

Killing core files:

Updating pkgsrc-2008Q3 pkgsrc tree (/ftp/.trees/pkgsrc/pkgsrc-2008Q3):

NetBSD source update | 2 Jan 2009 02:29
Picon

daily pkgsrc CVS update output


Updating pkgsrc tree:
? pkgsrc/INDEX
? pkgsrc/README-IPv6.html
? pkgsrc/README-all.html
P pkgsrc/audio/Makefile
P pkgsrc/audio/cmus/Makefile
P pkgsrc/audio/cmus/PLIST
P pkgsrc/audio/cmus/options.mk
P pkgsrc/databases/py-postgresql/Makefile
U pkgsrc/databases/py-postgresql/distinfo
P pkgsrc/doc/CHANGES-2008
U pkgsrc/doc/CHANGES-2009
P pkgsrc/doc/TODO
cvs update: pkgsrc/mail/claws-mail-smime/distinfo is no longer in the repository
P pkgsrc/meta-pkgs/Makefile
P pkgsrc/mk/defaults/options.description
P pkgsrc/security/amavisd-new/Makefile
P pkgsrc/security/amavisd-new/distinfo
P pkgsrc/www/squid26/Makefile
P pkgsrc/www/squid27/Makefile
P pkgsrc/www/squid30/Makefile
P pkgsrc/x11/xproto/distinfo
P pkgsrc/x11/xproto/patches/patch-aa

Killing core files:

Updating pkgsrc-2008Q3 pkgsrc tree (/ftp/.trees/pkgsrc/pkgsrc-2008Q3):

(Continue reading)

Georg Schwarz | 3 Jan 2009 01:24
Picon
Favicon

Re: X11/XlibConf.h missing


Am 14.12.2008 um 06:58 schrieb Jeremy C. Reed:

> On Sat, 13 Dec 2008, Jeremy C. Reed wrote:
>
>> On Sun, 14 Dec 2008, Georg Schwarz wrote:
>>
>>> Is it OK to simply include it to that list? Could that turn out a
>>> problem on Xfree versions not containing X11/XlibConf.h?
>>
>> It is okay to add extra files. The symlink simply won't be made if  
>> the
>> target doesn't exist. (Several entries for x11-links are already like
>> that.)
>
>
> Re-read your email again. FreeBSD 7 should be Xorg not XFree86. The  
> change

it is, at least that's what it says on installation of FreeBSD.  
However, pkgsrc for X11_TYPE seems to support either modular or  
native, the latter one being selected by default on FreeBSD. This  
choice is probably right, since it's not modular xorg, is it?

> should be in the xorg related file not "xfree86". I already see it  
> though.
>
> What made it use "xfree86" on your system? We may need to track that
> down instead.

(Continue reading)

Jeremy C. Reed | 3 Jan 2009 02:28

Re: X11/XlibConf.h missing

On Sat, 3 Jan 2009, Georg Schwarz wrote:

> .elif exists(${X11BASE}/lib/X11/config/xorgversion.def)
> .  include "xorg.mk"
> .else
> .  include "xfree.mk"
> .endif
> 
> 
> so /usr/X11R6/lib/x11/config does not exist on the stock FreeBSD installation,
> so it defaults to include xfree.mk.
> Do you think this is incorrect? Should it rather use xorg.mk (even though
> X11_TYPE is native, which is not checked here anyway)?

Let's fix that test so xorg is xorg. See below.

> We could change
> 
> .elif exists(${X11BASE}/lib/X11/config/xorgversion.def)
> 
> into
> 
> .elif exists(${X11BASE}/lib/X11/config/xorgversion.def) ||
> exists(${X11BASE}/bin/xorgconfig)
>
> Other items to trigger for could be the following directories:
> 
> /usr/X11R6/include/xorg
> /usr/X11R6/lib/xorg
> /usr/X11R6/libdata/xorg
(Continue reading)

NetBSD source update | 3 Jan 2009 03:14
Picon

daily pkgsrc CVS update output


Updating pkgsrc tree:
? pkgsrc/INDEX
? pkgsrc/README-IPv6.html
? pkgsrc/README-all.html
P pkgsrc/databases/rrdtool/Makefile
P pkgsrc/databases/rrdtool/buildlink3.mk
P pkgsrc/databases/rrdtool/distinfo
P pkgsrc/databases/rrdtool12/Makefile
P pkgsrc/databases/rrdtool12/buildlink3.mk
P pkgsrc/databases/rrdtool12/distinfo
P pkgsrc/databases/rrdtool12/patches/patch-aw
P pkgsrc/devel/cpuflags/Makefile
P pkgsrc/devel/cpuflags/files/subr_NetBSD
P pkgsrc/devel/p5-Rose-Object/Makefile
P pkgsrc/doc/CHANGES-2009
P pkgsrc/multimedia/pspvc/Makefile
P pkgsrc/textproc/p5-Text-WrapI18N/Makefile
P pkgsrc/textproc/p5-Text-WrapI18N/distinfo
U pkgsrc/textproc/p5-Text-WrapI18N/patches/patch-aa

Killing core files:

Updating tar files:

building list of README.html files
pkgsrc: collecting ... building .gz ... replacing... building .bz2 ... replacing...
pkgsrc-readmes: collecting ... building .gz ... replacing... building .bz2 ... replacing... done

Updating pkgsrc-2008Q3 pkgsrc tree (/ftp/.trees/pkgsrc/pkgsrc-2008Q3):
(Continue reading)

Georg Schwarz | 3 Jan 2009 14:22
Picon
Favicon

Re: X11/XlibConf.h missing


Am 03.01.2009 um 02:28 schrieb Jeremy C. Reed:

>
> Let's fix that test so xorg is xorg. See below.
>
>> We could change
>>
>> .elif exists(${X11BASE}/lib/X11/config/xorgversion.def)
>>
>> into
>>
>> .elif exists(${X11BASE}/lib/X11/config/xorgversion.def) ||
>> exists(${X11BASE}/bin/xorgconfig)
>>
>> Other items to trigger for could be the following directories:
>>
>> /usr/X11R6/include/xorg
>> /usr/X11R6/lib/xorg
>> /usr/X11R6/libdata/xorg
>>
>> What do you think would be the correct approach?
>
> Checking for xorgconfig seems good too.
>
> And or include/X11/XlibConf.h (like the subjectof this email)
>
> And or check for one of the include/xorg or lib/xorg directories.
>
> Do that and see if that works for you.
(Continue reading)

Jeremy C. Reed | 3 Jan 2009 14:55

Re: X11/XlibConf.h missing

> well, it's easy to have x11-links use xorg.mk instead of xfree.mk.
> However, as a consequence, since X11_TYPE is native and not modular,
> ../../x11/libX11/buildlink3.mk does not add libX11 to BUILDLINK_PACKAGES.
> Further to that, X11/Xlib.h does not get added to x11-links's PLIST which
> causes e.g. x11/Xfixes to fail to compile, although the FreeBSD installation
> does ship with a /usr/X11R6/include/X11/Xlib.h installed.
> As a hack, if one adds
> 
> BUILDLINK_PACKAGES:=    ${BUILDLINK_PACKAGES:NlibX11}
> BUILDLINK_PACKAGES+=    libX11
> 
> to xorg.mk and manually sets IS_BUILTIN.libX11=yes, things work.
> This is of course not a fix.
> The question thus remains whether xorg.mk is supposed to be used in the first
> place in case X11_TYPE is native, or even more broadly, whether it is correct
> to have X11_TYPE=native on a stock FreeBSD 7 installation. Depending on that
> answer, we can develop a correct fix.
> 
> The same issue applies to libXext, too, BTW. It appears that xorg.mk was not
> supposed to be used with X11_TYPE!=modular, was it?

x11-links (and xorg.mk) are never used with modular. x11-links and xorg.mk 
should be used with X11_TYPE=native when native X.org is detected.

A "native" X.org used to work (I have used it on NetBSD and Linux) and 
should work on FreeBSD.

Georg Schwarz | 3 Jan 2009 15:11
Picon
Favicon

Re: X11/XlibConf.h missing


Am 03.01.2009 um 14:55 schrieb Jeremy C. Reed:

>> x11-links (and xorg.mk) are never used with modular. x11-links and  
>> xorg.mk
> should be used with X11_TYPE=native when native X.org is detected.

thanks for clarifying

>
> A "native" X.org used to work (I have used it on NetBSD and Linux) and
> should work on FreeBSD.

unfortunately it does not, since libX11 and libXext and probably some  
further components do not get included with x11-links for X11_TYPE! 
=modular.
I wonder how this works on Linux and NetBSD.

--

-- 
Georg Schwarz    http://home.pages.de/~schwarz/
georg.schwarz <at> freenet.de  +49 151 11559652

Thomas Klausner | 3 Jan 2009 19:39
Picon

suggested pkglint change: error on missing comment for patch

Hi!

I'd like pkglint to report errors from now on if a patch doesn't have
a comment.

The comment should be one of:
. upstream bugtracker link for bug report associated with this patch
. upstream scm link, if patch is from (newer) upstream
. comment explaining why this patch is needed for portability but not
  fed upstream
. your idea here, if any?

I don't want to rototill all packages for this, but new packages and
package updates should include this.

Why I want this:
. to increase the chance of patches being fed upstream
. to make it easier tracking this
. to make it easier to check what a patch is good for

Comments?

Cheers,
 Thomas

Ignatios Souvatzis | 3 Jan 2009 20:01
Picon

Re: suggested pkglint change: error on missing comment for patch

On Sat, Jan 03, 2009 at 07:39:28PM +0100, Thomas Klausner wrote:
> Hi!
> 
> I'd like pkglint to report errors from now on if a patch doesn't have
> a comment.
> 
...
> Comments?

we have one-patch-per-file as a rule - what about multiple unrelated 
patches to the same (set of) files? Duplicate the comments?

	-is


Gmane