MLH | 1 Sep 01:09 2005

Malformed conditional && solaris


Why is bmake complaining about this on Solaris ?

bmake: "/usr/pkgsrc/x11/py-qt3-sip/Makefile" line 38: Malformed conditional
(${OPSYS} == "SunOS" && !empty(CC_VERSION:Mgcc*))
bmake: "/usr/pkgsrc/x11/py-qt3-sip/Makefile" line 44: if-less endif
bmake: "/usr/pkgsrc/x11/py-qt3-sip/Makefile" line 44: Need an operator

I suspect that something in the environment is causing
!empty(CC_VERSION:Mgcc*) to fail, but I can't locate what.

Any ideas?

Daniel Carosone | 1 Sep 01:15 2005
Picon

Re: printing with acroread7 and cups

On Wed, Aug 31, 2005 at 08:15:09AM -0400, Steven M. Bellovin wrote:
> >See http://mail-index.netbsd.org/tech-pkg/2005/05/06/0008.html
> 
> OK.  But why don't I have to do that on my other machines?

Any differences in directory structure under /emul/linux between the
machines?  Perhaps the chdir is winding up under /emul in one case,
and not in another where the /emul instance of the directory doesn't
exist?

--
Dan.
Jeremy C. Reed | 1 Sep 01:48 2005
Picon

Re: Malformed conditional && solaris

On Wed, 31 Aug 2005, MLH wrote:

> Why is bmake complaining about this on Solaris ?
>
> bmake: "/usr/pkgsrc/x11/py-qt3-sip/Makefile" line 38: Malformed conditional
> (${OPSYS} == "SunOS" && !empty(CC_VERSION:Mgcc*))

This is the code I committed for you. I don't know what changed. But now I 
think this CC_VERSION requires including the ../../mk/compiler.mk first.

Maybe use following instead. I wasn't even checking for version 3 in the 
first place, so using PKGSRC_COMPILER for checking gcc should be good 
enough.

(This just replaces CC_VERSION with PKGSRC_COMPILER.)

Index: x11/py-qt3-sip/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/py-qt3-sip/Makefile,v
retrieving revision 1.17
diff -b -u -r1.17 Makefile
--- x11/py-qt3-sip/Makefile	1 Jul 2005 01:27:09 -0000	1.17
+++ x11/py-qt3-sip/Makefile	31 Aug 2005 23:46:38 -0000
 <at>  <at>  -35,7 +35,7  <at>  <at> 
  CONFIGURE_ARGS+=	LFLAGS_PLUGIN="-bundle -flat_namespace -undefined suppress"
  .else
  CONFIGURE_ARGS+=	CFLAGS_SHLIB=-fPIC
-.if ${OPSYS} == "SunOS" && !empty(CC_VERSION:Mgcc*)
+.if ${OPSYS} == "SunOS" && !empty(PKGSRC_COMPILER:Mgcc*)
  # gcc3 uses -mimpure-text to not pass -assert pure-text to the linker
(Continue reading)

Joerg Sonnenberger | 1 Sep 01:24 2005
Picon

Re: CVS commit: pkgsrc/x11/xterm

On Wed, Aug 31, 2005 at 03:54:36PM -0700, Jeremy C. Reed wrote:
> This sinstall.sh check field 3 to see if previously-installed xterm was 
> installed setuid.
> 
> So this behaves different based on what is installed.
> 
> Since this uses configure script, we can use  --enable-setuid.
> 
> What platforms do we want this for?

Any platform without native Unix98 PTY support I guess :-) Testing would
be needed e.g. on DragonFly, which still doesn't have full grantpt
functionality, but e.g. Linux or FreeBSD with devfs or newer NetBSD with
ptmx should be save.

Joerg

Steven M. Bellovin | 1 Sep 02:14 2005

Re: printing with acroread7 and cups

In message <20050831231543.GU6862 <at> bcd.geek.com.au>, Daniel Carosone writes:
>
>--8r7XanZh5e+04UYw
>Content-Type: text/plain; charset=us-ascii
>Content-Disposition: inline
>Content-Transfer-Encoding: quoted-printable
>
>On Wed, Aug 31, 2005 at 08:15:09AM -0400, Steven M. Bellovin wrote:
>> >See http://mail-index.netbsd.org/tech-pkg/2005/05/06/0008.html
>>=20
>> OK.  But why don't I have to do that on my other machines?
>
>Any differences in directory structure under /emul/linux between the
>machines?  Perhaps the chdir is winding up under /emul in one case,
>and not in another where the /emul instance of the directory doesn't
>exist?
>

I doubt it, though I can check -- all of the machines in question have 
suse91 installed, and I haven't touched anything there.  But I'll look; 
thanks for the suggestion.

		--Steven M. Bellovin, http://www.cs.columbia.edu/~smb

MLH | 1 Sep 02:42 2005

Re: Malformed conditional && solaris

> 
> On Wed, 31 Aug 2005, MLH wrote:
> 
> > Why is bmake complaining about this on Solaris ?
> >
> > bmake: "/usr/pkgsrc/x11/py-qt3-sip/Makefile" line 38: Malformed conditional
> > (${OPSYS} == "SunOS" && !empty(CC_VERSION:Mgcc*))
> 
> This is the code I committed for you. I don't know what changed. But now I 
> think this CC_VERSION requires including the ../../mk/compiler.mk first.
> 
> Maybe use following instead. I wasn't even checking for version 3 in the 
> first place, so using PKGSRC_COMPILER for checking gcc should be good 
> enough.
> 
> (This just replaces CC_VERSION with PKGSRC_COMPILER.)

Ok. That fixed the Makefile problem and got down to:

===> Patching for py24-qt3-sip-4.2.1
===> Applying pkgsrc patches for py24-qt3-sip-4.2.1
===> Overriding tools for py24-qt3-sip-4.2.1
===> Creating toolchain wrappers for py24-qt3-sip-4.2.1
/bin/sh:
/usr/local/pkgwork/x11/py-qt3-sip/work.loonquawl/.buildlink/lib/pkgconfig/xextensions.pc:
cannot create
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/x11/py-qt3-sip
(Continue reading)

grant beattie | 1 Sep 02:41 2005
Picon

Re: Malformed conditional && solaris

On Wed, Aug 31, 2005 at 04:48:56PM -0700, Jeremy C. Reed wrote:

> On Wed, 31 Aug 2005, MLH wrote:
> 
> >Why is bmake complaining about this on Solaris ?
> >
> >bmake: "/usr/pkgsrc/x11/py-qt3-sip/Makefile" line 38: Malformed conditional
> >(${OPSYS} == "SunOS" && !empty(CC_VERSION:Mgcc*))
> 
> This is the code I committed for you. I don't know what changed. But now I 
> think this CC_VERSION requires including the ../../mk/compiler.mk first.
> 
> Maybe use following instead. I wasn't even checking for version 3 in the 
> first place, so using PKGSRC_COMPILER for checking gcc should be good 
> enough.
> 
> (This just replaces CC_VERSION with PKGSRC_COMPILER.)
> 
> Index: x11/py-qt3-sip/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/x11/py-qt3-sip/Makefile,v
> retrieving revision 1.17
> diff -b -u -r1.17 Makefile
> --- x11/py-qt3-sip/Makefile	1 Jul 2005 01:27:09 -0000	1.17
> +++ x11/py-qt3-sip/Makefile	31 Aug 2005 23:46:38 -0000
>  <at>  <at>  -35,7 +35,7  <at>  <at> 
>  CONFIGURE_ARGS+=	LFLAGS_PLUGIN="-bundle -flat_namespace -undefined 
>  suppress"
>  .else
>  CONFIGURE_ARGS+=	CFLAGS_SHLIB=-fPIC
(Continue reading)

Jeremy C. Reed | 1 Sep 02:50 2005
Picon

Re: Malformed conditional && solaris

On Wed, 31 Aug 2005, MLH wrote:

>> This is the code I committed for you. I don't know what changed. But now I
>> think this CC_VERSION requires including the ../../mk/compiler.mk first.

I should have followed that instead as grant pointed out in a reply.

>> (This just replaces CC_VERSION with PKGSRC_COMPILER.)
>
> Ok. That fixed the Makefile problem and got down to:

Switch it back :) And
.include "../../mk/compiler.mk" before that.

  .include "../../mk/bsd.prefs.mk"
+.include "../../mk/compiler.mk"

> ===> Creating toolchain wrappers for py24-qt3-sip-4.2.1
> /bin/sh:
> /usr/local/pkgwork/x11/py-qt3-sip/work.loonquawl/.buildlink/lib/pkgconfig/xextensions.pc:
> cannot create
> *** Error code 1

That is caused by something else. I just had same problem with kdelibs3 on 
Dragonfly:

===> Creating toolchain wrappers for kdelibs-3.4.2nb1
cannot create 
/home/reed/pkgsrc/x11/kdelibs3/work/.buildlink/lib/pkgconfig/xextensions.pc: 
permission denied
(Continue reading)

MLH | 1 Sep 02:53 2005

Re: Malformed conditional && solaris

> 
> On Wed, Aug 31, 2005 at 04:48:56PM -0700, Jeremy C. Reed wrote:
> 
> > On Wed, 31 Aug 2005, MLH wrote:
> > 
> > >Why is bmake complaining about this on Solaris ?
> > >
> > >bmake: "/usr/pkgsrc/x11/py-qt3-sip/Makefile" line 38: Malformed conditional
> > >(${OPSYS} == "SunOS" && !empty(CC_VERSION:Mgcc*))
... 
> > -.if ${OPSYS} == "SunOS" && !empty(CC_VERSION:Mgcc*)
> > +.if ${OPSYS} == "SunOS" && !empty(PKGSRC_COMPILER:Mgcc*)
> 
> this is not correct, since PKGSRC_COMPILER can contain multiple words,
> in order of preference, and this could match gcc* when it isn't the
> compiler being used.
> 
> CC_VERSION is the version string of the compiler currently being used,
> but you need to .include "../../mk/compiler.mk" before testing its
> value.

Ok. This also worked for the Makefile problem. Thanks!

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/py-qt3-sip/Makefile,v
retrieving revision 1.17
diff -b -u -r1.17 Makefile
--- Makefile	1 Jul 2005 01:27:09 -0000	1.17
+++ Makefile	1 Sep 2005 00:50:41 -0000
(Continue reading)

MLH | 1 Sep 02:55 2005

Re: Malformed conditional && solaris

> 
> On Wed, 31 Aug 2005, MLH wrote:
> 
> > ===> Creating toolchain wrappers for py24-qt3-sip-4.2.1
> > /bin/sh:
> > /usr/local/pkgwork/x11/py-qt3-sip/work.loonquawl/.buildlink/lib/pkgconfig/xextensions.pc:
> > cannot create
> > *** Error code 1
> 
> That is caused by something else. I just had same problem with kdelibs3 on 
> Dragonfly:
> 
> ===> Creating toolchain wrappers for kdelibs-3.4.2nb1
> cannot create 
> /home/reed/pkgsrc/x11/kdelibs3/work/.buildlink/lib/pkgconfig/xextensions.pc: 
> permission denied
> *** Error code 2
> 
> I did a bmake clean and tried again and it worked. I don't know what 
> changed yet.

Ok... I'll try to determine where it's coming from in a bit.

Thanks!


Gmane