headers
David Young | 1 Feb 2009 01:40
Picon
Favicon

Re: CVS commit: src/sys/dev/pci

On Sat, Jan 31, 2009 at 01:57:03PM +0000, Manuel Bouyer wrote:
> 
> Module Name:	src
> Committed By:	bouyer
> Date:		Sat Jan 31 13:57:03 UTC 2009
> 
> Modified Files:
> 	src/sys/dev/pci: if_jme.c
> 
> Log Message:
> Under some circunstance, the JMC250A2 (and maybe others) can enter a state
> where INTA is asserted while no enabled interrupts are pending, which
> cause a continous strean if interrupts with no way to clear it.
> Clearing/resetting the enabled interrupt mask in the interrupt handler seems
> to workaround this issue (this is what the FreeBSD driver does).
> While there properly return 0 if the interrupt was not for us, and explicitely
> disable JME_TMCSR in addition to TIMER1 and TIMER2.

Does FreeBSD enable/disable by changing the interrupt mask on the
NIC because that is the right / only workaround for this bug, or
do they do that because the change has been carried by the cargo
cult from driver to driver to driver?  Maybe you should disable/enable
only if INTA seems to be stuck?

Dave

--

-- 
David Young             OJC Technologies
dyoung <at> ojctech.com      Urbana, IL * (217) 278-3933
(Continue reading)

Permalink | Reply | 3 comments |
headers
YAMAMOTO Takashi | 1 Feb 2009 08:55
Picon

CVS commit: src/usr.sbin/syslogd


Module Name:	src
Committed By:	yamt
Date:		Sun Feb  1 07:55:42 UTC 2009

Modified Files:
	src/usr.sbin/syslogd: syslogd.8

Log Message:
make -o option consistent with others.

To generate a diff of this commit:
cvs rdiff -r1.44 -r1.45 src/usr.sbin/syslogd/syslogd.8

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
YAMAMOTO Takashi | 1 Feb 2009 09:12
Picon

CVS commit: src/usr.sbin/syslogd


Module Name:	src
Committed By:	yamt
Date:		Sun Feb  1 08:12:25 UTC 2009

Modified Files:
	src/usr.sbin/syslogd: syslogd.8

Log Message:
note some options' optarg in DESCRIPTION as well.

To generate a diff of this commit:
cvs rdiff -r1.45 -r1.46 src/usr.sbin/syslogd/syslogd.8

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Manuel Bouyer | 1 Feb 2009 12:33

Re: CVS commit: src/sys/dev/pci

On Sat, Jan 31, 2009 at 06:40:24PM -0600, David Young wrote:
> > Log Message:
> > Under some circunstance, the JMC250A2 (and maybe others) can enter a state
> > where INTA is asserted while no enabled interrupts are pending, which
> > cause a continous strean if interrupts with no way to clear it.
> > Clearing/resetting the enabled interrupt mask in the interrupt handler seems
> > to workaround this issue (this is what the FreeBSD driver does).
> > While there properly return 0 if the interrupt was not for us, and explicitely
> > disable JME_TMCSR in addition to TIMER1 and TIMER2.
> 
> Does FreeBSD enable/disable by changing the interrupt mask on the
> NIC because that is the right / only workaround for this bug, or
> do they do that because the change has been carried by the cargo
> cult from driver to driver to driver?

They do it because it's the right thing to do in their interrupt system
(the interrupt handler defers interrupt processing to a kernel thread).

> Maybe you should disable/enable
> only if INTA seems to be stuck?

How do we know if INTA is stuck ? Especially when it's shared with other
devices ? I guess this will require more cycles than the 2 single
writes to the adapter's registers required to do this.

--

-- 
Manuel Bouyer <bouyer <at> antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--
(Continue reading)

Permalink | Reply | 2 comments |
headers
Thomas Klausner | 1 Feb 2009 13:59
Picon

CVS commit: src/usr.sbin/syslogd


Module Name:	src
Committed By:	wiz
Date:		Sun Feb  1 12:59:05 UTC 2009

Modified Files:
	src/usr.sbin/syslogd: syslogd.8

Log Message:
Bump date for previous.

To generate a diff of this commit:
cvs rdiff -r1.46 -r1.47 src/usr.sbin/syslogd/syslogd.8

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Nick Hudson | 1 Feb 2009 15:25
Picon

CVS commit: src/sys/uvm


Module Name:	src
Committed By:	skrll
Date:		Sun Feb  1 14:25:11 UTC 2009

Modified Files:
	src/sys/uvm: uvm_stat.h

Log Message:
Fix printing of tv_sec,tv_usec in UVMHIST.

To generate a diff of this commit:
cvs rdiff -r1.44 -r1.45 src/sys/uvm/uvm_stat.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Antti Kantee | 1 Feb 2009 18:04
Picon

CVS commit: src/sys/netinet


Module Name:	src
Committed By:	pooka
Date:		Sun Feb  1 17:04:11 UTC 2009

Modified Files:
	src/sys/netinet: in_proto.c ip_flow.c ip_var.h

Log Message:
Init ipflow pool dynamically instead of using a linkset.

To generate a diff of this commit:
cvs rdiff -r1.95 -r1.96 src/sys/netinet/in_proto.c
cvs rdiff -r1.56 -r1.57 src/sys/netinet/ip_flow.c
cvs rdiff -r1.90 -r1.91 src/sys/netinet/ip_var.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Antti Kantee | 1 Feb 2009 18:05
Picon

CVS commit: src/sys/rump/net/lib/libnetinet


Module Name:	src
Committed By:	pooka
Date:		Sun Feb  1 17:05:26 UTC 2009

Modified Files:
	src/sys/rump/net/lib/libnetinet: Makefile.inc

Log Message:
enable GATEWAY

To generate a diff of this commit:
cvs rdiff -r1.1 -r1.2 src/sys/rump/net/lib/libnetinet/Makefile.inc

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Andrew Doran | 1 Feb 2009 18:36
Picon

CVS commit: src/sys/ufs/ffs


Module Name:	src
Committed By:	ad
Date:		Sun Feb  1 17:36:43 UTC 2009

Modified Files:
	src/sys/ufs/ffs: ffs_vnops.c

Log Message:
PR kern/40469 5.0_BETA/amd64 INSTALL kernel panics when installing on log-enabled filesystems
PR kern/40470 WAPBL corrupts ext2fs

Don't touch inodes at all unless VOP_FSYNC(). Might fix the ext2fs problem,
I am not sure.

To generate a diff of this commit:
cvs rdiff -r1.108 -r1.109 src/sys/ufs/ffs/ffs_vnops.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Andrew Doran | 1 Feb 2009 19:23
Picon

CVS commit: src/sys


Module Name:	src
Committed By:	ad
Date:		Sun Feb  1 18:23:04 UTC 2009

Modified Files:
	src/sys/kern: sys_pipe.c
	src/sys/sys: pipe.h

Log Message:
Apply pipe patch posted to tech-kern, slightly updated:

- Cache kva.
- Convert to use mutex_obj_alloc().
- Make better use of pool_cache.

Also:

Disable direct transfers for the moment. I believe there may be a bug that
can cause transfers to stall when switching between direct/buffered access.
I think this has most recently been run into on 'denver' but I have seen it
as far back as 3.1.

(As an aside, direct is a not a clear win on modern systems with large cache
and high TLB invalidation overhead. Particularly so on MP systems, although
micro benchmarks may report otherwise because they typically do not tax the
system. Anyone want to write a decent benchmark?)

To generate a diff of this commit:
cvs rdiff -r1.105 -r1.106 src/sys/kern/sys_pipe.c
(Continue reading)

Permalink | Reply | 0 comments |

Gmane