headers
Christian Biere | 1 Nov 2006 01:21
Picon
Picon
Gravatar

Re: CVS commit: src/usr.sbin/installboot

Tom Spindler wrote:
> Are braces really such a horrible solution for this?
> 
> gcc doesn't complain in the least about
> 
> 	if (params->fstype->needswap) {
> 		/* function that #defines to empty space */
> 	}

If it's a function I'd consider using a (static inline) function instead
of a macro as far as possible, that's also better for type-safety if
the non-empty variant is seldomly used.

> Then again, I dislike with the "No braces are used for control
> statements with zero or only a single argument[...]" in share/misc/style.

Bikeshead ahead. *must resist* Me too. *arrg*

--

-- 
Christian
Permalink | Reply | 0 comments |
headers
Tom Spindler | 1 Nov 2006 01:33
Picon

CVS commit: src/dist/file/src


Module Name:	src
Committed By:	dogcow
Date:		Wed Nov  1 00:33:40 UTC 2006

Modified Files:
	src/dist/file/src: print.c softmagic.c

Log Message:
Sprinkle llx -> PRIx64 around; fixes compilation on 64 bit platforms.

To generate a diff of this commit:
cvs rdiff -r1.4 -r1.5 src/dist/file/src/print.c
cvs rdiff -r1.6 -r1.7 src/dist/file/src/softmagic.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
David Young | 1 Nov 2006 07:14
Picon
Favicon

Re: CVS commit: src/sys/arch/i386/stand/bootxx

On Mon, Oct 23, 2006 at 09:57:46PM +0000, Christos Zoulas wrote:
> 
> Module Name:	src
> Committed By:	christos
> Date:		Mon Oct 23 21:57:46 UTC 2006
> 
> Modified Files:
> 	src/sys/arch/i386/stand/bootxx: Makefile.bootxx
> 
> Log Message:
> nuke $DBG, since it contains -O2; suggested by uwe.
> 

Why does this change matter?

Dave

--

-- 
David Young             OJC Technologies
dyoung <at> ojctech.com      Urbana, IL * (217) 278-3933
Permalink | Reply | 1 comment |
headers
Christian Biere | 1 Nov 2006 07:39
Picon

CVS commit: src/sys/dev


Module Name:	src
Committed By:	cbiere
Date:		Wed Nov  1 06:39:19 UTC 2006

Modified Files:
	src/sys/dev: audio.c

Log Message:
Fix for kern/17446. Restore the audio settings if an error occured.

To generate a diff of this commit:
cvs rdiff -r1.211 -r1.212 src/sys/dev/audio.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Jason R Thorpe | 1 Nov 2006 07:42
Picon

CVS commit: src/sys/dev/pci


Module Name:	src
Committed By:	thorpej
Date:		Wed Nov  1 06:42:12 UTC 2006

Modified Files:
	src/sys/dev/pci: if_pcn.c

Log Message:
Detect if we're talking to a VMware virtual interface, and, if so,
limit the number of Tx segments to 8 to work around a VMware bug.

To generate a diff of this commit:
cvs rdiff -r1.33 -r1.34 src/sys/dev/pci/if_pcn.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Juan Romero Pardines | 1 Nov 2006 09:39
Picon

CVS commit: src/sys/dev/usb


Module Name:	src
Committed By:	xtraeme
Date:		Wed Nov  1 08:39:25 UTC 2006

Modified Files:
	src/sys/dev/usb: if_rum.c

Log Message:
Missing __KERNEL_RCSID()

To generate a diff of this commit:
cvs rdiff -r1.1 -r1.2 src/sys/dev/usb/if_rum.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Juan Romero Pardines | 1 Nov 2006 09:49
Picon

CVS commit: src/sys/arch/i386/i386


Module Name:	src
Committed By:	xtraeme
Date:		Wed Nov  1 08:49:50 UTC 2006

Modified Files:
	src/sys/arch/i386/i386: est.c

Log Message:
Use __arraycount from <sys/cdefs.h>.

To generate a diff of this commit:
cvs rdiff -r1.29 -r1.30 src/sys/arch/i386/i386/est.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
YAMAMOTO Takashi | 1 Nov 2006 10:32
Picon

CVS commit: src/sys/kern


Module Name:	src
Committed By:	yamt
Date:		Wed Nov  1 09:32:53 UTC 2006

Modified Files:
	src/sys/kern: kern_synch.c

Log Message:
mi_switch: move rlimit and autonice handling out of sched_lock in order to
simplify locking.
related to PR/32962 and PR/34895.  reviewed by matthew green.

To generate a diff of this commit:
cvs rdiff -r1.168 -r1.169 src/sys/kern/kern_synch.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
YAMAMOTO Takashi | 1 Nov 2006 10:33
Picon

CVS commit: src/sys


Module Name:	src
Committed By:	yamt
Date:		Wed Nov  1 09:33:45 UTC 2006

Modified Files:
	src/sys/kern: kern_sig.c
	src/sys/sys: signalvar.h

Log Message:
kill sched_psignal.
related to PR/32962 and PR/34895.  reviewed by matthew green.

To generate a diff of this commit:
cvs rdiff -r1.232 -r1.233 src/sys/kern/kern_sig.c
cvs rdiff -r1.66 -r1.67 src/sys/sys/signalvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Christos Zoulas | 1 Nov 2006 10:36

Re: CVS commit: src/sys/arch/i386/stand/bootxx

On Nov 1, 12:14am, dyoung <at> pobox.com (David Young) wrote:
-- Subject: Re: CVS commit: src/sys/arch/i386/stand/bootxx

| On Mon, Oct 23, 2006 at 09:57:46PM +0000, Christos Zoulas wrote:
| > 
| > Module Name:	src
| > Committed By:	christos
| > Date:		Mon Oct 23 21:57:46 UTC 2006
| > 
| > Modified Files:
| > 	src/sys/arch/i386/stand/bootxx: Makefile.bootxx
| > 
| > Log Message:
| > nuke $DBG, since it contains -O2; suggested by uwe.
| > 
| 
| Why does this change matter?

According to uwe, when multiple -O flags are present the last one
takes precendence. We want -Os for the bootblocks.

christos
Permalink | Reply | 0 comments |

Gmane