headers
Valeriy E. Ushakov | 1 Jun 2006 02:43
Picon

CVS commit: src/sys/dev


Module Name:	src
Committed By:	uwe
Date:		Thu Jun  1 00:43:37 UTC 2006

Modified Files:
	src/sys/dev: cons.h

Log Message:
Remove redundant semicolon in dev_type_cnbell.

To generate a diff of this commit:
cvs rdiff -r1.24 -r1.25 src/sys/dev/cons.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Jonathan Stone | 1 Jun 2006 03:46
Picon

CVS commit: src/sys/dev/pci


Module Name:	src
Committed By:	jonathan
Date:		Thu Jun  1 01:46:41 UTC 2006

Modified Files:
	src/sys/dev/pci: if_bge.c

Log Message:
Fix a minor thinko in ascertaining whether or not a bge(4) device is
attached via PCI-Express:

The previous code first checked that the bge ASIC-revision matched the
5750 ASIC-revisoin (the bcm5721 has the same ASIC revision). However, the
bcm5752 is also a PCI-Express device, but has a different ASIC revision.
Thus, we were setting sc->bge_pcie to zero for bcm5752s, which in turn
causes bge_reset() to not perform required PCI-Express setup.

The test for a 5750 ASIC revision may (or may not) have been carried
across from the FreeBSD bge(4) driver. FreeBSD's bge(4) does not
properly detect or handle post-5750 bge devices. Instead, FreeBSD's
bge(4) keeps a sofc copy of the ASIC revision, and for post-5750
devices (5752, 5714, ...) overwrites that softc copy of the
ASIC-revision with the 5750 ASIC revision.  Thus, the test (mutatis
mutandis, using FreeBDS's softc asic-revision field), was correct for
FreeBSD; but manifestly incorrect for NetBSD.

Mark Davies (mark at mcs.vuw.ac..nz) has confirmed via private email
that this change fixes PR kern/kern/33509: his bcm5752 now works.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jonathan Stone | 1 Jun 2006 04:20
Picon

CVS commit: src/sys/dev/pci


Module Name:	src
Committed By:	jonathan
Date:		Thu Jun  1 02:20:55 UTC 2006

Modified Files:
	src/sys/dev/pci: if_bge.c

Log Message:
Rework bge_reset() to more closely follow the Broadcom-supplied Linux driver:

1. Instead of enabling the buffer manager hardware-FSM only on
pre-5705 devices, initialize the buffer manager on all bge devices.
Modelled on the Broadcom-authored Linux driver.

2. Instead of enabling the memory arbiter hardware-FSM only on
pre-5705 devices, initialize the memory arbiter on all bge devices.
Modelled on the Broadcom-authored Linux driver.

3. Ditto the second copy of code which enables the memory arbiter.
Also, add an XXX asking, why taunt the chip this way a second time?
(The most plausible explanatoin is that enabling the memory arbiter
twice is my own darn fault, likely a cut-and-paste glitch I made many
moons ago, when re-ordering hardware enables to match the Linux drivers.)

To generate a diff of this commit:
cvs rdiff -r1.108 -r1.109 src/sys/dev/pci/if_bge.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Simon Burge | 1 Jun 2006 07:57
Picon

CVS commit: [netbsd-1-6] src/sys/kern


Module Name:	src
Committed By:	simonb
Date:		Thu Jun  1 05:57:19 UTC 2006

Modified Files:
	src/sys/kern [netbsd-1-6]: vfs_vnops.c

Log Message:
Pull up rev 1.112 from trunk:
  Limit the size of any kernel buffers allocated by the VOP_READDIR
  routines to MAXBSIZE.

OK'd by tron <at> 

To generate a diff of this commit:
cvs rdiff -r1.54.6.1 -r1.54.6.2 src/sys/kern/vfs_vnops.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Simon Burge | 1 Jun 2006 08:03
Picon

CVS commit: [netbsd-1-6] src/doc


Module Name:	src
Committed By:	simonb
Date:		Thu Jun  1 06:03:17 UTC 2006

Modified Files:
	src/doc [netbsd-1-6]: CHANGES-1.6.3

Log Message:
Note sys/kern/vfs_vnops.c rev 1.112.

To generate a diff of this commit:
cvs rdiff -r1.1.2.180 -r1.1.2.181 src/doc/CHANGES-1.6.3

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Izumi Tsutsui | 1 Jun 2006 16:18
Picon

CVS commit: src/sys/arch/ews4800mips/ews4800mips


Module Name:	src
Committed By:	tsutsui
Date:		Thu Jun  1 14:18:41 UTC 2006

Modified Files:
	src/sys/arch/ews4800mips/ews4800mips: bus_space.c

Log Message:
Sync with hpcsh/bus_space.c rev 1.12:
> Use C99 syntax for designated initializers.
> Semicolon syntax is a gcc extension and has been obsolete since gcc 2.5.

To generate a diff of this commit:
cvs rdiff -r1.1 -r1.2 src/sys/arch/ews4800mips/ews4800mips/bus_space.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Nathan J Williams | 1 Jun 2006 17:53
Picon

CVS commit: src/sys/dev/scsipi


Module Name:	src
Committed By:	nathanw
Date:		Thu Jun  1 15:53:09 UTC 2006

Modified Files:
	src/sys/dev/scsipi: sd.c

Log Message:
Change return type of sdgetdisklabel() from void to int; return an error
if readdisklabel() returned an error.

sdopen(): Return an error if sdgetdisklabel() returns an error. This prevents
a crash in spec_open() (and possibly elsewhere) if a sd device is detached in
the middle of sdopen().

To generate a diff of this commit:
cvs rdiff -r1.247 -r1.248 src/sys/dev/scsipi/sd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
Christos Zoulas | 1 Jun 2006 17:59
Picon

CVS commit: src/sbin/ping


Module Name:	src
Committed By:	christos
Date:		Thu Jun  1 15:59:31 UTC 2006

Modified Files:
	src/sbin/ping: ping.c

Log Message:
PR/33623: Chuck Cranor: Ping stops when ran in the background
because it tries to set the tty not to print kerninfo. Change it
to only only play with the tty when ping is running in the foreground
(and will not stop when calling tcsetattr()). In my opinion, it is
preferable to print the kerninfo line with the ping info message
rather than to mess with the tty, but that's just me.

To generate a diff of this commit:
cvs rdiff -r1.78 -r1.79 src/sbin/ping/ping.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 1 comment |
headers
Matthias Drochner | 1 Jun 2006 18:12
Picon

CVS commit: src/games/tetris


Module Name:	src
Committed By:	drochner
Date:		Thu Jun  1 16:12:27 UTC 2006

Modified Files:
	src/games/tetris: scores.c

Log Message:
Better check data read from tetris.scores before use as array indices etc.
This is CVE-2006-1539, files against Gentoo Linux, the patch is from
Gentoo.
A standard NetBSD installation is not as much risk because tetris is
sgid "games", and users shouldn't be in that group.

To generate a diff of this commit:
cvs rdiff -r1.13 -r1.14 src/games/tetris/scores.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Permalink | Reply | 0 comments |
headers
matthew green | 1 Jun 2006 19:14
Picon
Favicon

re: CVS commit: src/sbin/ping


   Log Message:
   PR/33623: Chuck Cranor: Ping stops when ran in the background
   because it tries to set the tty not to print kerninfo. Change it
   to only only play with the tty when ping is running in the foreground
   (and will not stop when calling tcsetattr()). In my opinion, it is
   preferable to print the kerninfo line with the ping info message
   rather than to mess with the tty, but that's just me.

i also vote we fix ping to not turn of kerninfo...
Permalink | Reply | 0 comments |

Gmane