Re: [patch] ksh macro fixes for emacs input mode (aka bind -m)
On Fri, 3 Apr 2009, Alexander Hall wrote:
> Ehrm, you are referring to a line in the diff with a '-' in front of it...
Yeah, sorry, I need more coffee.
> > This is a separate feature from
> > the bugfix, if I see it correctly (but a desired one, methinks).
>
> Yes, I intended to fix it properly instead of just making it not hang.
> As I wrote in the mail regarding diff #3:
> "This diff is like the one above with the addition that macros
> including ^M or ^O or similar are continued on the next input
> line."
Yep. Ok, I’ll make separate commits out of them.
Thanks for looking at OpenBSD ksh; if you want, look at
http://mirbsd.de/mksh as well ;) which is where it’ll
end up.
bye,
//mirabilos
--
--
Sometimes they [people] care too much: pretty printers [and syntax highligh-
ting, d.A.] mechanically produce pretty output that accentuates irrelevant
detail in the program, which is as sensible as putting all the prepositions
in English text in bold font. -- Rob Pike in "Notes on Programming in C"
> Hmmm well reading the link I realize you did not in fact miss the latest > set of patches. I believe the last patch do what you want. Hm. I am slightly confused about <at> <at> -1762,8 +1765,10 <at> <at> x_e_getc(void) } else { if (macroptr) { c = *macroptr++; - if (!*macroptr) - macroptr = (char *) 0; + if (!c) { + macroptr = NULL; + c = x_getc(); + } } else c = x_getc(); } but upon reading it a third time or so, I think it handles the _last_ character of the replacement, whereas the rest handles all but the last character, right? - macroptr = (char *) 0;
RSS Feed