freenas | 1 Apr 04:54 2015

[freenas/freenas] cda8dc4: Remove stupid console.log

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit cda8dc4da04988026c67604f1d7854d496dbaa2f
Author: Suraj Ravichandran <suraj@...>
Date:   Tue Mar 31 19:53:56 2015 -0700

    Remove stupid console.log
---
 src/gui/app/jsx/components/common/Shell.jsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gui/app/jsx/components/common/Shell.jsx b/src/gui/app/jsx/components/common/Shell.jsx
index 5eea906..2f6cd53 100644
--- a/src/gui/app/jsx/components/common/Shell.jsx
+++ b/src/gui/app/jsx/components/common/Shell.jsx
 <at>  <at>  -39,7 +39,6  <at>  <at>  var Shell = React.createClass({
         this.isAuthenticated = false;
         ShellMiddleware.spawnShell( this.props.shellType, this.createNewShell );
       }
-      console.log("suraj in com. did update printing height: " + this.refs.termTarget.getDOMNode().clientHeight);
       if ( this.refs.termTarget.getDOMNode().clientHeight !== 0 ) {
         this.term.resize(80, this.refs.termTarget.getDOMNode().clientHeight * 0.05 );
       }
freenas | 1 Apr 04:47 2015

[freenas/freenas] c38b958: Auto-resize console based on available space.

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit c38b9582ab6b5feb330523a6df625fbf77fb750d
Author: Suraj Ravichandran <suraj@...>
Date:   Tue Mar 31 19:45:19 2015 -0700

    Auto-resize console based on available space.

    It was fun, I learnt flex (just a lil bit).

    Ticket: #8548
---
 src/gui/app/jsx/components/common/Shell.jsx | 8 ++++++--
 src/gui/app/source/styles/DebugPanel.less   | 1 +
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/gui/app/jsx/components/common/Shell.jsx b/src/gui/app/jsx/components/common/Shell.jsx
index 2f63737..5eea906 100644
--- a/src/gui/app/jsx/components/common/Shell.jsx
+++ b/src/gui/app/jsx/components/common/Shell.jsx
 <at>  <at>  -39,6 +39,10  <at>  <at>  var Shell = React.createClass({
         this.isAuthenticated = false;
         ShellMiddleware.spawnShell( this.props.shellType, this.createNewShell );
       }
+      console.log("suraj in com. did update printing height: " + this.refs.termTarget.getDOMNode().clientHeight);
+      if ( this.refs.termTarget.getDOMNode().clientHeight !== 0 ) {
+        this.term.resize(80, this.refs.termTarget.getDOMNode().clientHeight * 0.05 );
+      }
(Continue reading)

freenas | 1 Apr 04:37 2015

[freenas/freenas] c1313df: Stuck the UUID generating function in a new utility module, because sharing is caring.

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit c1313dfd44144b7347773c9315bda41d1ca2ea32
Author: Corey Vixie <corey.vixie@...>
Date:   Tue Mar 31 19:25:03 2015 -0700

    Stuck the UUID generating function in a new utility module, because sharing is caring.
---
 src/gui/app/jsx/common/freeNASUtil.js              | 22 +++++++++++++++++++
 .../jsx/components/Widgets/DummyWidgetContent.jsx  |  4 ++--
 src/gui/app/jsx/middleware/MiddlewareClient.js     | 25 ++++++----------------
 3 files changed, 31 insertions(+), 20 deletions(-)

diff --git a/src/gui/app/jsx/common/freeNASUtil.js b/src/gui/app/jsx/common/freeNASUtil.js
new file mode 100644
index 0000000..f42b0fe
--- /dev/null
+++ b/src/gui/app/jsx/common/freeNASUtil.js
 <at>  <at>  -0,0 +1,22  <at>  <at> 
+// FREENAS UTIL
+// ============
+// This module contains a set of common utility functions which have broad
+// applicability to different areas of the FreeNAS WebApp. They may be used in
+// React Components, Flux Stores, or entirely separate places.
+
+"use strict";
+
+var freeNASUtil = exports;
(Continue reading)

freenas | 1 Apr 03:24 2015

[freenas/freenas] a034cfe: Treat local changes as aborted only in comparison to accepted changes to remote state, not to *any* changes (which is what this.props.item contains).

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit a034cfe568d1ae5c41f4942b93dabc0e4855e79a
Author: Ben Milman <bpmilman@...>
Date:   Tue Mar 31 17:01:49 2015 -0700

    Treat local changes as aborted only in comparison to accepted changes to remote state, not to *any* changes
(which is what this.props.item contains).
---
 src/gui/app/jsx/views/Accounts/Users/UserItem.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
index 989984e..4c01bfb 100644
--- a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
+++ b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
 <at>  <at>  -241,7 +241,7  <at>  <at>  var UserEdit = React.createClass({
       // same as what the last payload from the middleware shows as the value
       // for the same key. If it is, we `delete` the key from our temp object
       // and update state.
-      if ( _.isEqual( this.props.item[ key ], inputValue ) ) {
+      if ( _.isEqual( this.state.remoteState[ key ], inputValue ) ) {
         delete newLocallyModified[ key ];
       } else {
         newLocallyModified[ key ] = inputValue;
freenas | 1 Apr 03:24 2015

[freenas/freenas] 3be1154: Add TODOs for future UI changes.

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit 3be11547b9b2eff6e99be84e615e9ded407152bb
Author: Ben Milman <bpmilman@...>
Date:   Tue Mar 31 16:59:36 2015 -0700

    Add TODOs for future UI changes.
---
 src/gui/app/jsx/views/Accounts/Users/UserItem.jsx | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
index a415b3b..989984e 100644
--- a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
+++ b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
 <at>  <at>  -286,6 +286,11  <at>  <at>  var UserEdit = React.createClass({

     }

+    // TODO: Currently this section just arbitrarily handles every property the
+    // middleware sends in the order the browser sends it. This should be updated
+    // to have a deliberate design.
+    // TODO: Add alerts when a remote administrator has changed items that the
+    // local administrator is also working on.
   , render: function() {
       var builtInUserAlert  = null;
       var editButtons       = null;
(Continue reading)

freenas | 1 Apr 03:24 2015

[freenas/freenas] a3c37c6: Rename variables to match other recent changes.

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit a3c37c669ed6317cc98a599fe572ea4e1fc60bbc
Author: Ben Milman <bpmilman@...>
Date:   Tue Mar 31 16:19:08 2015 -0700

    Rename variables to match other recent changes.
---
 src/gui/app/jsx/views/Accounts/Users/UserItem.jsx | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
index 6a415bc..ed0382a 100644
--- a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
+++ b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
 <at>  <at>  -246,7 +246,7  <at>  <at>  var UserEdit = React.createClass({
     }

   , handleValueChange: function( key, event ) {
-      var newValues  = this.state.locallyModifiedValues;
+      var newLocallyModified = this.state.locallyModifiedValues;
       var inputValue;

       // Use different logic to interpret input from different kinds of fields.
 <at>  <at>  -269,9 +269,9  <at>  <at>  var UserEdit = React.createClass({
       // for the same key. If it is, we `delete` the key from our temp object
       // and update state.
       if ( _.isEqual( this.props.item[ key ], inputValue ) ) {
(Continue reading)

freenas | 1 Apr 03:24 2015

[freenas/freenas] 082a467: UserItem should only let new props change the values currently being edited if it's in response to a change by the local administrator.

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit 082a467168743cc8223ffa041bd0f2bb1228e172
Author: Ben Milman <bpmilman@...>
Date:   Tue Mar 31 16:58:20 2015 -0700

    UserItem should only let new props change the values currently being edited if it's in response to a change
by the local administrator.

    Ticket: #7931
---
 src/gui/app/jsx/views/Accounts/Users/UserItem.jsx | 37 +++--------------------
 1 file changed, 5 insertions(+), 32 deletions(-)

diff --git a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
index ed0382a..a415b3b 100644
--- a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
+++ b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
 <at>  <at>  -170,14 +170,12  <at>  <at>  var UserEdit = React.createClass({
   , componentWillReceiveProps: function( nextProps ) {
       var newRemoteModified  = {};
       var newLocallyModified = {};
-      var oldLocallyModified = this.state.locallyModifiedValues;

       // remotelyModifiedValues represents everything that's changed remotely
       // since the view was opened. This is the difference between the newly arriving
       // props and the initial ones. Read-only and unknown values are ignored.
-      // TODO: Make this the difference between the initial state OR the last time
(Continue reading)

freenas | 1 Apr 03:24 2015

[freenas/freenas] 8e49503: We're gonna need a switch here to handle other input field types eventually. Get a little bit ahead of the game.

branch: freenas10/development
Repository: freenas/freenas
Pushed by: git
Pushed to: branch freenas10/development
commit 8e495036ec906c45236f05c98cc30c19514b5e0f
Author: Ben Milman <bpmilman@...>
Date:   Tue Mar 31 16:14:23 2015 -0700

    We're gonna need a switch here to handle other input field types eventually. Get a little bit ahead of the game.
---
 src/gui/app/jsx/views/Accounts/Users/UserItem.jsx | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
index e28c265..6a415bc 100644
--- a/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
+++ b/src/gui/app/jsx/views/Accounts/Users/UserItem.jsx
 <at>  <at>  -248,11 +248,20  <at>  <at>  var UserEdit = React.createClass({
   , handleValueChange: function( key, event ) {
       var newValues  = this.state.locallyModifiedValues;
       var inputValue;
-      if (event.target.type === "checkbox") {
-        inputValue = event.target.checked;
-      } else {
-        inputValue = event.target.value;
+
+      // Use different logic to interpret input from different kinds of fields.
+      // TODO: Cover every field in use with different cases as needed.
+      switch (event.target.type) {
+
(Continue reading)

freenas | 1 Apr 02:48 2015

[freenas/freenas] c6c4d5b: Add the ability to exclude the system dataset from a top level recursive snapshot task.

branch: TN-9.3-STABLE
Repository: freenas/freenas
Pushed by: git
Pushed to: branch TN-9.3-STABLE
commit c6c4d5bfa267c3d92f52868cdfb95b7fc02359d4
Author: Josh Paetzel <josh@...>
Date:   Tue Mar 31 17:43:38 2015 -0700

    Add the ability to exclude the system dataset from a top level recursive snapshot task.

    This allows you to recursively replicate an entire pool to another system's top
    level pool.

    Ticket: #8806

    Caveats:

    The GUI will allow you to exclude the system dataset from any replication task.  This
    is a no-op unless it's a recursive task of the entire pool. (We should fix that...)

    If you have snaphots of your system dataset, they will be deleted.  Regardless of when
    or how they were created.  This is neccasary for making this feature work, so deal.

    (cherry picked from commit 1de18e3dfa9aed0edcc5682b690bf374dee69cd7)
---
 ...to__add_field_task_task_excludesystemdataset.py | 130 +++++++++++++++++++++
 gui/storage/models.py                              |   6 +
 gui/tools/autosnap.py                              |   5 +
 3 files changed, 141 insertions(+)

(Continue reading)

freenas | 1 Apr 02:47 2015

[freenas/freenas] a4d772e: Add the ability to exclude the system dataset from a top level recursive snapshot task.

branch: 9.3-STABLE
Repository: freenas/freenas
Pushed by: git
Pushed to: branch 9.3-STABLE
commit a4d772e0ce0318fd031bc1fc276c8f1f784054bc
Author: Josh Paetzel <josh@...>
Date:   Tue Mar 31 17:43:38 2015 -0700

    Add the ability to exclude the system dataset from a top level recursive snapshot task.

    This allows you to recursively replicate an entire pool to another system's top
    level pool.

    Ticket: #8806

    Caveats:

    The GUI will allow you to exclude the system dataset from any replication task.  This
    is a no-op unless it's a recursive task of the entire pool. (We should fix that...)

    If you have snaphots of your system dataset, they will be deleted.  Regardless of when
    or how they were created.  This is neccasary for making this feature work, so deal.

    (cherry picked from commit 1de18e3dfa9aed0edcc5682b690bf374dee69cd7)
---
 ...to__add_field_task_task_excludesystemdataset.py | 130 +++++++++++++++++++++
 gui/storage/models.py                              |   6 +
 gui/tools/autosnap.py                              |   5 +
 3 files changed, 141 insertions(+)

(Continue reading)

freenas | 1 Apr 02:45 2015

[freenas/freenas] 1de18e3: Add the ability to exclude the system dataset from a top level recursive snapshot task.

branch: master
Repository: freenas/freenas
Pushed by: git
Pushed to: branch master
commit 1de18e3dfa9aed0edcc5682b690bf374dee69cd7
Author: Josh Paetzel <josh@...>
Date:   Tue Mar 31 17:43:38 2015 -0700

    Add the ability to exclude the system dataset from a top level recursive snapshot task.

    This allows you to recursively replicate an entire pool to another system's top
    level pool.

    Ticket: #8806

    Caveats:

    The GUI will allow you to exclude the system dataset from any replication task.  This
    is a no-op unless it's a recursive task of the entire pool. (We should fix that...)

    If you have snaphots of your system dataset, they will be deleted.  Regardless of when
    or how they were created.  This is neccasary for making this feature work, so deal.
---
 ...to__add_field_task_task_excludesystemdataset.py | 130 +++++++++++++++++++++
 gui/storage/models.py                              |   6 +
 gui/tools/autosnap.py                              |   5 +
 3 files changed, 141 insertions(+)

diff --git a/gui/storage/migrations/0051_auto__add_field_task_task_excludesystemdataset.py b/gui/storage/migrations/0051_auto__add_field_task_task_excludesystemdataset.py
new file mode 100644
(Continue reading)


Gmane