Robert Watson | 1 May 01:12 2007
Picon

cvs commit: src/sys/netinet in_pcb.c in_pcb.h ip_divert.c raw_ip.c tcp_subr.c udp_usrreq.c src/sys/netinet6 in6_pcb.c in6_src.c

rwatson     2007-04-30 23:12:05 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet          in_pcb.c in_pcb.h ip_divert.c raw_ip.c 
                         tcp_subr.c udp_usrreq.c 
    sys/netinet6         in6_pcb.c in6_src.c 
  Log:
  Rename some fields of struct inpcbinfo to have the ipi_ prefix,
  consistent with the naming of other structure field members, and
  reducing improper grep matches.  Clean up and comment structure
  fields in structure definition.

  Revision  Changes    Path
  1.189     +20 -19    src/sys/netinet/in_pcb.c
  1.96      +61 -31    src/sys/netinet/in_pcb.h
  1.124     +5 -4      src/sys/netinet/ip_divert.c
  1.171     +5 -4      src/sys/netinet/raw_ip.c
  1.276     +8 -7      src/sys/netinet/tcp_subr.c
  1.204     +6 -5      src/sys/netinet/udp_usrreq.c
  1.76      +11 -11    src/sys/netinet6/in6_pcb.c
  1.43      +3 -3      src/sys/netinet6/in6_src.c
_______________________________________________
cvs-src <at> freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-src
To unsubscribe, send any mail to "cvs-src-unsubscribe <at> freebsd.org"

Andrey Chernov | 1 May 02:02 2007
Picon

Re: cvs commit: src/usr.sbin/sysinstall main.c

On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote:
> I think Alfred is absolutely right, and this is a pretty major
> POLA violation. 

That's -current for. Do you suggest to wait yet more N years to commit 
exact that stuff?

> As a result of these changes, I've got two ports
> (so far) and some model checking software that won't build/run
> anymore. 

Please be specific, which ports exactly? Otherwise there is no useful 
information in your statement.

> If we've been doing something right for years, changing
> it around in order to inherit SVR4 bugs seems like a bad
> plan. Holding up your POSIX banner doesn't really make things
> okay; POSIX wasn't written by God, and we choose to ignore various
> parts of it. 

There is no SVR4 bugs in this commit. Just more strict args checking
(which really helps to catch poorly written things and have nothing 
common with SVR4) and clarifying that portable putenv() does not save arg.

Please send all your possible complains to the Open Group, perhaps they 
change standard. Until that we (and software developers which try to make 
things portable) have no other alternative.

Currrently we ignore just very minor things and don't need to increase 
that number without urgent needs. Other things are simple not implemented 
(Continue reading)

Andrey Chernov | 1 May 02:16 2007
Picon

Re: cvs commit: src/libexec/pppoed pppoed.c

On Mon, Apr 30, 2007 at 03:52:37PM -0400, Kris Kennaway wrote:
> On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote:
> > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote:
> > > What impact is this going to have on ports?  Surely there are lots of
> > > them that use putenv().  
> > 
> > If they work under Linux, they already forced to do the right thing. Only 
> > those which are BSD-only may fail.
> > 
> > > Can I assume you're interested in fixing them?
> > 
> > Yes.
> 
> Great, thanks!

Kris, could you please run test build for ports with all changes up to 
sys/param.h in? I want to see how many ports will failed if any. 
Personally me run lots of ports of my machine and didn't notice any bad 
side effect yet.

--

-- 
http://ache.pp.ru/
_______________________________________________
cvs-src <at> freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-src
To unsubscribe, send any mail to "cvs-src-unsubscribe <at> freebsd.org"

Andrey Chernov | 1 May 02:28 2007
Picon

Re: cvs commit: src/usr.sbin/sysinstall main.c

On Tue, May 01, 2007 at 04:02:42AM +0400, Andrey Chernov wrote:
> On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote:
> > I think Alfred is absolutely right, and this is a pretty major
> > POLA violation. 
> 
> That's -current for. Do you suggest to wait yet more N years to commit 
> exact that stuff?

Speaking about POLA, POLA says that valid call to setenv f.e. is in form
setenv("name", "value", 1);
it does not says that hacks like
setenv("name=value", "value", 1);
should be allowed and works.

Moreover, putenv() isn't BSD own function, and was incorrectly implemented 
initially in BSD. BSD implementation just violates original POLA for 
putenv() all other use.

Insisting to keep bug-to-bug compatibility forever leads to nowhere.
And increase porting efforts greately.

--

-- 
http://ache.pp.ru/
_______________________________________________
cvs-src <at> freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-src
To unsubscribe, send any mail to "cvs-src-unsubscribe <at> freebsd.org"

Kris Kennaway | 1 May 02:50 2007

Re: cvs commit: src/libexec/pppoed pppoed.c

On Tue, May 01, 2007 at 04:16:27AM +0400, Andrey Chernov wrote:
> On Mon, Apr 30, 2007 at 03:52:37PM -0400, Kris Kennaway wrote:
> > On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote:
> > > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote:
> > > > What impact is this going to have on ports?  Surely there are lots of
> > > > them that use putenv().  
> > > 
> > > If they work under Linux, they already forced to do the right thing. Only 
> > > those which are BSD-only may fail.
> > > 
> > > > Can I assume you're interested in fixing them?
> > > 
> > > Yes.
> > 
> > Great, thanks!
> 
> Kris, could you please run test build for ports with all changes up to 
> sys/param.h in? I want to see how many ports will failed if any. 
> Personally me run lots of ports of my machine and didn't notice any bad 
> side effect yet.

Will do.

Kris
_______________________________________________
cvs-src <at> freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-src
To unsubscribe, send any mail to "cvs-src-unsubscribe <at> freebsd.org"

(Continue reading)

Roman Kurakin | 1 May 02:59 2007
Picon

Re: cvs commit: src/usr.sbin/sysinstall main.c

Hi,

Since there is some noise around this, could we just scream for a while
that code should be fixed but allow it to still work? After some time than
the majority of the buggy code will be  fixed we will stick to the std
behavior? IMHO this will be less painful.

rik

Andrey Chernov wrote:
> On Tue, May 01, 2007 at 04:02:42AM +0400, Andrey Chernov wrote:
>   
>> On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote:
>>     
>>> I think Alfred is absolutely right, and this is a pretty major
>>> POLA violation. 
>>>       
>> That's -current for. Do you suggest to wait yet more N years to commit 
>> exact that stuff?
>>     
>
> Speaking about POLA, POLA says that valid call to setenv f.e. is in form
> setenv("name", "value", 1);
> it does not says that hacks like
> setenv("name=value", "value", 1);
> should be allowed and works.
>
> Moreover, putenv() isn't BSD own function, and was incorrectly implemented 
> initially in BSD. BSD implementation just violates original POLA for 
> putenv() all other use.
(Continue reading)

Andrey Chernov | 1 May 03:07 2007
Picon

Re: cvs commit: src/usr.sbin/sysinstall main.c

On Tue, May 01, 2007 at 04:59:42AM +0400, Roman Kurakin wrote:
>  Hi,
> 
>  Since there is some noise around this, could we just scream for a while
>  that code should be fixed but allow it to still work? After some time than
>  the majority of the buggy code will be  fixed we will stick to the std
>  behavior? IMHO this will be less painful.

Nice idea, but depends of amount of problem reports I'll got. If the 
number will be small, there is no pain to be std. After my last commit I 
not get any report yet (excepting unclear "some two ports", without 
names).

BTW, screaming can be only for args checking. For putenv() right or 
wrong usage can't be detected inside lib.

--

-- 
http://ache.pp.ru/
_______________________________________________
cvs-src <at> freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-src
To unsubscribe, send any mail to "cvs-src-unsubscribe <at> freebsd.org"

Alfred Perlstein | 1 May 03:39 2007
Picon

Re: cvs commit: src/usr.sbin/sysinstall main.c

Using the strategy "commit to -current then suffer the fallout"
is pretty bogus.

I don't understand why some form of compatibility or #define wasn't
thought out before hand.

This stands out like "fixing select" to record time elapsed into
the timevals, POSIX'ly correct, but incorrect for FreeBSD, without
more thought.

* Andrey Chernov <ache <at> FreeBSD.org> [070430 18:07] wrote:
> On Tue, May 01, 2007 at 04:59:42AM +0400, Roman Kurakin wrote:
> >  Hi,
> > 
> >  Since there is some noise around this, could we just scream for a while
> >  that code should be fixed but allow it to still work? After some time than
> >  the majority of the buggy code will be  fixed we will stick to the std
> >  behavior? IMHO this will be less painful.
> 
> Nice idea, but depends of amount of problem reports I'll got. If the 
> number will be small, there is no pain to be std. After my last commit I 
> not get any report yet (excepting unclear "some two ports", without 
> names).
> 
> BTW, screaming can be only for args checking. For putenv() right or 
> wrong usage can't be detected inside lib.
> 
> -- 
> http://ache.pp.ru/

(Continue reading)

Hidetoshi Shimokawa | 1 May 05:01 2007
Picon

cvs commit: src/sys/geom/uzip g_uzip.c

simokawa    2007-05-01 03:01:15 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/geom/uzip        g_uzip.c 
  Log:
  MFC: rev 1.12
  If compressed length is zero, return a zero-filled block.

  Revision  Changes    Path
  1.4.2.5   +7 -0      src/sys/geom/uzip/g_uzip.c
_______________________________________________
cvs-src <at> freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-src
To unsubscribe, send any mail to "cvs-src-unsubscribe <at> freebsd.org"

Alan Cox | 1 May 05:09 2007
Picon

cvs commit: src/sys/compat/linprocfs linprocfs.c

alc         2007-05-01 03:09:57 UTC

  FreeBSD src repository

  Modified files:
    sys/compat/linprocfs linprocfs.c 
  Log:
  Synchronize vm map and object accesses.

  Approved by: des <at> 

  Revision  Changes    Path
  1.112     +26 -8     src/sys/compat/linprocfs/linprocfs.c
_______________________________________________
cvs-src <at> freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-src
To unsubscribe, send any mail to "cvs-src-unsubscribe <at> freebsd.org"


Gmane