Jon TURNEY | 21 Apr 19:02 2014
Picon

[PATCH] minidumper patches


Attached are a couple of patches for the minidumper utility which could
probably use some review.

The first one changes to direct linkage with dbghelp, rather than using
GetProcAddress().

(This seems to be the current style, I assume since the reasons for not
directly linking (no import libs or Windows versions which don't have the
.dll) are no longer relevant.)

As suggested, the second one changes the default dump type to something with
more information that just MiniDumpNormal, without getting too big.

(This is complicated by the fact that it appears to be an error to call
MiniDumpWriteDump() with an unknown dump flag, but the documentation for which
dump flags are supported by which dbhelp.dll version and how
ImagehlpApiVersionEx() is supposed to work is not totally clear)
Link directly with dbghelp

2014-04-21  Jon TURNEY  <jon.turney <at> dronecode.org.uk>

	* Makefile.in (minidumper.exe): Link directly with dbghelp.
	* minidumper.cc (minidump): Ditto.

---
 utils/Makefile.in   |    1 +
 utils/minidumper.cc |   47 ++++++++++-------------------------------------
(Continue reading)

Weber, Mark | 20 Mar 22:10 2014

patch for command line containing equals sign


See
http://cygwin.com/ml/cygwin-patches/2014-q1/msg00017.html
and related.

Thanks for posting how the new behavior is different from the old.
I am having a related issue, with C++ code that parses the command line.

The command line we support is something like -
  program_name   arg1  -option1=val1  -option2=val2  ...

You get the idea.

Now, with the above mentioned Cygwin patch, we are seeing the input arguments

arg1  "-option1=val1"   "-option2=val2"  ...

If this were the extent of the issue, it would be no big deal to strip off the quotes. However, the user may have
put quotes on the command line himself, which Cygwin now moves around.
Such as:
  program_name  arg1  -option1="file name with spaces in it"

Is there any way to reliably tell what the user entered on the command line?

Oleg Kravtsov | 3 Mar 19:34 2014
Picon

[PATCH] Fix errno codes set by opendir() in case of problems with the path argument

Currently cygwin has a problem with errno code set by opendir() 
function. It always sets errno to ENOENT.
After applying the path opendir() sets errno to 'ENAMETOOLONG' when path 
or a path component is too long,
'ELOOP' when a loop of symbolic links exits in the path.

Best regards,
Oleg

2014-02-18  Oleg Kravtsov <Oleg.Kravtsov <at> oktetlabs.ru>

        * dir.cc (opendir): Set errno code depending on the type of an error
        instead of always setting it to ENOENT.

Attachment (opendir_errno_fix.patch): text/x-diff, 858 bytes
Ray Donnelly | 9 Feb 01:25 2014
Picon

[PATCH] Expand $CYGWIN error_start processing

I want to use QtCreator as my debugger but the hardcoded
nature of error_start makes that impossible.

This change allows a formatted commandline to be used where
'|' is used to represent spaces and <program-name> and
<process-id> are special tokens.

In my case, I set my CYGWIN env. var to
error_start:C:/Qt/bin/qtcreator.exe|-debug|<process-id>

.. note, QtCreator doesn't work if passed the program name
and must be invoked with the -debug option.

Ray Donnelly (1):
  * winsup/cygwin/exceptions.cc: Expand $CYGWIN error_start          
    processing so that custom commandlines can be passed to          
    the debugger program using '|' as an argument delimiter          
    and <program-name> and <process-id> as special tokens.

 winsup/cygwin/exceptions.cc | 50 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 46 insertions(+), 4 deletions(-)

--

-- 
1.8.5.4

Jon TURNEY | 7 Feb 17:36 2014
Picon

[PATCH] Add minidump write utility


This patch adds a 'minidumper' utility, which functions identically to
'dumper' except it writes a Windows minidump, rather than a core file.
	
I'm not sure if this is of use to anyone but me, but since I've had the patch
sitting around for a couple of years, here it is...

2014-02-07  Jon TURNEY  <jon.turney <at> dronecode.org.uk>

	* minidumper.cc: New file.
	* Makefile.in (CYGWIN_BINS): Add minidumper.
	* utils.xml (minidumper): New section.
Index: utils/Makefile.in
===================================================================
RCS file: /cvs/src/src/winsup/utils/Makefile.in,v
retrieving revision 1.113
diff -u -u -p -r1.113 Makefile.in
--- utils/Makefile.in	19 Nov 2013 11:14:36 -0000	1.113
+++ utils/Makefile.in	14 Jan 2014 00:01:13 -0000
 <at>  <at>  -56,7 +56,7  <at>  <at>  MINGW_CXX      :=  <at> MINGW_CXX <at> 

 # List all binaries to be linked in Cygwin mode.  Each binary on this list
 # must have a corresponding .o of the same name.
-CYGWIN_BINS := ${addsuffix .exe,cygpath getconf getfacl ldd locale kill mkgroup \
+CYGWIN_BINS := ${addsuffix .exe,cygpath getconf getfacl ldd locale kill minidumper mkgroup \
         mkpasswd mount passwd pldd ps regtool setfacl setmetamode ssp tzset umount}

 # List all binaries to be linked in MinGW mode.  Each binary on this list
(Continue reading)

Adam Dinwoodie | 29 Jan 17:46 2014

[PATCH] Snapshot install instructions use bz2, not xz

All,

I've attached a minor correction to the FAQ entry on installing
snapshots, to note that snapshots are now .xz archives, rather than
.bz2.

I've not been able to build this: the docs build requires "fop", which
isn't available in the main Cygwin repositories, and I don't
particularly want to set up this machine to start pulling packages from
Cygwin Ports.

2014-01-29  Adam Dinwoodie

	* faq-setup.xml (faq.setup.snapshots): Use .xz not .bz2.
Attachment (faq-patch.diff): text/x-diff, 1396 bytes
Daniel Dai | 20 Jan 07:02 2014
Picon

[PATCH] Fix parameter passing containing quote/equal to Windows batch command

We notice one issue when running a Windows batch command inside
cygwin. Here is one example.

Simple batch file:
a.bat:
echo %1

Run it under cygwin:
./a.bat a=b
a

./a.bat "a=b"
a

If we pass additional \"
./a.bat "\"a=b\""
"\"a

There seems no way to pass a=b into bat.

Attach quote.patch contains a fix. It does two things:
1. If the parameter contains a equal sign, automatically add quote
(similar to space, tab, new line, quote cygwin already do)
2. If the parameter is already quoted, don't quote again

Patch:
Index: cygwin/winf.cc
==============================
=====================================
RCS file: /cvs/src/src/winsup/cygwin/winf.cc,v
(Continue reading)

Christopher Faylor | 8 Jan 06:47 2014

Some of my email didn't go through in December

I changed my email configuration in December and that resulted in some
sourceware.org mailing lists not thinking I was subscribed.  So some of
my timely responses to messages here are showing up here in an untimely
manner.

I noticed this when Corinna made the same observation that I thought I
had and then realized that my messages had never shown up.

FYI.

cgf

Ray Donnelly | 7 Jan 17:31 2014
Picon

Request for feedback on 3 patches I posted in December.

Hi,

Could someone please look over these and give me some feedback?

http://www.cygwin.com/ml/cygwin-patches/2013-q4/msg00017.html
http://www.cygwin.com/ml/cygwin-patches/2013-q4/msg00018.html
http://www.cygwin.com/ml/cygwin-patches/2013-q4/msg00019.html

Cheers,

Ray.

Corinna Vinschen | 7 Jan 16:12 2014

Re: [PATCH] Reattach trailing dirsep on existing directories too.

On Dec 22 01:03, Ray Donnelly wrote:
> I hope this is OK and I've done it in the best place. Please advise if
> it needs any changes.

I have no idea if this is ok.  This is a patch to a very crucial
function in terms of path handling, and it's not clear that this isn't
doing the wrong thing.  What is this patch trying to accomplish?  Do you
have example user space code which is failing for this very reason?

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
Mark Geisert | 31 Dec 06:35 2013

[PATCH] FAQ update: packages needed to build Cygwin

Hope I'm doing this correctly.  Here is the ChangeLog entry followed by 
the patch.  I wasn't sure if patch originator or patch committer, if 
different, gets their name in the ChangeLog entry.  Patch rationale 
available on request.
Cheers,

..mark

====

2013-12-31  Mark Geisert  <mark <at> maxrnd.com>

 	* faq-programming.xml: Update packages needed to build Cygwin.

====

Index: faq-programming.xml
===================================================================
RCS file: /cvs/src/src/winsup/doc/faq-programming.xml,v
retrieving revision 1.27
diff -u -r1.27 faq-programming.xml
--- faq-programming.xml 5 Jun 2013 07:57:39 -0000       1.27
+++ faq-programming.xml 31 Dec 2013 05:25:33 -0000
 <at>  <at>  -693,11 +693,19  <at>  <at> 
  <answer>

  <para>First, you need to make sure you have the necessary build tools
-installed; you at least need <literal>gcc</literal>, <literal>make</literal>,
-<literal>perl</literal>, and <literal>cocom</literal>. If you want to run
-the tests, <literal>dejagnu</literal> is also required.
(Continue reading)


Gmane