Lev Bishop | 19 Nov 20:30 2014
Picon

Re: Fix performance on 10Gb networks

Maybe my analysis from some years ago can be relevant here? Another
issue with delayed acks and winsock. I haven't been following cygwin
for some time, so not sure exactly what the status is:
https://cygwin.com/ml/cygwin-patches/2006-q2/msg00031.html

Lev

--

-- 
Lev Bishop

Iuliu Rus | 18 Nov 20:30 2014
Picon

Fix performance on 10Gb networks

Hello,
Google is running Cygwin apps on its 10Gb networks and we are seeing
extremely bad performance in a couple of cases. For example, iperf
with the defaults results in only 10Mbits/sec.
We tracked this down to a combination of non-blocking sockets with
Nagle+delayed ack kicking in, since the apps eventually end up sending
a very small packets (2 bytes).
We have a case open against Microsoft but since everything is moving
very slow we would like to work around by picking socket buffers that
are multiple of 4k.

Change log:
2014-11-18 Iuliu Rus <rus.iuliu <at> gmail.com>

* net.cc Change default values for socket buffers to fix performance
on 10Gb networks.
Attachment (net_patch): application/octet-stream, 1969 bytes
Christian Franke | 25 Sep 14:40 2014
Picon

[PATCH] Disable AF_UNIX handshake with setsockopt(..., SO_PEERCRED, ...)

This is a workaround for this problem which blocks ITP postfix:
https://cygwin.com/ml/cygwin/2014-08/msg00420.html

With the patch, this disables the secret+cred handshakes of the AF_UNIX 
emulation:

int sd = socket(AF_UNIX, SOCK_STREAM, 0);

setsockopt(sd, SOL_SOCKET, SO_PEERCRED, NULL, 0);

Postfix works if socket() calls are replaced by the above.

Calls of getsockopt(..., SO_PEERCRED, ...) and getpeereid() would fail with ENOTSUP then. These are not
used by postfix.

Christian

Christian Franke | 23 Sep 18:01 2014
Picon

[PATCH] Fix crash of ffs (0x80000000) on 64 bit

This fixes the issue reported here:
https://cygwin.com/ml/cygwin/2014-09/msg00341.html

On 64 bit, i = 0x80000000 results in x = 0xffffffff80000000 due to sign 
extension.

Christian

Christian Franke | 7 Aug 22:15 2014
Picon

[PATCH] cygcheck -m, --check-mtimes option

Attached is an experimental patch which adds -m, 
--check-mtimes[=SECONDS] option to cygcheck. It provides an IMO useful 
heuristics to find files possibly modified after installation.

"cygcheck -c -m" prints the number of files with st_mtime > 
INSTALL_TIME+SECONDS. INSTALL_TIME is the st_mtime of the 
/etc/setup/PACKAGE.lst.gz file.

With -v, the affected path names are printed. The optional parameter 
SECONDS defaults to 600 to hide files modified by postinstall scripts.

Documentation update and changelog entry are still missing.

Christian

Eric Blake | 2 Aug 15:27 2014
Picon

docs: improve package maintainer instructions

I noticed that the main link on the cygwin.com left navbar
(https://cygwin.com/setup.html#submitting) has outdated instructions;
rather than duplicate things, I'd rather have a link to the more
up-to-date page
(https://sourceware.org/cygwin-apps/package-upload.html).  Okay to push?

2014-08-02  Eric Blake  <eblake <at> redhat.com>

	* setup.html: Modernize, point to package-upload.html

--

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment (setup.patch): text/x-patch, 18 KiB
Eric Blake | 31 Jul 18:07 2014
Picon

namespace safety with attributes

As pointed out here:
https://cygwin.com/ml/cygwin/2014-07/msg00371.html

any use of __attribute__ in a header that can be included by a user
should be namespace-safe, by decorating the attribute arguments with __
(while gcc does a lousy job at documenting it, ALL attributes have a __
counterpart, precisely so that public headers can use attributes without
risk of collision with macros belonging to user namespace).

2014-07-31  Eric Blake  <eblake <at> redhat.com>

	* include/pthread.h: Decorate attribute names with __, for
	namespace safety.
	* include/cygwin/core_dump.h: Likewise.
	* include/cygwin/cygwin_dll.h: Likewise.
	* include/sys/cygwin.h: Likewise.
	* include/sys/strace.h: Likewise.

--

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment (decorate.patch): text/x-patch, 8157 bytes
Yaakov Selkowitz | 14 Jul 01:38 2014

[PATCH] default to normal pthread mutexes

Defaulting to ERRORCHECK mutexes (with the various stringencies it 
implies) does not match the behaviour on Linux, where NORMAL mutexes are 
the default.  I have been testing this locally for some time, and I 
believe it affects a lot of software.  Patch and STC attached.

Yaakov
2014-07-13  Yaakov Selkowitz  <yselkowitz <at> ...>

	* thread.cc (pthread_mutex::pthread_mutex): Change default type
	to PTHREAD_MUTEX_NORMAL.
	(pthread_mutexattr::pthread_mutexattr): Ditto.
	(pthread_mutex_unlock): Do not fail if mutex is a normal mutex
	initializer.
	* include/pthread.h (PTHREAD_MUTEX_INITIALIZER): Redefine as
	PTHREAD_NORMAL_MUTEX_INITIALIZER_NP.

Index: thread.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/thread.cc,v
retrieving revision 1.287
diff -u -p -r1.287 thread.cc
--- thread.cc	1 Dec 2013 10:27:16 -0000	1.287
+++ thread.cc	26 Mar 2014 04:24:08 -0000
 <at>  <at>  -1708,7 +1708,7  <at>  <at>  pthread_mutex::pthread_mutex (pthread_mu
   tid (0),
 #endif
   recursion_counter (0), condwaits (0),
-  type (PTHREAD_MUTEX_ERRORCHECK),
(Continue reading)

Warren Young | 19 Jun 17:51 2014

/packages CGI HTML modernization

The current CGI code that generates the package and file lists for 
http://cygwin.com/packages emits highly redundant HTML, and it is laid 
out using a huge slow-to-render table.  The attached patch shows a 
minimal way to use <ul> instead of <table>, along with some CSS and JS 
to style it in a similar way to the current look.

If JavaScript is verboten on cygwin.com, you can empirically find an 
appropriate value for the width of the package name column and put that 
in the CSS:

     ul.pkglist span {
         float: left;
         width: 185px;
     }

All the jQuery code does is find that width value programmatically, 
which makes it robust in the face of different font sizes and such.

I have also attached a simple example HTML and CSS file, which show the 
basic idea of the change with all the distractions of the real /packages 
page stripped away.  Just put packages.* in a directory and open 
packages.html in your favorite browser.

I lack the ability to generate packages.inc here, but I expect applying 
the same concept to that script as well will have a measurable effect on 
the load time of cygwin.com/packages.  I expect it to roughly halve the 
size of the file and measurably reduce the page render time.

The contents of the attached CSS file should be inserted into one of 
cygwin.com's normal CSS files.
(Continue reading)

Denis Excoffier | 6 Jun 19:08 2014

typo correction in grp.cc

Hello,

The following patch (or equivalent) is needed in order for /usr/bin/id to return the full set of groups
in case the user given as argument belongs to more than 10 groups:

diff -uNr cygwin-snapshot-20140523-1.original/winsup/cygwin/grp.cc cygwin-snapshot-20140523-1.patched/winsup/cygwin/grp.cc
--- cygwin-snapshot-20140523-1.original/winsup/cygwin/grp.cc	2014-05-23 12:31:13.000000000 +0200
+++ cygwin-snapshot-20140523-1.patched/winsup/cygwin/grp.cc	2014-05-26 15:08:37.542897300 +0200
 <at>  <at>  -656,11 +656,11  <at>  <at> 
 	  groups[cnt] = grp->gr_gid;
 	++cnt;
       }
-  *ngroups = cnt;
   if (cnt > *ngroups)
     ret = -1;
   else
     ret = cnt;
+  *ngroups = cnt;

   syscall_printf ( "%d = getgrouplist(%s, %u, %p, %d)",
 		  ret, user, gid, groups, *ngroups);

Please apply.

Regards,

Denis Excoffier.
Christopher Faylor | 25 May 05:53 2014

Re: Rename detached debug info as cygwin1.dll.dbg

On Fri, May 23, 2014 at 04:05:34PM +0200, Corinna Vinschen wrote:
>On May 23 14:40, Jon TURNEY wrote:
>> 
>> Not sure if this is wanted, and it obviously has some knock on effects on
>> package and snapshot generation.
>> 
>> But, cygport names detached debug info files by appending the .dbg suffix.
>> This is 'obviously correct' as it means that both a foo.exe and foo.dll can
>> exist and have detached debug info.
>> 
>> For consistency, the attached patch changes the name of the detached debug
>> info file for cygwin1.dll from cygwin1.dbg to cygwin1.dll.dbg
>
>As far as releases go, this is ok.  I'll just have to tweak the next
>cygport file slightly.
>
>Chris might have to tweak the snapshot generation script as well, so
>he probably wants to chime in, too.

It's more than just a tweak.  I've known that there is a discrepancy for
a long time but haven't considered it that big a deal.  I'd prefer that
this change not be made.


Gmane