a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Christian Franke | 1 Dec 2008 20:23

Picon

[Patch] Encode invalid chars in /proc/registry entries (merge from 1.5)

This is a 1.5->1.7 merge of my patch from 
http://sourceware.org/ml/cygwin-patches/2007-q4/msg00017.html

Christian

2008-12-01  Christian Franke  <franke <at> computer.org>

	* fhandler_registry.cc (must_encode): New function.
	(encode_regname): Ditto.
	(decode_regname): Ditto.
	(fhandler_registry::exists): Encode name before path compare.
	(fhandler_registry::fstat): Pass decoded name to win32 registry call.
	(fhandler_registry::readdir): Return encoded name to user.
	(fhandler_registry::open): Store decoded name into value_name.
	(open_key): Pass decoded name to win32 registry call

Attachment (cygwin-1.7-regnames-encode.patch): text/x-patch, 4474 bytes

Corinna Vinschen | 2 Dec 2008 12:46

Re: [Patch] Encode invalid chars in /proc/registry entries (merge from 1.5)

On Dec  1 20:23, Christian Franke wrote:
> This is a 1.5->1.7 merge of my patch from 
> http://sourceware.org/ml/cygwin-patches/2007-q4/msg00017.html
>
> Christian
>
>
> 2008-12-01  Christian Franke  <franke <at> computer.org>
>
> 	* fhandler_registry.cc (must_encode): New function.
> 	(encode_regname): Ditto.
> 	(decode_regname): Ditto.
> 	(fhandler_registry::exists): Encode name before path compare.
> 	(fhandler_registry::fstat): Pass decoded name to win32 registry call.
> 	(fhandler_registry::readdir): Return encoded name to user.
> 	(fhandler_registry::open): Store decoded name into value_name.
> 	(open_key): Pass decoded name to win32 registry call

Patch applied.

Thanks,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Pierre A. Humblet | 3 Dec 2008 17:25

Picon

[Patch] Minires update

This patch syncs the built-in minires with the latest packaged version.
Also attaching the files to guarantee format preservation.

Pierre

2008-12-03  Pierre A. Humblet  <Pierre.Humblet <at> ieee.org>

        * libc/minires.c (open_sock): Set non blocking and close on exec.
        (res_ninit): Set id pseudo-randomly.
        (res_nsend): Do not set close on exec. Initialize server from id.
        Flush socket. Tighten rules for answer acceptance.
        (res_nmkquery): Update id using current data.

Index: minires.c
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/libc/minires.c,v
retrieving revision 1.4
diff -u -p -r1.4 minires.c
--- minires.c 1 Apr 2008 10:22:33 -0000 1.4
+++ minires.c 3 Dec 2008 02:57:26 -0000
 <at>  <at>  -1,6 +1,6  <at>  <at> 
 /* minires.c.  Stub synchronous resolver for Cygwin.

-   Copyright 2006 Red Hat, Inc.
+   Copyright 2008 Red Hat, Inc.

    Written by Pierre A. Humblet <Pierre.Humblet <at> ieee.org>

 <at>  <at>  -225,6 +225,17  <at>  <at>  static int open_sock(struct sockaddr_in 
     DPRINTF(debug, "socket(UDP): %s\n", strerror(errno));

(Continue reading)

Corinna Vinschen | 3 Dec 2008 17:40

Re: [Patch] Minires update

On Dec  3 11:25, Pierre A. Humblet wrote:
> This patch syncs the built-in minires with the latest packaged version.
> Also attaching the files to guarantee format preservation.
> 
> Pierre
> 
> 2008-12-03  Pierre A. Humblet  <Pierre.Humblet <at> ieee.org>
> 
>         * libc/minires.c (open_sock): Set non blocking and close on exec.
>         (res_ninit): Set id pseudo-randomly.
>         (res_nsend): Do not set close on exec. Initialize server from id.
>         Flush socket. Tighten rules for answer acceptance.
>         (res_nmkquery): Update id using current data.

Applied with a very minor change:

> Index: minires.c
> ===================================================================
> RCS file: /cvs/src/src/winsup/cygwin/libc/minires.c,v
> retrieving revision 1.4
> diff -u -p -r1.4 minires.c
> --- minires.c 1 Apr 2008 10:22:33 -0000 1.4
> +++ minires.c 3 Dec 2008 02:57:26 -0000
>  <at>  <at>  -1,6 +1,6  <at>  <at> 
>  /* minires.c.  Stub synchronous resolver for Cygwin.
>  
> -   Copyright 2006 Red Hat, Inc.
> +   Copyright 2008 Red Hat, Inc.

The Copyright should keep the old dates, like this:

(Continue reading)

Christian Franke | 4 Dec 2008 21:49

Picon

[Patch] Avoid duplicate names in /proc/registry (which may crash find)

Here is a simple approach to handle the duplicate key/value name problem 
in /proc/registry. A value is skipped if key with same name exists. 
Number of actual key existence checks are reduced by a simple hash table.

The patch also adds dirent.d_type support, find does no longer crash.

Christian

2008-12-04  Christian Franke  <franke <at> computer.org>

	* fhandler_registry.cc (__DIR_hash): New class.
	(d_hash): New macro.
	(key_exists): New function.
	(fhandler_registry::readdir): Allocate __DIR_hash.
	Record key names in hash table. Skip value if key
	with same name exists. Fix error handling of
	encode_regname (). Set dirent.d_type.
	(fhandler_registry::closedir): Delete __DIR_hash.

Attachment (cygwin-1.7-registry-nodups.patch): text/x-patch, 3526 bytes

Corinna Vinschen | 5 Dec 2008 10:57

Re: [Patch] Avoid duplicate names in /proc/registry (which may crash find)

On Dec  4 21:49, Christian Franke wrote:
> Here is a simple approach to handle the duplicate key/value name problem in 
> /proc/registry. A value is skipped if key with same name exists. Number of 
> actual key existence checks are reduced by a simple hash table.
>
> The patch also adds dirent.d_type support, find does no longer crash.
>
> Christian
>
>
> 2008-12-04  Christian Franke  <franke <at> computer.org>
>
> 	* fhandler_registry.cc (__DIR_hash): New class.
> 	(d_hash): New macro.
> 	(key_exists): New function.
> 	(fhandler_registry::readdir): Allocate __DIR_hash.
> 	Record key names in hash table. Skip value if key
> 	with same name exists. Fix error handling of
> 	encode_regname (). Set dirent.d_type.
> 	(fhandler_registry::closedir): Delete __DIR_hash.

That looks like a quite neat idea to rectify this problem but, now that
I think of it I'm wondering if this isn't a good starting point for
a better solution as you proposed on the Cygwin list.

So let's assume there's a key and a value with the same name. 

The old implementation just ignored the problem.  Trying to access the
value failed because the value was simply shadowed by the key.  `cat
foo' returned "is a directory" or something.

(Continue reading)

Christian Franke | 5 Dec 2008 23:23

Picon

Re: [Patch] Avoid duplicate names in /proc/registry (which may crash find)

Corinna Vinschen wrote:
> On Dec  4 21:49, Christian Franke wrote:
>   
>> Here is a simple approach to handle the duplicate key/value name problem in 
>> /proc/registry. A value is skipped if key with same name exists. Number of 
>> actual key existence checks are reduced by a simple hash table.
>>
>> ...
>>     
>
> That looks like a quite neat idea to rectify this problem but, now that
> I think of it I'm wondering if this isn't a good starting point for
> a better solution as you proposed on the Cygwin list.
>
>   

Yes, it is ... see below.

> So let's assume there's a key and a value with the same name. 
>
> The old implementation just ignored the problem.  Trying to access the
> value failed because the value was simply shadowed by the key.  `cat
> foo' returned "is a directory" or something.
>
> The now proposed solution hides the value instead.  There just isn't a
> value of that name anymore.  In the end, the result is the same.
> Accessing the value still doesn't work.
>
>

(Continue reading)

Corinna Vinschen | 7 Dec 2008 18:18

Re: [Patch] Avoid duplicate names in /proc/registry (which may crash find)

Hi Christian,

On Dec  5 23:23, Christian Franke wrote:
> Corinna Vinschen wrote:
>> Maybe ".val" is already a good suffix?
>
> I would prefer "%val" to avoid any extra encoding for names using ".val". 
> The "%" is already used as an escape char, so "%val" in a name would appear 
> as "%25val"

Very good idea!

> With the attached patch, a duplicate name "foo" is handled as follows:
>
> - readdir() returns the key as "foo" and the value as "foo%val".
> - If the name is "foo%val", stat() and open() consider only the value 
> "foo".
>
> This keeps the names 'as is' if possible and allows access to the (very 
> few) entries with duplicate names. The "%val" is at least somewhat 
> self-explanatory.

Cool.  Can you please send a ChangeLog entry as well?

Thanks,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com

(Continue reading)

Christian Franke | 7 Dec 2008 20:03

Picon

Re: [Patch] Avoid duplicate names in /proc/registry (which may crash find)

Hi Corinna,

Corinna Vinschen wrote:
> ...
>> With the attached patch, a duplicate name "foo" is handled as follows:
>>
>> - readdir() returns the key as "foo" and the value as "foo%val".
>> - If the name is "foo%val", stat() and open() consider only the value 
>> "foo".
>>
>> This keeps the names 'as is' if possible and allows access to the (very 
>> few) entries with duplicate names. The "%val" is at least somewhat 
>> self-explanatory.
>>     
>
> Cool.  Can you please send a ChangeLog entry as well?
>
>   

Of course:

2008-12-07  Christian Franke  <franke <at> computer.org>

	* fhandler_registry.cc (encode_regname): Add Parameter add_val.
	Append "%val" if add_val is set.
	(decode_regname): Remove trailing "%val". Change returncode
	accordingly.
	(__DIR_hash): New class.
	(d_hash): New macro.
	(key_exists): New function.

(Continue reading)

Corinna Vinschen | 8 Dec 2008 12:48

Re: [Patch] Avoid duplicate names in /proc/registry (which may crash find)

On Dec  7 20:03, Christian Franke wrote:
> Corinna Vinschen wrote:
>> ...
>>> With the attached patch, a duplicate name "foo" is handled as follows:
>>>
>>> - readdir() returns the key as "foo" and the value as "foo%val".
>>> - If the name is "foo%val", stat() and open() consider only the value 
>>> "foo".
>>[...]
>> Cool.  Can you please send a ChangeLog entry as well?
>
> Of course:

Thanks!  Patch applied.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Group

gmane.os.cygwin.patches.

Project Web Page

a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Search Archive

Page

1 | 2 | 3 | 4

Articles in period: 35

December 2008

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

May I remove setup.xml and cygwin-ug.xml? (10 May 2013)
[PATCH] fix GCC 4.7 warnings (30 Apr 2013)
Forgotted appersand (2 Apr 2013)
[PATCH 64bit] Fix ONDEE for 64bit, part 2 (20 Mar 2013)
[PATCH 64bit] Fix ONDEE for 64bit (4 Mar 2013)
[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target, part 2 (21 Feb 2013)
[PATCH] Missing dllimport's in (21 Feb 2013)
[PATCH] utils: force static linkage (20 Feb 2013)
[PATCH 64bit] Export symbols with underscore (20 Feb 2013)
[PATCH 64bit] ssize_t (20 Feb 2013)
Qsort defects (in C-library) (18 Feb 2013)
[PATCH 64bit] Fix speclib for x86_64 (17 Feb 2013)
[PATCH 64bit] utils: port dumper to 64bit (15 Feb 2013)
[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target (15 Feb 2013)
Console modes: cursor style (11 Jan 2013)
[PATCH] waitpid(2) WAIT_* macros (6 Dec 2012)
[PATCH] add cfsetspeed (21 Nov 2012)
[WIP] mingw64 related changes to Cygwin configure and other assorted f (12 Nov 2012)
[PATCH] additional sys/termios.h defines (5 Nov 2012)
[patch cygwin]: Rename strechr to strchrnul (26 Oct 2012)
Fwd: Re: [patch]: Decouple cygwin building from in-tree mingw/w32api b (24 Oct 2012)

Archives

13	May 2013
11	April 2013
22	March 2013
44	February 2013
7	January 2013
2	December 2012
19	November 2012
44	October 2012
11	September 2012
21	August 2012
12	July 2012
14	June 2012
7	May 2012
27	April 2012
20	March 2012
18	February 2012
16	January 2012
28	December 2011
18	November 2011
21	October 2011
5	September 2011
42	August 2011
39	July 2011
5	June 2011
135	May 2011
50	April 2011
34	March 2011
41	February 2011
14	January 2011
10	December 2010
4	November 2010
9	October 2010
48	September 2010
23	August 2010
8	July 2010
4	June 2010
15	May 2010
4	April 2010
22	March 2010
60	February 2010
51	January 2010
25	December 2009
50	November 2009
136	October 2009
60	September 2009
24	August 2009
39	July 2009
20	June 2009
7	May 2009
62	April 2009
37	March 2009
10	February 2009
9	January 2009
35	December 2008
11	November 2008
6	September 2008
7	August 2008
6	July 2008
2	June 2008
6	April 2008
77	March 2008
10	February 2008
16	January 2008
47	December 2007
31	November 2007
10	September 2007
9	August 2007
4	July 2007
18	June 2007
28	May 2007
25	April 2007
20	March 2007
2	February 2007
13	January 2007
9	December 2006
19	November 2006
9	October 2006
6	September 2006
29	August 2006
47	July 2006
21	June 2006
39	May 2006
33	April 2006
34	March 2006
51	February 2006
39	January 2006
5	December 2005
15	November 2005
14	October 2005
18	September 2005
39	August 2005
52	July 2005
45	June 2005
80	May 2005
16	April 2005
43	March 2005
34	February 2005
30	January 2005
122	December 2004
67	November 2004
109	October 2004
73	September 2004
41	August 2004
38	July 2004
50	June 2004
98	May 2004
53	April 2004
67	March 2004
36	February 2004
36	January 2004
53	December 2003
122	November 2003
55	October 2003
125	September 2003
125	August 2003
47	July 2003
63	June 2003
79	May 2003
69	April 2003
114	March 2003
189	February 2003
119	January 2003
102	December 2002
155	November 2002
44	October 2002
146	September 2002
89	August 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template