use volatile when replacing Interlocked*

Based on a recent patch to the win32 headers
(http://cygwin.com/ml/cygwin-cvs/2008-q2/msg00157.html), the Interlocked*
functions in winbase.h are now properly prototyped to take volatile
arguments.  This patch makes cygwin match.

2008-07-12  Eric Blake  <ebb9 <at> byu.net>

	Fix usage of recently fixed Interlocked* functions.
	* winbase.h (ilockincr, ilockdecr, ilockexch, ilockcmpexch): Add
	volatile qualifier, to match Interlocked* functions.

--
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9 <at> byu.net

Re: use volatile when replacing Interlocked*

On Jul 12 06:25, Eric Blake wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Based on a recent patch to the win32 headers
> (http://cygwin.com/ml/cygwin-cvs/2008-q2/msg00157.html), the Interlocked*
> functions in winbase.h are now properly prototyped to take volatile
> arguments.  This patch makes cygwin match.
>
> 2008-07-12  Eric Blake  <ebb9 <at> byu.net>
>
> 	Fix usage of recently fixed Interlocked* functions.
> 	* winbase.h (ilockincr, ilockdecr, ilockexch, ilockcmpexch): Add
> 	volatile qualifier, to match Interlocked* functions.

You missed to attach the patch, apparantly :)

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Re: use volatile when replacing Interlocked*

|> 2008-07-12  Eric Blake  <ebb9 <at> byu.net>
|>
|> 	Fix usage of recently fixed Interlocked* functions.
|> 	* winbase.h (ilockincr, ilockdecr, ilockexch, ilockcmpexch): Add
|> 	volatile qualifier, to match Interlocked* functions.
|
| You missed to attach the patch, apparantly :)

I hate it when that happens.

--
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9 <at> byu.net

Index: winbase.h
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/winbase.h,v
retrieving revision 1.13
diff -u -p -r1.13 winbase.h
--- winbase.h	7 Jun 2005 19:31:42 -0000	1.13
+++ winbase.h	12 Jul 2008 12:20:43 -0000
 <at>  <at>  -1,6 +1,6  <at>  <at> 
 /* winbase.h

-   Copyright 2002, 2003, 2004 Red Hat, Inc.
+   Copyright 2002, 2003, 2004, 2008 Red Hat, Inc.

Re: use volatile when replacing Interlocked*

On Sat, Jul 12, 2008 at 10:07:59AM -0600, Eric Blake wrote:
> |> 2008-07-12  Eric Blake  <ebb9 <at> byu.net>
> |>
> |> 	Fix usage of recently fixed Interlocked* functions.
> |> 	* winbase.h (ilockincr, ilockdecr, ilockexch, ilockcmpexch): Add
> |> 	volatile qualifier, to match Interlocked* functions.

Looks pretty uncontroversial.  Please check in.

Thanks.

cgf

cygcheck linking without libz

"godlygeek" in IRC just came across a bug with building cygcheck where
mingw-zlib is not installed.  The link fails with undefined symbols
because -lntdll is only specified if libz is present.  (bloda.cc
requires ntdll regardless of the zlib usage.)

Patch attached.

Yaakov

Re: cygcheck linking without libz

On Wed, Jul 30, 2008 at 12:57:26AM -0500, Yaakov (Cygwin Ports) wrote:
>+2008-07-30  Yaakov Selkowitz  <yselkowitz <at> users.sourceforge.net>
>+
>+	* Makefile.in: Link cygcheck with -lntdll even without mingw-zlib.

Applied.  Thanks.

(Btw, minor nit: Please don't post ChangeLog entries as a patch.  Just
send the ChangeLog entry as-is)

cgf