Re: Bug fix and enchantment in cygpath.cc

Corinna Vinschen wrote:
> On Jul 30 16:24, Ilya wrote:
>   
>> Corinna Vinschen wrote:
>>     
>>> On Jul 29 12:29, Ilya wrote:
>>>  
>>>       
>>>> This patch is against cygpath.cc 1.42.
>>>> In 1.43 addressed bug was already fixed, but I believe my fix is a bit 
>>>> better.
>>>>
>>>> Current fix just returns filename, in case filename is for a nonexistent 
>>>> file.  I think that internal short to long file name conversion routine 
>>>> could be used in this case, because it deals ok with nonexistent files.
>>>>    
>>>>         
>>> If you could regenerate your patch so that it's against current CVS, I
>>> will take it, since its size will then be below the "trivial fix" rule.
>>> Please see http://cygwin.com/contrib.html, "Before you get started",
>>> second paragraph.
>>>
>>>
>>> Thanks,
>>> Corinna
>>>  
>>>       
>> No problem :)
>> [...]
>> 	* cygpath.cc (get_long_name): Fallback to get_long_path_name_w32impl.

Re: Bug fix and enchantment in cygpath.cc

On May 12 15:47, Ilya Bobir wrote:
> >>[...]
> >>	* cygpath.cc (get_long_name): Fallback to get_long_path_name_w32impl.
> >>	Properly null-terminate 'buf'.
> [...]
> I've submitted this patch on 30.07.2006, but it seems that the bug still 
> exists in cygwin-1.5.24-2 that was released on 31.01.2007.
> I can see that HEAD CVS brunch contains the fix.
> 
> Why is that so?  Is it some kind of mistake?

No, the patch has gone into CVS HEAD, but the current releases are
taken from the cr-0x5f1 branch.  CVS HEAD is not yet ready for prime
time.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

export a few newlib functions

As discussed this morning:

2007-05-14  Eric Blake  <ebb9 <at> byu.net>

	* cygwin.din (asnprintf, dprint, _Exit, vasnprintf, vdprintf):
	Export.
	* include/cygwin/version.h: Bump API minor number.

--
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9 <at> byu.net

Index: cygwin.din
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/cygwin.din,v
retrieving revision 1.171
diff -u -p -r1.171 cygwin.din
--- cygwin.din	20 Feb 2007 15:48:04 -0000	1.171
+++ cygwin.din	15 May 2007 00:44:21 -0000
 <at>  <at>  -112,6 +112,7  <at>  <at>  asinh NOSIGFE
 _asinh = asinh NOSIGFE
 asinhf NOSIGFE
 _asinhf = asinhf NOSIGFE
+asnprintf SIGFE
 asprintf SIGFE
 _asprintf = asprintf SIGFE
 asprintf_r = _asprintf_r SIGFE

Re: export a few newlib functions

On Mon, May 14, 2007 at 06:51:32PM -0600, Eric Blake wrote:
>As discussed this morning:
>
>2007-05-14  Eric Blake  <ebb9 <at> byu.net>
>
>	* cygwin.din (asnprintf, dprint, _Exit, vasnprintf, vdprintf):
>	Export.
>	* include/cygwin/version.h: Bump API minor number.

Applied.  Thanks.

cgf

(Doh.  I could have just asked you to apply it, couldn't I?)

Re: [PATCH] getmntent()->mnt_type values that match Linux...

On Mon, Apr 16, 2007 at 10:50:04AM -0400, Christopher Faylor wrote:
>On Fri, Apr 06, 2007 at 02:46:12PM -0400, Ryan C. Gordon wrote:
>>>>Actually, I'd appreciate it if the patch could be resubmitted against
>>>>current CVS. 
>>>I'll do this shortly.
>>
>>I just checked...the patch still applies cleanly to the latest CVS...the 
>>changed files haven't been altered between when I wrote it and now.
>>
>>Let me know if you want me to resend it, but otherwise, the previous 
>>patch is still the one to use.
>
>I've applied the patch to my local sandbox.  It looks good except for a couple
>of very minor formatting problems (no spaces after a function name).  I'm in
>the process of a major computer revamp at my home so I can't test these things
>quickly but I hope to have this committed sometime in the next couple of days.

How embarrassing.  I completely forgot about this.  I noticed it after doing a
'cvs diff' while applying Eric's patch.

In any event, this is now checked in.  It will be in the next snapshot.

Thanks for the patch and apologies again for forgetting about it.

cgf

Re: [PATCH] getmntent()->mnt_type values that match Linux...

> Thanks for the patch and apologies again for forgetting about it.

In a strange twist of fate, the counter-signed copyright assignment 
papers just showed up from Red Hat today, so I guess that was good 
timing.   :)

Thanks for committing the patch!

--ryan.

Re: Dumper produces unuseable dumps (fix).

Hi Pedro,

On Apr 27 16:01, Pedro Alves wrote:
> On 4/27/07, Corinna Vinschen wrote:
> 
> >Unfortunately, the patch is too big to fall under the trivial patch
> >rule, so Red Hat needs a signed copyright assignment from you.
> >Please have a look on http://cygwin.com/contrib.html, especially the
> >"Before you get started" section, which has a link to the assignment
> >form.  As soon as we got the signed form from you, the patch can go
> >in.
> >
> 
> Ok, form signed and sent.

I just asked at our office and I got told that your copyright assignment
didn't arrive yet.  Can you check what happened?

Thanks,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Re: Dumper produces unuseable dumps (fix).

On 5/15/07, Corinna Vinschen <corinna-cygwin <at> xxx> wrote:

> I just asked at our office and I got told that your copyright assignment
> didn't arrive yet.  Can you check what happened?
>

Have no idea...  Should have been there by now.  Bummer.
I'll have new papers from my employer in a few days, and I'll resubmit them.

To be sure, the snail address at:

http://cygwin.com/assign.txt

... is still the correct one, right?

Cheers,
Pedro Alves

Re: Dumper produces unuseable dumps (fix).

On May 17 13:29, Pedro Alves wrote:
> To be sure, the snail address at:
> 
> http://cygwin.com/assign.txt
> 
> ... is still the correct one, right?

Yep.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

[Patch] Segfault on unaligned lseek() on /dev/sdX (was: [ITP] ddrescue 1.3)

Hi,

Cygwin 1.5.24-2 segfaults on unaligned lseek() on raw block devices with 
sector size >512 bytes.

Testcases:
$ dd skip=1000 bs=2047 if=/dev/scd0 of=/dev/null

$ ddrescue -c 1 /dev/scd0 file.iso

This is due to a fixed 512 byte buffer in fhandler_dev_floppy::lseek().
It is still present in HEAD revision.

The attached patch should fix. It should work for any sector size.
(Smoke-)tested with 1.5.24-2 (too busy to test with current CVS, sorry).

2007-05-18  Christian Franke <franke <at> computer.org>

	* fhandler_floppy.cc (fhandler_dev_floppy::lseek): Fixed segfault on
	unaligned seek due to fixed size buffer.

Christian

--- cygwin-1.5.24-2.orig/winsup/cygwin/fhandler_floppy.cc	2006-07-18 14:56:37.001000000 +0200
+++ cygwin-1.5.24-2/winsup/cygwin/fhandler_floppy.cc	2007-05-18 19:53:07.468750000 +0200
 <at>  <at>  -12,6 +12,7  <at>  <at>  details. */
 #include "winsup.h"
 #include <sys/termios.h>