Pekka Pessi | 7 Dec 22:19 2005
Picon

[patch] Handling non-winsock flags in fhandler_socket.cc

Hello,

 I found a problem with sendmsg() failng when MSG_NOSIGNAL is used. It
looks like MSG_WINMASK is used in sendto() but not in sendmsg().

The patch that should fix the problem is made against
fhandler_socket.cc revision 1.176 ("should" because I did not get
around to compile the whole shebang). It clears extra flags when
calling ws2 functions in all cases of sendmsg(), recvmsg() and
recvfrom().

--
Pekka.Pessi <at> {nokia.com,iki.fi}
Attachment (sendmsg-flags.patch): text/x-patch, 1726 bytes
Corinna Vinschen | 8 Dec 11:14 2005

Re: [patch] Handling non-winsock flags in fhandler_socket.cc

On Dec  7 23:19, Pekka Pessi wrote:
> Hello,
> 
>  I found a problem with sendmsg() failng when MSG_NOSIGNAL is used. It
> looks like MSG_WINMASK is used in sendto() but not in sendmsg().

Thanks for the patch.  Unfortunately it's missing a ChangeLog entry and
it didn't work OOTB since it was missing curly braces, but I took the
freedom to fix it up.  The change to fhandler_socket::recvfrom was not
necessary since flags is masked at the start of the function.  However,
maybe it comes handy to keep the original flags value at one point, so
I removed this masking at the function start.

Please note that I can take this patch only because it's relatively
small.  If you would like to send bigger patches or extensions to the
Cygwin functionality at one point, you'll have to sign a copyright
assignment form and send it to Red Hat.  Please read
http://cygwin.com/contrib.html for more details about contributing.

Other than that, patch applied with changes.

Thanks again,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat, Inc.

(Continue reading)

Eric Blake | 11 Dec 00:30 2005
Picon

Re: d_ino deprecated in latest snapshot


According to Christopher Faylor on 12/10/2005 4:25 PM:
> 
> I'll make the change but have you completely given up on the concept of
> "a patch" now?  It seems like you could have tested this pretty easily
> by just making changes to the header and then rectified the behavior
> by submitting a patch.

2005-12-10  Eric Blake  <ebb9 <at> byu.net>

	* include/sys/dirent.h (struct dirent): Deprecate d_ino member.

Index: cygwin/include/sys/dirent.h
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/include/sys/dirent.h,v
retrieving revision 1.8
diff -u -p -r1.8 dirent.h
--- cygwin/include/sys/dirent.h 5 Dec 2005 21:02:53 -0000       1.8
+++ cygwin/include/sys/dirent.h 10 Dec 2005 23:31:00 -0000
 <at>  <at>  -1,6 +1,6  <at>  <at> 
 /* Posix dirent.h for WIN32.

  Copyright 2001, 2002, 2003 Red Hat, Inc.
+   Copyright 2001, 2002, 2003, 2005 Red Hat, Inc.

    This software is a copyrighted work licensed under the terms of the
    Cygwin license.  Please consult the file "CYGWIN_LICENSE" for
 <at>  <at>  -31,7 +31,7  <at>  <at>  struct dirent
 struct dirent
 {
(Continue reading)

Igor Pechtchanski | 19 Dec 17:34 2005
Picon

Fix /lib=/usr/lib alias in "cygcheck -f"

Hi,

Due to a missing trailing "/", "cygcheck -f" did not recognize "/lib" as
being the same as "/usr/lib".  The attached patch fixes this.  ChangeLog
below.
	Igor
==============================================================================
2005-12-19  Igor Pechtchanski  <pechtcha <at> cs.nyu.edu>

	* dump_setup.cc (package_find): Fix is_alias computation for
	"/usr/lib".

--

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha <at> cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor <at> watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"
Index: dump_setup.cc
===================================================================
RCS file: /cvs/src/src/winsup/utils/dump_setup.cc,v
retrieving revision 1.17
diff -u -p -r1.17 dump_setup.cc
--- dump_setup.cc	25 Oct 2004 15:49:36 -0000	1.17
+++ dump_setup.cc	19 Dec 2005 16:30:01 -0000
(Continue reading)

Corinna Vinschen | 20 Dec 10:12 2005

Re: Fix /lib=/usr/lib alias in "cygcheck -f"

On Dec 19 11:34, Igor Pechtchanski wrote:
> Hi,
> 
> Due to a missing trailing "/", "cygcheck -f" did not recognize "/lib" as
> being the same as "/usr/lib".  The attached patch fixes this.  ChangeLog
> below.
> 	Igor
> ==============================================================================
> 2005-12-19  Igor Pechtchanski  <pechtcha <at> cs.nyu.edu>
> 
> 	* dump_setup.cc (package_find): Fix is_alias computation for
> 	"/usr/lib".

Applied, thanks.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Gmane