a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Brian Dessent | 6 Apr 2005 07:41

[patch] dup_ent does not set dst when src is NULL


In net.cc, there are several cases where dup_ent() is used as follows:

dup_ent (servent_buf, getservbyname (name, proto), t_servent);
syscall_printf ("%p = getservbyname (%s, %s)",
    _my_tls.locals.servent_buf, name, proto);
return _my_tls.locals.servent_buf;

This presents a problem if getservbyname() returns NULL, because
dup_ent just returns NULL, it does not modify 'dst'.  This results in
the function returning the previous successful value if the
get_foo_by_bar() function returned NULL.  This seems to be applicable to
getservbyname(), getservbyport(), gethostbyaddr(), and gethostbyname().  

In the case of gethostbyname() there's also another bug in that there
will be a spurious debug_printf() about dup_ent failing if the address
simply didn't resolve.  That should probably be fixed too but I wanted
to be sure the patch stayed "trivial".

A simple testcase that demonstrates the problem:

#include <stdio.h>
#include <string.h>
#include <netdb.h>
#include <sys/socket.h>
#include <netinet/in.h>

void mygetservbyname(char *serv, char *proto)
{
  struct servent *p;

(Continue reading)

Christopher Faylor | 6 Apr 2005 07:51

Re: [patch] dup_ent does not set dst when src is NULL

On Tue, Apr 05, 2005 at 10:41:30PM -0700, Brian Dessent wrote:
>In net.cc, there are several cases where dup_ent() is used as follows:
>
>dup_ent (servent_buf, getservbyname (name, proto), t_servent);
>syscall_printf ("%p = getservbyname (%s, %s)",
>    _my_tls.locals.servent_buf, name, proto);
>return _my_tls.locals.servent_buf;
>
>This presents a problem if getservbyname() returns NULL, because
>dup_ent just returns NULL, it does not modify 'dst'.  This results in
>the function returning the previous successful value if the
>get_foo_by_bar() function returned NULL.  This seems to be applicable to
>getservbyname(), getservbyport(), gethostbyaddr(), and gethostbyname().  
>
>In the case of gethostbyname() there's also another bug in that there
>will be a spurious debug_printf() about dup_ent failing if the address
>simply didn't resolve.  That should probably be fixed too but I wanted
>to be sure the patch stayed "trivial".

Thanks for the patch, but I went out of my way to avoid freeing the
buffer when I maded changes to dup_ent a couple of weeks ago.  I don't
want to revert to doing that again, so I've just used the return value
in all cases.

cgf

Brian Dessent | 6 Apr 2005 10:40

Re: [patch] dup_ent does not set dst when src is NULL

Christopher Faylor wrote:

> Thanks for the patch, but I went out of my way to avoid freeing the
> buffer when I maded changes to dup_ent a couple of weeks ago.  I don't
> want to revert to doing that again, so I've just used the return value
> in all cases.

Thanks for taking care of that.  My original fix did more or less what
you have done, by checking the return value, but I submitted the other
way because it was much shorter and I didn't want to send anything
non-trivial.  Hmm, maybe if my printer had some ink in it I could print
out that copyright assignment form...

Brian

Corinna Vinschen | 6 Apr 2005 10:42

Re: [patch] dup_ent does not set dst when src is NULL

On Apr  6 01:40, Brian Dessent wrote:
> Christopher Faylor wrote:
> 
> > Thanks for the patch, but I went out of my way to avoid freeing the
> > buffer when I maded changes to dup_ent a couple of weeks ago.  I don't
> > want to revert to doing that again, so I've just used the return value
> > in all cases.
> 
> Thanks for taking care of that.  My original fix did more or less what
> you have done, by checking the return value, but I submitted the other
> way because it was much shorter and I didn't want to send anything
> non-trivial.  Hmm, maybe if my printer had some ink in it I could print
> out that copyright assignment form...

I'm looking forward 

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin <at> cygwin.com
Red Hat, Inc.

Kazuhiro Fujieda | 14 Apr 2005 06:59

Picon

Correct debugging output in seteuid32

I'd submit a trivial patch after a long time.

2005-04-14  Kazuhiro Fujieda  <fujieda <at> jaist.ac.jp>

	* syscalls.cc (setuid32): Correct debugging output.

Index: syscalls.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/syscalls.cc,v
retrieving revision 1.372
diff -u -u -r1.372 syscalls.cc
--- syscalls.cc	11 Apr 2005 21:54:54 -0000	1.372
+++ syscalls.cc	14 Apr 2005 04:45:38 -0000
 <at>  <at>  -1959,7 +1959,7  <at>  <at> 
 extern "C" int
 seteuid32 (__uid32_t uid)
 {
-  debug_printf ("uid: %u myself->gid: %u", uid, myself->gid);
+  debug_printf ("uid: %u myself->uid: %u", uid, myself->uid);

   if (uid == myself->uid && !cygheap->user.groups.ischanged)
     {

____
  | AIST      Kazuhiro Fujieda <fujieda <at> jaist.ac.jp>
  | HOKURIKU  School of Information Science
o_/ 1990      Japan Advanced Institute of Science and Technology

Corinna Vinschen | 14 Apr 2005 12:05

Re: Correct debugging output in seteuid32

Hi Kazuhiro, welcome back 

On Apr 14 13:59, Kazuhiro Fujieda wrote:
> I'd submit a trivial patch after a long time.
> 
> 2005-04-14  Kazuhiro Fujieda  <fujieda <at> jaist.ac.jp>
> 
> 	* syscalls.cc (setuid32): Correct debugging output.

Thanks for the patch.  I'll apply it at one point, but right now I'm
debugging at this very point, so this will take some time.  Stay tuned.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin <at> cygwin.com
Red Hat, Inc.

Pierre A. Humblet | 14 Apr 2005 22:24

Picon

Re: Correct debugging output in seteuid32

I can see why would one think this is a bug, but it was meant
to be that way. Having a "wrong" gid can make seteuid fail.
Perhaps we could print the new and current uids and the current
gid to cover all cases.

Pierre

At 01:59 PM 4/14/2005 +0900, Kazuhiro Fujieda wrote:
>I'd submit a trivial patch after a long time.
>
>2005-04-14  Kazuhiro Fujieda  <fujieda <at> jaist.ac.jp>
>
>	* syscalls.cc (setuid32): Correct debugging output.
>
>Index: syscalls.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/syscalls.cc,v
>retrieving revision 1.372
>diff -u -u -r1.372 syscalls.cc
>--- syscalls.cc	11 Apr 2005 21:54:54 -0000	1.372
>+++ syscalls.cc	14 Apr 2005 04:45:38 -0000
> <at>  <at>  -1959,7 +1959,7  <at>  <at> 
> extern "C" int
> seteuid32 (__uid32_t uid)
> {
>-  debug_printf ("uid: %u myself->gid: %u", uid, myself->gid);
>+  debug_printf ("uid: %u myself->uid: %u", uid, myself->uid);
> 
>   if (uid == myself->uid && !cygheap->user.groups.ischanged)
>     {

(Continue reading)

Corinna Vinschen | 15 Apr 2005 10:19

Re: Correct debugging output in seteuid32

On Apr 14 16:24, Pierre A. Humblet wrote:
> I can see why would one think this is a bug, but it was meant
> to be that way. Having a "wrong" gid can make seteuid fail.
> Perhaps we could print the new and current uids and the current
> gid to cover all cases.

Yep, that's how I did it already locally.  I've applied it that way.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin <at> cygwin.com
Red Hat, Inc.

Christopher Faylor | 20 Apr 2005 06:16

Re: [Fwd: RE: ssh problem on Windows XP]

On Sat, Jan 22, 2005 at 03:58:45PM -0500, Bob Byrnes wrote:
>On Jan 21,  6:34pm, Corinna Vinschen wrote:
>-- Subject: [Fwd: RE: ssh problem on Windows XP]
>>
>> is there any chance that we get a fix in the next couple of weeks?
>
>I remain absolutely committed to fixing the problems that have been
>reported, but I can't say that I'll have a fix in that timeframe,
>because I have some urgent deadlines for other projects.  Maybe
>early to mid-February?

Any update on this, Bob?

cgf

Christopher Faylor | 20 Apr 2005 06:28

Re: Update of fhandler-tut.txt

On Sun, Nov 28, 2004 at 07:40:19PM +0100, Gerd Spalink wrote:
>When trying to add an experimental /dev/mixer, I found that
>the fhandler tutorial was obsolete. This patch brings it up-to-date.
>
>ChangeLog Entry:
>
>2004-11-28 Gerd Spalink <Gerd.Spalink <at> t-online.de>
>
>* fhandler-tut.txt: Update description to cygwin 1.5.13

I'm going through my email archives and see that I never applied this
patch.

That oversight has been rectified.  I've checked it in with some minor
tweaks.

Thanks for the patch and sorry for the extreme delay.

cgf

Group

gmane.os.cygwin.patches.

Advertisement

Project Web Page

a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Search Archive

Page

1 | 2

Articles in period: 16

April 2005

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

May I remove setup.xml and cygwin-ug.xml? (10 May 2013)
[PATCH] fix GCC 4.7 warnings (30 Apr 2013)
Forgotted appersand (2 Apr 2013)
[PATCH 64bit] Fix ONDEE for 64bit, part 2 (20 Mar 2013)
[PATCH 64bit] Fix ONDEE for 64bit (4 Mar 2013)
[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target, part 2 (21 Feb 2013)
[PATCH] Missing dllimport's in (21 Feb 2013)
[PATCH] utils: force static linkage (20 Feb 2013)
[PATCH 64bit] Export symbols with underscore (20 Feb 2013)
[PATCH 64bit] ssize_t (20 Feb 2013)
Qsort defects (in C-library) (18 Feb 2013)
[PATCH 64bit] Fix speclib for x86_64 (17 Feb 2013)
[PATCH 64bit] utils: port dumper to 64bit (15 Feb 2013)
[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target (15 Feb 2013)
Console modes: cursor style (11 Jan 2013)
[PATCH] waitpid(2) WAIT_* macros (6 Dec 2012)
[PATCH] add cfsetspeed (21 Nov 2012)
[WIP] mingw64 related changes to Cygwin configure and other assorted f (12 Nov 2012)
[PATCH] additional sys/termios.h defines (5 Nov 2012)
[patch cygwin]: Rename strechr to strchrnul (26 Oct 2012)
Fwd: Re: [patch]: Decouple cygwin building from in-tree mingw/w32api b (24 Oct 2012)

Archives

1	June 2013
17	May 2013
11	April 2013
22	March 2013
44	February 2013
7	January 2013
2	December 2012
19	November 2012
44	October 2012
11	September 2012
21	August 2012
12	July 2012
14	June 2012
7	May 2012
27	April 2012
20	March 2012
18	February 2012
16	January 2012
28	December 2011
18	November 2011
21	October 2011
5	September 2011
42	August 2011
39	July 2011
5	June 2011
135	May 2011
50	April 2011
34	March 2011
41	February 2011
14	January 2011
10	December 2010
4	November 2010
9	October 2010
48	September 2010
23	August 2010
8	July 2010
4	June 2010
15	May 2010
4	April 2010
22	March 2010
60	February 2010
51	January 2010
25	December 2009
50	November 2009
136	October 2009
60	September 2009
24	August 2009
39	July 2009
20	June 2009
7	May 2009
62	April 2009
37	March 2009
10	February 2009
9	January 2009
35	December 2008
11	November 2008
6	September 2008
7	August 2008
6	July 2008
2	June 2008
6	April 2008
77	March 2008
10	February 2008
16	January 2008
47	December 2007
31	November 2007
10	September 2007
9	August 2007
4	July 2007
18	June 2007
28	May 2007
25	April 2007
20	March 2007
2	February 2007
13	January 2007
9	December 2006
19	November 2006
9	October 2006
6	September 2006
29	August 2006
47	July 2006
21	June 2006
39	May 2006
33	April 2006
34	March 2006
51	February 2006
39	January 2006
5	December 2005
15	November 2005
14	October 2005
18	September 2005
39	August 2005
52	July 2005
45	June 2005
80	May 2005
16	April 2005
43	March 2005
34	February 2005
30	January 2005
122	December 2004
67	November 2004
109	October 2004
73	September 2004
41	August 2004
38	July 2004
50	June 2004
98	May 2004
53	April 2004
67	March 2004
36	February 2004
36	January 2004
53	December 2003
122	November 2003
55	October 2003
125	September 2003
125	August 2003
47	July 2003
63	June 2003
79	May 2003
69	April 2003
114	March 2003
189	February 2003
119	January 2003
102	December 2002
155	November 2002
44	October 2002
146	September 2002
89	August 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template