headers
Pierre A. Humblet | 2 Oct 2004 02:41
Picon

[Patch]: PATH_ISDISK

As discussed earlier today.

Note that if GetVolumeInformation fails, has_acls won't get set
and cygwin will work as if ntsec was off... 
Not sure how to avoid that, reliably.

Pierre

2004-10-02  Pierre Humblet <pierre.humblet <at> ieee.org>

	* path.h (enum path_types): Delete PATH_ISDISK.
	(path_conv::isdisk): Delete method.
	(path_conv::set_isdisk): Ditto.
	* path.cc (path_conv::check): Do not call set_isdisk.
	* uinfo.cc(pwdgrp::load): Do not call pc.isdisk. 

Index: path.h
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/path.h,v
retrieving revision 1.66
diff -u -p -r1.66 path.h
--- path.h      17 Jun 2004 13:34:24 -0000      1.66
+++ path.h      2 Oct 2004 00:28:49 -0000
 <at>  <at>  -64,7 +64,6  <at>  <at>  enum path_types
   PATH_ALL_EXEC = (PATH_CYGWIN_EXEC | PATH_EXEC),
   PATH_LNK =         0x01000000,
   PATH_TEXT =        0x02000000,
-  PATH_ISDISK =              0x04000000,
   PATH_HAS_SYMLINKS = 0x10000000,
   PATH_SOCKET =       0x40000000
(Continue reading)

Permalink | Reply | 1 comment |
headers
Christopher Faylor | 2 Oct 2004 03:49
Favicon

Re: [Patch]: PATH_ISDISK

On Fri, Oct 01, 2004 at 08:41:57PM -0400, Pierre A. Humblet wrote:
>As discussed earlier today.

Patch away.

Thanks,
cgf
Permalink | Reply | 0 comments |
headers
Corinna Vinschen | 4 Oct 2004 11:40
Picon
Favicon

Re: More pipe problems (was Re: [Fwd: 1.5.11-1: sftp performance problem])

On Sep 23 18:56, Corinna Vinschen wrote:
> On Sep 23 12:28, Bob Byrnes wrote:
> > OutboundQuota is just the size of the pipe.  How do we know that the
> > cygwin ssh didn't really inherit a huge pipe from the win32-native
> > unison?
> 
> We don't unless checking the the source code or the strace, I guess.
> 
> > The real trouble here seems to be that WriteQuotaAvailable is so low,
> > which (if that is to be believed) indicates the pipe has almost filled.
> > This seems similar to the sftp problem, which I am still investigating;
> > I haven't made much progress during the past week because I've been
> > busy with other things at work, but I have learned a few new things
> > and I'll try to send another report as soon as I can construct a
> > coherent explanation.
> 
> Cool with me.  As I noted, I didn't care for debugging this issue so
> far so I also might be off-track.  But at least my debugging pointed
> out where something goes wrong so I hope it was useful nevertheless.

Bob?  Any news on this?  If we don't have a solution soon we should at
least disable the code and revert to the old behaviour in the meantime,
shouldn't we?

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin <at> cygwin.com
Red Hat, Inc.
(Continue reading)

Permalink | Reply | 1 comment |
headers
Corinna Vinschen | 4 Oct 2004 11:44
Picon
Favicon

Re: [Patch] cygcheck: ``pclose'' what was ``popen''ed.

On Sep 29 23:06, Bas van Gompel wrote:
> 	* cygcheck.cc (pretty_id): Close pipe.

Applied with a formatting change:

> +  pclose(f);

     pclose (f);

Thanks,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin <at> cygwin.com
Red Hat, Inc.
Permalink | Reply | 0 comments |
headers
Christopher Faylor | 4 Oct 2004 16:38
Favicon

Re: More pipe problems (was Re: [Fwd: 1.5.11-1: sftp performance problem])

On Mon, Oct 04, 2004 at 11:40:10AM +0200, Corinna Vinschen wrote:
>On Sep 23 18:56, Corinna Vinschen wrote:
>> On Sep 23 12:28, Bob Byrnes wrote:
>> > OutboundQuota is just the size of the pipe.  How do we know that the
>> > cygwin ssh didn't really inherit a huge pipe from the win32-native
>> > unison?
>> 
>> We don't unless checking the the source code or the strace, I guess.
>> 
>> > The real trouble here seems to be that WriteQuotaAvailable is so low,
>> > which (if that is to be believed) indicates the pipe has almost filled.
>> > This seems similar to the sftp problem, which I am still investigating;
>> > I haven't made much progress during the past week because I've been
>> > busy with other things at work, but I have learned a few new things
>> > and I'll try to send another report as soon as I can construct a
>> > coherent explanation.
>> 
>> Cool with me.  As I noted, I didn't care for debugging this issue so
>> far so I also might be off-track.  But at least my debugging pointed
>> out where something goes wrong so I hope it was useful nevertheless.
>
>Bob?  Any news on this?  If we don't have a solution soon we should at
>least disable the code and revert to the old behaviour in the meantime,
>shouldn't we?

That would be a shame but maybe we can keep the code in and just default to
Win 9x behavior for now?

cgf
(Continue reading)

Permalink | Reply | 0 comments |
headers
Corinna Vinschen | 4 Oct 2004 17:22
Picon
Favicon

Re: More pipe problems (was Re: [Fwd: 1.5.11-1: sftp performance problem])

On Sep 23 12:28, Bob Byrnes wrote:
> On Sep 23,  2:31pm, Corinna Vinschen wrote:
> -- Subject: Re: More pipe problems (was Re: [Fwd: 1.5.11-1: sftp performance 
> >
> > It seems that NtQueryInformationFile doesn't return useful values
> > anymore under XP SP2.  I'm not quite sure though since it's the first
> > time I'm looking into this issue.
> > ...
> > [select_pipe] ssh 756 peek_pipe: WriteQuotaAvailable = 1024
> > [select_pipe] ssh 756 peek_pipe: OutboundQuota = 16117632
> > ...
> > Since WriteQuotaAvailable is < PIPE_BUF and OutboundQuota is ... way
> > too big, gotone resp. s->write_ready never gets set.
> > 
> -- End of excerpt from Corinna Vinschen

Oh oh.  While I just had another look into this issue, I found that my
debug output was somewhat wrong.

The correct results in this case using the native unison application is
the same endless loop. but with less weird numbers:

 ...
 [select_pipe] ssh 756 peek_pipe: WriteQuotaAvailable = 0
 [select_pipe] ssh 756 peek_pipe: OutboundQuota = 1024
 ...

So the NtQueryInformation results make more sense.  I'm terribly sorry
if my dumb fault led you on the wrong track :-(
(Continue reading)

Permalink | Reply | 4 comments |
headers
Bas van Gompel | 5 Oct 2004 03:49
Picon

[Patch] pinfo.cc: second CreatePipe, not first.

Hi,

Looking over pinfo.cc, I saw that the debugging-output on
_pinfo::commune_send is awkward. This (trivial again, IMHO)
patch changes that.

Changelog-entry:

2004-10-05  Bas van Gompel  <cygwin-patch.buzz <at> bavag.tmfweb.nl>

	* pinfo.cc (_pinfo::commune_send): Make debugging output less ambiguous.

--- src/winsup/cygwin/pinfo.cc	12 Sep 2004 03:47:56 -0000	1.120
+++ src/winsup/cygwin/pinfo.cc	4 Oct 2004 23:59:17 -0000
 <at>  <at>  -501,7 +501,7  <at>  <at>  _pinfo::commune_send (DWORD code, ...)
     }
   if (!CreatePipe (&fromme, &tothem, &sec_all_nih, PIPEBUFSIZE))
     {
-      sigproc_printf ("first CreatePipe failed, %E");
+      sigproc_printf ("second CreatePipe failed, %E");
       __seterrno ();
       goto err;
     }

L8r,

Buzz.
(On this one there was little formatting to botch. :-) )

BTW: Is it as it should be that either PID_INITIALIZING or (both
(Continue reading)

Permalink | Reply | 3 comments |
headers
Christopher Faylor | 5 Oct 2004 04:10
Favicon

Re: [Patch] pinfo.cc: second CreatePipe, not first.

On Tue, Oct 05, 2004 at 03:49:20AM +0200, Bas van Gompel wrote:
>Hi,
>
>Looking over pinfo.cc, I saw that the debugging-output on
>_pinfo::commune_send is awkward. This (trivial again, IMHO)
>patch changes that.
>
>
>Changelog-entry:
>
>2004-10-05  Bas van Gompel  <cygwin-patch.buzz <at> bavag.tmfweb.nl>
>
>	* pinfo.cc (_pinfo::commune_send): Make debugging output less ambiguous.

I've applied this patch.  Thanks.

I used a slightly less ambiguous ChangeLog, though. :-)

cgf
Permalink | Reply | 2 comments |
headers
Pierre A. Humblet | 5 Oct 2004 04:16
Picon

[Patch] has_security

Another cleanup, following the changes in environ.cc.

Pierre

2004-10-05  Pierre Humblet <pierre.humblet <at> ieee.org>

	* external.cc (check_ntsec): Do not call wincap.has_security.
	* path.cc (path_conv::check): Ditto.
	* security.cc (get_object_attribute): Ditto.
	(get_file_attribute): Ditto.

Index: external.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/external.cc,v
retrieving revision 1.66
diff -u -p -r1.66 external.cc
--- external.cc 28 May 2004 19:50:05 -0000      1.66
+++ external.cc 5 Oct 2004 01:58:33 -0000
 <at>  <at>  -125,9 +125,9  <at>  <at>  static DWORD
 check_ntsec (const char *filename)
 {
   if (!filename)
-    return wincap.has_security () && allow_ntsec;
+    return allow_ntsec;
   path_conv pc (filename);
-  return wincap.has_security () && allow_ntsec && pc.has_acls ();
+  return allow_ntsec && pc.has_acls ();
 }

 extern "C" unsigned long
(Continue reading)

Permalink | Reply | 2 comments |
headers
Christopher Faylor | 5 Oct 2004 04:31
Favicon

Re: [Patch] has_security

On Mon, Oct 04, 2004 at 10:16:45PM -0400, Pierre A. Humblet wrote:
>Another cleanup, following the changes in environ.cc.
>
>Pierre
>
>2004-10-05  Pierre Humblet <pierre.humblet <at> ieee.org>
>
>	* external.cc (check_ntsec): Do not call wincap.has_security.
>	* path.cc (path_conv::check): Ditto.
>	* security.cc (get_object_attribute): Ditto.
>	(get_file_attribute): Ditto.

I think this classifies as an obvious fix but I guess it's only polite
to wait for Corinna to validate that.

cgf
Permalink | Reply | 1 comment |

Gmane