a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Dr. Volker Zell | 1 Dec 2003 10:07

Picon

[PATCH] localtime.cc: Point TZDIR to the /usr/share/zoneinfo

Hi

As discussed in cygwin-apps here's a small patch to point cygwin to an existing
time zone datasbase when the tzcode/data package is installed.

2003-12-01  Dr. Volker Zell  <Dr.Volker.Zell <at> oracle.com>

	* include/tzfile.h: Remove duplicate definition of TM_SUNDAY.
	* localtime.cc: Point TZDIR to the /usr/share/zoneinfo directory used
	by the tzcode package.

Ciao
  Volker

Attachment (timzone.patch): text/x-patch, 1206 bytes

Corinna Vinschen | 1 Dec 2003 11:23

Re: [PATCH]: Add flock syscall emulation

On Sun, Nov 30, 2003 at 12:57:48PM -0500, Nicholas Wourms wrote:
> Corinna wrote:
> >I've run indent on flock.c since its formatting was non-GNU.
> 
> I can understand why you did it in this case (the tabs were out of 
> control), but can we make an exception for bsd/isc-derived code?  I 
> think that enforcing this rule strictly on written-from-scratch source 
> is ok, but doing it on derived source reduces the overall transparency 
> of changes against the upstream version.

I see.  Is that necessary for flock?  It's not BSD derived and will
not likely need another external update.

However, we have a problem here, which I just saw when looking into
the flock code another time.  The newlib defintion of `struct flock'
isn't 64 bit aware and it doesn't adhere to the SUSv3 definition.  
It uses 'long' as datatypes for l_start and l_len but these should
be off_t.

So we need to define flock32 and flock64 structs and change the fcntl
interface to accept both.  Sic.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin <at> cygwin.com
Red Hat, Inc.

(Continue reading)

Corinna Vinschen | 1 Dec 2003 11:28

Re: [PATCH] localtime.cc: Point TZDIR to the /usr/share/zoneinfo

On Mon, Dec 01, 2003 at 10:07:25AM +0100, Dr. Volker Zell wrote:
> Hi
> 
> As discussed in cygwin-apps here's a small patch to point cygwin to an existing
> time zone datasbase when the tzcode/data package is installed.

Should we do some extra stuff to maintain backward compatibility with
the old /usr/local/etc path?  I don't think so but...

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin <at> cygwin.com
Red Hat, Inc.

Corinna Vinschen | 1 Dec 2003 11:39

Re: [PATCH] localtime.cc: Point TZDIR to the /usr/share/zoneinfo

On Mon, Dec 01, 2003 at 11:28:07AM +0100, Corinna Vinschen wrote:
> On Mon, Dec 01, 2003 at 10:07:25AM +0100, Dr. Volker Zell wrote:
> > Hi
> > 
> > As discussed in cygwin-apps here's a small patch to point cygwin to an existing
> > time zone datasbase when the tzcode/data package is installed.
> 
> Should we do some extra stuff to maintain backward compatibility with
> the old /usr/local/etc path?  I don't think so but...

I've applied the patch as is for now.

Thanks,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin <at> cygwin.com
Red Hat, Inc.

Corinna Vinschen | 1 Dec 2003 12:18

Re: [Patch]: Create Global Privilege

On Sun, Nov 30, 2003 at 12:07:22AM +0100, Corinna Vinschen wrote:
> On Wed, Nov 26, 2003 at 10:45:57AM -0500, Pierre A. Humblet wrote:
> > At 03:32 PM 11/26/2003 +0100, Corinna Vinschen wrote:
> > >Imagine a sshd service is running on the system.  This service has the
> > >SE_CREATE_GLOBAL_NAME privilege and would create the global object on
> > >system startup (given the service is in automatic mode).  Other processes
> > >would then be able to access the global object, regardless if running in
> > >a terminal session or not.  This would keep the process list together,
> > >for instance.
> > [...]
> > The problem with the track you start on is that one can end up with a
> > split system, e.g. the cygwin share in global space and a tty in local
> > space, invisible to the rest of the system. I am unsure of what can
> > happen then. Also the user share could be either global or local, depending
> > if a user (or a seteuid process) is already running at the console/service
> > at the moment a session starts under Terminal Services. 
> > That leads to indeterminate behavior.
> 
> If we make sure that the first process started in a process hirarchy
> determines where the shared mem is, that shouldn't be a problem.  The
> decision should be made only once.

I've applied the patch which just a minor change to remove the
`if (!prefix)'.

However, I think the right thing to do would be to add prefix to
cygheap_init so that it survives exec(2) calls.

Chris, any problem with this?  It's another 8 bytes...

(Continue reading)

Christopher Faylor | 1 Dec 2003 14:57

Picon

Re: [Patch]: Create Global Privilege

On Mon, Dec 01, 2003 at 12:18:05PM +0100, Corinna Vinschen wrote:
>On Sun, Nov 30, 2003 at 12:07:22AM +0100, Corinna Vinschen wrote:
>> On Wed, Nov 26, 2003 at 10:45:57AM -0500, Pierre A. Humblet wrote:
>> > At 03:32 PM 11/26/2003 +0100, Corinna Vinschen wrote:
>> > >Imagine a sshd service is running on the system.  This service has the
>> > >SE_CREATE_GLOBAL_NAME privilege and would create the global object on
>> > >system startup (given the service is in automatic mode).  Other processes
>> > >would then be able to access the global object, regardless if running in
>> > >a terminal session or not.  This would keep the process list together,
>> > >for instance.
>> > [...]
>> > The problem with the track you start on is that one can end up with a
>> > split system, e.g. the cygwin share in global space and a tty in local
>> > space, invisible to the rest of the system. I am unsure of what can
>> > happen then. Also the user share could be either global or local, depending
>> > if a user (or a seteuid process) is already running at the console/service
>> > at the moment a session starts under Terminal Services. 
>> > That leads to indeterminate behavior.
>> 
>> If we make sure that the first process started in a process hirarchy
>> determines where the shared mem is, that shouldn't be a problem.  The
>> decision should be made only once.
>
>I've applied the patch which just a minor change to remove the
>`if (!prefix)'.
>
>However, I think the right thing to do would be to add prefix to
>cygheap_init so that it survives exec(2) calls.
>
>Chris, any problem with this?  It's another 8 bytes...

(Continue reading)

Nicholas Wourms | 1 Dec 2003 15:42

Re: [PATCH] localtime.cc: Point TZDIR to the /usr/share/zoneinfo

cygwin-patches <at> cygwin.com wrote:
> On Mon, Dec 01, 2003 at 10:07:25AM +0100, Dr. Volker Zell wrote:
> 
>>Hi
>>
>>As discussed in cygwin-apps here's a small patch to point cygwin to an existing
>>time zone datasbase when the tzcode/data package is installed.
> 
> 
> Should we do some extra stuff to maintain backward compatibility with
> the old /usr/local/etc path?  I don't think so but...
>

As mentioned in another thread, in theory this should be an evironmental 
variable.  However, IIRC, I think DJ ripped out that portion of the 
code, probably assuming at the time there was no need for timezone data. 
  I'll go back and check, though.

Cheers,
Nicholas

Igor Pechtchanski | 1 Dec 2003 17:50

Picon

Re: [PATCH] localtime.cc: Point TZDIR to the /usr/share/zoneinfo

On Mon, 1 Dec 2003, Corinna Vinschen wrote:

> On Mon, Dec 01, 2003 at 10:07:25AM +0100, Dr. Volker Zell wrote:
> > Hi
> >
> > As discussed in cygwin-apps here's a small patch to point cygwin to an existing
> > time zone datasbase when the tzcode/data package is installed.
>
> Should we do some extra stuff to maintain backward compatibility with
> the old /usr/local/etc path?  I don't think so but...
>
> Corinna

That's pretty much what I suggested in
<http://cygwin.com/ml/cygwin-apps/2003-11/msg00443.html>.  Right now, the
code is not $TZDIR-aware, AFAICS.  IMO, having it first check the TZDIR
environment variable, and if that's not set, default to the #defined value
of TZDIR would be the right solution.  Something like (very raw)

Index: localtime.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/localtime.cc,v
retrieving revision 1.8
diff -u -p -r1.8 localtime.cc
--- localtime.cc        20 Dec 2002 03:40:00 -0000      1.8
+++ localtime.cc        1 Dec 2003 16:44:49 -0000
 <at>  <at>  -717,7 +717,8  <at>  <at>  tzload(const char *name, struct state *s
 	register int		fid;
 	save_errno		save;

(Continue reading)

Nicholas Wourms | 1 Dec 2003 19:22

Re: [PATCH]: Add flock syscall emulation

Corinna wrote:
> On Sun, Nov 30, 2003 at 12:57:48PM -0500, Nicholas Wourms wrote:
> 
>>Corinna wrote:
>>
>>>I've run indent on flock.c since its formatting was non-GNU.
>>
>>I can understand why you did it in this case (the tabs were out of 
>>control), but can we make an exception for bsd/isc-derived code?  I 
>>think that enforcing this rule strictly on written-from-scratch source 
>>is ok, but doing it on derived source reduces the overall transparency 
>>of changes against the upstream version.
> 
> 
> I see.  Is that necessary for flock?  It's not BSD derived and will
> not likely need another external update.

Oh, I think I was unclear.  I was trying to say is that I agree with 
your formatting changes to the flock code.  I just wanted to see if I 
could have an exception from this policy in certain cases where the 
source was derived.

> However, we have a problem here, which I just saw when looking into
> the flock code another time.  The newlib defintion of `struct flock'
> isn't 64 bit aware and it doesn't adhere to the SUSv3 definition.  
> It uses 'long' as datatypes for l_start and l_len but these should
> be off_t.

> So we need to define flock32 and flock64 structs and change the fcntl
> interface to accept both.  Sic.

(Continue reading)

Corinna Vinschen | 1 Dec 2003 19:34

Re: [PATCH] localtime.cc: Point TZDIR to the /usr/share/zoneinfo

On Mon, Dec 01, 2003 at 11:50:39AM -0500, Igor Pechtchanski wrote:
> On Mon, 1 Dec 2003, Corinna Vinschen wrote:
> > Should we do some extra stuff to maintain backward compatibility with
> > the old /usr/local/etc path?  I don't think so but...
> >
> > Corinna
> 
> That's pretty much what I suggested in
> <http://cygwin.com/ml/cygwin-apps/2003-11/msg00443.html>.  Right now, the
> code is not $TZDIR-aware, AFAICS.  IMO, having it first check the TZDIR
> environment variable, and if that's not set, default to the #defined value
> of TZDIR would be the right solution.  Something like (very raw)

Interested to change this to a real patch with ChangeLog and all that?

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin <at> cygwin.com
Red Hat, Inc.

Group

gmane.os.cygwin.patches.

Project Web Page

a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6

Articles in period: 53

December 2003

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

May I remove setup.xml and cygwin-ug.xml? (10 May 2013)
[PATCH] fix GCC 4.7 warnings (30 Apr 2013)
Forgotted appersand (2 Apr 2013)
[PATCH 64bit] Fix ONDEE for 64bit, part 2 (20 Mar 2013)
[PATCH 64bit] Fix ONDEE for 64bit (4 Mar 2013)
[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target, part 2 (21 Feb 2013)
[PATCH] Missing dllimport's in (21 Feb 2013)
[PATCH] utils: force static linkage (20 Feb 2013)
[PATCH 64bit] Export symbols with underscore (20 Feb 2013)
[PATCH 64bit] ssize_t (20 Feb 2013)
Qsort defects (in C-library) (18 Feb 2013)
[PATCH 64bit] Fix speclib for x86_64 (17 Feb 2013)
[PATCH 64bit] utils: port dumper to 64bit (15 Feb 2013)
[PATCH 64bit] lsaauth: skip 32bit DLL on 64bit target (15 Feb 2013)
Console modes: cursor style (11 Jan 2013)
[PATCH] waitpid(2) WAIT_* macros (6 Dec 2012)
[PATCH] add cfsetspeed (21 Nov 2012)
[WIP] mingw64 related changes to Cygwin configure and other assorted f (12 Nov 2012)
[PATCH] additional sys/termios.h defines (5 Nov 2012)
[patch cygwin]: Rename strechr to strchrnul (26 Oct 2012)
Fwd: Re: [patch]: Decouple cygwin building from in-tree mingw/w32api b (24 Oct 2012)

Archives

15	May 2013
11	April 2013
22	March 2013
44	February 2013
7	January 2013
2	December 2012
19	November 2012
44	October 2012
11	September 2012
21	August 2012
12	July 2012
14	June 2012
7	May 2012
27	April 2012
20	March 2012
18	February 2012
16	January 2012
28	December 2011
18	November 2011
21	October 2011
5	September 2011
42	August 2011
39	July 2011
5	June 2011
135	May 2011
50	April 2011
34	March 2011
41	February 2011
14	January 2011
10	December 2010
4	November 2010
9	October 2010
48	September 2010
23	August 2010
8	July 2010
4	June 2010
15	May 2010
4	April 2010
22	March 2010
60	February 2010
51	January 2010
25	December 2009
50	November 2009
136	October 2009
60	September 2009
24	August 2009
39	July 2009
20	June 2009
7	May 2009
62	April 2009
37	March 2009
10	February 2009
9	January 2009
35	December 2008
11	November 2008
6	September 2008
7	August 2008
6	July 2008
2	June 2008
6	April 2008
77	March 2008
10	February 2008
16	January 2008
47	December 2007
31	November 2007
10	September 2007
9	August 2007
4	July 2007
18	June 2007
28	May 2007
25	April 2007
20	March 2007
2	February 2007
13	January 2007
9	December 2006
19	November 2006
9	October 2006
6	September 2006
29	August 2006
47	July 2006
21	June 2006
39	May 2006
33	April 2006
34	March 2006
51	February 2006
39	January 2006
5	December 2005
15	November 2005
14	October 2005
18	September 2005
39	August 2005
52	July 2005
45	June 2005
80	May 2005
16	April 2005
43	March 2005
34	February 2005
30	January 2005
122	December 2004
67	November 2004
109	October 2004
73	September 2004
41	August 2004
38	July 2004
50	June 2004
98	May 2004
53	April 2004
67	March 2004
36	February 2004
36	January 2004
53	December 2003
122	November 2003
55	October 2003
125	September 2003
125	August 2003
47	July 2003
63	June 2003
79	May 2003
69	April 2003
114	March 2003
189	February 2003
119	January 2003
102	December 2002
155	November 2002
44	October 2002
146	September 2002
89	August 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template