Development discussion of the internals of the Cygwin DLL

Eric Blake | 2 Feb 2011 16:00

Picon

Re: src/winsup/cygwin ChangeLog include/err.h

On 02/02/2011 03:16 AM, corinna wrote:
> CVSROOT:	/cvs/src
> Module name:	src
> Changes by:	corinna	2011-02-02 10:16:30
> 
> Modified files:
> 	winsup/cygwin  : ChangeLog 
> 	winsup/cygwin/include: err.h 
> 
> Log message:
> 	* include/err.h (err): Add noreturn attribute.
> 	(errx): Ditto.
> 	(verr): Ditto.
> 	(verrx): Ditto.
> 
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/ChangeLog.diff?cvsroot=src&r1=1.5141&r2=1.5142
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/include/err.h.diff?cvsroot=src&r1=1.1&r2=1.2

Oops, this introduced a syntax error:

-extern void warn (const char *fmt, ...);
-extern void warnx (const char *fmt, ...);
+extern void warn (const char *fmt, ...)
+extern void warnx (const char *fmt, ...)

Looks like you first marked warn as noreturn, then (correctly) changed
your mind, but forgot to restore the trailing ; in the process.

--

--

(Continue reading)

Corinna Vinschen | 2 Feb 2011 16:17

Re: src/winsup/cygwin ChangeLog include/err.h

On Feb  2 08:00, Eric Blake wrote:
> Oops, this introduced a syntax error:
> 
> -extern void warn (const char *fmt, ...);
> -extern void warnx (const char *fmt, ...);
> +extern void warn (const char *fmt, ...)
> +extern void warnx (const char *fmt, ...)
> 
> Looks like you first marked warn as noreturn, then (correctly) changed
> your mind, but forgot to restore the trailing ; in the process.

Urgh.  I tested my changes by rebuilding bsdlib.cc, not realizing that
bsdlib.cc does not include err.h.  I fixed that.

Thanks for catching,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Brian Ford | 16 Feb 2011 17:27

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

On Wed, 13 Oct 2010, Yoni Londner wrote:

> Attached is a combined patch, including all the issues i mentioned in
> previous emails, and excluding the controversial ACL issue.

Just curious what happened to the review of this patch?

http://cygwin.com/ml/cygwin-developers/2010-10/msg00069.html

I don't see any evidence that it didn't just get lost, but I know it
appears to have never been submitted to cygwin-patches with a proper
ChangeLog.  I also know it was sent with bad timing with respect to
available review resources, but I'd hate to see all that good work go to
waste.

--

-- 
Brian Ford
Staff Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
the best safety device in any aircraft is a well-trained crew...

Corinna Vinschen | 17 Feb 2011 10:25

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

On Feb 16 10:27, Brian Ford wrote:
> On Wed, 13 Oct 2010, Yoni Londner wrote:
> 
> > Attached is a combined patch, including all the issues i mentioned in
> > previous emails, and excluding the controversial ACL issue.
> 
> Just curious what happened to the review of this patch?
> 
> http://cygwin.com/ml/cygwin-developers/2010-10/msg00069.html
> 
> I don't see any evidence that it didn't just get lost, but I know it
> appears to have never been submitted to cygwin-patches with a proper
> ChangeLog.

I had completely forgotten about it.  I just had a look and, apart
from the missing ChangeLog and wrong formatting, I guess I can
add the symlink caching into a local build for testing.  The fs
caching doesn't take the already existing caching into account, though.
Anyway, I'll give it a whirl in the next couple of days.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Brian Ford | 17 Feb 2011 19:52

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

On Thu, 17 Feb 2011, Corinna Vinschen wrote:

> I had completely forgotten about it.  I just had a look and, apart
> from the missing ChangeLog and wrong formatting, I guess I can
> add the symlink caching into a local build for testing.  The fs
> caching doesn't take the already existing caching into account, though.
> Anyway, I'll give it a whirl in the next couple of days.

Thanks; no rush.  I just wanted to remind in case that was what happened.

--

-- 
Brian Ford
Staff Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
the best safety device in any aircraft is a well-trained crew...

Eric Blake | 21 Feb 2011 18:05

Picon

Re: src/winsup/cygwin fhandler_socket.cc net.cc

On 02/21/2011 10:01 AM, corinna wrote:
> Modified files:
> 	winsup/cygwin  : fhandler_socket.cc net.cc 
>

No ChangeLog modification?

--

-- 
Eric Blake   eblake@...    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Corinna Vinschen | 21 Feb 2011 18:12

Re: src/winsup/cygwin fhandler_socket.cc net.cc

On Feb 21 10:05, Eric Blake wrote:
> On 02/21/2011 10:01 AM, corinna wrote:
> > Modified files:
> > 	winsup/cygwin  : fhandler_socket.cc net.cc 
> >
> 
> No ChangeLog modification?

Thanks for the reminder.  I forgot to save my ChangeLog changes
before checking in.

Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Corinna Vinschen | 26 Feb 2011 16:32

LoadLibrary error 487 (was Re: Please test latest developer snapshot)

Guys

I'm seriously puzzled.  Any input would be much appreciated.

On Feb 26 11:35, Corinna Vinschen wrote:
> On Feb 25 16:09, David Rothenberger wrote:
> > I was able to reproduce this using a clone of the git repository itself:
> > 
> > % uname -a
> > CYGWIN_NT-5.1 tela 1.7.8s(0.236/5/3) 20110221 20:36:00 i686 Cygwin
> > % git clone git://github.com/git/git.git
> > Cloning into git...
> > remote: Counting objects: 134689, done.
> > remote: Compressing objects: 100% (39672/39672), done.
> > remote: Total 134689 (delta 100250), reused 126970 (delta 93150)
> > Receiving objects: 100% (134689/134689), 28.44 MiB | 621 KiB/s, done.
> > Resolving deltas: 100% (100250/100250), done.
> > % cd git/
> > % git log
> >       0 [main] git 3088 C:\cygwin\bin\git.exe: *** fatal error - could not load
C:\WINDOWS\system32\winmm.dll, Win32 error 487
> 
> Thanks for the report.  I can reproduce this under Windows XP but
> not under Windows 7.  Stay tuned.

What happens on XP is that at one point when git calls select(), the
timeout value in the select call triggers a call to hires_ms.nsecs().

The crash occurs in this line:

(Continue reading)

Corinna Vinschen | 26 Feb 2011 16:40

Re: LoadLibrary error 487 (was Re: Please test latest developer snapshot)

On Feb 26 16:32, Corinna Vinschen wrote:
> I tracked the above problem down to this simple change:
> 
>   -LoadDLLfuncEx (timeGetTime, 0, winmm, 1)
>   +LoadDLLfunc (timeGetTime, 0, winmm)
> 
> The difference is that the old version did NOT fail, even if LoadlLibrary
> failed.  It just returned 1 in that case.  The new version now potentially
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Correction: "It just return 0 in that case. "

> fails with the Win32 error returned by LoadLibrary.

Sorry,
Corinna

--

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Corinna Vinschen | 26 Feb 2011 19:04

Re: LoadLibrary error 487 (was Re: Please test latest developer snapshot)

On Feb 26 16:32, Corinna Vinschen wrote:
> I'm seriously puzzled.  Any input would be much appreciated.
> 
> On Feb 26 11:35, Corinna Vinschen wrote:
> > On Feb 25 16:09, David Rothenberger wrote:
> > > I was able to reproduce this using a clone of the git repository itself:
> > > 
> > > % uname -a
> > > CYGWIN_NT-5.1 tela 1.7.8s(0.236/5/3) 20110221 20:36:00 i686 Cygwin
> > > % git clone git://github.com/git/git.git
> > > Cloning into git...
> > > remote: Counting objects: 134689, done.
> > > remote: Compressing objects: 100% (39672/39672), done.
> > > remote: Total 134689 (delta 100250), reused 126970 (delta 93150)
> > > Receiving objects: 100% (134689/134689), 28.44 MiB | 621 KiB/s, done.
> > > Resolving deltas: 100% (100250/100250), done.
> > > % cd git/
> > > % git log
> > >       0 [main] git 3088 C:\cygwin\bin\git.exe: *** fatal error - could not load
C:\WINDOWS\system32\winmm.dll, Win32 error 487
> > 
> > Thanks for the report.  I can reproduce this under Windows XP but
> > not under Windows 7.  Stay tuned.
> [...]
> The only workaround which works for me is to use the GetTickCount()
> function instead of the timeGetTime() function in hires_ms::nsecs():
> [...]
> Does anybody have an idea what could cause this problem?  I already
> googled for this but all I can come up with is questions with no reply
> or questions which refer to loading a DLL as data or resource.  And

(Continue reading)

Group

gmane.os.cygwin.devel.

Project Web Page

Development discussion of the internals of the Cygwin DLL

Search Archive

Page

1 | 2 | 3 | 4 | 5

Articles in period: 40

February 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

Please confirm that I didn't break 64-bit cygwin build (1 May 2013)
64 bit branch merged into CVS HEAD (23 Apr 2013)
[COMMITTED 64bit] missing parenthesis in stdint.h (22 Apr 2013)
64bit: gcc vs. harfbuzz (16 Apr 2013)
[64 bit] problem using Win32 API in native Cygwin64 library (2 Apr 2013)
[64 bit] problem using Win32 API in native Cygwin64 library (2 Apr 2013)
64bit: weak symbols (31 Mar 2013)
[64bit] emacs is unable to call subprocesses if display-time-mode is s (30 Mar 2013)
64bit segfault in cygcheck (28 Mar 2013)
64 bit Cygwin 1.7.18-12 (27 Mar 2013)
tzset crash in 64-bit Cygwin (25 Mar 2013)
Update RLIM_INFINITY for x86_64? (20 Mar 2013)
What you have to look for on 64 bit (19 Mar 2013)
New 64 bit Cygwin DLL (19 Mar 2013)
Question on sys/reent.h (18 Mar 2013)
undefined reference to `strlwr' on 64bit Cygwin (17 Mar 2013)
[Cygwin64] unloading of dlls (15 Mar 2013)
[Cygwin64] make segfault (14 Mar 2013)
Error building libffi on x86_64 (13 Mar 2013)
[Cygwin64] Flex segfault (11 Mar 2013)
[Cygwin64] Python, Tk etc. (11 Mar 2013)

Archives

33	May 2013
78	April 2013
130	March 2013
177	February 2013
2	January 2013
58	December 2012
6	November 2012
19	October 2012
7	August 2012
62	July 2012
4	June 2012
26	February 2012
46	January 2012
4	December 2011
9	November 2011
20	October 2011
1	September 2011
66	August 2011
60	July 2011
125	June 2011
63	May 2011
37	April 2011
63	March 2011
31	February 2011
12	January 2011
8	December 2010
4	November 2010

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template