Jeremy Lavergne | 1 Feb 01:43

Re: [89493] trunk/dports/python/py-werkzeug/Portfile

> append to, don't overwrite, portgroup dependencies

Is this something that's worth making warning in lint?

Attachment (smime.p7s): application/pkcs7-signature, 8 KiB
Ryan Schmidt | 1 Feb 01:53
Favicon

Re: [89493] trunk/dports/python/py-werkzeug/Portfile


On Jan 31, 2012, at 18:43, Jeremy Lavergne wrote:

>> append to, don't overwrite, portgroup dependencies
> 
> Is this something that's worth making warning in lint?

It's probably a good rule of thumb that if you include any portgroup, you should -append to, not overwrite,
any dependencies, just in case that portgroup now or in the future declares dependencies. There are many
cases where it won't matter, but it's probably a good idea to get in the habit of -appending just so that you
don't forget to do so when it really does matter.

Dan Ports | 1 Feb 04:28
Favicon

adduser in destroot

I see that quite a few ports call adduser and addgroup in the destroot
phase. Isn't this going to fail if we're installing from a binary (and
skip destroot)?

Dan

--

-- 
Dan R. K. Ports              MIT CSAIL                http://drkp.net/
Joshua Root | 1 Feb 09:17
Favicon

Re: adduser in destroot

On 2012-2-1 14:28 , Dan Ports wrote:
> I see that quite a few ports call adduser and addgroup in the destroot
> phase. Isn't this going to fail if we're installing from a binary (and
> skip destroot)?

Yes. Ports that do this should be changed to use the add_users option
instead.

- Josh
Frank Schima | 1 Feb 18:52
Favicon

Re: [89515] trunk/dports/python

robitaille,


You are not unifying python ports correctly and the portindex is failing on them. 

You must use a "if {$subport != $name} {" block on the phases. If have fixed this port in r89528 [1]. Please fix the rest of your commits.


Thanks!
Frank



On Feb 1, 2012, at 9:22 AM, robitaille-/EBbbHb69GVg9hUCZPvPmw@public.gmane.org wrote:

[89515] trunk/dports/python
Revision 89515 Author robitaille-/EBbbHb69GVg9hUCZPvPmw@public.gmane.org Date 2012-02-01 08:22:54 -0800 (Wed, 01 Feb 2012)

Log Message

py-virtualenv: updated to 1.7 and switched to unified port format

Modified Paths

Removed Paths

  • trunk/dports/python/py25-virtualenv/
  • trunk/dports/python/py26-virtualenv/
  • trunk/dports/python/py27-virtualenv/
  • trunk/dports/python/py31-virtualenv/
  • trunk/dports/python/py32-virtualenv/

Diff

Modified: trunk/dports/python/py-virtualenv/Portfile (89514 => 89515)

--- trunk/dports/python/py-virtualenv/Portfile 2012-02-01 16:12:28 UTC (rev 89514) +++ trunk/dports/python/py-virtualenv/Portfile 2012-02-01 16:22:54 UTC (rev 89515) <at> <at> -2,34 +2,37 <at> <at> # $Id$ PortSystem 1.0 -PortGroup python24 1.0 +PortGroup python 1.0 name py-virtualenv -version 1.6.1 +version 1.7 +maintainers nomaintainer + categories-append devel -platforms darwin -maintainers nomaintainer -license MIT -homepage http://pypi.python.org/pypi/virtualenv description Virtual Python Environment builder long_description virtualenv is a tool to create isolated Python \ environments. +platforms darwin +license MIT + +homepage http://pypi.python.org/pypi/virtualenv master_sites http://pypi.python.org/packages/source/v/virtualenv/ distname virtualenv-${version} -checksums md5 1a475df2219457b6b4febb9fe595d915 \ - sha1 f875868d680b83bdfa86a23536d19bb00b28b40d \ - rmd160 1a5b11bad5c8ec50129724db99632755c637a9d7 +checksums md5 dcc105e5a3907a9dcaa978f813a4f526 \ + sha1 3c99e759a06470a1838c98b750d5b72972ac82d6 \ + rmd160 5d5f9a7b82bd4ec659d853a1bbaacaac32961116 -depends_lib-append port:py24-distribute +python.versions 24 25 26 27 31 32 +python.default_version 27 +depends_lib-append port:py${python.version}-distribute + post-destroot { - xinstall -m 755 -d ${destroot}${prefix}/share/doc/${name} - xinstall -m 644 -W ${worksrcpath}/docs index.txt \ - ${destroot}${prefix}/share/doc/${name} - - move ${destroot}${prefix}/bin/virtualenv \ - ${destroot}${prefix}/bin/virtualenv-${python.branch} + xinstall -m 755 -d ${destroot}${prefix}/share/doc/${subport} + foreach f [glob -directory ${worksrcpath}/docs *] { + copy $f ${destroot}${prefix}/share/doc/${subport}/[file tail $f] + } } livecheck.type regex
_______________________________________________
macports-changes mailing list
macports-changes-qhrM8SXbD5KlRa4neek8BWD2FQJk+8+b@public.gmane.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-changes

Bradley Giesbrecht | 1 Feb 18:54
Favicon
Gravatar

Re: adduser in destroot

On Feb 1, 2012, at 12:17 AM, Joshua Root wrote:

> On 2012-2-1 14:28 , Dan Ports wrote:
>> I see that quite a few ports call adduser and addgroup in the destroot
>> phase. Isn't this going to fail if we're installing from a binary (and
>> skip destroot)?
> 
> Yes. Ports that do this should be changed to use the add_users option
> instead.

Looks like there are currently 76 ports using adduser and/or addgroup.

Should some form of initiative be created?

nomaintainer
    angband
    gnome-libs
    tomcat5
    assp
    exim
    mailman
    nefu
    openntpd
    py-pgasync
    slocate
    privoxy
    zope
openmaintainer
    mysql4
    percona-server
    dbus
    jnethack
    gdm
    hadoop
    tomcat6
    amavisd-new
    cyrus-imapd
    dovecot
    avahi
    murmur
    nagios
    quagga
    rabbitmq-server
    squid3-devel
    zabbix
    policykit
    boxbackup
    clamav-server
    puppet
    canna
alpha
	munin
arhbkb@...
	nsd
aschenke
	larn
	moria
	rogue
bfulgham
	geneweb
cbellot@...
	postgrey
compconsultant@...
	fcron
	qmail-spamcontrol
	vpopmail
dluke@...
	milter-greylist
fclaire@...
	xymon
	xymon-server
jameskyle
	backuppc
jogwtr@...
	mariadb-server
jwa
	couchdb
	couchdb-devel
krischik
	leafnode
landonf
	openldap
markd
	moomps
	nrpe
	nsca
	sendpage
matt@...
	maildrop
miwi@...
	nut
mnick
	miredo
mww, jwa
    postgresql7
    postgresql80-server
    postgresql81-server
    postgresql82-server
    postgresql83-server
    postgresql84-server
    postgresql90-server
    postgresql91-server
pixilla
	dovecot2
	rbldnsd
	sqlgrey
rambiusparkisanius@...
	perforce
ryandesign
	mysql5-server
ryandesign, jwa
	mysql5-server-devel
sfiera
	lastfmsubmitd
simon@...
	pulse

Frank Schima | 1 Feb 19:47
Favicon

Re: [89525] trunk/dports/python/py-aplpy/Portfile

You don't need to update the revision when unifying python ports. 


On Feb 1, 2012, at 10:05 AM, robitaille-/EBbbHb69GVg9hUCZPvPmw@public.gmane.org wrote:

[89525] trunk/dports/python/py-aplpy/Portfile
Revision 89525 Author robitaille-/EBbbHb69GVg9hUCZPvPmw@public.gmane.org Date 2012-02-01 09:05:15 -0800 (Wed, 01 Feb 2012)

Log Message

py-aplpy: set revision to 1 (should have done it when updating to unified port format)

Modified Paths

Diff

Modified: trunk/dports/python/py-aplpy/Portfile (89524 => 89525)

--- trunk/dports/python/py-aplpy/Portfile 2012-02-01 17:04:01 UTC (rev 89524) +++ trunk/dports/python/py-aplpy/Portfile 2012-02-01 17:05:15 UTC (rev 89525) <at> <at> -6,6 +6,7 <at> <at> name py-aplpy version 0.9.6 +revision 1 maintainers robitaille stsci.edu:mperrin categories-append science
_______________________________________________
macports-changes mailing list
macports-changes-qhrM8SXbD5KlRa4neek8BWD2FQJk+8+b@public.gmane.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-changes

Frank Schima | 1 Feb 19:57
Favicon

Re: [89525] trunk/dports/python/py-aplpy/Portfile

I should follow-up and say that I mean in general you do not need to update the revision for unifying such as in your case below. If you also fixed something and added dependencies, then you would increase the revision. But the general rule is do not update the revision unless a dependency changes or if the installed files change. 

For example, if you unified py25-foo and py26-foo ports and py25-foo had an older version, you still wouldn't need to increase the revision because the version would increase for anyone with py25-foo and the users would see the port as outdated. Anyone with py26-foo would be fine and not need to rebuild. 


Cheers!
Frank

On Feb 1, 2012, at 11:47 AM, Frank Schima wrote:

You don't need to update the revision when unifying python ports. 


On Feb 1, 2012, at 10:05 AM, robitaille-/EBbbHb69GVg9hUCZPvPmw@public.gmane.org wrote:

[89525] trunk/dports/python/py-aplpy/Portfile
Revision 89525 Author robitaille-/EBbbHb69GVg9hUCZPvPmw@public.gmane.org Date 2012-02-01 09:05:15 -0800 (Wed, 01 Feb 2012)

Log Message

py-aplpy: set revision to 1 (should have done it when updating to unified port format)

Modified Paths

Diff

Modified: trunk/dports/python/py-aplpy/Portfile (89524 => 89525)

--- trunk/dports/python/py-aplpy/Portfile 2012-02-01 17:04:01 UTC (rev 89524) +++ trunk/dports/python/py-aplpy/Portfile 2012-02-01 17:05:15 UTC (rev 89525) <at> <at> -6,6 +6,7 <at> <at> name py-aplpy version 0.9.6 +revision 1 maintainers robitaille stsci.edu:mperrin categories-append science
_______________________________________________
macports-changes mailing list
macports-changes <at> lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-changes

_______________________________________________
macports-dev mailing list
macports-dev-qhrM8SXbD5JBG2y7cWolcg@public.gmane.orgforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Thomas Robitaille | 1 Feb 22:41
Picon
Gravatar

Re: [89525] trunk/dports/python/py-aplpy/Portfile

Ok, thanks for clarifying! I won't update the revision in future when
simply converting a port to unified format.

Cheers,
Tom

On 1 February 2012 19:47, Frank Schima <macsforever2000@...> wrote:
> You don't need to update the revision when unifying python ports.
>
>
> On Feb 1, 2012, at 10:05 AM, robitaille@... wrote:
>
> Revision 89525 Author robitaille@... Date 2012-02-01
09:05:15 -0800
> (Wed, 01 Feb 2012)
>
> Log Message
>
> py-aplpy: set revision to 1 (should have done it when updating to unified
> port format)
>
> Modified Paths
>
> trunk/dports/python/py-aplpy/Portfile
>
> Diff
>
> Modified: trunk/dports/python/py-aplpy/Portfile (89524 => 89525)
>
> --- trunk/dports/python/py-aplpy/Portfile	2012-02-01 17:04:01 UTC (rev
> 89524)
> +++ trunk/dports/python/py-aplpy/Portfile	2012-02-01 17:05:15 UTC (rev
> 89525)
> @@ -6,6 +6,7 @@
>
>  name                py-aplpy
>  version             0.9.6
> +revision            1
>  maintainers         robitaille stsci.edu:mperrin
>
>  categories-append   science
>
> _______________________________________________
> macports-changes mailing list
> macports-changes@...
> http://lists.macosforge.org/mailman/listinfo.cgi/macports-changes
>
>
Arno Hautala | 2 Feb 05:03
Favicon
Gravatar

Suggestion for new pseudo-portnames

The recent RFC for making an alias action for active and inactive
reminded me of some queries that I frequently use when working with
ports.

Specifically, outdated ports that have been upgraded (redundant), and
uninstalled dependencies (outstanding).

redundant can currently be achieved with "actinact and inactive"

For example:
> port selfupdate
> port echo outdated
> port upgrade outdated

> port uninstall actinact and inactive
or rather
> port uninstall redundant

outstanding right now would be "rdepof:<port> and not installed"

For example:
> port echo outstanding:gimp
...very long list
^C
> forget this!

One quandary for "outstanding" is whether the rdep search should be
performed first, or should branches be pruned as soon as an installed
port is discovered? Maybe separate that question into "outstanding"
and "routstanding"?

There may be better names of course.

Is this worth submitting an issue to trac? Or, are these just
redundant names for queries that are already possible?

I'd like to start hacking on base myself, so I'll be looking at
port.tcl, but I don't anticipate having anything to submit anytime
soon, just in case anyone considers this such an amazing idea they
can't wait to implement it ;-).

--

-- 
arno  s  hautala    /-|   arno <at> alum.wpi.edu

pgp b2c9d448
_______________________________________________
macports-dev mailing list
macports-dev <at> lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Gmane