Ryan Schmidt | 1 Feb 18:30 2008

Re: [33633] trunk/dports/print/abcm2ps/Portfile

You forgot to commit the rename of the patchfile.

$ sudo port install abcm2ps
--->  Fetching abcm2ps
--->  Attempting to fetch patch-Makefile.in.diff from http:// 
svn.macports.org/repository/macports/distfiles/abcm2ps
--->  Attempting to fetch patch-Makefile.in.diff from http:// 
svn.macports.org/repository/macports/distfiles/general/
--->  Attempting to fetch patch-Makefile.in.diff from http:// 
svn.macports.org/repository/macports/downloads/abcm2ps
Error: Target org.macports.fetch returned: fetch failed
Error: Status 1 encountered during processing.
$

On Feb 1, 2008, at 09:15, mww@... wrote:

> Revision: 33633
>           http://trac.macosforge.org/projects/macports/changeset/33633
> Author:   mww@...
> Date:     2008-02-01 07:15:26 -0800 (Fri, 01 Feb 2008)
>
> Log Message:
> -----------
> version 5.7.4
>
> Modified Paths:
> --------------
>     trunk/dports/print/abcm2ps/Portfile
>
> Modified: trunk/dports/print/abcm2ps/Portfile
(Continue reading)

John Owens | 1 Feb 23:55 2008
Picon

how to commit ...

OK, hate to admit this, but I'm ready to make a 
change to a portfile and, with the permission
of the port maintainer, am ready to check
into svn. But I don't know how, and I can't
find any docs on macports.org on how to do this.
I've used svn before ...

What is the server? (svn.macports.org?)
What is the path (just /trunk/...)?
Log in with my macports id? username or 
  username@...?
Is there any way to do this without having
  to check out a working copy (I'd rather just
  change a Portfile and the Portindex locally,
  check it works, and then check in the Portfile
  back into trunk)?

Good doc to have on the wiki.

JDO

Ryan Schmidt | 2 Feb 00:25 2008

Re: how to commit ...


On Feb 1, 2008, at 16:55, John Owens wrote:

> OK, hate to admit this, but I'm ready to make a
> change to a portfile and, with the permission
> of the port maintainer, am ready to check
> into svn. But I don't know how, and I can't
> find any docs on macports.org on how to do this.
> I've used svn before ...
>
> What is the server? (svn.macports.org?)

You can use either of these:

http://svn.macports.org/repository/macports
http://svn.macosforge.org/repository/macports

> What is the path (just /trunk/...)?

Ports are in /trunk/dports

> Log in with my macports id? username or
>   username@...?

Your macports.org email address.

> Is there any way to do this without having
>   to check out a working copy (I'd rather just
>   change a Portfile and the Portindex locally,
>   check it works, and then check in the Portfile
(Continue reading)

John Owens | 2 Feb 01:11 2008
Picon

Re: how to commit ...

Ryan Schmidt <ryandesign <at> ...> writes:

+ + Is there any way to do this without having
+ +   to check out a working copy (I'd rather just
+ +   change a Portfile and the Portindex locally,
+ +   check it works, and then check in the Portfile
+ +   back into trunk)?
+ 
+ You don't need to do anything to the portindex. You just need to  
+ modify the portfile, test, and when you're sure it works, commit it.  
+ You do need a working copy to commit changes to files. Personally I  
+ just changed my dports tree from an rsync update to a subversion  
+ working copy and use that. Yes, you will be checking in to trunk/ 
+ dports. (The dports don't live anywhere except in trunk, and really  
+ they belong outside of trunk, but rearranging that at this point is  
+ complicated and nobody has felt it worth the effort yet, though jmpp  
+ did bring it up at one point.)

First, can you expand on *exactly* what you do here (rsync->svn),
and second, does anyone have any other methods? Good to collect
methods that work. :)

JDO

Ryan Schmidt | 2 Feb 01:29 2008

Re: how to commit ...


On Feb 1, 2008, at 18:11, John Owens wrote:

> Ryan Schmidt <ryandesign <at> ...> writes:
>
> + + Is there any way to do this without having
> + +   to check out a working copy (I'd rather just
> + +   change a Portfile and the Portindex locally,
> + +   check it works, and then check in the Portfile
> + +   back into trunk)?
> +
> + You don't need to do anything to the portindex. You just need to
> + modify the portfile, test, and when you're sure it works, commit it.
> + You do need a working copy to commit changes to files. Personally I
> + just changed my dports tree from an rsync update to a subversion
> + working copy and use that. Yes, you will be checking in to trunk/
> + dports. (The dports don't live anywhere except in trunk, and really
> + they belong outside of trunk, but rearranging that at this point is
> + complicated and nobody has felt it worth the effort yet, though jmpp
> + did bring it up at one point.)
>
> First, can you expand on *exactly* what you do here (rsync->svn),
> and second, does anyone have any other methods? Good to collect
> methods that work. :)

In order to commit things to the repository, I need a working copy. I  
tend to work all over the repository, including my own several dozen  
ports, tickets for nomaintainer ports, cleanup involving several  
ports at once, even the occasional change to the documentation, web  
site or the base code. I checked out the entire trunk to my home  
(Continue reading)

Juan Manuel Palacios | 2 Feb 09:31 2008

Re: [33639] branches/release_1_6/base/portmgr/dmg/postflight


On Feb 2, 2008, at 2:46 AM, jmpp-/EBbbHb69GVg9hUCZPvPmw@public.gmane.org wrote:

Revision33639Authorjmpp-/EBbbHb69GVg9hUCZPvPmw@public.gmane.orgDate2008-02-01 23:16:35 -0800 (Fri, 01 Feb 2008)

Log Message

* Use dscl(1) to detect the default shell for the installing user, rather than trying to infer it from the inherited environment (which did not reflect the user's at all, as it is entirely imposed by Installer.app when the pkg is used in real life). Thanks to Ryan on macports-dev for the original suggestion! * Provide a little more information about the shell we detected. NOTE: I tested this edited script through a test pkg on Leopard and it works, both when used from an account with a bash shell and from one with a tcsh shell. If anyone cares to test on Tiger and/or Panther, they should contact me so I can hand them the pkg, thanks! In any case, I'm feeling confident it'll work consistently this time round to detect the shell type, given the nature of the dscl operation.

As you can see from the diff in this commit, I used an alternate method to get the sole shell name (awk). But in any case, the all work and produce the same output, as discussed on IRC earlier today, it's only a matter of taste.

I've put together a test dmg that has the latest /branches/release_1_6/base/portmgr/dmg/postflight in it, available at the following URL:




Appreciate it if anyone has a chance to help me test it, per my commit log above. Tiger and Panther reports would be great!

Regards,...


-jmpp

PS: Note that the MacPorts code in the installer is not necessarily what 1.6.1 final will be, I exported a tarball off the branch some days ago (so it's definitely not current wrt trunk and may even not be current wrt the branch itself. I'm only interested here in the behavior of the postflight script when run from within Installer.app (which is what was crippling the $SHELL evn variable detection).

<div>
<br><div>
<div>On Feb 2, 2008, at 2:46 AM, <a href="mailto:jmpp@...">jmpp@...</a> wrote:</div>
<br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span"><div><div>Revision<a href="http://trac.macosforge.org/projects/macports/changeset/33639">33639</a>Author<a href="mailto:jmpp@...">jmpp@...</a>Date2008-02-01 23:16:35 -0800 (Fri, 01 Feb 2008)<h3>Log Message</h3> * Use dscl(1) to detect the default shell for the installing user, rather than trying to infer it from the inherited environment
   (which did not reflect the user's at all, as it is entirely imposed by Installer.app when the pkg is used in real life). Thanks
   to Ryan on macports-dev for the original suggestion!

 * Provide a little more information about the shell we detected.

NOTE: I tested this edited script through a test pkg on Leopard and it works, both when used from an account with a bash shell and
from one with a tcsh shell. If anyone cares to test on Tiger and/or Panther, they should contact me so I can hand them the pkg, thanks!
In any case, I'm feeling confident it'll work consistently this time round to detect the shell type, given the nature of the dscl operation.</div></div></span></blockquote>
<br>
</div>
<div>
<span class="Apple-tab-span">	</span>As you can see from the diff in this commit, I used an alternate method to get the sole shell name (awk). But in any case, the all work and produce the same output, as discussed on IRC earlier today, it's only a matter of taste.<br>
</div>
<div><br></div>
<div>
<span class="Apple-tab-span">	</span>I've put together a test dmg that has the latest /branches/release_1_6/base/portmgr/dmg/postflight in it, available at the following URL:<br class="webkit-block-placeholder">
</div>
<div><br class="webkit-block-placeholder"></div>
<div><br class="webkit-block-placeholder"></div>
<div><a href="http://apollo.homeunix.net/macports/downloads/MacPorts-1.6.1.dmg">http://apollo.homeunix.net/macports/downloads/MacPorts-1.6.1.dmg</a></div>
<div><br class="webkit-block-placeholder"></div>
<div><br class="webkit-block-placeholder"></div>
<div>
<span class="Apple-tab-span">	</span>Appreciate it if anyone has a chance&nbsp;to help me test it, per my commit log above. Tiger and Panther reports would be great!<br class="webkit-block-placeholder">
</div>
<div><br class="webkit-block-placeholder"></div>
<div>
<span class="Apple-tab-span">	</span>Regards,...<br class="webkit-block-placeholder">
</div>
<div><br class="webkit-block-placeholder"></div>
<div><br class="webkit-block-placeholder"></div>
<div>-jmpp</div>
<div><br class="webkit-block-placeholder"></div>
<div>PS: Note that the MacPorts code in the installer is not necessarily what 1.6.1 final will be, I exported a tarball off the branch some days ago (so it's definitely not current wrt trunk and may even not be current wrt the branch itself. I'm only interested here in the behavior of the postflight script when run from within Installer.app (which is what was crippling the $SHELL evn variable detection).</div>
<div><br class="webkit-block-placeholder"></div>
</div>
Ryan Schmidt | 2 Feb 17:11 2008

Re: [33653] trunk/dports/net/psi/Portfile

Looks like you didn't commit the patchfiles.

$ sudo port checksum psi +plugins
--->  Fetching psi
--->  Attempting to fetch patch-src_about.ui from http:// 
svn.macports.org/repository/macports/distfiles/psi
--->  Attempting to fetch patch-src_about.ui from http:// 
svn.macports.org/repository/macports/distfiles/general/
--->  Attempting to fetch patch-src_about.ui from http:// 
svn.macports.org/repository/macports/downloads/psi
Error: Target org.macports.fetch returned: fetch failed
Error: Status 1 encountered during processing.
$

Also, the patchfile names aren't up to code.

$ sudo port lint psi +plugins
--->  Verifying Portfile for psi
Warning: Line 4 should be a newline (after PortSystem)
Warning: Patchfile patch-src_about.ui does not follow the source  
patch naming policy "patch-*.diff"
Warning: Patchfile patch-src_psiaccount.cpp does not follow the  
source patch naming policy "patch-*.diff"
Warning: Patchfile patch-src_pluginmanager.cpp does not follow the  
source patch naming policy "patch-*.diff"
Warning: Patchfile patch-src_psiplugin.h does not follow the source  
patch naming policy "patch-*.diff"
Warning: Patchfile patch-src_pluginmanager.h does not follow the  
source patch naming policy "patch-*.diff"
Warning: Patchfile patch-configure does not follow the source patch  
naming policy "patch-*.diff"
--->  0 errors and 7 warnings found.
$

On Feb 2, 2008, at 10:01, rowue@... wrote:

> Revision: 33653
>           http://trac.macosforge.org/projects/macports/changeset/33653
> Author:   rowue@...
> Date:     2008-02-02 08:01:42 -0800 (Sat, 02 Feb 2008)
>
> Log Message:
> -----------
> Added variant bundledqca for use of bundled qca and
> variant plugins for use of experimental plugin feature
>
> Modified Paths:
> --------------
>     trunk/dports/net/psi/Portfile
>
> Modified: trunk/dports/net/psi/Portfile
> ===================================================================
> --- trunk/dports/net/psi/Portfile	2008-02-02 15:42:56 UTC (rev 33652)
> +++ trunk/dports/net/psi/Portfile	2008-02-02 16:01:42 UTC (rev 33653)

[snip]

> +variant plugins description {Build with experimental Plugin  
> Support} {
> +
> +patchfiles-append   patch-src_about.ui \
> +                    patch-src_psiaccount.cpp \
> +                    patch-src_pluginmanager.cpp \
> +                    patch-src_psiplugin.h \
> +                    patch-src_pluginmanager.h \
> +                    patch-configure
> +
> +configure.args-append   --enable-plugins
> +}
Bryan Blackburn | 2 Feb 23:49 2008

macports-users list dead?

I haven't seen any mail on macports-users since the 29th of January;  
also, the archives[1] appear to stop at that same day, so I don't  
think it's an issue with my delivery alone.

Bryan

[1] - <http://lists.macosforge.org/pipermail/macports-users/>

William Siegrist | 3 Feb 00:10 2008
Picon

Re: macports-users list dead?

I'm looking into it. Thanks for reporting it.

-Bill

On Feb 2, 2008, at 2:49 PM, Bryan Blackburn wrote:

> I haven't seen any mail on macports-users since the 29th of January;  
> also, the archives[1] appear to stop at that same day, so I don't  
> think it's an issue with my delivery alone.
>
> Bryan
>
> [1] - <http://lists.macosforge.org/pipermail/macports-users/>
>
> _______________________________________________
> macports-dev mailing list
> macports-dev@...
> http://lists.macosforge.org/mailman/listinfo/macports-dev

----
William Siegrist
Software Support Engineer
Mac OS Forge
http://macosforge.org/
wsiegrist@...
408 862 7337

Attachment (smime.p7s): application/pkcs7-signature, 3271 bytes
I'm looking into it. Thanks for reporting it.

-Bill

On Feb 2, 2008, at 2:49 PM, Bryan Blackburn wrote:

> I haven't seen any mail on macports-users since the 29th of January;  
> also, the archives[1] appear to stop at that same day, so I don't  
> think it's an issue with my delivery alone.
>
> Bryan
>
> [1] - <http://lists.macosforge.org/pipermail/macports-users/>
>
> _______________________________________________
> macports-dev mailing list
> macports-dev@...
> http://lists.macosforge.org/mailman/listinfo/macports-dev

----
William Siegrist
Software Support Engineer
Mac OS Forge
http://macosforge.org/
wsiegrist@...
408 862 7337

William Siegrist | 3 Feb 00:16 2008
Picon

macports-users has been fixed

Sorry for the oversight, there was a mis-set permission on the server  
for macports-users. All the mail got deferred and has now been  
delivered.

-Bill

----
William Siegrist
Software Support Engineer
Mac OS Forge
http://macosforge.org/
wsiegrist <at> apple.com
408 862 7337

Attachment (smime.p7s): application/pkcs7-signature, 3271 bytes
Sorry for the oversight, there was a mis-set permission on the server  
for macports-users. All the mail got deferred and has now been  
delivered.

-Bill

----
William Siegrist
Software Support Engineer
Mac OS Forge
http://macosforge.org/
wsiegrist <at> apple.com
408 862 7337


Gmane