headers
reedy | 1 May 2011 01:18
Picon
Favicon

SVN: [87178] trunk/phase3/includes

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87178

Revision: 87178
Author:   reedy
Date:     2011-04-30 23:18:34 +0000 (Sat, 30 Apr 2011)
Log Message:
-----------
Followup r85884

Fixup the APIs strange way of doing table aliases on a join....

Only used in very few places

Modified Paths:
--------------
    trunk/phase3/includes/api/ApiQueryAllUsers.php
    trunk/phase3/includes/api/ApiQueryBase.php
    trunk/phase3/includes/api/ApiQueryWatchlist.php
    trunk/phase3/includes/db/Database.php

Modified: trunk/phase3/includes/api/ApiQueryAllUsers.php
===================================================================
--- trunk/phase3/includes/api/ApiQueryAllUsers.php	2011-04-30 22:12:51 UTC (rev 87177)
+++ trunk/phase3/includes/api/ApiQueryAllUsers.php	2011-04-30 23:18:34 UTC (rev 87178)
 <at>  <at>  -89,8 +89,7  <at>  <at> 
 			$useIndex = false;
 			// Filter only users that belong to a given group
 			$this->addTables( 'user_groups', 'ug1' );
-			$ug1 = $this->getAliasedName( 'user_groups', 'ug1' );
-			$this->addJoinConds( array( $ug1 => array( 'INNER JOIN', array( 'ug1.ug_user=user_id',
(Continue reading)

Permalink | Reply | 0 comments |
headers
reedy | 1 May 2011 02:17
Picon
Favicon

SVN: [87179] trunk/phase3/includes/api/ApiQueryWatchlist.php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87179

Revision: 87179
Author:   reedy
Date:     2011-05-01 00:17:39 +0000 (Sun, 01 May 2011)
Log Message:
-----------
$db is already defined, don't use $this->getDB() again

Modified Paths:
--------------
    trunk/phase3/includes/api/ApiQueryWatchlist.php

Modified: trunk/phase3/includes/api/ApiQueryWatchlist.php
===================================================================
--- trunk/phase3/includes/api/ApiQueryWatchlist.php	2011-04-30 23:18:34 UTC (rev 87178)
+++ trunk/phase3/includes/api/ApiQueryWatchlist.php	2011-05-01 00:17:39 UTC (rev 87179)
 <at>  <at>  -176,7 +176,7  <at>  <at> 
 			$this->addWhereFld( 'rc_user_text', $params['user'] );
 		}
 		if ( !is_null( $params['excludeuser'] ) ) {
-			$this->addWhere( 'rc_user_text != ' . $this->getDB()->addQuotes( $params['excludeuser'] ) );
+			$this->addWhere( 'rc_user_text != ' . $db->addQuotes( $params['excludeuser'] ) );
 		}

 		// This is an index optimization for mysql, as done in the Special:Watchlist page
Permalink | Reply | 0 comments |
headers
reedy | 1 May 2011 02:24
Picon
Favicon

SVN: [87180] trunk/phase3

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87180

Revision: 87180
Author:   reedy
Date:     2011-05-01 00:24:39 +0000 (Sun, 01 May 2011)
Log Message:
-----------
* (bug 28225) Allow hiding of user groups in list=allusers

Yay, a LEFT OUTER JOIN

Modified Paths:
--------------
    trunk/phase3/RELEASE-NOTES
    trunk/phase3/includes/api/ApiQueryAllUsers.php

Modified: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	2011-05-01 00:17:39 UTC (rev 87179)
+++ trunk/phase3/RELEASE-NOTES	2011-05-01 00:24:39 UTC (rev 87180)
 <at>  <at>  -368,6 +368,7  <at>  <at> 
 * (bug 27179) API: List of extension tags through meta=siteinfo
 * Get a list of function hooks through meta=siteinfo
 * Get a list of all subscribed hooks, and those subscribers
+* (bug 28225) Allow hiding of user groups in list=allusers

 === Languages updated in 1.18 ===

Modified: trunk/phase3/includes/api/ApiQueryAllUsers.php
===================================================================
(Continue reading)

Permalink | Reply | 0 comments |
headers
reedy | 1 May 2011 02:49
Picon
Favicon

SVN: [87181] trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87181

Revision: 87181
Author:   reedy
Date:     2011-05-01 00:49:17 +0000 (Sun, 01 May 2011)
Log Message:
-----------
Feedbacks isn't English

Modified Paths:
--------------
    trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php

Modified: trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php
===================================================================
--- trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php	2011-05-01 00:24:39 UTC (rev 87180)
+++ trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php	2011-05-01 00:49:17 UTC (rev 87181)
 <at>  <at>  -397,7 +397,7  <at>  <at> 

 	public function getDescription() {
 		return array(
-			'Submit article feedbacks'
+			'Submit article feedback'
 		);
 	}
Permalink | Reply | 0 comments |
headers
nikerabbit | 1 May 2011 11:46
Picon
Favicon

SVN: [87182] trunk/extensions/Translate/groups/Mifos/Mifos.yaml

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87182

Revision: 87182
Author:   nikerabbit
Date:     2011-05-01 09:46:46 +0000 (Sun, 01 May 2011)
Log Message:
-----------
New group for mifos

Modified Paths:
--------------
    trunk/extensions/Translate/groups/Mifos/Mifos.yaml

Modified: trunk/extensions/Translate/groups/Mifos/Mifos.yaml
===================================================================
--- trunk/extensions/Translate/groups/Mifos/Mifos.yaml	2011-05-01 00:49:17 UTC (rev 87181)
+++ trunk/extensions/Translate/groups/Mifos/Mifos.yaml	2011-05-01 09:46:46 UTC (rev 87182)
 <at>  <at>  -1096,3 +1096,19  <at>  <at> 
   sourcePattern: %GROUPROOT%/mifos/userInterface/src/main/resources/org/mifos/ui/localizedProperties/widget_messages_%CODE%.properties
   definitionFile: %GROUPROOT%/mifos/userInterface/src/main/resources/org/mifos/ui/localizedProperties/widget_messages.properties
   targetPattern: mifos/userInterface/src/main/resources/org/mifos/ui/localizedProperties/widget_messages_%CODE%.properties
+
+---
+BASIC:
+  id: out-mifos-accounting
+  label: Mifos - Accounting
+
+MANGLER:
+  class: StringMatcher
+  prefix: accounting-
(Continue reading)

Permalink | Reply | 0 comments |
headers
reedy | 1 May 2011 13:20
Picon
Favicon

SVN: [87183] trunk/phase3/includes/api/ApiQueryAllUsers.php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87183

Revision: 87183
Author:   reedy
Date:     2011-05-01 11:20:14 +0000 (Sun, 01 May 2011)
Log Message:
-----------
Remove unneeded manual quoting from r87180

Modified Paths:
--------------
    trunk/phase3/includes/api/ApiQueryAllUsers.php

Modified: trunk/phase3/includes/api/ApiQueryAllUsers.php
===================================================================
--- trunk/phase3/includes/api/ApiQueryAllUsers.php	2011-05-01 09:46:46 UTC (rev 87182)
+++ trunk/phase3/includes/api/ApiQueryAllUsers.php	2011-05-01 11:20:14 UTC (rev 87183)
 <at>  <at>  -103,7 +103,7  <at>  <at> 
 			$this->addTables( 'user_groups', 'ug1' );

 			if ( count( $params['excludegroup'] ) == 1 ) {
-				$exclude = array( 'ug1.ug_group = ' . $db->addQuotes( $params['excludegroup'][0] ) );
+				$exclude = array( 'ug1.ug_group' => $params['excludegroup'][0] );
 			} else {
 				$exclude = array( $db->makeList( array( 'ug1.ug_group' => $params['excludegroup'] ), LIST_OR ) );
 			}
Permalink | Reply | 0 comments |
headers
yaron | 1 May 2011 15:17
Picon
Favicon

SVN: [87184] trunk/extensions/SemanticForms/includes/SF_FormPrinter.php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87184

Revision: 87184
Author:   yaron
Date:     2011-05-01 13:17:36 +0000 (Sun, 01 May 2011)
Log Message:
-----------
Fix to handle default value of '0'

Modified Paths:
--------------
    trunk/extensions/SemanticForms/includes/SF_FormPrinter.php

Modified: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
===================================================================
--- trunk/extensions/SemanticForms/includes/SF_FormPrinter.php	2011-05-01 11:20:14 UTC (rev 87183)
+++ trunk/extensions/SemanticForms/includes/SF_FormPrinter.php	2011-05-01 13:17:36 UTC (rev 87184)
 <at>  <at>  -795,7 +795,7  <at>  <at> 
 					}

 					if ( empty( $cur_value ) && !$form_submitted ) {
-						if ( $default_value ) {
+						if ( !is_null( $default_value ) ) {
 							// Set to the default value specified in the form, if it's there.
 							$cur_value = $default_value;
 						} elseif ( $preload_page ) {
Permalink | Reply | 0 comments |
headers
krinkle | 1 May 2011 15:18
Picon
Favicon

SVN: [87185] trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ ext.articleFeedback.js

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87185

Revision: 87185
Author:   krinkle
Date:     2011-05-01 13:18:51 +0000 (Sun, 01 May 2011)
Log Message:
-----------
(bug 28737) inArray returns the index if found (can also be 0), or -1 if not found

Modified Paths:
--------------
    trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js

Modified: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
===================================================================
---
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js	2011-05-01
13:17:36 UTC (rev 87184)
+++
trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js	2011-05-01
13:18:51 UTC (rev 87185)
 <at>  <at>  -280,7 +280,7  <at>  <at> 
 					var groups =  mw.config.get( 'wgUserGroups' );
 					// Verify that each restriction exists in the user's groups
 					for ( var i = 0; i < restrictions.length; i++ ) {
-						if ( !$.inArray( restrictions[i], groups ) ) {
+						if ( $.inArray( restrictions[i], groups ) < 0 ) {
 							return false;
 						}
 					}
(Continue reading)

Permalink | Reply | 0 comments |
headers
krinkle | 1 May 2011 15:33
Picon
Favicon

SVN: [87186] trunk/extensions/ClickTracking/modules/ext.UserBuckets.js

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87186

Revision: 87186
Author:   krinkle
Date:     2011-05-01 13:33:56 +0000 (Sun, 01 May 2011)
Log Message:
-----------
Follow-up r86961: Code conventions; line-wrap around 80-100 chars; using isFunction instead of typeof check

Modified Paths:
--------------
    trunk/extensions/ClickTracking/modules/ext.UserBuckets.js

Modified: trunk/extensions/ClickTracking/modules/ext.UserBuckets.js
===================================================================
--- trunk/extensions/ClickTracking/modules/ext.UserBuckets.js	2011-05-01 13:18:51 UTC (rev 87185)
+++ trunk/extensions/ClickTracking/modules/ext.UserBuckets.js	2011-05-01 13:33:56 UTC (rev 87186)
 <at>  <at>  -21,25 +21,25  <at>  <at> 
 	var buckets = $.getBuckets();
 	for ( var iter in mw.activeCampaigns ) {
 		var campaign = mw.activeCampaigns[iter];
-		// if bucket has been set, or bucket version is out of date,
-		// set up a user bucket
-		if(campaign.all){
+		// If bucket has been set, or bucket version is out of date,
+		// set up a user bucket.
+		if ( campaign.all ){
 			campaign.all();
 		}
(Continue reading)

Permalink | Reply | 0 comments |
headers
ialex | 1 May 2011 15:49
Picon
Favicon

SVN: [87187] trunk/extensions

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87187

Revision: 87187
Author:   ialex
Date:     2011-05-01 13:49:16 +0000 (Sun, 01 May 2011)
Log Message:
-----------
svn:eol-style native (and svn:mime-type where needed)

Property Changed:
----------------
    trunk/extensions/WebFonts/fonts/my/MasterpieceUniSans.svg
    trunk/extensions/WebFonts/fonts/my/Myanmar3.svg
    trunk/extensions/WebFonts/fonts/my/Padauk-Regular.svg
    trunk/extensions/WebFonts/fonts/my/Yunghkio.svg
    trunk/extensions/WikiLove/WikiLove.i18n.php
    trunk/extensions/WikiLove/WikiLove.php
    trunk/extensions/WikiLove/WikiLove.sql

Property changes on: trunk/extensions/WebFonts/fonts/my/MasterpieceUniSans.svg
___________________________________________________________________
Added: svn:mime-type
   + image/svg+xml

Property changes on: trunk/extensions/WebFonts/fonts/my/Myanmar3.svg
___________________________________________________________________
Added: svn:mime-type
   + image/svg+xml

Property changes on: trunk/extensions/WebFonts/fonts/my/Padauk-Regular.svg
(Continue reading)

Permalink | Reply | 0 comments |

Gmane