reedy | 1 Sep 01:08 2010
Picon

SVN: [72062] trunk/extensions/CodeReview

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72062

Revision: 72062
Author:   reedy
Date:     2010-08-31 23:08:22 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
More braces

Modified Paths:
--------------
    trunk/extensions/CodeReview/backend/CodeRepository.php
    trunk/extensions/CodeReview/backend/DiffHighlighter.php
    trunk/extensions/CodeReview/ui/CodeReleaseNotes.php
    trunk/extensions/CodeReview/ui/CodeRevisionListView.php
    trunk/extensions/CodeReview/ui/SpecialCode.php

Modified: trunk/extensions/CodeReview/backend/CodeRepository.php
===================================================================
--- trunk/extensions/CodeReview/backend/CodeRepository.php	2010-08-31 22:56:20 UTC (rev 72061)
+++ trunk/extensions/CodeReview/backend/CodeRepository.php	2010-08-31 23:08:22 UTC (rev 72062)
 <at>  <at>  -412,12 +412,14  <at>  <at> 
 			__METHOD__
 		);
 		$user = null;
-		if ( $wikiUser !== false )
+		if ( $wikiUser !== false ) {
 			$user = User::newFromName( $wikiUser );
-		if ( $user instanceof User )
(Continue reading)

tparscal | 1 Sep 01:15 2010
Picon

SVN: [72063] branches/resourceloader/phase3/resources/mediawiki/mediawiki. js

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72063

Revision: 72063
Author:   tparscal
Date:     2010-08-31 23:15:54 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
Added auto-register from pre-loaded manifest. Now when this loads, it tries to execute a startup routine
which registers the initial module map.

Modified Paths:
--------------
    branches/resourceloader/phase3/resources/mediawiki/mediawiki.js

Modified: branches/resourceloader/phase3/resources/mediawiki/mediawiki.js
===================================================================
--- branches/resourceloader/phase3/resources/mediawiki/mediawiki.js	2010-08-31 23:08:22 UTC
(rev 72062)
+++ branches/resourceloader/phase3/resources/mediawiki/mediawiki.js	2010-08-31 23:15:54 UTC
(rev 72063)
 <at>  <at>  -586,4 +586,11  <at>  <at> 
 	
 	this.util = {};
 	this.legacy = {};
+	
+	/* Auto-register from pre-loaded startup scripts */
+	
+	if ( typeof window['mediaWikiStartUp'] === 'function' ) {
+		window['mediaWikiStartUp']();
(Continue reading)

catrope | 1 Sep 01:28 2010
Picon

SVN: [72064] branches/resourceloader/phase3

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72064

Revision: 72064
Author:   catrope
Date:     2010-08-31 23:28:50 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
resourceloader: Put startup code in its own module

Modified Paths:
--------------
    branches/resourceloader/phase3/includes/ResourceLoader.php
    branches/resourceloader/phase3/includes/ResourceLoaderModule.php
    branches/resourceloader/phase3/resources/Resources.php

Modified: branches/resourceloader/phase3/includes/ResourceLoader.php
===================================================================
--- branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:15:54 UTC (rev 72063)
+++ branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:28:50 UTC (rev 72064)
 <at>  <at>  -117,14 +117,14  <at>  <at> 
 	 * 
 	 *  <at> return {string} JavaScript code for registereing all modules with client loader
 	 */
-	protected static function getModuleRegistrations() {
+	public static function getModuleRegistrations() {
 		$scripts = '';
 		$registrations = array();
 		foreach ( self::$modules as $name => $module ) {
 			if ( !in_array( $name, self::$preRegisteredModules ) ) {
(Continue reading)

catrope | 1 Sep 01:36 2010
Picon

SVN: [72065] branches/resourceloader/phase3/includes/ResourceLoader.php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72065

Revision: 72065
Author:   catrope
Date:     2010-08-31 23:36:48 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
resourceloader: Put modification timestamp in registration data

Modified Paths:
--------------
    branches/resourceloader/phase3/includes/ResourceLoader.php

Modified: branches/resourceloader/phase3/includes/ResourceLoader.php
===================================================================
--- branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:28:50 UTC (rev 72064)
+++ branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:36:48 UTC (rev 72065)
 <at>  <at>  -115,7 +115,7  <at>  <at> 
 	/**
 	 * Gets registration code for all modules, except pre-registered ones listed in self::$preRegisteredModules
 	 * 
-	 *  <at> return {string} JavaScript code for registereing all modules with client loader
+	 *  <at> return {string} JavaScript code for registering all modules with the client loader
 	 */
 	public static function getModuleRegistrations() {
 		$scripts = '';
 <at>  <at>  -130,11 +130,11  <at>  <at> 
 				else {
 					// Modules without dependencies pass one argument (name) to mediaWiki.loader.register()
(Continue reading)

adam | 1 Sep 01:41 2010
Picon

SVN: [72066] trunk/extensions/ArticleAssessmentPilot

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72066

Revision: 72066
Author:   adam
Date:     2010-08-31 23:41:19 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
ArticleAssessment in progress commit...need to head home for the night and will be working more on it later
at home

Modified Paths:
--------------
    trunk/extensions/ArticleAssessmentPilot/css/ArticleAssessment.css
    trunk/extensions/ArticleAssessmentPilot/js/ArticleAssessment.js
    trunk/extensions/ArticleAssessmentPilot/js/jquery.cookie.js
    trunk/extensions/ArticleAssessmentPilot/js/jquery.stars.js
    trunk/extensions/ArticleAssessmentPilot/js/jquery.tipsy.js

Modified: trunk/extensions/ArticleAssessmentPilot/css/ArticleAssessment.css
===================================================================
--- trunk/extensions/ArticleAssessmentPilot/css/ArticleAssessment.css	2010-08-31 23:36:48 UTC
(rev 72065)
+++ trunk/extensions/ArticleAssessmentPilot/css/ArticleAssessment.css	2010-08-31 23:41:19 UTC
(rev 72066)
 <at>  <at>  -91,6 +91,7  <at>  <at> 
 }
 .article-assessment-wrapper .rating-field-label{
 	float: left;
+	font-weight: bold;
(Continue reading)

catrope | 1 Sep 01:44 2010
Picon

SVN: [72067] branches/resourceloader/phase3/includes/ResourceLoaderModule. php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72067

Revision: 72067
Author:   catrope
Date:     2010-08-31 23:44:53 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
resourceloader: Add in-object caching for modification times

Modified Paths:
--------------
    branches/resourceloader/phase3/includes/ResourceLoaderModule.php

Modified: branches/resourceloader/phase3/includes/ResourceLoaderModule.php
===================================================================
--- branches/resourceloader/phase3/includes/ResourceLoaderModule.php	2010-08-31 23:41:19 UTC
(rev 72066)
+++ branches/resourceloader/phase3/includes/ResourceLoaderModule.php	2010-08-31 23:44:53 UTC
(rev 72067)
 <at>  <at>  -121,6 +121,8  <at>  <at> 
 	
 	// In-object cache for file dependencies
 	private $fileDeps = null;
+	// In-object cache for mtime
+	private $modifiedTime = null;
 	
 	/* Public methods */
 	
 <at>  <at>  -360,6 +362,10  <at>  <at> 
(Continue reading)

catrope | 1 Sep 01:49 2010
Picon

SVN: [72068] branches/resourceloader/phase3/includes/ResourceLoader.php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72068

Revision: 72068
Author:   catrope
Date:     2010-08-31 23:49:20 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
resourceloader: Move getModuleRegistrations() to the right section

Modified Paths:
--------------
    branches/resourceloader/phase3/includes/ResourceLoader.php

Modified: branches/resourceloader/phase3/includes/ResourceLoader.php
===================================================================
--- branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:44:53 UTC (rev 72067)
+++ branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:49:20 UTC (rev 72068)
 <at>  <at>  -112,37 +112,6  <at>  <at> 
 		return $result;
 	}
 	
-	/**
-	 * Gets registration code for all modules, except pre-registered ones listed in self::$preRegisteredModules
-	 * 
-	 *  <at> return {string} JavaScript code for registering all modules with the client loader
-	 */
-	public static function getModuleRegistrations() {
-		$scripts = '';
-		$registrations = array();
(Continue reading)

catrope | 1 Sep 01:59 2010
Picon

SVN: [72069] branches/resourceloader/phase3/includes

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72069

Revision: 72069
Author:   catrope
Date:     2010-08-31 23:59:44 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
resourceloader: Write a function to get the highest mtime of all modules and use that as the startup
module's mtime

Modified Paths:
--------------
    branches/resourceloader/phase3/includes/ResourceLoader.php
    branches/resourceloader/phase3/includes/ResourceLoaderModule.php

Modified: branches/resourceloader/phase3/includes/ResourceLoader.php
===================================================================
--- branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:49:20 UTC (rev 72068)
+++ branches/resourceloader/phase3/includes/ResourceLoader.php	2010-08-31 23:59:44 UTC (rev 72069)
 <at>  <at>  -194,6 +194,14  <at>  <at> 
 		return "window.mediaWikiStartUp = function() {" . $scripts . "};";
 	}
 	
+	public static function getHighestModifiedTime() {
+		$retval = 1; // wfTimestamp() treats 0 as 'now', so that's not a suitable choice
+		foreach ( self::$modules as $module ) {
+			$retval = max( $retval, $module->getModifiedTime() );
+		}
+		return $retval;
(Continue reading)

bharris | 1 Sep 02:00 2010
Picon

SVN: [72070] trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot .i18n.php

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72070

Revision: 72070
Author:   bharris
Date:     2010-09-01 00:00:18 +0000 (Wed, 01 Sep 2010)

Log Message:
-----------
Added descriptions.

Modified Paths:
--------------
    trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.i18n.php

Modified: trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.i18n.php
===================================================================
--- trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.i18n.php	2010-08-31
23:59:44 UTC (rev 72069)
+++ trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.i18n.php	2010-09-01
00:00:18 UTC (rev 72070)
 <at>  <at>  -12,7 +12,7  <at>  <at> 
 	'articleassessment-yourfeedback' => 'Your feedback',
 	'articleassessment-pleaserate' => "Please take a moment to rate this page below.",
 	'articleassessment-submit' => 'Submit',
-	'articleassessment-rating-wellsourced' => 'Well sourced:',
+	'articleassessment-rating-wellsourced' => 'Well-Sourced:',
 	'articleassessment-rating-neutrality' => 'Neutrality:',
 	'articleassessment-rating-completeness' => 'Completeness:',
 	'articleassessment-rating-readability' => 'Readability:',
 <at>  <at>  -39,24 +39,24  <at>  <at> 
(Continue reading)

reedy | 1 Sep 02:06 2010
Picon

SVN: [72071] trunk/extensions/ArticleAssessmentPilot

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72071

Revision: 72071
Author:   reedy
Date:     2010-09-01 00:06:30 +0000 (Wed, 01 Sep 2010)

Log Message:
-----------
Merge hooks. JS is used to add stuff onto pages. Do restriction now in addResources

As before, only for NS_MAIN, but also, has to be in $wgArticleAssessmentPages

To add stuff... After including the extension in LocalSettings, add

$wgArticleAssessmentPages = array( 1 => 'Main page', 25 => 'Something' );

ie pageid => title

Right hand side of the => doesn't matter hugely, just neededed to force the pageid to be the key. Some
maintainability i suppose also?

Remove some trailing whitespace

Modified Paths:
--------------
    trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.hooks.php
    trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.php

Modified: trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.hooks.php
===================================================================
(Continue reading)


Gmane