headers
brion | 1 Aug 2008 01:20
Picon
Favicon

SVN: [38321] trunk/phase3/includes/WatchlistEditor.php

Revision: 38321
Author:   brion
Date:     2008-07-31 23:20:37 +0000 (Thu, 31 Jul 2008)

Log Message:
-----------
Revert r38302,38306 -- "Add an order by to the list of watched pages."
This looks wrong -- an order by title wouldn't be indexed properly, and could be rather slow.

Modified Paths:
--------------
    trunk/phase3/includes/WatchlistEditor.php

Modified: trunk/phase3/includes/WatchlistEditor.php
===================================================================
--- trunk/phase3/includes/WatchlistEditor.php	2008-07-31 22:10:06 UTC (rev 38320)
+++ trunk/phase3/includes/WatchlistEditor.php	2008-07-31 23:20:37 UTC (rev 38321)
 <at>  <at>  -208,9 +208,6  <at>  <at> 
 		$sql = "SELECT wl_namespace, wl_title, page_id, page_len, page_is_redirect
 			FROM {$watchlist} LEFT JOIN {$page} ON ( wl_namespace = page_namespace
 			AND wl_title = page_title ) WHERE wl_user = {$uid}";
-		if ( !$dbr->implicitOrderby() ) {
-			$sql .= ' ORDER BY wl_title';
-		}
 		$res = $dbr->query( $sql, __METHOD__ );
 		if( $res && $dbr->numRows( $res ) > 0 ) {
 			$cache = LinkCache::singleton();
Permalink | Reply | 2 comments |
headers
brion | 1 Aug 2008 01:34
Picon
Favicon

SVN: [38322] trunk/extensions/CSS/CSS.php

Revision: 38322
Author:   brion
Date:     2008-07-31 23:34:19 +0000 (Thu, 31 Jul 2008)

Log Message:
-----------
Revert r38275, 38307 for now -- proper way to escape this stuff is being discussed.

Modified Paths:
--------------
    trunk/extensions/CSS/CSS.php

Modified: trunk/extensions/CSS/CSS.php
===================================================================
--- trunk/extensions/CSS/CSS.php	2008-07-31 23:20:37 UTC (rev 38321)
+++ trunk/extensions/CSS/CSS.php	2008-07-31 23:34:19 UTC (rev 38322)
 <at>  <at>  -13,7 +13,7  <at>  <at> 

 if (!defined('MEDIAWIKI')) die('Not an entry point.');

-define('CSS_VERSION', '1.0.5, 2008-07-31');
+define('CSS_VERSION', '1.0.4, 2008-06-01');

 $wgCSSMagic                    = "css";
 $wgExtensionFunctions[]        = 'wfSetupCSS';
 <at>  <at>  -44,7 +44,9  <at>  <at> 
 			$css = htmlspecialchars(trim(Sanitizer::checkCss($css)));
 			$parser->mOutput->addHeadItem( <<<EOT
 <style type="text/css">
+/*<![CDATA[*/
(Continue reading)

Permalink | Reply | 0 comments |
headers
jhsoby | 1 Aug 2008 02:22
Picon
Favicon

SVN: [38323] trunk/phase3/includes/Linker.php

Revision: 38323
Author:   jhsoby
Date:     2008-08-01 00:22:39 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
Changing the code rendered for headers; removing <a name="$anchor">, making into <h# id="$anchor">
instead. This removes one line from the output code, but more importantly enables CSS marking of a title
based on its id. Probably not backwards-compatible with browsers like IE4 (brion checked with IE5) and
Netscape 4, but hey, who cares?

Modified Paths:
--------------
    trunk/phase3/includes/Linker.php

Modified: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	2008-07-31 23:34:19 UTC (rev 38322)
+++ trunk/phase3/includes/Linker.php	2008-08-01 00:22:39 UTC (rev 38323)
 <at>  <at>  -1488,7 +1488,7  <at>  <at> 
 	 *  <at> return string HTML headline
 	 */
 	public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
-		return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
+		return "<h$level id=\"$anchor\"$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 	}

 	/**
Permalink | Reply | 0 comments |
headers
siebrand | 1 Aug 2008 02:30
Picon
Favicon

SVN: [38324] trunk/phase3/languages/messages/MessagesEn.php

Revision: 38324
Author:   siebrand
Date:     2008-08-01 00:30:13 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
Adding links to a lot of messages to improve usability.

Modified Paths:
--------------
    trunk/phase3/languages/messages/MessagesEn.php

Modified: trunk/phase3/languages/messages/MessagesEn.php
===================================================================
--- trunk/phase3/languages/messages/MessagesEn.php	2008-08-01 00:22:39 UTC (rev 38323)
+++ trunk/phase3/languages/messages/MessagesEn.php	2008-08-01 00:30:13 UTC (rev 38324)
 <at>  <at>  -813,7 +813,7  <at>  <at> 
 This is usually caused by following an outdated diff or history link to a page that has been deleted.

 If this is not the case, you may have found a bug in the software.
-Please report this to an administrator, making note of the URL.',
+Please report this to an [[Special:ListUsers/sysop|administrator]], making note of the URL.',
 'missingarticle-rev'   => '(revision#: $1)',
 'missingarticle-diff'  => '(Diff: $1, $2)',
 'readonly_lag'         => 'The database has been automatically locked while the slave database servers catch up
to the master',
 <at>  <at>  -870,11 +870,11  <at>  <at> 
 'logouttitle'                => 'User logout',
 'logouttext'                 => '<strong>You are now logged out.</strong>
(Continue reading)

Permalink | Reply | 0 comments |
headers
simetrical | 1 Aug 2008 02:47
Picon
Favicon

SVN: [38325] trunk/phase3

Revision: 38325
Author:   simetrical
Date:     2008-08-01 00:47:26 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
(bug 14995) Some link fragments in the interface stopped appearing, because Title::getLocalURL()
doesn't include the fragment.  For some reason Title::getFullURL() does, however . . . more functions to
clean up?  :)

Modified Paths:
--------------
    trunk/phase3/RELEASE-NOTES
    trunk/phase3/includes/Linker.php
    trunk/phase3/includes/Title.php

Modified: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	2008-08-01 00:30:13 UTC (rev 38324)
+++ trunk/phase3/RELEASE-NOTES	2008-08-01 00:47:26 UTC (rev 38325)
 <at>  <at>  -48,6 +48,7  <at>  <at> 
 * Recursion loop check added to Categoryfinder class
 * Fixed few performance troubles of large job queue processing
 * Not setting various parameters in Foreign Repos now fails more gracefully
+* (bug 14995) Some link fragments in the interface stopped appearing

 === API changes in 1.14 ===

Modified: trunk/phase3/includes/Linker.php
===================================================================
(Continue reading)

Permalink | Reply | 0 comments |
headers
simetrical | 1 Aug 2008 02:54
Picon
Favicon

SVN: [38326] trunk/phase3

Revision: 38326
Author:   simetrical
Date:     2008-08-01 00:54:08 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
(bug 14997) Rollback links now work again, yay!  But doesn't the code look so much prettier?

Modified Paths:
--------------
    trunk/phase3/RELEASE-NOTES
    trunk/phase3/includes/Linker.php

Modified: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	2008-08-01 00:47:26 UTC (rev 38325)
+++ trunk/phase3/RELEASE-NOTES	2008-08-01 00:54:08 UTC (rev 38326)
 <at>  <at>  -49,6 +49,7  <at>  <at> 
 * Fixed few performance troubles of large job queue processing
 * Not setting various parameters in Foreign Repos now fails more gracefully
 * (bug 14995) Some link fragments in the interface stopped appearing
+* (bug 14997) Rollback links now work again

 === API changes in 1.14 ===

Modified: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	2008-08-01 00:47:26 UTC (rev 38325)
+++ trunk/phase3/includes/Linker.php	2008-08-01 00:54:08 UTC (rev 38326)
 <at>  <at>  -1547,7 +1547,10  <at>  <at>
(Continue reading)

Permalink | Reply | 0 comments |
headers
simetrical | 1 Aug 2008 02:55
Picon
Favicon

SVN: [38327] trunk/phase3/includes/Linker.php

Revision: 38327
Author:   simetrical
Date:     2008-08-01 00:55:29 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
Rollback links should not get new/mw-redirect/stub classes, either.

Modified Paths:
--------------
    trunk/phase3/includes/Linker.php

Modified: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	2008-08-01 00:54:08 UTC (rev 38326)
+++ trunk/phase3/includes/Linker.php	2008-08-01 00:55:29 UTC (rev 38327)
 <at>  <at>  -1557,7 +1557,7  <at>  <at> 
 		$query['token'] = $wgUser->editToken( array( $title->getPrefixedText(),
 			$rev->getUserText() ) );
 		return $this->link( $title, wfMsgHtml( 'rollbacklink' ), array(),
-			$query,	'known'	);
+			$query,	array( 'known', 'noclasses' ) );
 	}

 	/**
Permalink | Reply | 0 comments |
headers
simetrical | 1 Aug 2008 03:03
Picon
Favicon

SVN: [38328] trunk/phase3/includes/Linker.php

Revision: 38328
Author:   simetrical
Date:     2008-08-01 01:03:26 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
Revert 38323 for now.  Causes massive parser test failure.  Also needs to update RELEASE-NOTES.

Modified Paths:
--------------
    trunk/phase3/includes/Linker.php

Modified: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	2008-08-01 00:55:29 UTC (rev 38327)
+++ trunk/phase3/includes/Linker.php	2008-08-01 01:03:26 UTC (rev 38328)
 <at>  <at>  -1493,7 +1493,7  <at>  <at> 
 	 *  <at> return string HTML headline
 	 */
 	public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
-		return "<h$level id=\"$anchor\"$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
+		return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 	}

 	/**
Permalink | Reply | 0 comments |
headers
simetrical | 1 Aug 2008 03:37
Picon
Favicon

SVN: [38329] trunk/phase3/includes

Revision: 38329
Author:   simetrical
Date:     2008-08-01 01:37:07 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
Use Linker::link() in a couple more places, since I want to break lots more bits of the site interface.  Also
clean up Skin::nameAndLogin(), although it's seemingly only used in Standard.

Modified Paths:
--------------
    trunk/phase3/includes/Linker.php
    trunk/phase3/includes/Skin.php

Modified: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	2008-08-01 01:03:26 UTC (rev 38328)
+++ trunk/phase3/includes/Linker.php	2008-08-01 01:37:07 UTC (rev 38329)
 <at>  <at>  -147,7 +147,8  <at>  <at> 
 	 *   change to support Images, literal URLs, etc.
 	 *  <at> param $text          string The HTML contents of the <a> element, i.e.,
 	 *   the link text.  This is raw HTML and will not be escaped.  If null,
-	 *   defaults to the page name of the Title.
+	 *   defaults to the prefixed text of the Title; or if the Title is just a
+	 *   fragment, the contents of the fragment.
 	 *  <at> param $query         array  The query string to append to the URL
 	 *   you're linking to, in key => value array form.  Query keys and values
 	 *   will be URL-encoded.

Modified: trunk/phase3/includes/Skin.php
(Continue reading)

Permalink | Reply | 0 comments |
headers
simetrical | 1 Aug 2008 03:47
Picon
Favicon

SVN: [38330] trunk/phase3

Revision: 38330
Author:   simetrical
Date:     2008-08-01 01:47:02 +0000 (Fri, 01 Aug 2008)

Log Message:
-----------
(bug 14995 again) Fix behavior of link() when it's provided with Titles that have no text, only a fragment. 
getLocalURL() doesn't work here either.  Can we have a function that actually means "generate a link to
whatever this Title points at"?

Also remove, as Tim so eloquently terms it, "that crap in the release notes", which I also think is
unnecessary and crufty.

Modified Paths:
--------------
    trunk/phase3/RELEASE-NOTES
    trunk/phase3/includes/Linker.php

Modified: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	2008-08-01 01:37:07 UTC (rev 38329)
+++ trunk/phase3/RELEASE-NOTES	2008-08-01 01:47:02 UTC (rev 38330)
 <at>  <at>  -48,8 +48,6  <at>  <at> 
 * Recursion loop check added to Categoryfinder class
 * Fixed few performance troubles of large job queue processing
 * Not setting various parameters in Foreign Repos now fails more gracefully
-* (bug 14995) Some link fragments in the interface stopped appearing
-* (bug 14997) Rollback links now work again

 === API changes in 1.14 ===
(Continue reading)

Permalink | Reply | 0 comments |

Gmane