Kate Turner | 1 Jul 02:03 2005
Picon
Picon

phase3/includes Article.php, 1.347, 1.348 OutputPage.php, 1.229, 1.230 PageHistory.php, 1.75, 1.76 ParserCache.php, 1.22, 1.23

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20802

Modified Files:
	Article.php OutputPage.php PageHistory.php ParserCache.php 
Log Message:
remove wfdebug in pagehistory
set ETag header on article views

Index: ParserCache.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/ParserCache.php,v
retrieving revision 1.22
retrieving revision 1.23
diff -C2 -d -r1.22 -r1.23
*** ParserCache.php	19 Jun 2005 03:05:50 -0000	1.22
--- ParserCache.php	1 Jul 2005 00:03:31 -0000	1.23
***************
*** 20,24 ****
  		$this->mMemc =& $memCached;
  	}
! 	
  	function getKey( &$article, &$user ) {
  		global $wgDBname;
--- 20,24 ----
  		$this->mMemc =& $memCached;
  	}
! 
  	function getKey( &$article, &$user ) {
  		global $wgDBname;
(Continue reading)

Brion Vibber | 1 Jul 07:28 2005
Picon
Picon

phase3/includes Database.php, 1.103, 1.104 RecentChange.php, 1.27, 1.28

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24320/includes

Modified Files:
	Database.php RecentChange.php 
Log Message:
Replace !! with explicit operations.

Index: RecentChange.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/RecentChange.php,v
retrieving revision 1.27
retrieving revision 1.28
diff -C2 -d -r1.27 -r1.28
*** RecentChange.php	29 Jun 2005 07:01:24 -0000	1.27
--- RecentChange.php	1 Jul 2005 05:28:07 -0000	1.28
***************
*** 370,374 ****
  			'rc_title' => $row->page_title,
  			'rc_comment' => $row->rev_comment,
! 			'rc_minor' => !!$row->rev_minor_edit,
  			'rc_type' => $row->page_is_new ? RC_NEW : RC_EDIT,
  			'rc_cur_id' => $row->page_id,
--- 370,374 ----
  			'rc_title' => $row->page_title,
  			'rc_comment' => $row->rev_comment,
! 			'rc_minor' => $row->rev_minor_edit ? 1 : 0,
  			'rc_type' => $row->page_is_new ? RC_NEW : RC_EDIT,
  			'rc_cur_id' => $row->page_id,

(Continue reading)

Kate Turner | 1 Jul 08:50 2005
Picon
Picon

phase3/includes SpecialContributions.php,1.81,1.82

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv28902

Modified Files:
	SpecialContributions.php 
Log Message:
page contributions based on timestamp, not on limit,offset.
significantly reduces database load (O(offset) -> O(1)) for users with many edits.

Index: SpecialContributions.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/SpecialContributions.php,v
retrieving revision 1.81
retrieving revision 1.82
diff -C2 -d -r1.81 -r1.82
*** SpecialContributions.php	29 Jun 2005 06:16:00 -0000	1.81
--- SpecialContributions.php	1 Jul 2005 06:50:03 -0000	1.82
***************
*** 5,8 ****
--- 5,112 ----
   */

+ class contribs_finder {
+ 	var $username, $offset, $limit, $namespace, $invert;
+ 	var $dbr;
+ 
+ 	function contribs_finder($username) {
+ 		$this->username = $username;
+ 		$this->dbr =& wfGetDB(DB_SLAVE);
+ 	}
(Continue reading)

Kate Turner | 1 Jul 09:07 2005
Picon
Picon

phase3/includes SpecialContributions.php,1.82,1.83

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3549

Modified Files:
	SpecialContributions.php 
Log Message:
honour namespace/minor/etc in showing paging buttons
cleanups from brion

Index: SpecialContributions.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/SpecialContributions.php,v
retrieving revision 1.82
retrieving revision 1.83
diff -C2 -d -r1.82 -r1.83
*** SpecialContributions.php	1 Jul 2005 06:50:03 -0000	1.82
--- SpecialContributions.php	1 Jul 2005 07:07:54 -0000	1.83
***************
*** 32,51 ****

  	function get_edit_limits() {
  		$sql =	"SELECT MIN(rev_timestamp) as earliest, MAX(rev_timestamp) as latest " .
! 			"FROM revision " .
! 			"WHERE rev_user_text = " . $this->dbr->addQuotes($this->username);
  		$res = $this->dbr->query($sql, "contribs_finder::get_edit_limits");
! 		$row = $this->dbr->fetchObject($res);
! 		if (!$row)
! 			return array(null, null);
! 		$this->dbr->freeResult($res);
  		return array($row->earliest, $row->latest);
(Continue reading)

Kate Turner | 1 Jul 09:14 2005
Picon
Picon

phase3/includes SpecialContributions.php,1.83,1.84

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6029/includes

Modified Files:
	SpecialContributions.php 
Log Message:
showhideminor is not appropriate here.  add a new message which makes sense.

Index: SpecialContributions.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/SpecialContributions.php,v
retrieving revision 1.83
retrieving revision 1.84
diff -C2 -d -r1.83 -r1.84
*** SpecialContributions.php	1 Jul 2005 07:07:54 -0000	1.83
--- SpecialContributions.php	1 Jul 2005 07:14:05 -0000	1.84
***************
*** 255,259 ****
  	$prevnextbits = wfMsgHtml("viewprevnext", $prevlink, $nextlink, $bits);

! 	$shm = wfMsgHtml( "showhideminor", $mlink );
  	$wgOut->addHTML( "<br />{$prevnextbits} ($shm)</p>\n");

--- 255,259 ----
  	$prevnextbits = wfMsgHtml("viewprevnext", $prevlink, $nextlink, $bits);

! 	$shm = wfMsgHtml( "contribs-showhideminor", $mlink );
  	$wgOut->addHTML( "<br />{$prevnextbits} ($shm)</p>\n");
Kate Turner | 1 Jul 09:14 2005
Picon
Picon

phase3/languages Language.php,1.595,1.596

Update of /cvsroot/wikipedia/phase3/languages
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6029/languages

Modified Files:
	Language.php 
Log Message:
showhideminor is not appropriate here.  add a new message which makes sense.

Index: Language.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/languages/Language.php,v
retrieving revision 1.595
retrieving revision 1.596
diff -C2 -d -r1.595 -r1.596
*** Language.php	29 Jun 2005 06:16:03 -0000	1.595
--- Language.php	1 Jul 2005 07:14:06 -0000	1.596
***************
*** 1377,1380 ****
--- 1377,1381 ----
  'uctop'         => ' (top)' ,
  'newbies'       => 'newbies',
+ 'contribs-showhideminor' => '$1 minor edits',

  # What links here
Kate Turner | 1 Jul 09:35 2005
Picon
Picon

phase3/includes SpecialContributions.php,1.84,1.85

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv17442/includes

Modified Files:
	SpecialContributions.php 
Log Message:
show "earlier" and "latest" links

Index: SpecialContributions.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/SpecialContributions.php,v
retrieving revision 1.84
retrieving revision 1.85
diff -C2 -d -r1.84 -r1.85
*** SpecialContributions.php	1 Jul 2005 07:14:05 -0000	1.84
--- SpecialContributions.php	1 Jul 2005 07:35:39 -0000	1.85
***************
*** 105,108 ****
--- 105,126 ----
  	}

+ 	function get_first_offset_for_paging() {
+ 		list($index, $usercond) = $this->get_user_cond();
+ 		$use_index = $this->dbr->useIndexClause($index);
+ 
+ 		$sql =	"SELECT rev_timestamp FROM page, revision $use_index " .
+ 			"WHERE page_id = rev_page AND " .
+ 			"rev_user_text = " . $this->dbr->addQuotes($this->username);
+ 		$sql .= $this->get_namespace_cond();
+ 		$sql .= $this->get_minor_cond();
(Continue reading)

Kate Turner | 1 Jul 10:19 2005
Picon
Picon

phase3/includes SpecialContributions.php,1.85,1.86

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6770

Modified Files:
	SpecialContributions.php 
Log Message:
rev_timestamp is a string

Index: SpecialContributions.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/SpecialContributions.php,v
retrieving revision 1.85
retrieving revision 1.86
diff -C2 -d -r1.85 -r1.86
*** SpecialContributions.php	1 Jul 2005 07:35:39 -0000	1.85
--- SpecialContributions.php	1 Jul 2005 08:19:28 -0000	1.86
***************
*** 92,96 ****

  		$sql =	"SELECT rev_timestamp FROM page, revision $use_index " .
! 			"WHERE page_id = rev_page AND rev_timestamp > " . $this->offset . " AND " .
  			"rev_user_text = " . $this->dbr->addQuotes($this->username);
  		$sql .= $this->get_namespace_cond();
--- 92,96 ----

  		$sql =	"SELECT rev_timestamp FROM page, revision $use_index " .
! 			"WHERE page_id = rev_page AND rev_timestamp > '" . $this->offset . "' AND " .
  			"rev_user_text = " . $this->dbr->addQuotes($this->username);
  		$sql .= $this->get_namespace_cond();
***************
(Continue reading)

Kate Turner | 1 Jul 10:50 2005
Picon
Picon

phase3/includes Skin.php,1.353,1.354

Update of /cvsroot/wikipedia/phase3/includes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20772

Modified Files:
	Skin.php 
Log Message:
initialise $changed to prevent warning
fix display of new talk notification in non-template skins

Index: Skin.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/Skin.php,v
retrieving revision 1.353
retrieving revision 1.354
diff -C2 -d -r1.353 -r1.354
*** Skin.php	28 Jun 2005 15:02:22 -0000	1.353
--- Skin.php	1 Jul 2005 08:50:27 -0000	1.354
***************
*** 536,540 ****
  		# own talk page

! 			if( $wgTitle->equals( $wgUser->getTalkPage() ) ) {
  				$tl = $this->makeKnownLinkObj( $wgUser->getTalkPage(),
  						wfMsg('newmessageslink') );
--- 536,540 ----
  		# own talk page

! 			if( !$wgTitle->equals( $wgUser->getTalkPage() ) ) {
  				$tl = $this->makeKnownLinkObj( $wgUser->getTalkPage(),
  						wfMsg('newmessageslink') );
(Continue reading)

Kate Turner | 1 Jul 11:25 2005
Picon
Picon

phase3/config index.php,1.124,1.125

Update of /cvsroot/wikipedia/phase3/config
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv5258

Modified Files:
	index.php 
Log Message:
diff3 cleanups, from callek

Index: index.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/config/index.php,v
retrieving revision 1.124
retrieving revision 1.125
diff -C2 -d -r1.124 -r1.125
*** index.php	30 Jun 2005 08:23:32 -0000	1.124
--- index.php	1 Jul 2005 09:25:31 -0000	1.125
***************
*** 143,147 ****
  if( file_exists( "./LocalSettings.php" ) ) {
  	writeSuccessMessage();
! 	
  	dieout( '' );
  }
--- 143,147 ----
  if( file_exists( "./LocalSettings.php" ) ) {
  	writeSuccessMessage();
! 
  	dieout( '' );
  }
***************
(Continue reading)


Gmane