headers
TheDJ (Code Review | 19 May 2013 23:55
Picon

[MediaWiki-commits] [Gerrit] Correct flickr url generation. - change (mediawiki...UploadWizard)

TheDJ has submitted this change and it was merged.

Change subject: Correct flickr url generation.
......................................................................

Correct flickr url generation.

The urls for images in flickr was getting wrong. Setting it to the right
thing as per http://www.flickr.com/services/api/misc.urls.html

Note: Couldn't test this locally because of the curl error, so please test
before merging

Bug 46559

Change-Id: I57900feba9eafc5c4790b17459c857bccdf9e236
---
M resources/mw.FlickrChecker.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  TheDJ: Verified; Looks good to me, approved
  jenkins-bot: Checked

diff --git a/resources/mw.FlickrChecker.js b/resources/mw.FlickrChecker.js
index 4f6b99d..012a04f 100644
--- a/resources/mw.FlickrChecker.js
+++ b/resources/mw.FlickrChecker.js
 <at>  <at>  -84,7 +84,7  <at>  <at> 
 			api_key: _this.apiKey,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Odder (Code Review | 19 May 2013 23:01
Picon

[MediaWiki-commits] [Gerrit] (bug 48620) Enable Translate extension on Wikimedia Commons - change (operations/mediawiki-config)

Odder has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64539

Change subject: (bug 48620) Enable Translate extension on Wikimedia Commons
......................................................................

(bug 48620) Enable Translate extension on Wikimedia Commons

This patch enables the Translate extension on Commons. In line
with the default settings, bureaucrats will be able to add and
remove users from the 'translationadmin' group. Since Commons
does not require so many translation states, we'll be using
Nike's suggestion from bug 41585 comment 3, including automatic
state changes.

Other configuration changes (enabling admins to add and remove
themselves from the abovementioned user group, enabling the
TranslateNotification extension) might follow soon upon
community request if need be.

I'm also using this opportunity to remove the redundant
definition in $wmgUseTranslationMemory for testwiki, since
the default setting is set to 'true' anyway.

Bug: 48620
Change-Id: I2a4b70a075dabe0489456db372a6ee40c9360c4d
---
M wmf-config/InitialiseSettings.php
1 file changed, 12 insertions(+), 2 deletions(-)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Denny Vrandecic (Code Review | 19 May 2013 23:00
Picon

[MediaWiki-commits] [Gerrit] changed namespaces a bit, added license - change (mediawiki...Wikibase)

Denny Vrandecic has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64538

Change subject: changed namespaces a bit, added license
......................................................................

changed namespaces a bit, added license

Change-Id: Iea1d34372ba30466d8b76a3650c95cfabadc21dd
---
M repo/includes/rdf/RdfBuilder.php
1 file changed, 16 insertions(+), 13 deletions(-)

  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/38/64538/1

diff --git a/repo/includes/rdf/RdfBuilder.php b/repo/includes/rdf/RdfBuilder.php
index 2267357..da8aadd 100755
--- a/repo/includes/rdf/RdfBuilder.php
+++ b/repo/includes/rdf/RdfBuilder.php
 <at>  <at>  -56,9 +56,11  <at>  <at> 

 	const NS_SKOS = 'skos'; // SKOS vocabulary
 	const NS_SCHEMA_ORG = 'schema'; // schema.org vocabulary
+	const NS_CC = 'cc';

 	const SKOS_URI = 'http://www.w3.org/2004/02/skos/core#';
 	const SCHEMA_ORG_URI = 'http://schema.org/';
+	const CC_URI = 'http://creativecommons.org/ns#';
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dan Bolser (Code Review | 19 May 2013 22:44
Picon

[MediaWiki-commits] [Gerrit] simplifying scale calculation - change (mediawiki...SemanticDrilldown)

Dan Bolser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64536

Change subject: simplifying scale calculation
......................................................................

simplifying scale calculation

Change-Id: If168245a37227feac667cac7b424c05420653cdc
---
M specials/SD_BrowseData.php
1 file changed, 2 insertions(+), 4 deletions(-)

  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticDrilldown refs/changes/36/64536/1

diff --git a/specials/SD_BrowseData.php b/specials/SD_BrowseData.php
index 0ceac38..8b502fe 100644
--- a/specials/SD_BrowseData.php
+++ b/specials/SD_BrowseData.php
 <at>  <at>  -595,9 +595,7  <at>  <at> 
 		if ( $sdgFiltersSmallestFontSize > 0 && $sdgFiltersLargestFontSize > 0 ) {
 			$lowest_num_results = min( $filter_values );
 			$highest_num_results = max( $filter_values );
-			$num_results_midpoint = ( $lowest_num_results + $highest_num_results ) / 2;
-			$font_size_midpoint = ( $sdgFiltersSmallestFontSize + $sdgFiltersLargestFontSize ) / 2;
-			$num_results_per_font_pixel = ( $highest_num_results + 1 - $lowest_num_results ) / (
$sdgFiltersLargestFontSize + 1 - $sdgFiltersSmallestFontSize );
+			$scale_factor = ( $sdgFiltersLargestFontSize - $sdgFiltersSmallestFontSize ) / (
$highest_num_results - $lowest_num_results );
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dan Bolser (Code Review | 19 May 2013 22:44
Picon

[MediaWiki-commits] [Gerrit] adding log-scale option for tag-cloud - change (mediawiki...SemanticDrilldown)

Dan Bolser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64537

Change subject: adding log-scale option for tag-cloud
......................................................................

adding log-scale option for tag-cloud

Change-Id: Iaad92f14e055c714ae4dc0764f7677e694ee04b6
---
M SemanticDrilldown.php
M specials/SD_BrowseData.php
2 files changed, 9 insertions(+), 1 deletion(-)

  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticDrilldown refs/changes/37/64537/1

diff --git a/SemanticDrilldown.php b/SemanticDrilldown.php
index 1b0c58b..98f05a5 100644
--- a/SemanticDrilldown.php
+++ b/SemanticDrilldown.php
 <at>  <at>  -121,6 +121,8  <at>  <at> 
 // set these to a positive value to trigger the "tag cloud" display
 $sdgFiltersSmallestFontSize = - 1;
 $sdgFiltersLargestFontSize = - 1;
+// logarithmic scale?
+$sdgFiltersLogScale = 0;
 // print categories list as tabs
 $sdgShowCategoriesAsTabs = false;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dan Bolser (Code Review | 19 May 2013 22:44
Picon

[MediaWiki-commits] [Gerrit] tidying up layout of SD 'filters' - change (mediawiki...SemanticDrilldown)

Dan Bolser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64535

Change subject: tidying up layout of SD 'filters'
......................................................................

tidying up layout of SD 'filters'

Change-Id: I782e9b7b4c1e1e1314099ef3c5a85c6dcd5c76b1
---
M specials/SD_BrowseData.php
1 file changed, 1 insertion(+), 1 deletion(-)

  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticDrilldown refs/changes/35/64535/1

diff --git a/specials/SD_BrowseData.php b/specials/SD_BrowseData.php
index 9bdf8e0..0ceac38 100644
--- a/specials/SD_BrowseData.php
+++ b/specials/SD_BrowseData.php
 <at>  <at>  -604,7 +604,7  <at>  <at> 
 		foreach ( $filter_values as $value_str => $num_results ) {
 			if ( $num_printed_values++ > 0 ) { $results_line .= " ยท "; }
 			$filter_text = $this->printFilterValue( $f, $value_str );
-			$filter_text .= " ($num_results)";
+			$filter_text .= "&nbsp;($num_results)";
 			$filter_url = $cur_url . urlencode( str_replace( ' ', '_', $f->name ) ) . '=' . urlencode( str_replace(
' ', '_', $value_str ) );
 			if ( $sdgFiltersSmallestFontSize > 0 && $sdgFiltersLargestFontSize > 0 ) {
 				$font_size = round( $font_size_midpoint + ( ( $num_results - $num_results_midpoint ) /
(Continue reading)

Permalink | Reply | 0 comments |
headers
Aaron Schulz (Code Review | 19 May 2013 22:23
Picon

[MediaWiki-commits] [Gerrit] Made SwiftFileBackend::loadObjectListing() populate stat ent... - change (mediawiki/core)

Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64534

Change subject: Made SwiftFileBackend::loadObjectListing() populate stat entries in reverse order.
......................................................................

Made SwiftFileBackend::loadObjectListing() populate stat entries in reverse order.

Change-Id: I07bf9c852729d65cee72364ca3249e31936d0562
---
M includes/filebackend/SwiftFileBackend.php
1 file changed, 6 insertions(+), 2 deletions(-)

  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/34/64534/1

diff --git a/includes/filebackend/SwiftFileBackend.php b/includes/filebackend/SwiftFileBackend.php
index f9e2ce4..54a90d3 100644
--- a/includes/filebackend/SwiftFileBackend.php
+++ b/includes/filebackend/SwiftFileBackend.php
 <at>  <at>  -1111,7 +1111,11  <at>  <at> 
 		$names = array();
 		$storageDir = rtrim( $params['dir'], '/' );
 		$suffixStart = ( $dir === '' ) ? 0 : strlen( $dir ) + 1; // size of "path/to/dir/"
-		foreach ( $cfObjects as $object ) {
+		// Iterate over the list *backwards* as this primes the stat cache, which is LRU.
+		// If this fills the cache and the caller stats an uncached file before stating
+		// the ones on the listing, there would be zero cache hits if this went forwards.
+		for ( end( $cfObjects ); key( $cfObjects ) !== null; prev( $cfObjects ) ) {
+			$object = current( $cfObjects );
(Continue reading)

Permalink | Reply | 0 comments |
headers
Balloonguy (Code Review | 19 May 2013 21:56
Picon

[MediaWiki-commits] [Gerrit] Warn if page was edited while deletion was being confirmed - change (mediawiki/core)

Balloonguy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64533

Change subject: Warn if page was edited while deletion was being confirmed
......................................................................

Warn if page was edited while deletion was being confirmed

Pass the page's current revision id as a parameter in the deletion confirmation form that
is generated by Article::confirmDelete and compare it with the revision id of the page
during deletion in Article::delete to see if they differ. If they do, it indicates
the page has been edited. The user is then warned and the deletion confirmation form is displayed
again to reconfirm deletion. The message editedwhiledeleting was created as the warning message.
This only partially fixes bug 6315 as the bug involves files, while this only addresses pages.

To make the code a little cleaner, the generation of the history and big deletion warnings
have been moved from Article::delete to Article::confirmDelete where they will be shown even if
confirmDelete is passed a prefilled reason. In addition, the reason parameter has explicitly been
made optional. Previously, reason would be set to null if it was not defined as a side-effect
of trying to get the posted reason from the request.

Bug: 6315
Change-Id: Ifc962130a1e2ef62b18384b13f6c0e8320819a79
---
M includes/Article.php
M languages/messages/MessagesEn.php
M languages/messages/MessagesQqq.php
M maintenance/language/messages.inc
4 files changed, 55 insertions(+), 37 deletions(-)
(Continue reading)

Permalink | Reply | 0 comments |
headers
TheDJ (Code Review | 19 May 2013 21:44
Picon

[MediaWiki-commits] [Gerrit] (bug 17602) fix Monobook action tabs not quite touching the ... - change (mediawiki/core)

TheDJ has submitted this change and it was merged.

Change subject: (bug 17602) fix Monobook action tabs not quite touching the page body
......................................................................

(bug 17602) fix Monobook action tabs not quite touching the page body

This was caused by insufficient bottom padding on the tabs (0.1em on
normal ones, and for some reason 0.2em on active ones, which was
apparently enough). In some browsers (at least Opera) this resulted in
a one-pixel gap between the tabs and the page body.

This patch raises the padding to 1em, just in case. This shouldn't
cause any issues, as all z-indices are set reasonably on the involved
elements; the excess space is hidden "under" the page body.

Change-Id: I07223ba46913f721907f9aa88f79bc94402b6cf6
---
M skins/monobook/main.css
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  TheDJ: Checked; Looks good to me, approved
  GWicke: Looks good to me, but someone else must approve
  jenkins-bot: Verified

diff --git a/skins/monobook/main.css b/skins/monobook/main.css
index 147cd15..fd0338a 100644
--- a/skins/monobook/main.css
+++ b/skins/monobook/main.css
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nischayn22 (Code Review | 19 May 2013 21:41
Picon

[MediaWiki-commits] [Gerrit] updated ROADMAP with current issues. - change (mediawiki...SemanticSignup)

Nischayn22 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64532

Change subject: updated ROADMAP with current issues.
......................................................................

updated ROADMAP with current issues.

JS and CSS loaded from SF needs to be fixed.

Change-Id: Ic0a7b24663274337e3c65f709ab5249d8c3a7f06
---
M ROADMAP
1 file changed, 1 insertion(+), 0 deletions(-)

  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticSignup refs/changes/32/64532/1

diff --git a/ROADMAP b/ROADMAP
index e175f01..7f16dae 100644
--- a/ROADMAP
+++ b/ROADMAP
 <at>  <at>  -6,5 +6,6  <at>  <at> 

 == Version 0.4 ==

+* Fix compatibility with latest SemanticForms
 * Fix compatibility with Confirm Edit and other captcha extensions.
 * Fix loading of obsolete JavaScript and CSS files.
(Continue reading)

Permalink | Reply | 0 comments |
headers
jenkins-bot (Code Review | 19 May 2013 20:27
Picon

[MediaWiki-commits] [Gerrit] Removed Closure type hints where not needed. - change (mediawiki/core)

jenkins-bot has submitted this change and it was merged.

Change subject: Removed Closure type hints where not needed.
......................................................................

Removed Closure type hints where not needed.

Closures are not the only types of callable objects in PHP.
Specifically, any string referencing a valid function, any object with a __call(),
or any class with a __callStatic() can all be called.
Therefore, removed type hinting for Closures in places where a callable is expected.
(Unfortunately, the callable type-hint only comes in PHP 5.4.)

Change-Id: I6bff7e4a95716ef63aa7e07d3d9fef6d20eb65a6
---
M includes/MappedIterator.php
M includes/ScopedCallback.php
M includes/db/Database.php
3 files changed, 13 insertions(+), 13 deletions(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified

diff --git a/includes/MappedIterator.php b/includes/MappedIterator.php
index b4376f4..14495f2 100644
--- a/includes/MappedIterator.php
+++ b/includes/MappedIterator.php
 <at>  <at>  -29,7 +29,7  <at>  <at> 
 class MappedIterator implements Iterator {
(Continue reading)

Permalink | Reply | 0 comments |

Gmane