"Tim Starling" changed the status of MediaWiki.r110261 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110261 Old status: new > New status: ok Commit summary for MediaWiki.r110261: Renamed FileBackend to FileBackendStore and ugly FileBackendBase to FileBackend. Callers doing things like FileBackend::extensionFromPath() are now more proper.
"Aaron Schulz" posted a comment on MediaWiki.r110454. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110454#c30321 Commit summary for MediaWiki.r110454: Revert part of r109617 Breaks updates. Will re-evaluate it after sleep Remove big seperator Aaron Schulz's comment: Always got to slip in some style cleanup :)
"Tim Starling" changed the status of MediaWiki.r110435 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110435#c30322 Old Status: new > New Status: ok Commit summary for MediaWiki.r110435: Expanded 'shardViaHashLevels' config var in FileBackendStore to be able to recognize FileRepo-style deleted zone hash paths (which are different than for the other zones). Tim Starling's comment: You should probably throw an exception if the base is something other than 16 or 36, or if the number of levels is something other than 0 or 2, rather than ignoring the setting. <pre> - $numShards = 1 << ( $digits * 4 ); + $numShards = pow( $base, $digits ); </pre> I was worried about whether pow() is exact for integer arguments, so I checked the source. It is exact.
"Tim Starling" changed the status of MediaWiki.r109428 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109428#c30323 Old Status: new > New Status: ok Commit summary for MediaWiki.r109428: In SwiftFileBackend: * r108944: doCleanInternal() should delete empty containers only if the container dir was given. * Made doSecureInternal() set container permissions. Also renamed swiftProxyUser -> swiftAnonUser. * Made doGetFileStat() respect the 'latest' parameter (using r109235). * Fixed connTTL default and renamed it to authTTL. Also added explicit close() call to getConnection(). * Reduced RTTs in doPrepareInternal() by checking getContainer() first (which is process cached). * Killed an RTT in doStoreInternal(), doCreateInternal(), and doCopyInternal() by using create_object(). Also cleaned up logic with regards to the destination CF_Object object fields getting preloaded before write(). * Cleanups to getLocalCopy(); only create the tmp file if get_object() succeeds to short-circuits things. * Made getContainer() limit the container cache size for sanity. * Simplified doDeleteInternal() code a bit. * Renamed $destRel => $dstRel for consistency. Tim Starling's comment: Would it be possible to move setContainerAccess() to cloudfiles after the 1.19 branch point?
"Tim Starling" changed the status of MediaWiki.r110230 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110230 Old status: new > New status: ok Commit summary for MediaWiki.r110230: Added addMissingMetadata() function to SwiftFileBackend to retroactively add metadata (sha1) on the fly. This can be useful if files were imported from some script that doesn't set the metadata.
"Aaron Schulz" changed the status of MediaWiki.r110456 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110456 Old status: new > New status: ok Commit summary for MediaWiki.r110456: Adding my USERINFO file.
"Tim Starling" changed the status of MediaWiki.r110073 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110073#c30324 Old Status: new > New Status: ok Commit summary for MediaWiki.r110073: Further reduced RTTs in SwiftFileBackend by making "file already exists" checks use the stat cache, typically already set in FileOp::doPrecheck(). FileBackendBase::doOperationsInternal() already clears the cache after locking (and before FileOp::attemptBatch) for consistency. Tim Starling's comment: Optional boolean parameters which default to false are one of the few acceptable applications of empty(). Aaron added lots of them in the FileBackend project, probably just to annoy empty-haters ;)
"Tim Starling" changed the status of MediaWiki.r109980 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109980#c30325 Old Status: new > New Status: ok Commit summary for MediaWiki.r109980: In FileBackend: * Use 'b' param in some fopen() calls as needed for Windows and newline handling. * Removed some useless padding code in FileBackend::getContainerShard(). Initialized $m to make IDE happy. * Updated some code comments. In SwiftFileBackend: * Manually set the ETag when using php-cloudfiles for creating files to avoid https://github.com/rackspace/php-cloudfiles/issues/59. * Manually set the content type based on how StreamFile::getType(). This makes it safe to read files directly out of the proxy to end-users. The streamFile() backend functions already uses a similar content-type check. Tim Starling's comment: I may have misled you a bit with my outdated knowledge of binary mode: "As of PHP 4.3.2, the default mode is set to binary for all platforms that distinguish between binary and text mode." [http://au2.php.net/manual/en/function.fopen.php]. Oh well, it's harmless.
"Tim Starling" changed the status of MediaWiki.r109703 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109703 Old status: new > New status: ok Commit summary for MediaWiki.r109703: * Fixed bugs in SwiftFileBackend file listing code * Clear container cache in SwiftFileBackend when clearCache() is called * Updated a comment and fixed a comment typo
"Tim Starling" changed the status of MediaWiki.r109583 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109583 Old status: new > New status: ok Commit summary for MediaWiki.r109583: * Follow-up r109009: Check that paths are usable in FileOp::doPrecheck(). Also lock parent directories to avoid prepare()/clean() race conditions for FS backends. * Fixed bogus $params var in logException() call in SwiftFileBackend. * Added 'latest' param to FileBackendMultliWrite::consistencyCheck(). * Dummy-proof FileBackend::getFileStat() w.r.t the 'latest' param and removed related FileOp::allowStaleReads() comment. * Tweaked backend-fail-batchsize message from r109469.
RSS Feed5 | |
|---|---|
126 | |
143 | |
131 | |
85 | |
103 | |
182 | |
159 | |
197 | |
476 | |
2400 | |
3103 | |
4002 | |
4880 | |
3689 | |
3079 | |
4064 | |
3360 | |
2474 | |
3968 | |
1924 | |
2054 | |
46 |
