headers
Maxim Uvarov | 1 Apr 2011 09:11
Picon

Re: non English characters

2011/3/31 Guy Harris <guy@...>:
>
> On Mar 31, 2011, at 12:16 PM, Maxim Uvarov wrote:
>
>> Thanks. Can you please point me to function(or file) were it puts dots
>> instead of real chars?
>
> print_hex_data_buffer(), in print.c.
>
> Note that you *CANNOT* make this work just by changing
>
>                line[k++] = c >= ' ' && c < 0x7f ? c : '.';
>
> not to map all bytes with the 8th bit set to '.'.  If you're trying to make 8-bit characters from, say, ISO
8859-5 or a KOI-8 character set display properly, you will have to translate those characters from the
character encoding in question to UTF-8, and insert the UTF-8 octet sequence into the line buffer,
because GTK+ expects to be handed UTF-8 strings.  That would require you to make the line buffer bigger,
as the current size is based on the assumption that each line has 1 character position per byte.

Thanks. In general with console thark it works ok. Some clean up is
needed to change ^M symbols and probably others. But it's definitely
what do I need.

--

-- 
Best regards,
Maxim Uvarov
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@...>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chaswi Przellczyk | 1 Apr 2011 10:00
Picon
Picon

Re: was: Adding Files to Wireshark (new developer)


-------- Original-Nachricht --------
> Datum: Thu, 31 Mar 2011 12:01:20 -0400
> Von: Fulko Hew <fulko.hew@...>
> An: Developer support list for Wireshark <wireshark-dev@...>
> CC: Chaswi Przellczyk <cp70@...>
> Betreff: Re: [Wireshark-dev] (no subject)

> On Thu, Mar 31, 2011 at 11:52 AM, Chaswi Przellczyk <cp70@...> wrote:
> 
> >
> > Dear Anders,
> >
> > I'm feeling a bit silly here, since "wireshark trunk" only makes sense
> to
> > me in using the trunk-branch of wireshark to do that and I have found
> three
> > of those
> >    * 1.5 (unstable) trunk
> >    * 1.4 (stable) trunk
> >    * 1.2 (old stable) trunk
> >
> > But unfortunately I'm unable to find out what you really mean. Sorry.
> >
> 
> 1.5 is the 'next' version where all new features are being added and
> tested
> (and thats why its unstable)
> 1.4 is the 'current' release tree - bug fixes only (thats why its stable)
> 1.2 was the 'previous' stable version
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chaswi Przellczyk | 1 Apr 2011 15:52
Picon
Picon

Fwd: Re: was: Adding Files to Wireshark

Uhm... sorry.
Something went wrong with my last post.
Here's what I wrote:

-------- Original-Nachricht --------
> Datum: Thu, 31 Mar 2011 12:01:20 -0400
> Von: Fulko Hew <fulko.hew@...>
> An: Developer support list for Wireshark <wireshark-dev@...>
> CC: Chaswi Przellczyk <cp70@...>
> Betreff: Re: [Wireshark-dev] (no subject)

> On Thu, Mar 31, 2011 at 11:52 AM, Chaswi Przellczyk <cp70@...> wrote:
> 
> >
> > Dear Anders,
> >
> > I'm feeling a bit silly here, since "wireshark trunk" only makes sense
> to
> > me in using the trunk-branch of wireshark to do that and I have found
> three
> > of those
> >    * 1.5 (unstable) trunk
> >    * 1.4 (stable) trunk
> >    * 1.2 (old stable) trunk
> >
> > But unfortunately I'm unable to find out what you really mean. Sorry.
> >
> 
> 1.5 is the 'next' version where all new features are being added and
> tested
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stephen Fisher | 1 Apr 2011 17:43

Re: (no subject)

On Thu, Mar 31, 2011 at 10:38:52AM +0200, Chaswi Przellczyk wrote:

> At the end of tap-rtp-common.c is a function called int 
> rtp_packet_analyse(...). Inside rtp_packet_analyse when you go down to 
> /* Dynamic PT */ and go to the else of that if, there is a statement 
> that says

> clock_rate = 0;

It sounds like you should add a standard Wirshark preference.  See the 
README.developer file in the doc directory of the source code for more 
details.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@...>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@...?subject=unsubscribe
Permalink | Reply | 6 comments |
headers
Chaswi Przellczyk | 1 Apr 2011 18:57
Picon
Picon

Re: was: Adding Files to Wireshark (new developer)


-------- Original-Nachricht --------
> Datum: Fri, 1 Apr 2011 09:43:28 -0600
> Von: Stephen Fisher <steve@...>
> An: Developer support list for Wireshark <wireshark-dev@...>
> Betreff: Re: [Wireshark-dev] (no subject)

> On Thu, Mar 31, 2011 at 10:38:52AM +0200, Chaswi Przellczyk wrote:
> 
> > At the end of tap-rtp-common.c is a function called int 
> > rtp_packet_analyse(...). Inside rtp_packet_analyse when you go down to 
> > /* Dynamic PT */ and go to the else of that if, there is a statement 
> > that says
> 
> > clock_rate = 0;
> 
> It sounds like you should add a standard Wirshark preference.  See the 
> README.developer file in the doc directory of the source code for more 
> details.
> 
> 

Dear Stephen,

that would be a good way to get this solved. I went ahead and modified packet-rtp.c to add a field for a
sampling-rate preference. That works nice.
BUT the preferences are typically used in the dissectors, which is not true for my case. I can make the
variable visible in all files (make it truly global), but I'm wondering if that's the right way to go. At the
very least it would differ from what I've seen in other source-files. Is there a different way of accessing
these preferences "correctly"?
(Continue reading)

Permalink | Reply | 5 comments |
headers
Anders Broman | 1 Apr 2011 20:19

Re: was: Adding Files to Wireshark (new developer)

Chaswi Przellczyk skrev 2011-04-01 18:57:
> -------- Original-Nachricht --------
>> Datum: Fri, 1 Apr 2011 09:43:28 -0600
>> Von: Stephen Fisher<steve@...>
>> An: Developer support list for Wireshark<wireshark-dev@...>
>> Betreff: Re: [Wireshark-dev] (no subject)
>> On Thu, Mar 31, 2011 at 10:38:52AM +0200, Chaswi Przellczyk wrote:
>>
>>> At the end of tap-rtp-common.c is a function called int
>>> rtp_packet_analyse(...). Inside rtp_packet_analyse when you go down to
>>> /* Dynamic PT */ and go to the else of that if, there is a statement
>>> that says
>>> clock_rate = 0;
>> It sounds like you should add a standard Wirshark preference.  See the
>> README.developer file in the doc directory of the source code for more
>> details.
>>
>>
> Dear Stephen,
>
> that would be a good way to get this solved. I went ahead and modified packet-rtp.c to add a field for a
sampling-rate preference. That works nice.
> BUT the preferences are typically used in the dissectors, which is not true for my case. I can make the
variable visible in all files (make it truly global), but I'm wondering if that's the right way to go. At the
very least it would differ from what I've seen in other source-files. Is there a different way of accessing
these preferences "correctly"?
>
> Thanks a lot for the hint!
>
> Regards - and have a nice weekend,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Bill Meier | 1 Apr 2011 20:36
Favicon

Re: was: Adding Files to Wireshark (new developer)

On 4/1/2011 12:57 PM, Chaswi Przellczyk wrote:

> Dear Stephen,
>
> that would be a good way to get this solved. I went ahead and
> modified packet-rtp.c to add a field for a sampling-rate preference.
> That works nice. BUT the preferences are typically used in the
> dissectors, which is not true for my case. I can make the variable
> visible in all files (make it truly global), but I'm wondering if
> that's the right way to go. At the very least it would differ from
> what I've seen in other source-files. Is there a different way of
> accessing these preferences "correctly"?
>

Take at look at the data struct passed to register_tap() (or whatever
it's called) when the tap is created by the dissector.

I'm not a 'tap' expert, but I think a ptr to that struct is passed to
the tap callback fcn called for each frame.

Also  see doc/README.tapping

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@...>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@...?subject=unsubscribe
Permalink | Reply | 3 comments |
headers
Chaswi Przellczyk | 1 Apr 2011 23:44
Picon
Picon

Re: was: Adding Files to Wireshark (new developer)


-------- Original-Nachricht --------
> Datum: Fri, 01 Apr 2011 14:36:50 -0400
> Von: Bill Meier <wmeier@...>
> An: Developer support list for Wireshark <wireshark-dev@...>
> Betreff: Re: [Wireshark-dev] was: Adding Files to Wireshark (new developer)

> On 4/1/2011 12:57 PM, Chaswi Przellczyk wrote:
> 
> > Dear Stephen,
> >
> > that would be a good way to get this solved. I went ahead and
> > modified packet-rtp.c to add a field for a sampling-rate preference.
> > That works nice. BUT the preferences are typically used in the
> > dissectors, which is not true for my case. I can make the variable
> > visible in all files (make it truly global), but I'm wondering if
> > that's the right way to go. At the very least it would differ from
> > what I've seen in other source-files. Is there a different way of
> > accessing these preferences "correctly"?
> >
> 
> 
> Take at look at the data struct passed to register_tap() (or whatever
> it's called) when the tap is created by the dissector.
> 
> I'm not a 'tap' expert, but I think a ptr to that struct is passed to
> the tap callback fcn called for each frame.
> 
> Also  see doc/README.tapping
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stephen Fisher | 1 Apr 2011 23:54

Re: was: Adding Files to Wireshark (new developer)

On Fri, Apr 01, 2011 at 02:36:50PM -0400, Bill Meier wrote:

> Take at look at the data struct passed to register_tap() (or whatever 
> it's called) when the tap is created by the dissector.
> 
> I'm not a 'tap' expert, but I think a ptr to that struct is passed to 
> the tap callback fcn called for each frame.

The tap_queue_packet() function takes three parameters:

void tap_queue_packet(int tap_id, packet_info *pinfo, const void 
*tap_specific_data)

The third value, tap_specific_data can be used to pass any data you 
would like from a dissector to the tap functions.

For an example, look at the dissect_http_message function in 
epan/dissectors/packet-http.c which passes the eo_info struct to the 
http_eo_tap (which is read by the tap code in gtk/export_object_http.c 
function eo_http_packet).
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@...>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@...?subject=unsubscribe
Permalink | Reply | 1 comment |
headers
Roland Knall | 2 Apr 2011 00:05
Picon
Gravatar

Re: Modbus/TCP hookup for subdissector

There is no specific need for data to the subdissector. It was just an
idea I was thinking out loud. The basic idea would be, that there
could be a case, where a subdissector would need information from the
calling dissector. Especially if the subdissector only sees part of
the packet data. Some information is passed down by the packet_info
package, but I was thinking of finding a way to access the complete
information. In the case of the ModbusTCP diessector, the dissector
has a struct, which contains all fields dissected so far. They could
be interesting to a subdissector.

But just to clarify, this is just an idea I had, not a requirement.
And specifically my patch does not provide or need such functionality.

The main reason for my patch has been to be able to access the data
payload, which is accomplished by the patch on

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5786

And therefore I would kindly ask you to consider adding the patch to
the subversion repository.

kind regards,
Roland

On Fri, Mar 25, 2011 at 5:17 PM, Anders Broman
<anders.broman@...> wrote:
>
>
> -----Original Message-----
> From: wireshark-dev-bounces@...
(Continue reading)

Permalink | Reply | 0 comments |

Gmane