GUNA | 24 May 18:16 2016
Picon

tipc_sk_rcv: Kernel panic on one of the card on 4.4.0

I suspect there could be glitch on switch may cause lost the probe or
abort message.  However, even if the messages are lost for what ever
reason, is not TIPC stack should handle the graceful shutdown of the
TIPC connection by releasing all the resources instead of panic or
dead itself ?

Does lock_sock/release_sock use in tipc_sk_timeout() fix the issue ?

Thanks,
Guna

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
Parthasarathy Bhuvaragan | 24 May 12:45 2016
Picon

[PATCH net-next v2 0/5] tipc: netlink updates for neighbour monitor

The commits are based on the Jon Maloy's "[PATCH net-next v7 0/4] tipc: neighbor monitoring etc"

v2: - updated #2, #3, #5 Variables ordering in stack from longest to shortest
    - updated #5 TIPC_NLA_MON_ACTIVATION_THRESHOLD to retain the same value as
      in previous patches in the series.

regards
Partha

Parthasarathy Bhuvaragan (5):
  tipc: introduce constants for tipc address validation
  tipc: make cluster size threshold for monitoring configurable
  tipc: get monitor threshold for the cluster
  tipc: add a function to get the bearer name
  tipc: dump monitor attributes

 include/uapi/linux/tipc.h         |  30 ++++++-
 include/uapi/linux/tipc_netlink.h |  37 +++++++++
 net/tipc/addr.h                   |   5 +-
 net/tipc/bearer.c                 |  25 +++++-
 net/tipc/bearer.h                 |   1 +
 net/tipc/monitor.c                | 152 +++++++++++++++++++++++++++++++++++
 net/tipc/monitor.h                |   9 +++
 net/tipc/netlink.c                |  27 ++++++-
 net/tipc/netlink.h                |   1 +
 net/tipc/node.c                   | 165 ++++++++++++++++++++++++++++++++++++++
 net/tipc/node.h                   |   5 ++
 11 files changed, 445 insertions(+), 12 deletions(-)

--

-- 
(Continue reading)

Parthasarathy Bhuvaragan | 23 May 15:27 2016
Picon

[PATCH iproute2 v1 0/4] tipc: updates for neighbour monitor

Hi,

This commit series requires the following kernel patch set:
"[PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor"

I have issues compiling the latest iproute2 package, so compiled
myseries on commit c13b6b097ab3 "add coverity model file".

regards
Partha

Parthasarathy Bhuvaragan (4):
  tipc: cleanup dead code
  tipc: add monitor set command
  tipc: get monitor command
  tipc: list monitor command

 include/linux/tipc_netlink.h |  37 +++++
 tipc/bearer.c                |   2 +-
 tipc/link.c                  | 374 ++++++++++++++++++++++++++++++++++++++++++-
 tipc/node.c                  |  21 ++-
 tipc/node.h                  |   2 +
 5 files changed, 427 insertions(+), 9 deletions(-)

--

-- 
2.1.4

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
(Continue reading)

Parthasarathy Bhuvaragan | 23 May 15:27 2016
Picon

[PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor

Hi,

The commits are based on the Jon Maloy's "[PATCH net-next v7 0/4] tipc: neighbor monitoring etc"

The updates to iproute2 will be sent as a seperate series shortly.

regards
Partha

Parthasarathy Bhuvaragan (5):
  tipc: introduce constants for tipc address validation
  tipc: make cluster size threshold for monitoring configurable
  tipc: get monitor threshold for the cluster
  tipc: add a function to get the bearer name
  tipc: dump monitor attributes

 include/uapi/linux/tipc.h         |  30 ++++++-
 include/uapi/linux/tipc_netlink.h |  37 +++++++++
 net/tipc/addr.h                   |   5 +-
 net/tipc/bearer.c                 |  25 +++++-
 net/tipc/bearer.h                 |   1 +
 net/tipc/monitor.c                | 152 +++++++++++++++++++++++++++++++++++
 net/tipc/monitor.h                |   9 +++
 net/tipc/netlink.c                |  27 ++++++-
 net/tipc/netlink.h                |   1 +
 net/tipc/node.c                   | 165 ++++++++++++++++++++++++++++++++++++++
 net/tipc/node.h                   |   5 ++
 11 files changed, 445 insertions(+), 12 deletions(-)

--

-- 
(Continue reading)

Rune Torgersen | 20 May 18:10 2016

Tipc crash in Ubuntu 16.04 4.4.0-22

Was all the tipc changes ported to the Ubuntu mainline kernel (16.04LTS, 4.4.0-22-generic)?

I got this particular crash today:

[682190.533680] BUG: unable to handle kernel NULL pointer dereference at           (null)
[682190.534571] IP: [<ffffffffc053e2d3>] tipc_nameseq_remove_publ+0x1b3/0x220 [tipc]
[682190.535461] PGD 0 
[682190.536313] Oops: 0000 [#1] SMP 
[682190.537176] Modules linked in: btrfs ufs qnx4 hfsplus hfs minix ntfs msdos jfs xfs tipc cls_fw sch_sfq
sch_htb xt_CLASSIFY xt_multiport iptable_mangle ip_tables x_tables nls_iso8859_1 quota_v2 mvsas
quota_tree ixgbe libsas mei_me igb vxlan mei scsi_transport_sas ip6_udp_tunnel udp_tunnel
intel_rapl ptp lpc_ich pps_core mdio acpi_pad acpi_power_meter fjes x86_pkg_temp_thermal
intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul input_leds
ipmi_ssif cryptd joydev hid_generic sb_edac 8250_fintek shpchp edac_core usbhid hid ioatdma dca
mac_hid ib_iser rdma_cm iw_cm ib_cm ib_sa ib_mad ib_core ib_addr iscsi_tcp libiscsi_tcp libiscsi
scsi_transport_iscsi ipmi_si ipmi_devintf ipmi_msghandler autofs4 raid10 raid456 libcrc32c
async_raid6_recov async_memcpy async_pq asy
 nc_xor xor
[682190.543356]  async_tx raid6_pq raid1 raid0 multipath linear ast i2c_algo_bit ttm drm_kms_helper
syscopyarea sysfillrect sysimgblt fb_sys_fops drm ahci libahci wmi
[682190.545761] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G        W       4.4.0-22-generic #39-Ubuntu
[682190.547006] Hardware name: Supermicro Super Server/X10SRL-F, BIOS 1.0b 04/17/2015
[682190.548264] task: ffffffff81e11500 ti: ffffffff81e00000 task.ti: ffffffff81e00000
[682190.549582] RIP: 0010:[<ffffffffc053e2d3>]  [<ffffffffc053e2d3>]
tipc_nameseq_remove_publ+0x1b3/0x220 [tipc]
[682190.550939] RSP: 0018:ffff88103cc03a40  EFLAGS: 00010213
[682190.552251] RAX: 0000000000000000 RBX: ffff88010e40de00 RCX: 0000000000000002
[682190.553649] RDX: 0000000000000009 RSI: 0000000000000009 RDI: ffff8809a0a6f200
[682190.555051] RBP: ffff88103cc03a80 R08: 00000000e7f01c05 R09: 0000000001001001
[682190.556456] R10: 0000000000000000 R11: 0000000000000005 R12: ffffffffffffff80
(Continue reading)

Richard Alpe | 20 May 10:12 2016
Picon

[PATCH net-next 0/4] Introduce UDP replicast

Introduce TIPC replicast. A concept where we emulate IP multicast by sending
multiple unicast messages to configured peers.

tipc discussion:
I'm still testing this, but as I have mentioned I'm working on this to some of
you I wanted to show it "early". If you have any feedback it's always apricated.

Richard Alpe (4):
  tipc: add the ability to get UDP options via netlink
  tipc: split udp nl address parsing
  tipc: split UDP send function
  tipc: introduce UDP replicast

 include/uapi/linux/tipc_netlink.h |   1 +
 net/tipc/bearer.c                 |  52 ++++++
 net/tipc/bearer.h                 |   1 +
 net/tipc/netlink.c                |   5 +
 net/tipc/udp_media.c              | 322 +++++++++++++++++++++++++++++---------
 net/tipc/udp_media.h              |  43 +++++
 6 files changed, 349 insertions(+), 75 deletions(-)
 create mode 100644 net/tipc/udp_media.h

--

-- 
2.1.4

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
(Continue reading)

Erik Hugne | 20 May 07:19 2016
Picon

Re: tipc_sk_rcv: Kernel panic on one of the card on 4.4.0

A little more awake now. Didnt see this yesterday.
Look at the trace from CPU2 in Guna's initial mail.

TIPC is recursing into the receive loop a second time, and freezes when it
tries to take slock a second time. this is done in a timer CB, and softirq
lockup detector kicks in after ~20s.

//E

[686797.257426]  <IRQ>

[686797.257426]  [<ffffffff816de340>] _raw_spin_trylock_bh+0x40/0x50

[686797.257430]  [<ffffffffa01546cc>] tipc_sk_rcv+0xbc/0x490 [tipc]

[686797.257432]  [<ffffffff8162ecde>] ? tcp_rcv_established+0x40e/0x760

[686797.257435]  [<ffffffffa014f58f>] tipc_node_xmit+0x11f/0x150 [tipc]

[686797.257437]  [<ffffffff810b5353>] ? find_busiest_group+0x153/0x980

[686797.257441]  [<ffffffffa014f5f7>] tipc_node_xmit_skb+0x37/0x60 [tipc]

[686797.257444]  [<ffffffffa0151cb9>] tipc_sk_respond+0x99/0xc0 [tipc]

[686797.257447]  [<ffffffffa0152e6d>] filter_rcv+0x4cd/0x550 [tipc]

[686797.257451]  [<ffffffffa01548ed>] tipc_sk_rcv+0x2dd/0x490 [tipc]

[686797.257454]  [<ffffffffa014f58f>] tipc_node_xmit+0x11f/0x150 [tipc]
(Continue reading)

Jon Maloy | 19 May 20:08 2016
Picon

[PATCH net-next v7 0/4] tipc: neighbor monitoring etc

This is not really a series, as the commits will be delivered one by one.

I think I have got as far as I can with this one now; it feels pretty
solid even when I push the envelope to 500 namespaces.

v6: - Added the jiffies-to-ms patch as #1. Please ack asap, since
      net-next is still open.
    - Updated monitor patch to v6. See commit log. It is starting to
      look pretty stable now.
    - Separated out the disovery rate control as commit #3. 
    - More measuring points in the profiling commit (#4)

v7: - Added a new commit #1, which solves a problem I have been chasing
      for some time.
    - Updated #3 (v6/#2), see its commit log.
    - Removed v6/#3 as it doesn't seem to make any difference.
    - Finally got the "monitored links" counter in #4 right, plus more.

Jon Maloy (4):
  tipc: correct error in node fsm
  tipc: change node timer unit from jiffies to ms
  tipc: add neighbor monitoring framework
  tipc: debugging_tracing_profiling support for neighbor monitoring code

 net/tipc/Makefile  |    2 +-
 net/tipc/addr.c    |    1 +
 net/tipc/addr.h    |    1 +
 net/tipc/bearer.c  |   18 +-
 net/tipc/bearer.h  |    2 +-
 net/tipc/core.c    |    1 +
(Continue reading)

GUNA | 19 May 16:34 2016
Picon

tipc_sk_rcv: Kernel panic on one of the card on 4.4.0

One of the card in my system is dead and rebooted to recover it.
The system is running on Kernel 4.4.0 + some latest TIPC patches.
Your earliest feedback of the issue is recommended.

The cascaded failure logs are following:

[686797.257405] Modules linked in: nf_log_ipv4 nf_log_common xt_LOG
sctp libcrc32c e1000e tipc udp_tunnel ip6_udp_tunnel 8021q garp
iTCO_wdt xt_physdev br_netfilter bridge stp llc nf_conntrack_ipv4
ipmiq_drv(O) sio_mmc(O) nf_defrag_ipv4 ip6t_REJECT nf_reject_ipv6
nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack event_drv(O)
ip6table_filter ip6_tables ddi(O) lockd pt_timer_info(O) grace ixgbe
usb_storage igb pcspkr iTCO_vendor_support i2c_algo_bit i2c_i801 ptp
i2c_core ioatdma lpc_ich mfd_core tpm_tis dca pps_core intel_ips tpm
mdio sunrpc [last unloaded: iTCO_wdt]

[686797.257407] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G        W  O L
 4.4.0 #17

[686797.257407] Hardware name: PT AMC124/Base Board Product Name, BIOS
LGNAJFIP.PTI.0012.P15 01/15/2014

[686797.257408] task: ffff880351a751c0 ti: ffff880351a80000 task.ti:
ffff880351a80000

[686797.257411] RIP: 0010:[<ffffffff81083fec>]  [<ffffffff81083fec>]
__local_bh_enable_ip+0x4c/0x90

[686797.257412] RSP: 0018:ffff88035fc43aa0  EFLAGS: 00000296

(Continue reading)

Richard Alpe | 17 May 16:57 2016
Picon

[PATCH net] tipc: fix nametable publication field in nl compat

The publication field of the old netlink API should contain the
publication key and not the publication reference.

Fixes: 44a8ae94fd55 (tipc: convert legacy nl name table dump to nl compat)
Signed-off-by: Richard Alpe <richard.alpe <at> ericsson.com>
Acked-by: Jon Maloy <jon.maloy <at> ericsson.com>
---
 net/tipc/netlink_compat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index d7d050f..4dfc5c1 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
 <at>  <at>  -802,7 +802,7  <at>  <at>  static int tipc_nl_compat_name_table_dump(struct tipc_nl_compat_msg *msg,
 		goto out;

 	tipc_tlv_sprintf(msg->rep, "%-10u %s",
-			 nla_get_u32(publ[TIPC_NLA_PUBL_REF]),
+			 nla_get_u32(publ[TIPC_NLA_PUBL_KEY]),
 			 scope_str[nla_get_u32(publ[TIPC_NLA_PUBL_SCOPE])]);
 out:
 	tipc_tlv_sprintf(msg->rep, "\n");
--

-- 
2.1.4

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
(Continue reading)

Richard Alpe | 16 May 15:50 2016
Picon

[PATCH net-next] tipc: fix nametable publication field in nl compat

The publication field of the old netlink API should contain the
publication key and not the publication reference.

Signed-off-by: Richard Alpe <richard.alpe <at> ericsson.com>
---
 net/tipc/netlink_compat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index d7d050f..4dfc5c1 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
 <at>  <at>  -802,7 +802,7  <at>  <at>  static int tipc_nl_compat_name_table_dump(struct tipc_nl_compat_msg *msg,
 		goto out;

 	tipc_tlv_sprintf(msg->rep, "%-10u %s",
-			 nla_get_u32(publ[TIPC_NLA_PUBL_REF]),
+			 nla_get_u32(publ[TIPC_NLA_PUBL_KEY]),
 			 scope_str[nla_get_u32(publ[TIPC_NLA_PUBL_SCOPE])]);
 out:
 	tipc_tlv_sprintf(msg->rep, "\n");
--

-- 
2.1.4

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
(Continue reading)


Gmane