headers
Urs Janßen | 2 Dec 2010 23:54

[PATCH] embedding a directive within macro arguments is not portable

just to be one the safe side

=== modified file 'src/help.c'
--- src/help.c	2010-10-17 19:03:17 +0000
+++ src/help.c	2010-12-02 22:43:05 +0000
 <at>  <at>  -768,16 +768,23  <at>  <at> 
 				printascii(key[2], func_to_key(GLOBAL_HELP, attachment_keys)),
 				printascii(key[3], func_to_key(GLOBAL_QUIT, attachment_keys)));
 			center_line(line, FALSE, buf);
+#ifndef DONT_HAVE_PIPING
 			snprintf(buf, bufs, _(txt_mini_attachment_2),
 				printascii(key[0], func_to_key(ATTACHMENT_SELECT, attachment_keys)),
-#ifndef DONT_HAVE_PIPING
 				printascii(key[5], func_to_key(ATTACHMENT_PIPE, attachment_keys)),
 				printascii(key[6], func_to_key(GLOBAL_PIPE, attachment_keys)),
+				printascii(key[1], func_to_key(ATTACHMENT_SAVE, attachment_keys)),
+				printascii(key[2], func_to_key(ATTACHMENT_TAG, attachment_keys)),
+				printascii(key[3], func_to_key(ATTACHMENT_TAG_PATTERN, attachment_keys)),
+				printascii(key[4], func_to_key(ATTACHMENT_UNTAG, attachment_keys)));
+#else
+			snprintf(buf, bufs, _(txt_mini_attachment_2),
+				printascii(key[0], func_to_key(ATTACHMENT_SELECT, attachment_keys)),
+				printascii(key[1], func_to_key(ATTACHMENT_SAVE, attachment_keys)),
+				printascii(key[2], func_to_key(ATTACHMENT_TAG, attachment_keys)),
+				printascii(key[3], func_to_key(ATTACHMENT_TAG_PATTERN, attachment_keys)),
+				printascii(key[4], func_to_key(ATTACHMENT_UNTAG, attachment_keys)));
 #endif /* !DONT_HAVE_PIPING */
-				printascii(key[1], func_to_key(ATTACHMENT_SAVE, attachment_keys)),
-				printascii(key[2], func_to_key(ATTACHMENT_TAG, attachment_keys)),
-				printascii(key[3], func_to_key(ATTACHMENT_TAG_PATTERN, attachment_keys)),
(Continue reading)

Permalink | Reply | 1 comment |
headers
Urs Janßen | 7 Dec 2010 16:36

[PATCH] allow .so TLD, disallow .yu TLD

.so is active again, .yu is historic now

=== modified file 'include/policy.h'
--- include/policy.h	2010-10-17 19:03:17 +0000
+++ include/policy.h	2010-12-07 15:31:50 +0000
 <at>  <at>  -167,9 +167,10  <at>  <at> 
  * .sh  St. Helena                     .si  Slovenia
  * .sk  Slovakia                       .sl  Sierra Leone
  * .sm  San Marino                     .sn  Senegal
- * .sr  Surinam                        .st  Sao Tome and Principe
- * .su  Soviet Union (former)          .sv  El Salvador
- * .sy  Syrian Arab Republic           .sz  Swaziland
+ * .so  Somalia                        .sr  Surinam
+ * .st  Sao Tome and Principe          .su  Soviet Union (former)
+ * .sv  El Salvador                    .sy  Syrian Arab Republic
+ * .sz  Swaziland
  *
  * .tc  The Turks & Caicos Islands     .td  Chad
  * .tf  French Southern Territories    .tg  Togo
 <at>  <at>  -194,7 +195,6  <at>  <at> 
  * .wf  Wallis and Futuna Islands      .ws  Western Samoa
  *
  * .ye  Yemen                          .yt  Mayotte
- * .yu  Yugoslavia
  *
  * .za  South Africa                   .zm  Zambia
  * .zw  Zimbabwe
 <at>  <at>  -205,8 +205,10  <at>  <at> 
  * .cs  former Czechoslovakia, now .cz and .sk
  * .dd  former German Democratic Republic, now .de
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dennis Preiser | 9 Dec 2010 17:53
Picon
Picon

Re: [PATCH] embedding a directive within macro arguments is not portable

On Thu, Dec 02, 2010 at 11:54:06PM +0100, Urs Janßen wrote:
> just to be one the safe side

Another in post.c:

diff -urp tin-1.9.6/src/post.c tin-1.9.6_r1/src/post.c
--- tin-1.9.6/src/post.c	2010-12-04 08:41:10.000000000 +0100
+++ tin-1.9.6_r1/src/post.c	2010-12-09 17:41:50.000000000 +0100
 <at>  <at>  -1886,18 +1886,43  <at>  <at>  post_article_loop:
 			char keypgp[MAXKEYLEN];
 #endif /* HAVE_PGP_GPG */

+#if defined(HAVE_ISPELL) && defined(HAVE_PGP_GPG)
 			snprintf(buf, sizeof(buf), _(txt_quit_edit_xpost),
 					printascii(keyquit, func_to_key(GLOBAL_QUIT, post_post_keys)),
 					printascii(keyedit, func_to_key(POST_EDIT, post_post_keys)),
-#ifdef HAVE_ISPELL
 					printascii(keyispell, func_to_key(POST_ISPELL, post_post_keys)),
-#endif /* HAVE_ISPELL */
-#ifdef HAVE_PGP_GPG
 					printascii(keypgp, func_to_key(POST_PGP, post_post_keys)),
-#endif /* HAVE_PGP_GPG */
 					printascii(keymenu, func_to_key(GLOBAL_OPTION_MENU, post_post_keys)),
 					printascii(keypost, func_to_key(GLOBAL_POST, post_post_keys)),
 					printascii(keypostpone, func_to_key(POST_POSTPONE, post_post_keys)));
+#else
+#	ifdef HAVE_ISPELL
+			snprintf(buf, sizeof(buf), _(txt_quit_edit_xpost),
+					printascii(keyquit, func_to_key(GLOBAL_QUIT, post_post_keys)),
+					printascii(keyedit, func_to_key(POST_EDIT, post_post_keys)),
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dennis Preiser | 9 Dec 2010 22:24
Picon
Picon

[PATCH] typo in filter.c

Small typo in filter.c:filter_menu(). Not a bug, because quat_time
and double_time currently have the same size.

diff -urp tin-1.9.6/src/filter.c tin-1.9.6_r1/src/filter.c
--- tin-1.9.6/src/filter.c	2010-11-13 00:41:57.000000000 +0100
+++ tin-1.9.6_r1/src/filter.c	2010-12-09 22:17:06.000000000 +0100
 <at>  <at>  -1328,7 +1328,7  <at>  <at>  filter_menu(
 	 * Expire time
 	 */
 	snprintf(double_time, sizeof(double_time), "2x %s", text_time);
-	snprintf(quat_time, sizeof(double_time), "4x %s", text_time);
+	snprintf(quat_time, sizeof(quat_time), "4x %s", text_time);
 	list = my_malloc(sizeof(char *) * 4);
 	list[0] = (char *) _(txt_unlimited_time);
 	list[1] = text_time;
Permalink | Reply | 0 comments |
headers
Dennis Preiser | 20 Dec 2010 19:09
Picon
Picon

Annotations on TODO

The piping part has been revised this year and works (at least for me)
as expected. This entry can be reduced to printing (I don't do printing,
so I'm not sure whether printing grabbles the screen):

o  piping/printing articles grabbles screen
   [20030501 Urs Janssen <urs <at> tin.org>]

This one I cannot reproduce:

o  Add to the 'M'enu:
     '?','/','\' search (partly done, currently only the displayed page is
                         searched which is not that useful)

I'm able to search the menu in both directions and the search is not
restricted to the displayed page (also whith 'repeat last search').

This one can be removed:

o  Add to the 'M'enu:
     'h'  (GLOBAL_HELP)

'h' works in the 'M'enu.

Dennis
Permalink | Reply | 1 comment |
headers
Dennis Preiser | 20 Dec 2010 20:39
Picon
Picon

Re: Annotations on TODO

On Mon, Dec 20, 2010 at 07:09:07PM +0100, Dennis Preiser wrote:

Forgot to attach the changes I would suggest...

Dennis

--- tin-1.9.6_r1/doc/TODO	2010-11-25 23:24:09.000000000 +0100
+++ tin-1.9.6_r2/doc/TODO	2010-12-20 18:58:31.000000000 +0100
 <at>  <at>  -31,7 +31,7  <at>  <at>  o  unexpected multiline responses confus
    (the servers response should be a single line (INN 2.2))
    [20050207 Urs Janssen <urs <at> tin.org>]

-o  piping/printing articles grabbles screen
+o  printing articles grabbles screen
    [20030501 Urs Janssen <urs <at> tin.org>]

 o  better integrate saving of MIME/non-MIME articles when not using libuu.
 <at>  <at>  -349,10 +349,6  <at>  <at>  o  Add to the 'M'enu:
      '&'  (GLOBAL_TOGGLE_COLOR)
      and maybe a way to change built in path like DEFAULT_MAILER, PATH_PGP, ...

-     '?','/','\' search (partly done, currently only the displayed page is
-                         searched which is not that useful)
-     'h'  (GLOBAL_HELP)
-
 o  Add to the attachment menu ('V'):
      'F'  post followup to current article, not including current attachment
      'R'  reply through mail to author, not including current attachment
(Continue reading)

Permalink | Reply | 0 comments |

Gmane